)]}'
{"specs/mitaka/rabbitmq-pika-driver.rst":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"b1c5227b780f776f0681f9ae5f527de593ce11b0","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Current RabbitMQ oslo.messaging driver uses kombu client library."},{"line_number":13,"context_line":"This library is not supported properly now and RabbitMQ developers"},{"line_number":14,"context_line":"recommend to use pika librarty instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Now pika library supports modern RabbitMQ reatures, like direct reply"},{"line_number":17,"context_line":"or heatbeat. "}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_a50e098a","line":14,"updated":"2015-09-29 17:51:34.000000000","message":"nit: library","commit_id":"bb155236a802ab74b0633504594537a02f166021"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"689ee37d4748e249a64eb1e0a1e7199ddbd762f4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Current RabbitMQ oslo.messaging driver uses kombu client library."},{"line_number":13,"context_line":"This library is not supported properly now and RabbitMQ developers"},{"line_number":14,"context_line":"recommend to use pika librarty instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Now pika library supports modern RabbitMQ reatures, like direct reply"},{"line_number":17,"context_line":"or heatbeat. "}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_aa48edcc","line":14,"in_reply_to":"9a1a9d01_a50e098a","updated":"2015-09-30 14:42:04.000000000","message":"Done","commit_id":"bb155236a802ab74b0633504594537a02f166021"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"b1c5227b780f776f0681f9ae5f527de593ce11b0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This library is not supported properly now and RabbitMQ developers"},{"line_number":14,"context_line":"recommend to use pika librarty instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Now pika library supports modern RabbitMQ reatures, like direct reply"},{"line_number":17,"context_line":"or heatbeat. "},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_251bd9cb","line":16,"updated":"2015-09-29 17:51:34.000000000","message":"nit: features","commit_id":"bb155236a802ab74b0633504594537a02f166021"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"689ee37d4748e249a64eb1e0a1e7199ddbd762f4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This library is not supported properly now and RabbitMQ developers"},{"line_number":14,"context_line":"recommend to use pika librarty instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Now pika library supports modern RabbitMQ reatures, like direct reply"},{"line_number":17,"context_line":"or heatbeat. "},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_ea4265ad","line":16,"in_reply_to":"9a1a9d01_251bd9cb","updated":"2015-09-30 14:42:04.000000000","message":"Done","commit_id":"bb155236a802ab74b0633504594537a02f166021"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"b1c5227b780f776f0681f9ae5f527de593ce11b0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"In this specification I propose to create fully new driver which:"},{"line_number":23,"context_line":"#. sould be developed in optimal way regarding to all pika client"},{"line_number":24,"context_line":"   library new features and best practices;"},{"line_number":25,"context_line":"#. should be fully conpatible with current driver interface;"},{"line_number":26,"context_line":"#. may change internals and does not guarantee compatibility with "},{"line_number":27,"context_line":"   kombu driver (means you can not use old kombu driver for some set "},{"line_number":28,"context_line":"   of services and new pika driver for another services)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_c561bd3a","line":25,"updated":"2015-09-29 17:51:34.000000000","message":"nit: compatible","commit_id":"bb155236a802ab74b0633504594537a02f166021"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"689ee37d4748e249a64eb1e0a1e7199ddbd762f4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"In this specification I propose to create fully new driver which:"},{"line_number":23,"context_line":"#. sould be developed in optimal way regarding to all pika client"},{"line_number":24,"context_line":"   library new features and best practices;"},{"line_number":25,"context_line":"#. should be fully conpatible with current driver interface;"},{"line_number":26,"context_line":"#. may change internals and does not guarantee compatibility with "},{"line_number":27,"context_line":"   kombu driver (means you can not use old kombu driver for some set "},{"line_number":28,"context_line":"   of services and new pika driver for another services)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_8a1889d4","line":25,"in_reply_to":"9a1a9d01_c561bd3a","updated":"2015-09-30 14:42:04.000000000","message":"Done","commit_id":"bb155236a802ab74b0633504594537a02f166021"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"b1c5227b780f776f0681f9ae5f527de593ce11b0","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Maybe we can extend them by adding some more tricky cases."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"We also have py27-func-zeromq configuration to run as CI gate job."},{"line_number":82,"context_line":"This gate should be used for the new driver to check it."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"We also need some kind of multi-node deployment testing."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_057fb5ab","line":81,"updated":"2015-09-29 17:51:34.000000000","message":"we have 3:\npy27-func-rabbit,\npy27-func-amqp,\npy27-func-zeromq\n\nwe need to add py27-func-pika as well","commit_id":"bb155236a802ab74b0633504594537a02f166021"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"689ee37d4748e249a64eb1e0a1e7199ddbd762f4","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Maybe we can extend them by adding some more tricky cases."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"We also have py27-func-zeromq configuration to run as CI gate job."},{"line_number":82,"context_line":"This gate should be used for the new driver to check it."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"We also need some kind of multi-node deployment testing."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a1a9d01_0a255907","line":81,"in_reply_to":"9a1a9d01_057fb5ab","updated":"2015-09-30 14:42:04.000000000","message":"Done","commit_id":"bb155236a802ab74b0633504594537a02f166021"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"79dc794e93e521c2a42241544b94f2f5d769f976","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Current RabbitMQ oslo.messaging driver uses kombu client library."},{"line_number":13,"context_line":"This library is not supported properly now and RabbitMQ developers"},{"line_number":14,"context_line":"recommend to use pika library instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Now pika library supports modern RabbitMQ features, like direct reply"},{"line_number":17,"context_line":"or heatbeats. "}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_7ef6fc5d","line":14,"updated":"2015-10-01 00:19:06.000000000","message":"What does \u0027not supported properly now\u0027 mean?\n\nIt doesn\u0027t seem dead; from my understanding we also know a core committer on the kombu team (flaper87) so I worry about statements like this a little (because kombu has worked for everyone for years, and discarding it on a whim, feels sorta bad).\n\nAlso \u0027RabbitMQ\u0027 developers recommending pika I get, they created it right? If that\u0027s correct then they are somewhat biased. It\u0027d be nice to not just accept there word on blind faith.","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"d7a873bea46d515980985aa9dee6f1bf48f38783","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Current RabbitMQ oslo.messaging driver uses kombu client library."},{"line_number":13,"context_line":"This library is not supported properly now and RabbitMQ developers"},{"line_number":14,"context_line":"recommend to use pika library instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Now pika library supports modern RabbitMQ features, like direct reply"},{"line_number":17,"context_line":"or heatbeats. "}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a2fa921_b7e9d01c","line":14,"in_reply_to":"7a2fa921_ab08b929","updated":"2015-10-06 14:57:07.000000000","message":"Sure, will do","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"1392de000057fe75fd3a3c373c876fe7a822f14e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Current RabbitMQ oslo.messaging driver uses kombu client library."},{"line_number":13,"context_line":"This library is not supported properly now and RabbitMQ developers"},{"line_number":14,"context_line":"recommend to use pika library instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Now pika library supports modern RabbitMQ features, like direct reply"},{"line_number":17,"context_line":"or heatbeats. "}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a2fa921_ab08b929","line":14,"in_reply_to":"9a1a9d01_0d0f38e2","updated":"2015-10-05 16:19:47.000000000","message":"It would be good to have some of this in the body of the spec as a more concrete justification for writing a new driver.","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e9749bea2f8dd95a420dffba5f9f8d43a4d1a795","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Current RabbitMQ oslo.messaging driver uses kombu client library."},{"line_number":13,"context_line":"This library is not supported properly now and RabbitMQ developers"},{"line_number":14,"context_line":"recommend to use pika library instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Now pika library supports modern RabbitMQ features, like direct reply"},{"line_number":17,"context_line":"or heatbeats. "}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_0d0f38e2","line":14,"in_reply_to":"9a1a9d01_15f0f1c7","updated":"2015-10-03 00:24:11.000000000","message":"That\u0027s an interesting statement from the rabbitmq folks but okie dokie, guess it is what it is...","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"02075c1be26a2c1ea905818c2bfd3bec7eb61198","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Current RabbitMQ oslo.messaging driver uses kombu client library."},{"line_number":13,"context_line":"This library is not supported properly now and RabbitMQ developers"},{"line_number":14,"context_line":"recommend to use pika library instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Now pika library supports modern RabbitMQ features, like direct reply"},{"line_number":17,"context_line":"or heatbeats. "}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_15f0f1c7","line":14,"in_reply_to":"9a1a9d01_7ef6fc5d","updated":"2015-10-01 12:02:42.000000000","message":"\u0027not supported properly now\u0027 means that new features support and bugfixing process in more slower then pika do this. I\u0027m not investigated this question. I just get it from other oslo.messeging developers.\n\nAbout kombu. You can continue use it if it works fine. But in our case we have problems with RabbitMQ stable work in HA mode. And when we asked RabbitQM developers for help in bugfixing they said that it is possible but first of all update your environment to recommended library stack. It is mane reason of developing this driver.","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"7eed5f746af6f5399368847e87bdde1aaf3c42ea","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Current RabbitMQ oslo.messaging driver uses kombu client library."},{"line_number":13,"context_line":"This library is not supported properly now and RabbitMQ developers"},{"line_number":14,"context_line":"recommend to use pika library instead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Now pika library supports modern RabbitMQ features, like direct reply"},{"line_number":17,"context_line":"or heatbeats. "}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_b7fcb272","line":14,"in_reply_to":"9a1a9d01_7ef6fc5d","updated":"2015-10-01 07:37:09.000000000","message":"I may mistake but AFAIK they didn\u0027t create pika. Pika is driven by people from python community and seems that it is the only supported (means active contribution and releases) python library for rabbit now. Cool that flaper87 is kombu commiter, didn\u0027t know that.","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"79dc794e93e521c2a42241544b94f2f5d769f976","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Heartbeats"},{"line_number":54,"context_line":"----------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Pika driver has it\u0027s own heartbeats mechanism."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_3e6964f9","line":56,"updated":"2015-10-01 00:19:06.000000000","message":"Any idea on how this works, how does it heartbeat? Who does the heartbeating (some pika maintained thread?)","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"02075c1be26a2c1ea905818c2bfd3bec7eb61198","unresolved":false,"context_lines":[{"line_number":53,"context_line":"Heartbeats"},{"line_number":54,"context_line":"----------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Pika driver has it\u0027s own heartbeats mechanism."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a1a9d01_3745f8b2","line":56,"in_reply_to":"9a1a9d01_3e6964f9","updated":"2015-10-01 12:02:42.000000000","message":"No. Current implementation of pika driver uses BlockingConnectioin. It has method \u0027process_data_events\u0027 which listen in loop response from RabbitMQ. It should be executed after sending request of when consumers are registered. This method  run loop:\n\nwhile not is_done():\n    self._impl.ioloop.poll()\n    self._impl.ioloop.process_timeouts()\n\nwhere sends heartbeats (inside process_timeout_method) according to configured - heartbeat_timeout\n\nSo we have heartbeats working for all listeners with defined interval. For connections used for message publishing heartbeats will be sent only when connection is active - when you are executing publish method.","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"1392de000057fe75fd3a3c373c876fe7a822f14e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Performance Impact"},{"line_number":77,"context_line":"------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Performance should become better because of more optimal implementation."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Configuration Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a2fa921_2b4b495b","line":79,"updated":"2015-10-05 16:19:47.000000000","message":"Do we know anything about how well pika works with eventlet?","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"d7a873bea46d515980985aa9dee6f1bf48f38783","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Performance Impact"},{"line_number":77,"context_line":"------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Performance should become better because of more optimal implementation."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Configuration Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a2fa921_11c5343b","line":79,"in_reply_to":"7a2fa921_2b4b495b","updated":"2015-10-06 14:57:07.000000000","message":"Pika has a few connection adapters For working with different frameworks. It doesnot have special adapter for eventlet.But I use BlockingConnection and eventlet monkey patching and it works pretty well. Only one problem I found - it tried to use select.epull API which is not patched but current eventlet implementation. So I added code which remove pull and epull attributes from select module if eventlet is patched. In this case pika uses standard select api which is patched by eventlet","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"1392de000057fe75fd3a3c373c876fe7a822f14e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Configuration Impact"},{"line_number":83,"context_line":"--------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Configuration options should be added to setup pika client library."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a2fa921_cb72d5ad","line":85,"updated":"2015-10-05 16:19:47.000000000","message":"Do you expect to have the same level of complexity for configuration options? Less? More?","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"d7a873bea46d515980985aa9dee6f1bf48f38783","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Configuration Impact"},{"line_number":83,"context_line":"--------------------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Configuration options should be added to setup pika client library."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a2fa921_bc4a1782","line":85,"in_reply_to":"7a2fa921_cb72d5ad","updated":"2015-10-06 14:57:07.000000000","message":"hm. Complexity it is not correct worrect word I guess. I would be a few levels of options - pika connection options which represent pika possibility \n\n1) connection options (represents pika functionality):\n    \u0027channel_max\u0027 - Maximum number of channels to allow,\n    \u0027frame_max\u0027 - The maximum byte size for an AMQP frame,\n    \u0027heartbeat_interval\u0027 - How often to send heartbeats,\n    \u0027ssl\u0027 - Enable SSL or not,\n    \u0027ssl_options\u0027 - SSL options if ssl is enabled,\n    \u0027socket_timeout\u0027 - Socket timeout for pika connections,\n    \u0027locale\u0027 - Locale value,\n    \u0027backpressure_detection\u0027 - Enable backpressure detection or not\n\n2) connection pool options:\n    \u0027pool_max_size\u0027 - Maximum number of connections to keep queued,\n    \u0027pool_max_overflow\u0027 - Maximum number of connections to create above\n    \u0027pool_timeout\u0027 - Number of seconds to wait for available connection,\n    \u0027pool_recycle\u0027 - Lifetime of a connection (since creation) in seconds or None for no recycling. Expired connections are closed on acquire,\n    \u0027pool_stale\u0027 - Threshold at which inactive (since release) connections are considered stale in seconds or None for no staleness. Stale connections are closed on acquire\n\n3) reconnection policy options:\n     \u0027connection_retry\u0027 - Reconnecting retry count in case of connectivity problem,\n     \u0027connection_retry_delay\u0027 - Reconnecting retry delay in case of connectivity problem,\n     \u0027rejected_message_retry\u0027 - Resend rejected messages retry count,\n     \u0027rejected_message_retry_delay\u0027 - Resend rejected messages retry delay\n4) rpc options:\n    \u0027rpc_queue_expiration\u0027 - Time to live for rpc queues without consumers in seconds,\n    \u0027default_rpc_exchange\u0027 - Exchange name for for sending RPC messages,\n    \u0027rpc_reply_exchange\u0027, Exchange name for for receiving RPC replies.\n5) notification options:\n    \u0027notification_persistence\u0027 - Persist notification messages,\n    \u0027default_notification_exchange\u0027 - Exchange name for for sending notifications.\n\nAlso for backward compatibility next options will be supported:\n    \u0027rabbit_host\u0027 - The RabbitMQ broker address where a single node is used,\n    \u0027rabbit_port\u0027 - The RabbitMQ broker port where a single node is used,\n    \u0027rabbit_hosts\u0027 - RabbitMQ HA cluster host:port pairs,\n    \u0027rabbit_userid\u0027 - The RabbitMQ userid,\n    \u0027rabbit_password\u0027 - The RabbitMQ password.\n\nThat\u0027i it what will be available for configuration","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"1392de000057fe75fd3a3c373c876fe7a822f14e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"----------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Devstack should be adapted to be able to setup gate test environment with"},{"line_number":93,"context_line":"new driver."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Testing Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a2fa921_eb9a31c5","line":93,"updated":"2015-10-05 16:19:47.000000000","message":"This will actually require changes outside of devstack to create a plugin, similar to the zmq and amqp1 work.","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"d7a873bea46d515980985aa9dee6f1bf48f38783","unresolved":false,"context_lines":[{"line_number":90,"context_line":"----------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Devstack should be adapted to be able to setup gate test environment with"},{"line_number":93,"context_line":"new driver."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Testing Impact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a2fa921_f7b9882f","line":93,"in_reply_to":"7a2fa921_eb9a31c5","updated":"2015-10-06 14:57:07.000000000","message":"I don\u0027t think so. Yes, plugin is needed if we will leave devstack as is, but if we adapt it (it is just small configurable oprtion - rpc_backend - now it is hardcoded as \"rabbit\") we don\u0027t need plugin. ZMQ is different - but here we just changing driver implementation but still require RabbitMQ installed and configured, etc.","commit_id":"ad1fd463f675c1dd45775b38d2814566f7195d1e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d10620a020ed1c20123da533a32bd6f07b3ae9ff","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#. should be fully compatible with current driver interface;"},{"line_number":31,"context_line":"#. may change internals and does not guarantee compatibility with"},{"line_number":32,"context_line":"   Kombu driver (means you can not use old Kombu driver for some set"},{"line_number":33,"context_line":"   of services and new Pika driver for another services)"},{"line_number":34,"context_line":"#. support only current actual features without any deprecated features."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Features and it\u0027s design"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_24f51a56","line":33,"updated":"2015-10-08 16:01:27.000000000","message":"I agree we must not be compatible at all with the old drivers. Many issues of the old drivers are not due of the kombu usage, but just because the issues is really hard to solve without breaking rolling upgrade.","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4dcfe1ff12af94c9fdd67c5cb94fe709668691bd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Pika has it\u0027s own heartbeats mechanism. \u0027BlockingConnectioin\u0027 adapter has"},{"line_number":73,"context_line":"method \u0027process_data_events\u0027 which listen in loop response from RabbitMQ."},{"line_number":74,"context_line":"It should be executed after sending request or when consumers are registered."},{"line_number":75,"context_line":"This method run loop:"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    while not is_done():"},{"line_number":78,"context_line":"        self._impl.ioloop.poll()"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_eec97879","line":75,"updated":"2015-10-07 16:19:12.000000000","message":"If you end this line with 2 colons sphinx will render the block below as source code.","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"539768210906e05acd99219db843dc8172f4150b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Pika has it\u0027s own heartbeats mechanism. \u0027BlockingConnectioin\u0027 adapter has"},{"line_number":73,"context_line":"method \u0027process_data_events\u0027 which listen in loop response from RabbitMQ."},{"line_number":74,"context_line":"It should be executed after sending request or when consumers are registered."},{"line_number":75,"context_line":"This method run loop:"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    while not is_done():"},{"line_number":78,"context_line":"        self._impl.ioloop.poll()"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_4fa39c9d","line":75,"in_reply_to":"7a2fa921_eec97879","updated":"2015-10-11 09:52:11.000000000","message":"Will do, thank you.","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d10620a020ed1c20123da533a32bd6f07b3ae9ff","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Configuration Impact"},{"line_number":111,"context_line":"--------------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Configuration options should be added to setup Pika client library."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"The next configuration possibilities are suggested:"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_044c9e9c","line":113,"updated":"2015-10-08 16:01:27.000000000","message":"I have made some remark on this on the code itself, most of them looks like the dhellman one :)","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4dcfe1ff12af94c9fdd67c5cb94fe709668691bd","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Configuration options should be added to setup Pika client library."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"The next configuration possibilities are suggested:"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#. connection options (represents Pika functionality):"},{"line_number":118,"context_line":"   * \u0027channel_max\u0027 - Maximum number of channels to allow,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_8eeb24b0","line":115,"updated":"2015-10-07 16:19:12.000000000","message":"Could you add the default settings to the docs here, please?","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"539768210906e05acd99219db843dc8172f4150b","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Configuration options should be added to setup Pika client library."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"The next configuration possibilities are suggested:"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#. connection options (represents Pika functionality):"},{"line_number":118,"context_line":"   * \u0027channel_max\u0027 - Maximum number of channels to allow,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_0fa9247b","line":115,"in_reply_to":"7a2fa921_8eeb24b0","updated":"2015-10-11 09:52:11.000000000","message":"Will do","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d10620a020ed1c20123da533a32bd6f07b3ae9ff","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#. connection options (represents Pika functionality):"},{"line_number":118,"context_line":"   * \u0027channel_max\u0027 - Maximum number of channels to allow,"},{"line_number":119,"context_line":"   * \u0027frame_max\u0027 - The maximum byte size for an AMQP frame,"},{"line_number":120,"context_line":"   * \u0027heartbeat_interval\u0027 - How often to send heartbeats,"},{"line_number":121,"context_line":"   * \u0027ssl\u0027 - Enable SSL or not,"},{"line_number":122,"context_line":"   * \u0027ssl_options\u0027 - SSL options if ssl is enabled,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_bf55b7c2","line":119,"updated":"2015-10-08 16:01:27.000000000","message":"This looks weird to me ? What happens if the deployer sets this to a higher value than its network MTU ?","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"539768210906e05acd99219db843dc8172f4150b","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#. connection options (represents Pika functionality):"},{"line_number":118,"context_line":"   * \u0027channel_max\u0027 - Maximum number of channels to allow,"},{"line_number":119,"context_line":"   * \u0027frame_max\u0027 - The maximum byte size for an AMQP frame,"},{"line_number":120,"context_line":"   * \u0027heartbeat_interval\u0027 - How often to send heartbeats,"},{"line_number":121,"context_line":"   * \u0027ssl\u0027 - Enable SSL or not,"},{"line_number":122,"context_line":"   * \u0027ssl_options\u0027 - SSL options if ssl is enabled,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_1176c905","line":119,"in_reply_to":"7a2fa921_bf55b7c2","updated":"2015-10-11 09:52:11.000000000","message":"It is maximum data size of AMPQ frame. it works at application level. MTU  is working on TCP level so it we specify frame_max \u003e MTU - our frame will be split at TCP level and concatenated again ant TCP level at receiver side. by default it is 131072 bytes. It should be negotiated with broker configuration","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4dcfe1ff12af94c9fdd67c5cb94fe709668691bd","unresolved":false,"context_lines":[{"line_number":121,"context_line":"   * \u0027ssl\u0027 - Enable SSL or not,"},{"line_number":122,"context_line":"   * \u0027ssl_options\u0027 - SSL options if ssl is enabled,"},{"line_number":123,"context_line":"   * \u0027socket_timeout\u0027 - Socket timeout for Pika connections,"},{"line_number":124,"context_line":"   * \u0027locale\u0027 - Locale value,"},{"line_number":125,"context_line":"   * \u0027backpressure_detection\u0027 - Enable backpressure detection or not"},{"line_number":126,"context_line":"#. connection pool options:"},{"line_number":127,"context_line":"   * \u0027pool_max_size\u0027 - Maximum number of connections to keep queued,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_ee773838","line":124,"updated":"2015-10-07 16:19:12.000000000","message":"Why does pika  need a locale?","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"539768210906e05acd99219db843dc8172f4150b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"   * \u0027ssl\u0027 - Enable SSL or not,"},{"line_number":122,"context_line":"   * \u0027ssl_options\u0027 - SSL options if ssl is enabled,"},{"line_number":123,"context_line":"   * \u0027socket_timeout\u0027 - Socket timeout for Pika connections,"},{"line_number":124,"context_line":"   * \u0027locale\u0027 - Locale value,"},{"line_number":125,"context_line":"   * \u0027backpressure_detection\u0027 - Enable backpressure detection or not"},{"line_number":126,"context_line":"#. connection pool options:"},{"line_number":127,"context_line":"   * \u0027pool_max_size\u0027 - Maximum number of connections to keep queued,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_51de81dd","line":124,"in_reply_to":"7a2fa921_ee773838","updated":"2015-10-11 09:52:11.000000000","message":"It sends it to broker during establishing connection. information from AMQP reference: \"The locale defines the language in which the server will send reply texts\". Probably this option also should be removed from oslo.messaging configuration","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4dcfe1ff12af94c9fdd67c5cb94fe709668691bd","unresolved":false,"context_lines":[{"line_number":122,"context_line":"   * \u0027ssl_options\u0027 - SSL options if ssl is enabled,"},{"line_number":123,"context_line":"   * \u0027socket_timeout\u0027 - Socket timeout for Pika connections,"},{"line_number":124,"context_line":"   * \u0027locale\u0027 - Locale value,"},{"line_number":125,"context_line":"   * \u0027backpressure_detection\u0027 - Enable backpressure detection or not"},{"line_number":126,"context_line":"#. connection pool options:"},{"line_number":127,"context_line":"   * \u0027pool_max_size\u0027 - Maximum number of connections to keep queued,"},{"line_number":128,"context_line":"   * \u0027pool_max_overflow\u0027 - Maximum number of connections to create above"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_6e9a4865","line":125,"updated":"2015-10-07 16:19:12.000000000","message":"Why not always enable this?","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"539768210906e05acd99219db843dc8172f4150b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"   * \u0027ssl_options\u0027 - SSL options if ssl is enabled,"},{"line_number":123,"context_line":"   * \u0027socket_timeout\u0027 - Socket timeout for Pika connections,"},{"line_number":124,"context_line":"   * \u0027locale\u0027 - Locale value,"},{"line_number":125,"context_line":"   * \u0027backpressure_detection\u0027 - Enable backpressure detection or not"},{"line_number":126,"context_line":"#. connection pool options:"},{"line_number":127,"context_line":"   * \u0027pool_max_size\u0027 - Maximum number of connections to keep queued,"},{"line_number":128,"context_line":"   * \u0027pool_max_overflow\u0027 - Maximum number of connections to create above"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_11f009c8","line":125,"in_reply_to":"7a2fa921_6e9a4865","updated":"2015-10-11 09:52:11.000000000","message":"Hm... Sorry I have not investigated this option deep enough previously. TCP backpressure is used always. this options allows us to detect it by client and register callback for this event end do something on application level. But it seems it is internal feature for oslo.messaging driver and we don\u0027t need to add it for oslo,messaging configuration","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4dcfe1ff12af94c9fdd67c5cb94fe709668691bd","unresolved":false,"context_lines":[{"line_number":133,"context_line":"     considered stale in seconds or None for no staleness. Stale connections"},{"line_number":134,"context_line":"     are closed on acquire"},{"line_number":135,"context_line":"#. reconnection policy options:"},{"line_number":136,"context_line":"   * \u0027connection_retry\u0027 - Reconnecting retry count in case of connectivity"},{"line_number":137,"context_line":"     problem,"},{"line_number":138,"context_line":"   * \u0027connection_retry_delay\u0027 - Reconnecting retry delay in case of"},{"line_number":139,"context_line":"     connectivity problem,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_ce2fdcf4","line":136,"updated":"2015-10-07 16:19:12.000000000","message":"If this is a number, maybe include something in the name to indicate that, like \"connection_retry_attempts\"?","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"539768210906e05acd99219db843dc8172f4150b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"     considered stale in seconds or None for no staleness. Stale connections"},{"line_number":134,"context_line":"     are closed on acquire"},{"line_number":135,"context_line":"#. reconnection policy options:"},{"line_number":136,"context_line":"   * \u0027connection_retry\u0027 - Reconnecting retry count in case of connectivity"},{"line_number":137,"context_line":"     problem,"},{"line_number":138,"context_line":"   * \u0027connection_retry_delay\u0027 - Reconnecting retry delay in case of"},{"line_number":139,"context_line":"     connectivity problem,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_717a9d25","line":136,"in_reply_to":"7a2fa921_7f987fc0","updated":"2015-10-11 09:52:11.000000000","message":"retries are working not for listeners - there we have infinite loop where we execute driver\u0027s poll method and catch all possible exceptions. it is another story\n\nretries works for send and send_notification method. And a propose SLA here that these methods will try to cover connectivity problem (for example one node of RabbitMQ is down but we can reconnect to other node and perform operation) and if it isn\u0027t successful application logic gets ConnectionException. It means than RabbitMQ is permanently unavailable now and client can decide what to do next.\n\nSure, send and send_notifications have retry argument available for application logic. But I think it should perform retries of request based on application level error not Connectivity Error. For example we want to execute some request but our server responds that some resource is busy and can\u0027t execute that request. If application expects such behavior it can set retry to execute this request when resource become available","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d10620a020ed1c20123da533a32bd6f07b3ae9ff","unresolved":false,"context_lines":[{"line_number":133,"context_line":"     considered stale in seconds or None for no staleness. Stale connections"},{"line_number":134,"context_line":"     are closed on acquire"},{"line_number":135,"context_line":"#. reconnection policy options:"},{"line_number":136,"context_line":"   * \u0027connection_retry\u0027 - Reconnecting retry count in case of connectivity"},{"line_number":137,"context_line":"     problem,"},{"line_number":138,"context_line":"   * \u0027connection_retry_delay\u0027 - Reconnecting retry delay in case of"},{"line_number":139,"context_line":"     connectivity problem,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_7f987fc0","line":136,"in_reply_to":"7a2fa921_ce2fdcf4","updated":"2015-10-08 16:01:27.000000000","message":"More than that the oslo.messaging public API have a \u0027retry\u0027 parameter in many place that correspond of the connection retries in other drivers. I think this should be removed and just use the \u0027retry\u0027 parameter that go to the driver and retry indefinitely if this one is None. Like other driver does.\n\nAll applications expects the oslo.messaging listeners to block if the connection to rabbit is dead, they doesn\u0027t expect to got a exceptions.","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"539768210906e05acd99219db843dc8172f4150b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"     considered stale in seconds or None for no staleness. Stale connections"},{"line_number":134,"context_line":"     are closed on acquire"},{"line_number":135,"context_line":"#. reconnection policy options:"},{"line_number":136,"context_line":"   * \u0027connection_retry\u0027 - Reconnecting retry count in case of connectivity"},{"line_number":137,"context_line":"     problem,"},{"line_number":138,"context_line":"   * \u0027connection_retry_delay\u0027 - Reconnecting retry delay in case of"},{"line_number":139,"context_line":"     connectivity problem,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_31ebc5dd","line":136,"in_reply_to":"7a2fa921_ce2fdcf4","updated":"2015-10-11 09:52:11.000000000","message":"ok, will do","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4dcfe1ff12af94c9fdd67c5cb94fe709668691bd","unresolved":false,"context_lines":[{"line_number":137,"context_line":"     problem,"},{"line_number":138,"context_line":"   * \u0027connection_retry_delay\u0027 - Reconnecting retry delay in case of"},{"line_number":139,"context_line":"     connectivity problem,"},{"line_number":140,"context_line":"   * \u0027rejected_message_retry\u0027 - Resend rejected messages retry count,"},{"line_number":141,"context_line":"   * \u0027rejected_message_retry_delay\u0027 - Resend rejected messages retry delay"},{"line_number":142,"context_line":"#. rpc options:"},{"line_number":143,"context_line":"   * \u0027rpc_queue_expiration\u0027 - Time to live for rpc queues without consumers in"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_0e4634bf","line":140,"updated":"2015-10-07 16:19:12.000000000","message":"Same comment as for connection_retry.","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"539768210906e05acd99219db843dc8172f4150b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"     problem,"},{"line_number":138,"context_line":"   * \u0027connection_retry_delay\u0027 - Reconnecting retry delay in case of"},{"line_number":139,"context_line":"     connectivity problem,"},{"line_number":140,"context_line":"   * \u0027rejected_message_retry\u0027 - Resend rejected messages retry count,"},{"line_number":141,"context_line":"   * \u0027rejected_message_retry_delay\u0027 - Resend rejected messages retry delay"},{"line_number":142,"context_line":"#. rpc options:"},{"line_number":143,"context_line":"   * \u0027rpc_queue_expiration\u0027 - Time to live for rpc queues without consumers in"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_11756930","line":140,"in_reply_to":"7a2fa921_0e4634bf","updated":"2015-10-11 09:52:11.000000000","message":"will do","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4dcfe1ff12af94c9fdd67c5cb94fe709668691bd","unresolved":false,"context_lines":[{"line_number":145,"context_line":"   * \u0027default_rpc_exchange\u0027 - Exchange name for for sending RPC messages,"},{"line_number":146,"context_line":"   * \u0027rpc_reply_exchange\u0027, Exchange name for for receiving RPC replies."},{"line_number":147,"context_line":"#. notification options:"},{"line_number":148,"context_line":"   * \u0027notification_persistence\u0027 - Persist notification messages,"},{"line_number":149,"context_line":"   * \u0027default_notification_exchange\u0027 - Exchange name for for sending"},{"line_number":150,"context_line":"     notifications."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_2e6f702c","line":148,"updated":"2015-10-07 16:19:12.000000000","message":"Is this an option for the kombu driver? What does turning it off do? Why does it need to be an option if the semantics for notifications are guaranteed delivery?","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"539768210906e05acd99219db843dc8172f4150b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"   * \u0027default_rpc_exchange\u0027 - Exchange name for for sending RPC messages,"},{"line_number":146,"context_line":"   * \u0027rpc_reply_exchange\u0027, Exchange name for for receiving RPC replies."},{"line_number":147,"context_line":"#. notification options:"},{"line_number":148,"context_line":"   * \u0027notification_persistence\u0027 - Persist notification messages,"},{"line_number":149,"context_line":"   * \u0027default_notification_exchange\u0027 - Exchange name for for sending"},{"line_number":150,"context_line":"     notifications."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_31a745a8","line":148,"in_reply_to":"7a2fa921_2e6f702c","updated":"2015-10-11 09:52:11.000000000","message":"In kombu we have amqp_durable_queues. but it works for all queues (for rpc too, but it seems to me that we need it only for notifications now).\nby default in kombu amqp_durable_queues \u003d False. BTW if I turn it on by default a lot of our tempest tests get failed because of increased operation time and expired timeouts in our tests. So the main reason why it is False by default is our tempest tests (but probably I could change this option in devstack only). Probably using notification_persistence \u003d False is possible if we use rabbit cluster","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4dcfe1ff12af94c9fdd67c5cb94fe709668691bd","unresolved":false,"context_lines":[{"line_number":149,"context_line":"   * \u0027default_notification_exchange\u0027 - Exchange name for for sending"},{"line_number":150,"context_line":"     notifications."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Also for backward compatibility next options will be supported:"},{"line_number":153,"context_line":"* \u0027rabbit_host\u0027 - The RabbitMQ broker address where a single node is used,"},{"line_number":154,"context_line":"* \u0027rabbit_port\u0027 - The RabbitMQ broker port where a single node is used,"},{"line_number":155,"context_line":"* \u0027rabbit_hosts\u0027 - RabbitMQ HA cluster host:port pairs,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_ee9418e3","line":152,"updated":"2015-10-07 16:19:12.000000000","message":"If the plan is to create a new driver that needs to be enabled explicitly by the user, why do these options need to be included?","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"539768210906e05acd99219db843dc8172f4150b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"   * \u0027default_notification_exchange\u0027 - Exchange name for for sending"},{"line_number":150,"context_line":"     notifications."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Also for backward compatibility next options will be supported:"},{"line_number":153,"context_line":"* \u0027rabbit_host\u0027 - The RabbitMQ broker address where a single node is used,"},{"line_number":154,"context_line":"* \u0027rabbit_port\u0027 - The RabbitMQ broker port where a single node is used,"},{"line_number":155,"context_line":"* \u0027rabbit_hosts\u0027 - RabbitMQ HA cluster host:port pairs,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_11da4917","line":152,"in_reply_to":"7a2fa921_04657e1c","updated":"2015-10-11 09:52:11.000000000","message":"I will remove it with pleasure. I was decided with Dims and devstack team, because the don\u0027t want to make change in rpc_backend configuration. It was solution with minimal devstack change. But now they asked me to persuade them that it is necessary change at all and I think that it would be more easier to create devstack plugin in spite of huge copy/paste","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d10620a020ed1c20123da533a32bd6f07b3ae9ff","unresolved":false,"context_lines":[{"line_number":149,"context_line":"   * \u0027default_notification_exchange\u0027 - Exchange name for for sending"},{"line_number":150,"context_line":"     notifications."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Also for backward compatibility next options will be supported:"},{"line_number":153,"context_line":"* \u0027rabbit_host\u0027 - The RabbitMQ broker address where a single node is used,"},{"line_number":154,"context_line":"* \u0027rabbit_port\u0027 - The RabbitMQ broker port where a single node is used,"},{"line_number":155,"context_line":"* \u0027rabbit_hosts\u0027 - RabbitMQ HA cluster host:port pairs,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a2fa921_04657e1c","line":152,"in_reply_to":"7a2fa921_ee9418e3","updated":"2015-10-08 16:01:27.000000000","message":"I agree that should be removed.","commit_id":"5bbac651f3b8b67b6e6d2dda6e531c4ecf6bcca1"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"6d662320729342f57ae395cfc53ba78061ad9d38","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"In this specification I propose to create fully new driver which:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"#. sould be developed in optimal way regarding to all Pika client"},{"line_number":29,"context_line":"   library new features and best practices;"},{"line_number":30,"context_line":"#. should be fully compatible with current driver interface;"},{"line_number":31,"context_line":"#. may change internals and does not guarantee compatibility with"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_a993c54e","line":28,"updated":"2015-10-12 19:38:19.000000000","message":"\u0027sould\u0027 -\u003e \u0027should\u0027","commit_id":"4fec208ac203069b6ba7d02443d5cc79b137b856"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"6d662320729342f57ae395cfc53ba78061ad9d38","unresolved":false,"context_lines":[{"line_number":36,"context_line":"Features and it\u0027s design"},{"line_number":37,"context_line":"------------------------"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"During oslo.messaging driver investigation I separeted a few main"},{"line_number":40,"context_line":"supported features:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"#. RPC - unrelieble fast sending of the message to single remote server"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_699dad58","line":39,"updated":"2015-10-12 19:38:19.000000000","message":"separeted -\u003e separated","commit_id":"4fec208ac203069b6ba7d02443d5cc79b137b856"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"6d662320729342f57ae395cfc53ba78061ad9d38","unresolved":false,"context_lines":[{"line_number":39,"context_line":"During oslo.messaging driver investigation I separeted a few main"},{"line_number":40,"context_line":"supported features:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"#. RPC - unrelieble fast sending of the message to single remote server"},{"line_number":43,"context_line":"   defined using target and getting reply."},{"line_number":44,"context_line":"   It has small timeout (a couple of seconds) therefore this"},{"line_number":45,"context_line":"   message should be recieved by server and processed in real time"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_29a01590","line":42,"updated":"2015-10-12 19:38:19.000000000","message":"unrelieble -\u003e unreliable","commit_id":"4fec208ac203069b6ba7d02443d5cc79b137b856"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"6d662320729342f57ae395cfc53ba78061ad9d38","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Heartbeats"},{"line_number":70,"context_line":"----------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Pika has it\u0027s own heartbeats mechanism. \u0027BlockingConnectioin\u0027 adapter has"},{"line_number":73,"context_line":"method \u0027process_data_events\u0027 which listen in loop response from RabbitMQ."},{"line_number":74,"context_line":"It should be executed after sending request or when consumers are registered."},{"line_number":75,"context_line":"This method run loop:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_09caf94f","line":72,"updated":"2015-10-12 19:38:19.000000000","message":"BlockingConnectioin -\u003e BlockingConnection","commit_id":"4fec208ac203069b6ba7d02443d5cc79b137b856"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"6d662320729342f57ae395cfc53ba78061ad9d38","unresolved":false,"context_lines":[{"line_number":77,"context_line":"::"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":" while not is_done():"},{"line_number":80,"context_line":"     self._impl.ioloop.poll()"},{"line_number":81,"context_line":"     self._impl.ioloop.process_timeouts()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"where sends heartbeats (inside process_timeout_method) according to configured"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a2fa921_a9e185d2","line":80,"updated":"2015-10-12 19:38:19.000000000","message":"I hope poll takes a timeout, otherwise heartbeats will never get processed?","commit_id":"4fec208ac203069b6ba7d02443d5cc79b137b856"},{"author":{"_account_id":18805,"name":"Alexey Lebedev","email":"alebedev@mirantis.com","username":"binarin"},"change_message_id":"cafe011ceca6eda6d06bd802df5fd584c07bfa3c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"first of all, please update your environment to recommended library stack."},{"line_number":17,"context_line":"It is main reason of developing this driver."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also Pika supports modern RabbitMQ features, like direct reply and heatbeats."},{"line_number":20,"context_line":"I guess It is preferred way to use this functionality instead developing it"},{"line_number":21,"context_line":"ourselves."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a2ca52d_a919607b","line":19,"updated":"2015-10-14 15:07:09.000000000","message":"\u0027heatbeats\u0027 -\u003e \u0027heartbeats\u0027","commit_id":"5d2a26b7dc4d8656c5e955f74e91740ba51f904c"}]}
