)]}'
{"specs/ocata/oslo-validator.rst":[{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c84e093852c54515d1debb1c99f8bbd72a784090","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Configuration validation can help alleviate these issues by providing a way to"},{"line_number":25,"context_line":"validate options and configured values both manually, via cli, and on service"},{"line_number":26,"context_line":"start.  Operators have been asking for this functionality for some time now,"},{"line_number":27,"context_line":"as the deviance from version to version, with regard to options,"},{"line_number":28,"context_line":"can be substantial."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_7dc86a75","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":15},"updated":"2016-10-04 17:08:42.000000000","message":"s/deviance/deviation/","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6bd1caeb6ed3b1b8f78d24d3407b466d8764a1bf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Configuration validation can help alleviate these issues by providing a way to"},{"line_number":25,"context_line":"validate options and configured values both manually, via cli, and on service"},{"line_number":26,"context_line":"start.  Operators have been asking for this functionality for some time now,"},{"line_number":27,"context_line":"as the deviance from version to version, with regard to options,"},{"line_number":28,"context_line":"can be substantial."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Use Cases"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_8de4230e","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":15},"in_reply_to":"1a95cdbc_7dc86a75","updated":"2016-10-04 18:21:15.000000000","message":"Done","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"abacf94a36d826d6d693ea2c9bcd53253f2aeaeb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"start."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":46,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":47,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":48,"context_line":"configuration file will need to validate against.  In addition, `--conf_file`"},{"line_number":49,"context_line":"will be a required argument to indicate the location of their coniguration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_b32ce3ac","line":46,"updated":"2016-10-04 17:26:45.000000000","message":"IDK how much this changes the technical difficulty, but I suspect operators will be more likely to use this functionality if it\u0027s \"built-in\" to any app that uses oslo.config with a given flag, i.e. ironic-api --validate-config","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6bd1caeb6ed3b1b8f78d24d3407b466d8764a1bf","unresolved":false,"context_lines":[{"line_number":43,"context_line":"start."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":46,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":47,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":48,"context_line":"configuration file will need to validate against.  In addition, `--conf_file`"},{"line_number":49,"context_line":"will be a required argument to indicate the location of their coniguration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_adf1dfcf","line":46,"in_reply_to":"1a95cdbc_693eecb9","updated":"2016-10-04 18:21:15.000000000","message":"Done","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"23ef9b895b7c5ffe34c7a69315475721a52bd6c3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"start."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":46,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":47,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":48,"context_line":"configuration file will need to validate against.  In addition, `--conf_file`"},{"line_number":49,"context_line":"will be a required argument to indicate the location of their coniguration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_693eecb9","line":46,"in_reply_to":"1a95cdbc_b32ce3ac","updated":"2016-10-04 17:48:08.000000000","message":"This is a great idea on the implementation for each project.  You could support an argument that would validate your config.  The point of this spec is to support some type of validation, how each project uses it is up to them.  But, I would hope this would be an avenue as it\u0027s a great idea.  I know we could get support for this potentially on the Neutron side.","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"abacf94a36d826d6d693ea2c9bcd53253f2aeaeb","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":46,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":47,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":48,"context_line":"configuration file will need to validate against.  In addition, `--conf_file`"},{"line_number":49,"context_line":"will be a required argument to indicate the location of their coniguration"},{"line_number":50,"context_line":"file."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_73adfb30","line":47,"updated":"2016-10-04 17:26:45.000000000","message":"don\u0027t namespaces in oslo configurations exist outside of just what application is being run? In Ironic, we have namespaces for different drivers and different services all within the same application.","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"23ef9b895b7c5ffe34c7a69315475721a52bd6c3","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":46,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":47,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":48,"context_line":"configuration file will need to validate against.  In addition, `--conf_file`"},{"line_number":49,"context_line":"will be a required argument to indicate the location of their coniguration"},{"line_number":50,"context_line":"file."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_6e2272bb","line":47,"in_reply_to":"1a95cdbc_73adfb30","updated":"2016-10-04 17:48:08.000000000","message":"Correct, you would have to pass the namespaces you wish to check, just as generator gets passed these today to generate the sample files.","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6bd1caeb6ed3b1b8f78d24d3407b466d8764a1bf","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":46,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":47,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":48,"context_line":"configuration file will need to validate against.  In addition, `--conf_file`"},{"line_number":49,"context_line":"will be a required argument to indicate the location of their coniguration"},{"line_number":50,"context_line":"file."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_cdee2bec","line":47,"in_reply_to":"1a95cdbc_73adfb30","updated":"2016-10-04 18:21:15.000000000","message":"Done","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"8258caf4febc2ea8c648116ccad5ea65cb4b5232","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":46,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":47,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":48,"context_line":"configuration file will need to validate against.  In addition, `--conf_file`"},{"line_number":49,"context_line":"will be a required argument to indicate the location of their coniguration"},{"line_number":50,"context_line":"file."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_c98e2027","line":47,"in_reply_to":"1a95cdbc_73adfb30","updated":"2016-10-04 17:58:18.000000000","message":"So as an example, Neutron could create a similar shell script for validator that will traverse the namespaces the project uses: https://github.com/openstack/neutron/blob/master/tools/generate_config_file_samples.sh\n\nWhich is configured here: https://github.com/openstack/neutron/tree/master/etc/oslo-config-generator\n\nMight be too much detail here for this spec, but again the implementation can be similar to oslo-config-generator.\n\nhttps://github.com/openstack/oslo.config/blob/master/doc/source/generator.rst","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":16157,"name":"Ken Johnston","email":"kenny@kencjohnston.com","username":"kencjohnston"},"change_message_id":"cb0fdea4ea88d7e70ef5ca90c8a1d1b995fb802c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"file."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":53,"context_line":"and pass a required collection of configured options to check against the"},{"line_number":54,"context_line":"registered namespaces and options in `olso.config`.  Ideally, this would be"},{"line_number":55,"context_line":"performed on service start, after configuration files are ingested, and output"},{"line_number":56,"context_line":"to the configured log file."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_8ee7be3f","line":54,"range":{"start_line":53,"start_character":11,"end_line":54,"end_character":50},"updated":"2016-10-04 17:30:49.000000000","message":"From the keystone-manage doctor spec, this collection of configured options should become a set of best practices or known mis-configurations. We should state the experience for developers in defining and maintaining this set of \"shared knowledge\" over subsequent releases.","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6bd1caeb6ed3b1b8f78d24d3407b466d8764a1bf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"file."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":53,"context_line":"and pass a required collection of configured options to check against the"},{"line_number":54,"context_line":"registered namespaces and options in `olso.config`.  Ideally, this would be"},{"line_number":55,"context_line":"performed on service start, after configuration files are ingested, and output"},{"line_number":56,"context_line":"to the configured log file."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_edb927ee","line":54,"range":{"start_line":53,"start_character":11,"end_line":54,"end_character":50},"in_reply_to":"1a95cdbc_8ee7be3f","updated":"2016-10-04 18:21:15.000000000","message":"Done","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"188338262e1396aa5db036d9764b15b102c57868","unresolved":false,"context_lines":[{"line_number":50,"context_line":"file."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":53,"context_line":"and pass a required collection of configured options to check against the"},{"line_number":54,"context_line":"registered namespaces and options in `olso.config`.  Ideally, this would be"},{"line_number":55,"context_line":"performed on service start, after configuration files are ingested, and output"},{"line_number":56,"context_line":"to the configured log file."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_4972107e","line":54,"range":{"start_line":53,"start_character":11,"end_line":54,"end_character":50},"in_reply_to":"1a95cdbc_8ee7be3f","updated":"2016-10-04 17:53:07.000000000","message":"See below.","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c84e093852c54515d1debb1c99f8bbd72a784090","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":59,"context_line":"* Option not in namespace(error)"},{"line_number":60,"context_line":"* Option has no value(error)"},{"line_number":61,"context_line":"* Option has not value and is required(error)"},{"line_number":62,"context_line":"* Option value is not in range(error)"},{"line_number":63,"context_line":"* Option value is default, not required in config(warning)"},{"line_number":64,"context_line":"* Option is deprecated(warning)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_1d3a0637","line":61,"range":{"start_line":61,"start_character":13,"end_line":61,"end_character":16},"updated":"2016-10-04 17:08:42.000000000","message":"s/not/no/","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6bd1caeb6ed3b1b8f78d24d3407b466d8764a1bf","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":59,"context_line":"* Option not in namespace(error)"},{"line_number":60,"context_line":"* Option has no value(error)"},{"line_number":61,"context_line":"* Option has not value and is required(error)"},{"line_number":62,"context_line":"* Option value is not in range(error)"},{"line_number":63,"context_line":"* Option value is default, not required in config(warning)"},{"line_number":64,"context_line":"* Option is deprecated(warning)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_2db4eff0","line":61,"range":{"start_line":61,"start_character":13,"end_line":61,"end_character":16},"in_reply_to":"1a95cdbc_1d3a0637","updated":"2016-10-04 18:21:15.000000000","message":"Done","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"65bd1473c6bc94791d1a0bccf0fbd4c0951d58c9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* Option not in namespace(error)"},{"line_number":60,"context_line":"* Option has no value(error)"},{"line_number":61,"context_line":"* Option has not value and is required(error)"},{"line_number":62,"context_line":"* Option value is not in range(error)"},{"line_number":63,"context_line":"* Option value is default, not required in config(warning)"},{"line_number":64,"context_line":"* Option is deprecated(warning)"},{"line_number":65,"context_line":"* Option is advanced(warning)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_ba175853","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":37},"updated":"2016-10-04 16:34:39.000000000","message":"Would this include type validation?\nI don\u0027t see type validation on the list, but it is a common problem with users.  For example \u00272\u0027 vs 2","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6bd1caeb6ed3b1b8f78d24d3407b466d8764a1bf","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* Option not in namespace(error)"},{"line_number":60,"context_line":"* Option has no value(error)"},{"line_number":61,"context_line":"* Option has not value and is required(error)"},{"line_number":62,"context_line":"* Option value is not in range(error)"},{"line_number":63,"context_line":"* Option value is default, not required in config(warning)"},{"line_number":64,"context_line":"* Option is deprecated(warning)"},{"line_number":65,"context_line":"* Option is advanced(warning)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_6dcef784","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":37},"in_reply_to":"1a95cdbc_ba175853","updated":"2016-10-04 18:21:15.000000000","message":"Done","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"85464051ca661d4362e63f9442aedbb1f1654e1f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* Option not in namespace(error)"},{"line_number":60,"context_line":"* Option has no value(error)"},{"line_number":61,"context_line":"* Option has not value and is required(error)"},{"line_number":62,"context_line":"* Option value is not in range(error)"},{"line_number":63,"context_line":"* Option value is default, not required in config(warning)"},{"line_number":64,"context_line":"* Option is deprecated(warning)"},{"line_number":65,"context_line":"* Option is advanced(warning)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_ddedfe26","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":37},"in_reply_to":"1a95cdbc_ba175853","updated":"2016-10-04 16:37:19.000000000","message":"So this would be: value is not in the type \u0027choice\u0027 array of applicable values.  Good call out though, the type check would be a valuable add and I\u0027ll get it on the list here.","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"c84e093852c54515d1debb1c99f8bbd72a784090","unresolved":false,"context_lines":[{"line_number":65,"context_line":"* Option is advanced(warning)"},{"line_number":66,"context_line":"* Invalid namespace(error)"},{"line_number":67,"context_line":"* Missing namespace(warning)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Files to add:"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* oslo_config/oslo_config/validator.py"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_f8d72821","line":68,"updated":"2016-10-04 17:08:42.000000000","message":"Will the validator simply print warnings for all of these checks? If so, then the start-up module should probably skip all the invalid checks. Reason being that existing config validation in Oslo would prevent the service from starting if an invalid option is supplied. So those validator module warnings would be redundant (at service start, still useful for cli check).","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6bd1caeb6ed3b1b8f78d24d3407b466d8764a1bf","unresolved":false,"context_lines":[{"line_number":65,"context_line":"* Option is advanced(warning)"},{"line_number":66,"context_line":"* Invalid namespace(error)"},{"line_number":67,"context_line":"* Missing namespace(warning)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Files to add:"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* oslo_config/oslo_config/validator.py"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_adc8ff75","line":68,"in_reply_to":"1a95cdbc_f8d72821","updated":"2016-10-04 18:21:15.000000000","message":"Done","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"204d5998e1fc431f2d3ad06a9ac0ff58ce83f935","unresolved":false,"context_lines":[{"line_number":65,"context_line":"* Option is advanced(warning)"},{"line_number":66,"context_line":"* Invalid namespace(error)"},{"line_number":67,"context_line":"* Missing namespace(warning)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Files to add:"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"* oslo_config/oslo_config/validator.py"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_aef9da4f","line":68,"in_reply_to":"1a95cdbc_f8d72821","updated":"2016-10-04 17:43:57.000000000","message":"So not entirely true.  Say you misspelled username in [keystone_authtoken], the service will start without you knowing until your calls fail.  Now, validator could alert to this ahead of time.\n\nAnother example is misspelling an option where you have changed the value to something other than the default.  You think you are using the value you configured but in reality you are using the default value, validator could alert to this as well.\n\nNow, to your point about failing a process start, I think validator would return the correct response failed t/f, but it would be up to the project devs to determine if the process would stop.\n\nIt would also be up to the devs of each project to print out the returned \u0027report\u0027 in the log files, which would give a better synopsis of the config file state.","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":16157,"name":"Ken Johnston","email":"kenny@kencjohnston.com","username":"kencjohnston"},"change_message_id":"cb0fdea4ea88d7e70ef5ca90c8a1d1b995fb802c","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"This additional module will not require any dependencies."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"References"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"oslo.config: http://git.openstack.org/cgit/openstack/oslo.config/"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_8e1dfe68","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":10},"updated":"2016-10-04 17:30:49.000000000","message":"This seems similar in functionality to keystone-manage doctor. It would be good to reference it here. https://specs.openstack.org/openstack/keystone-specs/specs/keystone/newton/keystone-manage-doctor.html","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6bd1caeb6ed3b1b8f78d24d3407b466d8764a1bf","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"This additional module will not require any dependencies."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"References"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"oslo.config: http://git.openstack.org/cgit/openstack/oslo.config/"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_eda047a8","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":10},"in_reply_to":"1a95cdbc_8e1dfe68","updated":"2016-10-04 18:21:15.000000000","message":"Done","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"822f82fafae69b94a778dc078214650feec38be9","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"This additional module will not require any dependencies."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"References"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"oslo.config: http://git.openstack.org/cgit/openstack/oslo.config/"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a95cdbc_49ddb06f","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":10},"in_reply_to":"1a95cdbc_8e1dfe68","updated":"2016-10-04 17:50:44.000000000","message":"So this is just a primitive form of config validation.  Oslo.config has no opinion on what the best practice is for each project.  This is simply to point out common mistakes in configuration.  Now this could be a first step prior to any opinionated tool to scrub for the most basic things first.  But, for oslo.config to support an opinionated sort of validation is out of the scope.","commit_id":"70e6b4725bdc0ddeb4db445e741a55ec054120dc"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d5d1c84c753911e02861afe3694d165754ae3522","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_614b602c","line":49,"range":{"start_line":49,"start_character":39,"end_line":49,"end_character":46},"updated":"2016-10-04 20:00:54.000000000","message":"missing a verb","commit_id":"fefc1b2ae1bc50a597c7e6d9a4310cc292ae3d9d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"8e2a383c046f9bbc93d38bfd085969c159774147","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_223b16ed","line":49,"range":{"start_line":49,"start_character":39,"end_line":49,"end_character":46},"in_reply_to":"1a95cdbc_614b602c","updated":"2016-10-04 21:25:01.000000000","message":"Done","commit_id":"fefc1b2ae1bc50a597c7e6d9a4310cc292ae3d9d"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d5d1c84c753911e02861afe3694d165754ae3522","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":63,"context_line":"and pass a required collection of configured options to check against the"},{"line_number":64,"context_line":"registered namespaces and options in `olso.config`.  This could be"},{"line_number":65,"context_line":"performed on service start(example usage), after configuration files are"},{"line_number":66,"context_line":"ingested, and output to the configured log file.  It could be also used"},{"line_number":67,"context_line":"in each project as an additional argument, i.e. `ironic-api --validate-config`,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_e103f074","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":42},"updated":"2016-10-04 20:00:54.000000000","message":"typo","commit_id":"fefc1b2ae1bc50a597c7e6d9a4310cc292ae3d9d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"8e2a383c046f9bbc93d38bfd085969c159774147","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":63,"context_line":"and pass a required collection of configured options to check against the"},{"line_number":64,"context_line":"registered namespaces and options in `olso.config`.  This could be"},{"line_number":65,"context_line":"performed on service start(example usage), after configuration files are"},{"line_number":66,"context_line":"ingested, and output to the configured log file.  It could be also used"},{"line_number":67,"context_line":"in each project as an additional argument, i.e. `ironic-api --validate-config`,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_62251ec1","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":42},"in_reply_to":"1a95cdbc_e103f074","updated":"2016-10-04 21:25:01.000000000","message":"Done","commit_id":"fefc1b2ae1bc50a597c7e6d9a4310cc292ae3d9d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bdbbd4442a932efbe8c50919f28cb6e392ade4b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":" OSLO Config Validator"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/oslo.config/+spec/oslo-validator"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_765f9f72","line":2,"updated":"2016-10-04 21:47:59.000000000","message":"OSLO isn\u0027t an acronym. Use Oslo\n\nAlso, what\u0027s an oslo config? Suggest remove Oslo and call this \"Configuration Validator\".","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2249c584dfca846f0890f9acc6af8251144a27f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":" OSLO Config Validator"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/oslo.config/+spec/oslo-validator"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_d977c400","line":2,"in_reply_to":"1a95cdbc_765f9f72","updated":"2016-10-04 22:06:29.000000000","message":"Done","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bdbbd4442a932efbe8c50919f28cb6e392ade4b6","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would be a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_96898bcd","line":49,"range":{"start_line":49,"start_character":50,"end_line":49,"end_character":65},"updated":"2016-10-04 21:47:59.000000000","message":"What\u0027s a \"primitive check\"? Suggestion: remove \"primitive\".","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bdbbd4442a932efbe8c50919f28cb6e392ade4b6","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would be a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_d6fcf340","line":49,"range":{"start_line":49,"start_character":5,"end_line":49,"end_character":14},"updated":"2016-10-04 21:47:59.000000000","message":"what does \"start(example)\" mean?","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2249c584dfca846f0890f9acc6af8251144a27f8","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would be a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_f97480fe","line":49,"range":{"start_line":49,"start_character":50,"end_line":49,"end_character":65},"in_reply_to":"1a95cdbc_96898bcd","updated":"2016-10-04 22:06:29.000000000","message":"Done","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"4e922eb3da6ab646ffe10e513a87493eb8c34c29","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would be a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_f90000ad","line":49,"range":{"start_line":49,"start_character":50,"end_line":49,"end_character":65},"in_reply_to":"1a95cdbc_96898bcd","updated":"2016-10-04 21:59:52.000000000","message":"The checks are a clear comparison to registered options, meaning does the option exist in the namespace.  This would make no assumptions on whether this config option has been configured with a correct usable value, which is something keytron-manage-doc attempts to do. I would like to keep \"primitive\" but it could be switched out with \"basic\".  Need something here.","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"4e922eb3da6ab646ffe10e513a87493eb8c34c29","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would be a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_59265469","line":49,"range":{"start_line":49,"start_character":5,"end_line":49,"end_character":14},"in_reply_to":"1a95cdbc_d6fcf340","updated":"2016-10-04 21:59:52.000000000","message":"\"example usage\" might be clearer.  Basically, how it\u0027s implemented is up to the project.","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2249c584dfca846f0890f9acc6af8251144a27f8","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would be a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_39650845","line":49,"range":{"start_line":49,"start_character":5,"end_line":49,"end_character":14},"in_reply_to":"1a95cdbc_d6fcf340","updated":"2016-10-04 22:06:29.000000000","message":"Done","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bdbbd4442a932efbe8c50919f28cb6e392ade4b6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would be a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_f6a72f4d","line":51,"updated":"2016-10-04 21:47:59.000000000","message":"I don\u0027t see how it\u0027s possible that there\u0027s no opinion being given if the module is reporting errors and warnings.","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2249c584dfca846f0890f9acc6af8251144a27f8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would be a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_595ad484","line":51,"in_reply_to":"1a95cdbc_f6a72f4d","updated":"2016-10-04 22:06:29.000000000","message":"Done","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"4e922eb3da6ab646ffe10e513a87493eb8c34c29","unresolved":false,"context_lines":[{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example).  Oslo config validator would be a primitive check on common"},{"line_number":50,"context_line":"configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_59dd7441","line":51,"in_reply_to":"1a95cdbc_f6a72f4d","updated":"2016-10-04 21:59:52.000000000","message":"See above.  Basic checks, no opinion on if it\u0027s the best configuration, or if it will \"work\" with all openstack services or if it is performant.","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bdbbd4442a932efbe8c50919f28cb6e392ade4b6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":55,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":56,"context_line":"configuration file will need to validate against.  In addition, `--conf_file`"},{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"},{"line_number":59,"context_line":"the namespaces used by the project for validation, i.e:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_1631fb0b","line":56,"range":{"start_line":56,"start_character":24,"end_line":56,"end_character":31},"updated":"2016-10-04 21:47:59.000000000","message":"suggestion: remove \"need to\"","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"4e922eb3da6ab646ffe10e513a87493eb8c34c29","unresolved":false,"context_lines":[{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":55,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":56,"context_line":"configuration file will need to validate against.  In addition, `--conf_file`"},{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"},{"line_number":59,"context_line":"the namespaces used by the project for validation, i.e:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_99e7fc11","line":56,"range":{"start_line":56,"start_character":24,"end_line":56,"end_character":31},"in_reply_to":"1a95cdbc_1631fb0b","updated":"2016-10-04 21:59:52.000000000","message":"agree.","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"bdbbd4442a932efbe8c50919f28cb6e392ade4b6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"},{"line_number":59,"context_line":"the namespaces used by the project for validation, i.e:"},{"line_number":60,"context_line":"neutron/blob/master/tools/generate_config_file_samples.sh"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":63,"context_line":"and pass a required collection of configured options to check against the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_b9103850","line":60,"updated":"2016-10-04 21:47:59.000000000","message":"It would be easier for the project to provide an entrypoint that provides the config namespaces used by the project. Then oslo-config-validator could execute that entrypoint and not have to call a shell script.","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"4e922eb3da6ab646ffe10e513a87493eb8c34c29","unresolved":false,"context_lines":[{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"},{"line_number":59,"context_line":"the namespaces used by the project for validation, i.e:"},{"line_number":60,"context_line":"neutron/blob/master/tools/generate_config_file_samples.sh"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":63,"context_line":"and pass a required collection of configured options to check against the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_19884c22","line":60,"in_reply_to":"1a95cdbc_b9103850","updated":"2016-10-04 21:59:52.000000000","message":"Again, this is just an example of how each project can consume the module.  This is just how Neutron used oslo-config-generator, but there are other options on how both oslo-config-generator and olso-config-validator can be used.","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2249c584dfca846f0890f9acc6af8251144a27f8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"},{"line_number":59,"context_line":"the namespaces used by the project for validation, i.e:"},{"line_number":60,"context_line":"neutron/blob/master/tools/generate_config_file_samples.sh"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":63,"context_line":"and pass a required collection of configured options to check against the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a95cdbc_99545c55","line":60,"in_reply_to":"1a95cdbc_b9103850","updated":"2016-10-04 22:06:29.000000000","message":"Done","commit_id":"1d2ac80c1b0c13de48057710626921f794cd4628"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"32523738cb765a34e585d7615129f97972d9de8a","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":55,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":56,"context_line":"configuration file will validate against.  In addition, `--conf_file`"},{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_85ab0a89","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":40},"updated":"2016-10-05 05:38:15.000000000","message":"namespace is about","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"74e7759a6c407f433dd73954873afd4cd00957c2","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":55,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":56,"context_line":"configuration file will validate against.  In addition, `--conf_file`"},{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_c5951241","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":40},"in_reply_to":"1a95cdbc_85ab0a89","updated":"2016-10-05 05:38:41.000000000","message":"Forget that.","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"da8cd8b830d5cb730b2e656ec5cc1ea675c97adf","unresolved":false,"context_lines":[{"line_number":60,"context_line":"neutron/blob/master/tools/generate_config_file_samples.sh"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":63,"context_line":"and pass a required collection of configured options to check against the"},{"line_number":64,"context_line":"registered namespaces and options in `oslo.config`.  This could be"},{"line_number":65,"context_line":"performed on service start(example usage), after configuration files are"},{"line_number":66,"context_line":"ingested, and output to the configured log file.  It could be also used"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_d3b061f7","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":52},"updated":"2016-10-05 14:43:14.000000000","message":"I will rephrase my question bellow in context on this comment. How does the application will pass the complete options list when some options depends of an option value in the configuration file ? (Still think of options in library with driver like keystonemiddleware).","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"755fb35f101d91e87d54b75fde844d579a96c0b9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"neutron/blob/master/tools/generate_config_file_samples.sh"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":63,"context_line":"and pass a required collection of configured options to check against the"},{"line_number":64,"context_line":"registered namespaces and options in `oslo.config`.  This could be"},{"line_number":65,"context_line":"performed on service start(example usage), after configuration files are"},{"line_number":66,"context_line":"ingested, and output to the configured log file.  It could be also used"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_494ca2c7","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":52},"in_reply_to":"1a95cdbc_d3b061f7","updated":"2016-10-05 15:15:36.000000000","message":"In the Neutron world those are imported as well and I\u0027m certain other projects do the same.  They are registered and the conf file is parsed for values, same kind of behavior as oslo-config-generator but in reverse.","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"32523738cb765a34e585d7615129f97972d9de8a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"project implements config validation is out of the scope of this spec."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":73,"context_line":"* Option not in namespace(error)"},{"line_number":74,"context_line":"* Option has no value(error)"},{"line_number":75,"context_line":"* Option has no value and is required(error)"},{"line_number":76,"context_line":"* Option value is not in range(error)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_05c9ba78","line":73,"updated":"2016-10-05 05:38:15.000000000","message":"What about configuration that required only an another one is set to a particular value ?\n\nFor example, all keystone_authtoken options list and requirements depends on auth-type value.","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"92473840ad114c305eb80b0f8b617201aba72d0f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"project implements config validation is out of the scope of this spec."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":73,"context_line":"* Option not in namespace(error)"},{"line_number":74,"context_line":"* Option has no value(error)"},{"line_number":75,"context_line":"* Option has no value and is required(error)"},{"line_number":76,"context_line":"* Option value is not in range(error)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_46301602","line":73,"in_reply_to":"1a95cdbc_05c9ba78","updated":"2016-10-05 13:52:02.000000000","message":"Currently I don\u0027t believe there is a way to link dependencies in oslo.config with registered options and their values.  There was an initiative to develop a related_options with an array of options that are commonly used along with the option you are configuring.  But, it was put down in favor of expanding on help text.","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"c2af12b96b990348c54f75367e4fe0d9ebcfae08","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Files to add:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* oslo_config/oslo_config/validator.py"},{"line_number":87,"context_line":"* oslo_config/doc/validator.rst"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Files to modify:"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_0230ac9d","line":87,"updated":"2016-10-05 17:00:09.000000000","message":"I think this should be oslo_config/doc/source/validator.rst","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"90bddcd0ca65006a832b220c5d663c0f630ec295","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Files to add:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* oslo_config/oslo_config/validator.py"},{"line_number":87,"context_line":"* oslo_config/doc/validator.rst"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Files to modify:"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_0216eca6","line":87,"in_reply_to":"1a95cdbc_0230ac9d","updated":"2016-10-05 17:03:55.000000000","message":"Done","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"d2c99bc9871b42e2aae066bf2e1e66895d19f997","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Files to add:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* oslo_config/oslo_config/validator.py"},{"line_number":87,"context_line":"* oslo_config/doc/validator.rst"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Files to modify:"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_c2724449","line":87,"in_reply_to":"1a95cdbc_0230ac9d","updated":"2016-10-05 17:03:37.000000000","message":"yep, good catch","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"7d0cc01f44301b5d4e9344c4bf317c6d15183b98","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Files to add:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* oslo_config/oslo_config/validator.py"},{"line_number":87,"context_line":"* oslo_config/doc/validator.rst"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Files to modify:"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_e24ae082","line":87,"in_reply_to":"1a95cdbc_c2724449","updated":"2016-10-05 17:07:10.000000000","message":"Actually it\u0027s oslo.config/doc/source/validator.rst, I spoke too soon.","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"cadb45dba1b33337d856208f2a59026a9bbfef71","unresolved":false,"context_lines":[{"line_number":84,"context_line":"Files to add:"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* oslo_config/oslo_config/validator.py"},{"line_number":87,"context_line":"* oslo_config/doc/validator.rst"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Files to modify:"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a95cdbc_4d24a5ae","line":87,"in_reply_to":"1a95cdbc_e24ae082","updated":"2016-10-05 17:09:24.000000000","message":"Done","commit_id":"4391224752a9ff495128a980b6e5bc7378bc551a"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3fe46ff7c11529962ecff9235a81d33d0b71454f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":" Configiguration Validator"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/oslo.config/+spec/oslo-validator"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_e8b63589","line":2,"range":{"start_line":2,"start_character":1,"end_line":2,"end_character":16},"updated":"2016-10-05 22:32:32.000000000","message":"typo: Configuration","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"72d1da53139fdeabfdffc7e27be3b34eea6828c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":" Configiguration Validator"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/oslo.config/+spec/oslo-validator"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_9fe9611d","line":2,"range":{"start_line":2,"start_character":1,"end_line":2,"end_character":16},"in_reply_to":"1a95cdbc_e8b63589","updated":"2016-10-06 02:50:11.000000000","message":"Done","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3fe46ff7c11529962ecff9235a81d33d0b71454f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support the ability to validate oslo.config options at a basic level"},{"line_number":8,"context_line":"against an operator configuration file, as-well-as potentially validation"},{"line_number":9,"context_line":"of options on service start(example usage)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Problem description"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_a8634d19","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":42},"updated":"2016-10-05 22:32:32.000000000","message":"I think you can remove that.","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"72d1da53139fdeabfdffc7e27be3b34eea6828c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support the ability to validate oslo.config options at a basic level"},{"line_number":8,"context_line":"against an operator configuration file, as-well-as potentially validation"},{"line_number":9,"context_line":"of options on service start(example usage)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Problem description"},{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_7f8c957f","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":42},"in_reply_to":"1a95cdbc_a8634d19","updated":"2016-10-06 02:50:11.000000000","message":"No this was added to clear up confusion and to clearly highlight that how each project consumes the validator is up to them.","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3fe46ff7c11529962ecff9235a81d33d0b71454f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"* Invalid Options"},{"line_number":18,"context_line":"* Deprecated Options"},{"line_number":19,"context_line":"* Misspellings"},{"line_number":20,"context_line":"* Usage of Advanced Options(warnings)"},{"line_number":21,"context_line":"* Lack of Configured Required Options"},{"line_number":22,"context_line":"* Usage of Choices Outside of Scope"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_0871a1e0","line":20,"updated":"2016-10-05 22:32:32.000000000","message":"missing whitespace","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3fe46ff7c11529962ecff9235a81d33d0b71454f","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Configuration validation, in its basic form, can help alleviate these basic"},{"line_number":25,"context_line":"issues by providing a way to validate options and configured values both"},{"line_number":26,"context_line":"manually, via cli, and on service start(example usage).  Operators have been"},{"line_number":27,"context_line":"asking for this functionality for some time now, as the deviation from version"},{"line_number":28,"context_line":"to version, with regard to options, can be substantial."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_4873a9e7","line":26,"range":{"start_line":26,"start_character":39,"end_line":26,"end_character":54},"updated":"2016-10-05 22:32:32.000000000","message":"You can remove that.","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3fe46ff7c11529962ecff9235a81d33d0b71454f","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example usage).  Oslo config validator would be a basic check on"},{"line_number":50,"context_line":"common configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_485ac951","line":49,"range":{"start_line":49,"start_character":5,"end_line":49,"end_character":20},"updated":"2016-10-05 22:32:32.000000000","message":"I think, that one is unnecessary.","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3fe46ff7c11529962ecff9235a81d33d0b71454f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":63,"context_line":"and pass a required collection of configured options to check against the"},{"line_number":64,"context_line":"registered namespaces and options in `oslo.config`.  This could be"},{"line_number":65,"context_line":"performed on service start(example usage), after configuration files are"},{"line_number":66,"context_line":"ingested, and output to the configured log file.  It could be also used"},{"line_number":67,"context_line":"in each project as an additional argument, i.e. `ironic-api --validate-config`,"},{"line_number":68,"context_line":"where the configuration is then validated as a separate operation, if a shell"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_e83b95e9","line":65,"range":{"start_line":65,"start_character":26,"end_line":65,"end_character":41},"updated":"2016-10-05 22:32:32.000000000","message":"ditto","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3fe46ff7c11529962ecff9235a81d33d0b71454f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"project implements config validation is out of the scope of this spec."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":73,"context_line":"* Option not in namespace(error)"},{"line_number":74,"context_line":"* Option has no value(error)"},{"line_number":75,"context_line":"* Option has no value and is required(error)"},{"line_number":76,"context_line":"* Option value is not in range(error)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_cb29738b","line":73,"updated":"2016-10-05 22:32:32.000000000","message":"You need to add newline before first bullet point. Without that, listing is currently broken, and displayed in one blob.","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"72d1da53139fdeabfdffc7e27be3b34eea6828c1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"project implements config validation is out of the scope of this spec."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":73,"context_line":"* Option not in namespace(error)"},{"line_number":74,"context_line":"* Option has no value(error)"},{"line_number":75,"context_line":"* Option has no value and is required(error)"},{"line_number":76,"context_line":"* Option value is not in range(error)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_bfec5d2a","line":73,"in_reply_to":"1a95cdbc_cb29738b","updated":"2016-10-06 02:50:11.000000000","message":"Done","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3fe46ff7c11529962ecff9235a81d33d0b71454f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"-----------------------"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Minimal impact, as the consumption of validator can be determined for each"},{"line_number":102,"context_line":"project on service start(example usage), although it would be highly suggested."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Security impact"},{"line_number":105,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_4b3d63ba","line":102,"range":{"start_line":102,"start_character":24,"end_line":102,"end_character":39},"updated":"2016-10-05 22:32:32.000000000","message":"Unnecessary part.","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3fe46ff7c11529962ecff9235a81d33d0b71454f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Performance Impact"},{"line_number":110,"context_line":"------------------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"This could be an additional check on service start(example usage), which could"},{"line_number":113,"context_line":"have an impact on the time it would take to become fully operational.  At its"},{"line_number":114,"context_line":"most basic form, manual checks via cli would not have a performance impact."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a95cdbc_6b35bfd8","line":112,"range":{"start_line":112,"start_character":50,"end_line":112,"end_character":65},"updated":"2016-10-05 22:32:32.000000000","message":"ditto","commit_id":"de2ea75328ff4017d9caac0bc0078fe3f8de9bf0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f3605b4fc3dd5b21447539705abb8f324fa10a9","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is extremely easy to have invalid conf files for any project:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Incorrect Namespaces"},{"line_number":17,"context_line":"* Invalid Options"},{"line_number":18,"context_line":"* Deprecated Options"},{"line_number":19,"context_line":"* Misspellings"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_cc26cdcd","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":22},"updated":"2016-10-06 14:33:53.000000000","message":"Do you mean invalid group name?","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"58dd6e9125e3712e3a899b208ae589ff375f8417","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is extremely easy to have invalid conf files for any project:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Incorrect Namespaces"},{"line_number":17,"context_line":"* Invalid Options"},{"line_number":18,"context_line":"* Deprecated Options"},{"line_number":19,"context_line":"* Misspellings"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_c3b05846","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":22},"in_reply_to":"1a95cdbc_cc26cdcd","updated":"2016-10-06 15:54:52.000000000","message":"Section","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f3605b4fc3dd5b21447539705abb8f324fa10a9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"It is extremely easy to have invalid conf files for any project:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Incorrect Namespaces"},{"line_number":17,"context_line":"* Invalid Options"},{"line_number":18,"context_line":"* Deprecated Options"},{"line_number":19,"context_line":"* Misspellings"},{"line_number":20,"context_line":"* Usage of Advanced Options (warnings)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_2c03b110","line":17,"range":{"start_line":17,"start_character":10,"end_line":17,"end_character":17},"updated":"2016-10-06 14:33:53.000000000","message":"Do you mean option name?","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"58dd6e9125e3712e3a899b208ae589ff375f8417","unresolved":false,"context_lines":[{"line_number":14,"context_line":"It is extremely easy to have invalid conf files for any project:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* Incorrect Namespaces"},{"line_number":17,"context_line":"* Invalid Options"},{"line_number":18,"context_line":"* Deprecated Options"},{"line_number":19,"context_line":"* Misspellings"},{"line_number":20,"context_line":"* Usage of Advanced Options (warnings)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_a380ac47","line":17,"range":{"start_line":17,"start_character":10,"end_line":17,"end_character":17},"in_reply_to":"1a95cdbc_2c03b110","updated":"2016-10-06 15:54:52.000000000","message":"Correct, I\u0027ll fix","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f3605b4fc3dd5b21447539705abb8f324fa10a9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"* Misspellings"},{"line_number":20,"context_line":"* Usage of Advanced Options (warnings)"},{"line_number":21,"context_line":"* Lack of Configured Required Options"},{"line_number":22,"context_line":"* Usage of Choices Outside of Scope"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Configuration validation, in its basic form, can help alleviate these basic"},{"line_number":25,"context_line":"issues by providing a way to validate options and configured values both"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_2afe3637","line":22,"updated":"2016-10-06 14:33:53.000000000","message":"We should probably warn about having conf entries that match the defaults. Its not a problem, just makes upgrade harder if you really don\u0027t have a preference.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"58dd6e9125e3712e3a899b208ae589ff375f8417","unresolved":false,"context_lines":[{"line_number":19,"context_line":"* Misspellings"},{"line_number":20,"context_line":"* Usage of Advanced Options (warnings)"},{"line_number":21,"context_line":"* Lack of Configured Required Options"},{"line_number":22,"context_line":"* Usage of Choices Outside of Scope"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Configuration validation, in its basic form, can help alleviate these basic"},{"line_number":25,"context_line":"issues by providing a way to validate options and configured values both"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_23bbbc0f","line":22,"in_reply_to":"1a95cdbc_2afe3637","updated":"2016-10-06 15:54:52.000000000","message":"Yes, it\u0027s below but I\u0027ll list it here.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"01d5d92acea68d4344050f7efcb9cc046d4429b2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example usage).  Oslo config validator would be a basic check on"},{"line_number":50,"context_line":"common configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_4390d5ec","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":10},"updated":"2016-10-06 12:54:59.000000000","message":"s/or/and ?","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f3605b4fc3dd5b21447539705abb8f324fa10a9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example usage).  Oslo config validator would be a basic check on"},{"line_number":50,"context_line":"common configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_4a69c28a","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":10},"in_reply_to":"1a95cdbc_4390d5ec","updated":"2016-10-06 14:33:53.000000000","message":"+1 for and","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"e76cae311ed3dd812ea833c93e44a0398e0d42e7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example usage).  Oslo config validator would be a basic check on"},{"line_number":50,"context_line":"common configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_e597218e","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":10},"in_reply_to":"1a95cdbc_4390d5ec","updated":"2016-10-06 14:03:01.000000000","message":"Done","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"58dd6e9125e3712e3a899b208ae589ff375f8417","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The new validator module would offer two avenues for consumption: cli"},{"line_number":48,"context_line":"command or the ability to import the validator for use during service"},{"line_number":49,"context_line":"start(example usage).  Oslo config validator would be a basic check on"},{"line_number":50,"context_line":"common configuration mistakes and in no way offers an opinion on a correct"},{"line_number":51,"context_line":"configuration or a desired configuration."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_633b049d","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":10},"in_reply_to":"1a95cdbc_4a69c28a","updated":"2016-10-06 15:54:52.000000000","message":"Done","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"01d5d92acea68d4344050f7efcb9cc046d4429b2","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":55,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":56,"context_line":"configuration file will validate against.  In addition, `--conf_file`"},{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_d6e821e5","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":70},"updated":"2016-10-06 12:54:59.000000000","message":"Does the \u0027namespace\u0027 has same meaning as namespaces like https://github.com/openstack/nova/blob/master/etc/nova/nova-config-generator.conf.  From your description it means application, right? Maybe we need choose another word .","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"58dd6e9125e3712e3a899b208ae589ff375f8417","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":55,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":56,"context_line":"configuration file will validate against.  In addition, `--conf_file`"},{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_43b7e8d7","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":70},"in_reply_to":"1a95cdbc_2a5ab64f","updated":"2016-10-06 15:54:52.000000000","message":"So olso-config-generator does have a --namespace argument but if the generator-config-file is specified, this is pulled from the generator-config-file.  I\u0027ll add further clarification.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"c30f7d03baf30b9f919bdf2a13bb7dda7cc990d2","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":55,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":56,"context_line":"configuration file will validate against.  In addition, `--conf_file`"},{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_25aca933","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":70},"in_reply_to":"1a95cdbc_d6e821e5","updated":"2016-10-06 14:03:40.000000000","message":"Done","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"e76cae311ed3dd812ea833c93e44a0398e0d42e7","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":55,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":56,"context_line":"configuration file will validate against.  In addition, `--conf_file`"},{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_653871a1","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":70},"in_reply_to":"1a95cdbc_d6e821e5","updated":"2016-10-06 14:03:01.000000000","message":"No this is exactly what I mean.  The operation is identical to oslo-config-generator at this level.  Will change to application namespace to clarify.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f3605b4fc3dd5b21447539705abb8f324fa10a9","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":54,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":55,"context_line":"be able to pass an argument `--namespace` to indicate what application their"},{"line_number":56,"context_line":"configuration file will validate against.  In addition, `--conf_file`"},{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_2a5ab64f","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":70},"in_reply_to":"1a95cdbc_d6e821e5","updated":"2016-10-06 14:33:53.000000000","message":"So to generate the example config we have:\n\n  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf\n\nFor policy we have:\n\n  oslopolicy-sample-generator --config-file\u003detc/nova/nova-policy-generator.conf\n  oslopolicy-list-redundant --namespace nova\n  oslopolicy-policy-generator --namespace nova --output-file policy-merged.yaml\n\nI guess I was expecting something like this:\n\n  oslo-config-validator --generator-config-file\u003detc/nova/nova-config-generator.conf --config-file\u003detc/nova/nova.conf\n\nBut you are going a bit more like the olsopolicy way, which seems odd I guess.\n\nWe should probably be clear on the return value, I assume the return value is 0 if there are no warnings and no errors. But we should be clear we get a non-zero return if there are warnings or errors?","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f3605b4fc3dd5b21447539705abb8f324fa10a9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"},{"line_number":59,"context_line":"the namespaces used by the project for validation, i.e:"},{"line_number":60,"context_line":"neutron/blob/master/tools/generate_config_file_samples.sh"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":63,"context_line":"and pass a required collection of configured options to check against the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_ca48728a","line":60,"range":{"start_line":60,"start_character":20,"end_line":60,"end_character":57},"updated":"2016-10-06 14:33:53.000000000","message":"Nit: I assume we only need the end of that file listing really, this is part of a git hub url I guess?","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"58dd6e9125e3712e3a899b208ae589ff375f8417","unresolved":false,"context_lines":[{"line_number":57,"context_line":"will be a required argument to indicate the location of their configuration"},{"line_number":58,"context_line":"file. Ideally, each project would implement a shell script tool to traverse"},{"line_number":59,"context_line":"the namespaces used by the project for validation, i.e:"},{"line_number":60,"context_line":"neutron/blob/master/tools/generate_config_file_samples.sh"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":63,"context_line":"and pass a required collection of configured options to check against the"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_c3a4d8a7","line":60,"range":{"start_line":60,"start_character":20,"end_line":60,"end_character":57},"in_reply_to":"1a95cdbc_ca48728a","updated":"2016-10-06 15:54:52.000000000","message":"No it\u0027s the path in neutron to the shell script as an example.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"01d5d92acea68d4344050f7efcb9cc046d4429b2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"ingested, and output to the configured log file.  It could be also used"},{"line_number":67,"context_line":"in each project as an additional argument, i.e. `ironic-api --validate-config`,"},{"line_number":68,"context_line":"where the configuration is then validated as a separate operation, if a shell"},{"line_number":69,"context_line":"script is not developed above.  Both options would be available, how each"},{"line_number":70,"context_line":"project implements config validation is out of the scope of this spec."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_96369950","line":70,"range":{"start_line":69,"start_character":32,"end_line":70,"end_character":70},"updated":"2016-10-06 12:54:59.000000000","message":"I think we need describe more details about how to integrate it into projects. what kind of interface will be provided in the oslo.config.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"e76cae311ed3dd812ea833c93e44a0398e0d42e7","unresolved":false,"context_lines":[{"line_number":66,"context_line":"ingested, and output to the configured log file.  It could be also used"},{"line_number":67,"context_line":"in each project as an additional argument, i.e. `ironic-api --validate-config`,"},{"line_number":68,"context_line":"where the configuration is then validated as a separate operation, if a shell"},{"line_number":69,"context_line":"script is not developed above.  Both options would be available, how each"},{"line_number":70,"context_line":"project implements config validation is out of the scope of this spec."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_053c0d2e","line":70,"range":{"start_line":69,"start_character":32,"end_line":70,"end_character":70},"in_reply_to":"1a95cdbc_96369950","updated":"2016-10-06 14:03:01.000000000","message":"Hmm, wasn\u0027t my desire to go into too much detail here as we will shape what this looks like when the patch goes up.  The actual available ways to implement this might be very different and take a different path as we all contribute to molding the validator module.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f3605b4fc3dd5b21447539705abb8f324fa10a9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"ingested, and output to the configured log file.  It could be also used"},{"line_number":67,"context_line":"in each project as an additional argument, i.e. `ironic-api --validate-config`,"},{"line_number":68,"context_line":"where the configuration is then validated as a separate operation, if a shell"},{"line_number":69,"context_line":"script is not developed above.  Both options would be available, how each"},{"line_number":70,"context_line":"project implements config validation is out of the scope of this spec."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_cc5fad3f","line":70,"range":{"start_line":69,"start_character":32,"end_line":70,"end_character":70},"in_reply_to":"1a95cdbc_96369950","updated":"2016-10-06 14:33:53.000000000","message":"I would take one particular use case, how to fail on startup of a service if the configuration file has any errors (ignores warnings), and just make sure thats possible, and give the example of how that happens here.\n\nI guess you might return a list of errors in objects that represent the list blow, and that could all be logged out nicely? Unsure.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"01d5d92acea68d4344050f7efcb9cc046d4429b2","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* Option not in namespace(error)"},{"line_number":75,"context_line":"* Option has no value(error)"},{"line_number":76,"context_line":"* Option has no value and is required(error)"},{"line_number":77,"context_line":"* Option value is not in range(error)"},{"line_number":78,"context_line":"* Option value is default, not required in config(warning)"},{"line_number":79,"context_line":"* Option is deprecated(warning)"},{"line_number":80,"context_line":"* Option is advanced(warning)"},{"line_number":81,"context_line":"* Option type validation, i.e. \u00272\u0027 vs 2(error)"},{"line_number":82,"context_line":"* Invalid namespace(error)"},{"line_number":83,"context_line":"* Missing namespace(warning)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Files to add:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_76f2ed70","line":83,"range":{"start_line":74,"start_character":0,"end_line":83,"end_character":28},"updated":"2016-10-06 12:54:59.000000000","message":"Does namespace mean option group or sections here ?","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"c30f7d03baf30b9f919bdf2a13bb7dda7cc990d2","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* Option not in namespace(error)"},{"line_number":75,"context_line":"* Option has no value(error)"},{"line_number":76,"context_line":"* Option has no value and is required(error)"},{"line_number":77,"context_line":"* Option value is not in range(error)"},{"line_number":78,"context_line":"* Option value is default, not required in config(warning)"},{"line_number":79,"context_line":"* Option is deprecated(warning)"},{"line_number":80,"context_line":"* Option is advanced(warning)"},{"line_number":81,"context_line":"* Option type validation, i.e. \u00272\u0027 vs 2(error)"},{"line_number":82,"context_line":"* Invalid namespace(error)"},{"line_number":83,"context_line":"* Missing namespace(warning)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Files to add:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_45a7f54e","line":83,"range":{"start_line":74,"start_character":0,"end_line":83,"end_character":28},"in_reply_to":"1a95cdbc_76f2ed70","updated":"2016-10-06 14:03:40.000000000","message":"Done","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"e76cae311ed3dd812ea833c93e44a0398e0d42e7","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Oslo config validator would report on the following discrepancies:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"* Option not in namespace(error)"},{"line_number":75,"context_line":"* Option has no value(error)"},{"line_number":76,"context_line":"* Option has no value and is required(error)"},{"line_number":77,"context_line":"* Option value is not in range(error)"},{"line_number":78,"context_line":"* Option value is default, not required in config(warning)"},{"line_number":79,"context_line":"* Option is deprecated(warning)"},{"line_number":80,"context_line":"* Option is advanced(warning)"},{"line_number":81,"context_line":"* Option type validation, i.e. \u00272\u0027 vs 2(error)"},{"line_number":82,"context_line":"* Invalid namespace(error)"},{"line_number":83,"context_line":"* Missing namespace(warning)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Files to add:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_859f3db3","line":83,"range":{"start_line":74,"start_character":0,"end_line":83,"end_character":28},"in_reply_to":"1a95cdbc_76f2ed70","updated":"2016-10-06 14:03:01.000000000","message":"Namespace refers to section.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f3605b4fc3dd5b21447539705abb8f324fa10a9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"* Invalid namespace(error)"},{"line_number":83,"context_line":"* Missing namespace(warning)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Files to add:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* oslo.config/oslo_config/validator.py"},{"line_number":88,"context_line":"* oslo.config/doc/source/validator.rst"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Files to modify:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* oslo.config/setup.cfg"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_4f838f56","line":92,"range":{"start_line":85,"start_character":0,"end_line":92,"end_character":23},"updated":"2016-10-06 14:33:53.000000000","message":"Hmm, sees odd to see that in a spec, is that a normal oslo thing?","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"58dd6e9125e3712e3a899b208ae589ff375f8417","unresolved":false,"context_lines":[{"line_number":82,"context_line":"* Invalid namespace(error)"},{"line_number":83,"context_line":"* Missing namespace(warning)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Files to add:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* oslo.config/oslo_config/validator.py"},{"line_number":88,"context_line":"* oslo.config/doc/source/validator.rst"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Files to modify:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"* oslo.config/setup.cfg"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_03224000","line":92,"range":{"start_line":85,"start_character":0,"end_line":92,"end_character":23},"in_reply_to":"1a95cdbc_4f838f56","updated":"2016-10-06 15:54:52.000000000","message":"Noticed this in other olso specs, just maintaining consistency.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f3605b4fc3dd5b21447539705abb8f324fa10a9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Impact on Existing APIs"},{"line_number":100,"context_line":"-----------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Minimal impact, as the consumption of validator can be determined for each"},{"line_number":103,"context_line":"project on service start(example usage), although it would be highly suggested."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_2f8d637b","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":14},"updated":"2016-10-06 14:33:53.000000000","message":"None?","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"58dd6e9125e3712e3a899b208ae589ff375f8417","unresolved":false,"context_lines":[{"line_number":99,"context_line":"Impact on Existing APIs"},{"line_number":100,"context_line":"-----------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"Minimal impact, as the consumption of validator can be determined for each"},{"line_number":103,"context_line":"project on service start(example usage), although it would be highly suggested."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_43c8c822","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":14},"in_reply_to":"1a95cdbc_2f8d637b","updated":"2016-10-06 15:54:52.000000000","message":"I guess None, yes.  It\u0027s existence doesn\u0027t immediately require any changes.","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8f3605b4fc3dd5b21447539705abb8f324fa10a9","unresolved":false,"context_lines":[{"line_number":159,"context_line":"Adoption"},{"line_number":160,"context_line":"--------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"It is likely that this module will be used throughout Openstack as it satisfies"},{"line_number":163,"context_line":"operator need surrounding the complexity of configuration files."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Library"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a95cdbc_aff7b3f3","line":162,"range":{"start_line":162,"start_character":54,"end_line":162,"end_character":63},"updated":"2016-10-06 14:33:53.000000000","message":"Nit: OpenStack","commit_id":"8cc521920cc4392d7528f6fe3da1376b902cb19d"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4b47ebb9c3b4f5878b344c7462cc6e7791876218","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* Usage of Advanced Options (warnings)"},{"line_number":21,"context_line":"* Lack of Configured Required Options"},{"line_number":22,"context_line":"* Usage of Choices Outside of Scope"},{"line_number":23,"context_line":"* Usage of Default Values in Configuration File"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Configuration validation, in its basic form, can help alleviate these basic"},{"line_number":26,"context_line":"issues by providing a way to validate options and configured values both"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_f4b97e16","line":23,"updated":"2016-10-06 19:37:33.000000000","message":"`keystone-manage doctor` also does configuration validation, but it doesn\u0027t cover any of these universally-applicable cases. Instead `doctor` looks for things like combinations of config that are unsupported or not recommended, and it\u0027s also in a position to validate the state of our database. I\u0027d love to be able to include validation for all of these items in keystone-manage doctor\u0027s output.\n\n  https://specs.openstack.org/openstack/keystone-specs/specs/keystone/newton/keystone-manage-doctor.html","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"1de788d88ffc15b6a2a339f667626381d9c56abc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* Usage of Advanced Options (warnings)"},{"line_number":21,"context_line":"* Lack of Configured Required Options"},{"line_number":22,"context_line":"* Usage of Choices Outside of Scope"},{"line_number":23,"context_line":"* Usage of Default Values in Configuration File"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Configuration validation, in its basic form, can help alleviate these basic"},{"line_number":26,"context_line":"issues by providing a way to validate options and configured values both"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_5fa96b8f","line":23,"in_reply_to":"1a95cdbc_f4b97e16","updated":"2016-10-06 19:47:54.000000000","message":"No overlap is good, this is just for basic checks.  I hope other project employ other opinionated tools like keystone!","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4b47ebb9c3b4f5878b344c7462cc6e7791876218","unresolved":false,"context_lines":[{"line_number":49,"context_line":"command and the ability to import the validator for use during service"},{"line_number":50,"context_line":"start(example usage).  Oslo config validator would be a basic check on"},{"line_number":51,"context_line":"common configuration mistakes and in no way offers an opinion on a correct"},{"line_number":52,"context_line":"configuration or a desired configuration."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":55,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_94e91ae9","line":52,"updated":"2016-10-06 19:37:33.000000000","message":"\u003e and in no way offers an opinion on a correct configuration or a desired configuration\n\nCool; that\u0027s precisely the use case for `keystone-manage doctor` today.","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"1de788d88ffc15b6a2a339f667626381d9c56abc","unresolved":false,"context_lines":[{"line_number":49,"context_line":"command and the ability to import the validator for use during service"},{"line_number":50,"context_line":"start(example usage).  Oslo config validator would be a basic check on"},{"line_number":51,"context_line":"common configuration mistakes and in no way offers an opinion on a correct"},{"line_number":52,"context_line":"configuration or a desired configuration."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":55,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_7fb707f5","line":52,"in_reply_to":"1a95cdbc_94e91ae9","updated":"2016-10-06 19:47:54.000000000","message":"Perfect.","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"563c57745eaa49eac004266f83d75b997c77c696","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"For cli usage, a new entry point will be added to oslo.config,"},{"line_number":55,"context_line":"`oslo-config-validator`.  Similar to `oslo-config-generator`, operators will"},{"line_number":56,"context_line":"be able to pass an argument, `--namespace`, to indicate what application"},{"line_number":57,"context_line":"namespace their configuration file will validate against.  Or, optionally an"},{"line_number":58,"context_line":"operator/developer can pass `--validator-config-file`, which would contain the"},{"line_number":59,"context_line":"application namespaces. In addition, `--config-file` will be a required"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da36d5c6_b4d64025","line":56,"updated":"2017-02-21 19:16:32.000000000","message":"Can I pass namespace multiple times to support multiple namespaces?","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"563c57745eaa49eac004266f83d75b997c77c696","unresolved":false,"context_lines":[{"line_number":60,"context_line":"argument to indicate the location of their configuration file. Ideally, each"},{"line_number":61,"context_line":"project would implement a shell script tool to traverse the namespaces used"},{"line_number":62,"context_line":"by the project for validation.  For example, here is the usage in Neutron:"},{"line_number":63,"context_line":"neutron/blob/master/tools/generate_config_file_samples.sh"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":66,"context_line":"and pass a required collection of configured options to check against the"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da36d5c6_f4aef896","line":63,"updated":"2017-02-21 19:16:32.000000000","message":"keystone has config-generator/keystone.conf which lists the namespaces already. Can we continue to use that?\n\n[1] https://github.com/openstack/keystone/blob/master/config-generator/keystone.conf","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"563c57745eaa49eac004266f83d75b997c77c696","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For module import, developers will be able to utilize `validator.validate`"},{"line_number":66,"context_line":"and pass a required collection of configured options to check against the"},{"line_number":67,"context_line":"registered namespaces and options in `oslo.config`.  This could be"},{"line_number":68,"context_line":"performed on service start(example usage), after configuration files are"},{"line_number":69,"context_line":"ingested, and output to the configured log file.  It could be also used"},{"line_number":70,"context_line":"in each project as an additional argument, i.e. `ironic-api --validate-config`,"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da36d5c6_b492c049","line":67,"range":{"start_line":67,"start_character":26,"end_line":67,"end_character":50},"updated":"2017-02-21 19:16:32.000000000","message":"what does this mean?","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4b47ebb9c3b4f5878b344c7462cc6e7791876218","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    invalid_configuration_items[\u0027config_warnings\u0027] \u003d ["},{"line_number":94,"context_line":"        {\u0027config_item\u0027: \u0027option\u0027, \u0027item_name\u0027: \u0027auth_strategy\u0027,"},{"line_number":95,"context_line":"         \u0027message\u0027: \u0027Option is configured with the default value, not required.\u0027},"},{"line_number":96,"context_line":"        {\u0027config_item\u0027: \u0027option\u0027, \u0027item_name\u0027: \u0027some_advanced_option\u0027,"},{"line_number":97,"context_line":"         \u0027message\u0027: \u0027Option some_advanced_option is an advanced option and may\u0027"},{"line_number":98,"context_line":"                    \u0027effect performance.\u0027},"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_743e4edb","line":95,"updated":"2016-10-06 19:37:33.000000000","message":"nit: I don\u0027t understand this particular message?","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"1de788d88ffc15b6a2a339f667626381d9c56abc","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    invalid_configuration_items[\u0027config_warnings\u0027] \u003d ["},{"line_number":94,"context_line":"        {\u0027config_item\u0027: \u0027option\u0027, \u0027item_name\u0027: \u0027auth_strategy\u0027,"},{"line_number":95,"context_line":"         \u0027message\u0027: \u0027Option is configured with the default value, not required.\u0027},"},{"line_number":96,"context_line":"        {\u0027config_item\u0027: \u0027option\u0027, \u0027item_name\u0027: \u0027some_advanced_option\u0027,"},{"line_number":97,"context_line":"         \u0027message\u0027: \u0027Option some_advanced_option is an advanced option and may\u0027"},{"line_number":98,"context_line":"                    \u0027effect performance.\u0027},"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_7f29c736","line":95,"in_reply_to":"1a95cdbc_743e4edb","updated":"2016-10-06 19:47:54.000000000","message":"Basically, you are using a default value in your configuration file, not really needed in the configuration file as the registered option is already assigning the default.  I wouldn\u0027t get too caught up with the exact messages here, this is just to highlight an example of some type of data structure being returned from validator, indicating the failures.","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"eff76ffad6f71e25ea316302c03b390b40618a9b","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    invalid_configuration_items[\u0027config_warnings\u0027] \u003d ["},{"line_number":94,"context_line":"        {\u0027config_item\u0027: \u0027option\u0027, \u0027item_name\u0027: \u0027auth_strategy\u0027,"},{"line_number":95,"context_line":"         \u0027message\u0027: \u0027Option is configured with the default value, not required.\u0027},"},{"line_number":96,"context_line":"        {\u0027config_item\u0027: \u0027option\u0027, \u0027item_name\u0027: \u0027some_advanced_option\u0027,"},{"line_number":97,"context_line":"         \u0027message\u0027: \u0027Option some_advanced_option is an advanced option and may\u0027"},{"line_number":98,"context_line":"                    \u0027effect performance.\u0027},"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_da490962","line":95,"in_reply_to":"1a95cdbc_7f29c736","updated":"2016-10-06 19:58:30.000000000","message":"Ah, that makes sense. I\u0027m sure the message could convey that more clearly without being too verbose, but it makes perfect sense to me now that I understand the intent.","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4b47ebb9c3b4f5878b344c7462cc6e7791876218","unresolved":false,"context_lines":[{"line_number":95,"context_line":"         \u0027message\u0027: \u0027Option is configured with the default value, not required.\u0027},"},{"line_number":96,"context_line":"        {\u0027config_item\u0027: \u0027option\u0027, \u0027item_name\u0027: \u0027some_advanced_option\u0027,"},{"line_number":97,"context_line":"         \u0027message\u0027: \u0027Option some_advanced_option is an advanced option and may\u0027"},{"line_number":98,"context_line":"                    \u0027effect performance.\u0027},"},{"line_number":99,"context_line":"    ]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"These are just examples of data structures potentially being returned and"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_1f4fe36b","line":98,"updated":"2016-10-06 19:37:33.000000000","message":"Most of this spec proposes checks for corrections that are fairly obvious to correct once they\u0027ve been spotted. In this case, there\u0027s a hint here at usage of some_advanced_option requiring careful (re)consideration. In this case, keystone-manage doctor makes a point to explain why the current setting may not be ideal and why a different value would be more reasonable (in other words, there\u0027s an increased focused on the WHY). For example:\n\n  https://github.com/openstack/keystone/blob/master/keystone/cmd/doctor/ldap.py","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"1de788d88ffc15b6a2a339f667626381d9c56abc","unresolved":false,"context_lines":[{"line_number":95,"context_line":"         \u0027message\u0027: \u0027Option is configured with the default value, not required.\u0027},"},{"line_number":96,"context_line":"        {\u0027config_item\u0027: \u0027option\u0027, \u0027item_name\u0027: \u0027some_advanced_option\u0027,"},{"line_number":97,"context_line":"         \u0027message\u0027: \u0027Option some_advanced_option is an advanced option and may\u0027"},{"line_number":98,"context_line":"                    \u0027effect performance.\u0027},"},{"line_number":99,"context_line":"    ]"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"These are just examples of data structures potentially being returned and"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_5fb24b07","line":98,"in_reply_to":"1a95cdbc_1f4fe36b","updated":"2016-10-06 19:47:54.000000000","message":"There was an initiative to add a parameter into oslo.config to label options as advanced.  The overall goal was to put these at the bottom of the generated config file samples and move the required options to the top.  This would just be an indication that you are using an advanced option, that\u0027s all.","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4b47ebb9c3b4f5878b344c7462cc6e7791876218","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Performance Impact"},{"line_number":143,"context_line":"------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"This could be an additional check on service start(example usage), which could"},{"line_number":146,"context_line":"have an impact on the time it would take to become fully operational.  At its"},{"line_number":147,"context_line":"most basic form, manual checks via cli would not have a performance impact."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_9422fa50","line":145,"updated":"2016-10-06 19:37:33.000000000","message":"I\u0027d suggest not doing this at startup, as it might unexpectedly increase startup time substantially. If it\u0027s an explicit step, then I can do it while a service is running, for example, without having to perform a (slow) restart.","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"1de788d88ffc15b6a2a339f667626381d9c56abc","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Performance Impact"},{"line_number":143,"context_line":"------------------"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"This could be an additional check on service start(example usage), which could"},{"line_number":146,"context_line":"have an impact on the time it would take to become fully operational.  At its"},{"line_number":147,"context_line":"most basic form, manual checks via cli would not have a performance impact."},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_dfabbb73","line":145,"in_reply_to":"1a95cdbc_9422fa50","updated":"2016-10-06 19:47:54.000000000","message":"This is just an example of implementation, how it\u0027s actually used is up to the projects.","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4b47ebb9c3b4f5878b344c7462cc6e7791876218","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"This could be an additional check on service start(example usage), which could"},{"line_number":146,"context_line":"have an impact on the time it would take to become fully operational.  At its"},{"line_number":147,"context_line":"most basic form, manual checks via cli would not have a performance impact."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Configuration Impact"},{"line_number":150,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_b41ff606","line":147,"updated":"2016-10-06 19:37:33.000000000","message":"++","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"563c57745eaa49eac004266f83d75b997c77c696","unresolved":false,"context_lines":[{"line_number":160,"context_line":"--------------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Additional unit tests would be required to cover raised warnings and"},{"line_number":163,"context_line":"errors provided by validator."},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"Implementation"},{"line_number":166,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da36d5c6_74e1289a","line":163,"updated":"2017-02-21 19:16:32.000000000","message":"The config check should be added to the devstack deploy for the projects so that we can test it.","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4b47ebb9c3b4f5878b344c7462cc6e7791876218","unresolved":false,"context_lines":[{"line_number":180,"context_line":"----------"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"* Create new module `validator.py`."},{"line_number":183,"context_line":"* Create new entrypoint `oslo-config-validator`."},{"line_number":184,"context_line":"* Create new docs file `validator.rst`"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Incubation"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_5456b2ce","line":183,"updated":"2016-10-06 19:37:33.000000000","message":"Or `\u003cservice\u003e-manage doctor`? :)","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"1de788d88ffc15b6a2a339f667626381d9c56abc","unresolved":false,"context_lines":[{"line_number":180,"context_line":"----------"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"* Create new module `validator.py`."},{"line_number":183,"context_line":"* Create new entrypoint `oslo-config-validator`."},{"line_number":184,"context_line":"* Create new docs file `validator.rst`"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Incubation"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_ff715745","line":183,"in_reply_to":"1a95cdbc_5456b2ce","updated":"2016-10-06 19:47:54.000000000","message":"To employ a manage doctor type tool, this would be at the project level.  oslo.config doesn\u0027t operate at this level.","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"eff76ffad6f71e25ea316302c03b390b40618a9b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"----------"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"* Create new module `validator.py`."},{"line_number":183,"context_line":"* Create new entrypoint `oslo-config-validator`."},{"line_number":184,"context_line":"* Create new docs file `validator.rst`"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Incubation"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a95cdbc_9a222151","line":183,"in_reply_to":"1a95cdbc_ff715745","updated":"2016-10-06 19:58:30.000000000","message":"++","commit_id":"5f188151caef22fc0246bec629845c947b6a7724"}]}
