)]}'
{"specs/victoria/policy-json-to-yaml.rst":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2206d8fd502ee713140d4448de1569e72960915e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"policy.json file that would be a fatal error and stop the service from even"},{"line_number":66,"context_line":"starting. That would prevent us from silently opening security holes in a"},{"line_number":67,"context_line":"deployment."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_ec7e1668","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":0},"updated":"2020-06-04 17:12:31.000000000","message":"also we can log the warning if policy file has default rules. warning saying remove them and reply on default-in-code","commit_id":"951f6309635c096103ac2663ee8e2065975c5b75"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7b18c7889d0f6bd639892bdcab981e9a5d5dedc3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"policy.json file that would be a fatal error and stop the service from even"},{"line_number":66,"context_line":"starting. That would prevent us from silently opening security holes in a"},{"line_number":67,"context_line":"deployment."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Alternatives"},{"line_number":70,"context_line":"------------"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_f9f7c1d3","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":0},"in_reply_to":"ff570b3c_ec7e1668","updated":"2020-06-15 19:04:40.000000000","message":"Yeah, I didn\u0027t include that here because it isn\u0027t strictly necessary for switching the default format, but it is a good thing for the deprecation process. I\u0027ll include a note about it.","commit_id":"951f6309635c096103ac2663ee8e2065975c5b75"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2206d8fd502ee713140d4448de1569e72960915e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"-----------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Primary assignee:"},{"line_number":131,"context_line":"  ???"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Other contributors:"},{"line_number":134,"context_line":"  ???"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_2c948e8a","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":5},"updated":"2020-06-04 17:12:31.000000000","message":"you can add my name here.","commit_id":"951f6309635c096103ac2663ee8e2065975c5b75"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7b18c7889d0f6bd639892bdcab981e9a5d5dedc3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"-----------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Primary assignee:"},{"line_number":131,"context_line":"  ???"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Other contributors:"},{"line_number":134,"context_line":"  ???"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf51134e_d9f47dd2","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":5},"in_reply_to":"ff570b3c_2c948e8a","updated":"2020-06-15 19:04:40.000000000","message":"Thanks!","commit_id":"951f6309635c096103ac2663ee8e2065975c5b75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"02af76ef175fe39adab8067ba2e81d694052f9cc","unresolved":false,"context_lines":[{"line_number":59,"context_line":"If we detect that a JSON file is in use for policy we should log a warning."},{"line_number":60,"context_line":"Support for JSON in CLI tools will also need to be deprecated."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"We may also want to make existence of a JSON file a hard error on the"},{"line_number":63,"context_line":"oslo.policy side. We could provide a flag that services can set once they have"},{"line_number":64,"context_line":"completed their migration to YAML. If that flag is set and we find a"},{"line_number":65,"context_line":"policy.json file that would be a fatal error and stop the service from even"},{"line_number":66,"context_line":"starting. That would prevent us from silently opening security holes in a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_2485fb5a","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":17},"updated":"2020-06-23 17:50:46.000000000","message":"++\n\nI\u0027d make this the case for a future major version when we actually drop the JSON support","commit_id":"01aa9d04350e387150316adfd74ac95e1b774224"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"02af76ef175fe39adab8067ba2e81d694052f9cc","unresolved":false,"context_lines":[{"line_number":119,"context_line":"We will want to come up with a test matrix covering all the possible cases we"},{"line_number":120,"context_line":"may encounter. For example, deployers may have:"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"* policy.json"},{"line_number":123,"context_line":"* policy.yaml"},{"line_number":124,"context_line":"* both policy.json and policy.yaml"},{"line_number":125,"context_line":"* a JSON file at a custom path"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_048a7768","line":122,"range":{"start_line":122,"start_character":2,"end_line":122,"end_character":13},"updated":"2020-06-23 17:50:46.000000000","message":"nit: ``literal``","commit_id":"01aa9d04350e387150316adfd74ac95e1b774224"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"02af76ef175fe39adab8067ba2e81d694052f9cc","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  gmann"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Other contributors:"},{"line_number":140,"context_line":"  ???"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Milestones"},{"line_number":143,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bf51134e_647b737a","line":140,"range":{"start_line":140,"start_character":2,"end_line":140,"end_character":5},"updated":"2020-06-23 17:50:46.000000000","message":"I can help with this effort if you\u0027re time-constrained","commit_id":"01aa9d04350e387150316adfd74ac95e1b774224"}]}