)]}'
{"specs/juno/add-tpool-proxy-wrapper.rst":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"525c1f6957094a027edea6a01dc33b088f7f7f32","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Cinder teams based on their experience of adoption of oslo.db changes. To"},{"line_number":12,"context_line":"make things easier for oslo.db users, it\u0027d actually be better to provide"},{"line_number":13,"context_line":"optional integration with eventlet ``TPool`` as a seperate module within"},{"line_number":14,"context_line":"olso.db tree."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ae8d1ca_42112fab","line":14,"updated":"2014-05-29 14:01:39.000000000","message":"oslo.db - typo","commit_id":"7b7872e370e2b86b1bbe4152e50589c0aeae3e30"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"474596ef5efc36e6f947ce0a8dafd81ed35eabd1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Cinder teams based on their experience of adoption of oslo.db changes. To"},{"line_number":12,"context_line":"make things easier for oslo.db users, it\u0027d actually be better to provide"},{"line_number":13,"context_line":"optional integration with eventlet ``TPool`` as a seperate module within"},{"line_number":14,"context_line":"olso.db tree."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ae8d1ca_b5722b47","line":14,"in_reply_to":"3ae8d1ca_42112fab","updated":"2014-05-29 14:24:17.000000000","message":"Done","commit_id":"7b7872e370e2b86b1bbe4152e50589c0aeae3e30"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"525c1f6957094a027edea6a01dc33b088f7f7f32","unresolved":false,"context_lines":[{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"To work properly, this depends on the unreleased version of eventlet. Though,"},{"line_number":189,"context_line":"we\u0027ve been providing ``use_tpool`` option so far anyway. Rackspace use patched"},{"line_number":190,"context_line":"version of eventlet in production. We are going to leave it up to deployers to"},{"line_number":191,"context_line":"decide whether to enable this or not (default was and remains ``False``)."},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ae8d1ca_02cc8734","line":189,"updated":"2014-05-29 14:01:39.000000000","message":"s/use/uses/","commit_id":"7b7872e370e2b86b1bbe4152e50589c0aeae3e30"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"474596ef5efc36e6f947ce0a8dafd81ed35eabd1","unresolved":false,"context_lines":[{"line_number":186,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"To work properly, this depends on the unreleased version of eventlet. Though,"},{"line_number":189,"context_line":"we\u0027ve been providing ``use_tpool`` option so far anyway. Rackspace use patched"},{"line_number":190,"context_line":"version of eventlet in production. We are going to leave it up to deployers to"},{"line_number":191,"context_line":"decide whether to enable this or not (default was and remains ``False``)."},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3ae8d1ca_f5cbd31b","line":189,"in_reply_to":"3ae8d1ca_02cc8734","updated":"2014-05-29 14:24:17.000000000","message":"Done","commit_id":"7b7872e370e2b86b1bbe4152e50589c0aeae3e30"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"dee7c417d4a430db379aa886795f02dc22fd79e9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"``tpool.Proxy`` proxying for all database methods calls. This was used by Nova"},{"line_number":35,"context_line":"at least.  It\u0027s worth mentioning, that in order to actually use ``use_tpool``"},{"line_number":36,"context_line":"option one had to use a patched version of eventlet, as neither PyPI releases"},{"line_number":37,"context_line":"nor master HEAD didn\u0027t play nicely with ``MySQL-Python``."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"During Icehouse release cycle we worked on removing extra dependencies from"},{"line_number":40,"context_line":"common DB code. eventlet was removed as one of the dependencies we thought were"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ae8d1ca_8a30a902","line":37,"updated":"2014-05-29 18:02:25.000000000","message":"This is a double negative.  I think you just want to remove \"didn\u0027t\" here - neither play nicely with MySQL-Python.","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fb71abe98f1518f8aeb154494df61e4557836cd6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"``tpool.Proxy`` proxying for all database methods calls. This was used by Nova"},{"line_number":35,"context_line":"at least.  It\u0027s worth mentioning, that in order to actually use ``use_tpool``"},{"line_number":36,"context_line":"option one had to use a patched version of eventlet, as neither PyPI releases"},{"line_number":37,"context_line":"nor master HEAD didn\u0027t play nicely with ``MySQL-Python``."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"During Icehouse release cycle we worked on removing extra dependencies from"},{"line_number":40,"context_line":"common DB code. eventlet was removed as one of the dependencies we thought were"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_cef866c7","line":37,"in_reply_to":"3ae8d1ca_8a30a902","updated":"2014-05-30 08:27:50.000000000","message":"Done","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"dee7c417d4a430db379aa886795f02dc22fd79e9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"concurrency model, nor it can make any assumptions how the target projects"},{"line_number":43,"context_line":"process concurrent requests, whether they use eventlet green threads, real"},{"line_number":44,"context_line":"OS threads, multiple processing, etc). But the best is the enemy of the good,"},{"line_number":45,"context_line":"and is seems that it\u0027s actually better to provide optional integration with"},{"line_number":46,"context_line":"eventlet ``tpool.Proxy``, so the people wouldn\u0027t need to do this in their"},{"line_number":47,"context_line":"source trees."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ae8d1ca_ed03070b","line":45,"updated":"2014-05-29 18:02:25.000000000","message":"s/is/it/","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fb71abe98f1518f8aeb154494df61e4557836cd6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"concurrency model, nor it can make any assumptions how the target projects"},{"line_number":43,"context_line":"process concurrent requests, whether they use eventlet green threads, real"},{"line_number":44,"context_line":"OS threads, multiple processing, etc). But the best is the enemy of the good,"},{"line_number":45,"context_line":"and is seems that it\u0027s actually better to provide optional integration with"},{"line_number":46,"context_line":"eventlet ``tpool.Proxy``, so the people wouldn\u0027t need to do this in their"},{"line_number":47,"context_line":"source trees."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_0e032eb9","line":45,"in_reply_to":"3ae8d1ca_ed03070b","updated":"2014-05-30 08:27:50.000000000","message":"Done","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"dee7c417d4a430db379aa886795f02dc22fd79e9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"To make it possible to use oslo.db with ``MySQL-Python`` DB API driver and"},{"line_number":54,"context_line":"eventlet ``tpool.Proxy`` call proxying we need:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"1. Provide a helper that will either call ``DBAPI`` methods directly or use"},{"line_number":57,"context_line":"   ``tpool.Proxy`` to wrap the calls depending on the value of ``use_tpool``"},{"line_number":58,"context_line":"   config option set."},{"line_number":59,"context_line":"2. Make this proposed helper register ``use_tpool`` config option in group"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ae8d1ca_13b690fa","line":56,"updated":"2014-05-29 18:02:25.000000000","message":"Thinking out loud, since this will just be a pass-through to the real DBAPI when use_tpool is False, I wonder if we even need it to be a separate thing.  I guess having it be separate makes it every explicit when a project wants to enable this functionality though, so I\u0027m good with that.","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fb71abe98f1518f8aeb154494df61e4557836cd6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"To make it possible to use oslo.db with ``MySQL-Python`` DB API driver and"},{"line_number":54,"context_line":"eventlet ``tpool.Proxy`` call proxying we need:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"1. Provide a helper that will either call ``DBAPI`` methods directly or use"},{"line_number":57,"context_line":"   ``tpool.Proxy`` to wrap the calls depending on the value of ``use_tpool``"},{"line_number":58,"context_line":"   config option set."},{"line_number":59,"context_line":"2. Make this proposed helper register ``use_tpool`` config option in group"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_cd5ceb28","line":56,"in_reply_to":"3ae8d1ca_13b690fa","updated":"2014-05-30 08:27:50.000000000","message":"Yeah, it\u0027s a pity that we have to cover this very specific use case (eventlet + MySQL + MySQL-Python), which happens to have a place in most OS deployments :( At the same time, psycopg2 and most other DB API driver work just fine...","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"dee7c417d4a430db379aa886795f02dc22fd79e9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"The disadvantage of this solution is that we add more interdependencies between"},{"line_number":87,"context_line":"oslo.* libraries and make it harder to use oslo.db (it\u0027d probably be not very"},{"line_number":88,"context_line":"clear to users why they need to use another library, if they use eventlet and"},{"line_number":89,"context_line":"MySQL together)."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Impact on Existing APIs"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ae8d1ca_cd83ab54","line":89,"updated":"2014-05-29 18:02:25.000000000","message":"I don\u0027t actually think this would be unreasonable - eventlet is a concurrency library, so if you want to use it with an oslo library, also needing oslo.concurrency to glue them together would be logical.\n\nBut I still find it weird that this lived in-tree in the first place given that it depends on an out-of-tree patch to eventlet, so I\u0027m kind of \"meh\" on where it lives going forward.  I\u0027m fine with the proposed plan to put it in db itself.","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fb71abe98f1518f8aeb154494df61e4557836cd6","unresolved":false,"context_lines":[{"line_number":86,"context_line":"The disadvantage of this solution is that we add more interdependencies between"},{"line_number":87,"context_line":"oslo.* libraries and make it harder to use oslo.db (it\u0027d probably be not very"},{"line_number":88,"context_line":"clear to users why they need to use another library, if they use eventlet and"},{"line_number":89,"context_line":"MySQL together)."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Impact on Existing APIs"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_2d62afd8","line":89,"in_reply_to":"3ae8d1ca_cd83ab54","updated":"2014-05-30 08:27:50.000000000","message":"I guess we just want to go forward with lesser of two evils here: make oslo.db usable out-of-box for as much use cases as we can.","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"dee7c417d4a430db379aa886795f02dc22fd79e9","unresolved":false,"context_lines":[{"line_number":180,"context_line":"Documentation Impact"},{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"None."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ae8d1ca_ed64e74a","line":183,"updated":"2014-05-29 18:02:25.000000000","message":"It seems like we should have some documentation of the fact that this option only works with patched eventlet.","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fb71abe98f1518f8aeb154494df61e4557836cd6","unresolved":false,"context_lines":[{"line_number":180,"context_line":"Documentation Impact"},{"line_number":181,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"None."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_c95dc04a","line":183,"in_reply_to":"3ae8d1ca_ed64e74a","updated":"2014-05-30 08:27:50.000000000","message":"Done","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"dee7c417d4a430db379aa886795f02dc22fd79e9","unresolved":false,"context_lines":[{"line_number":192,"context_line":"decide whether to enable this or not (default was and remains ``False``)."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"References"},{"line_number":196,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"http://eventlet.net/doc/threading.html#module-eventlet.tpool"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3ae8d1ca_d07a5ef0","line":195,"updated":"2014-05-29 18:02:25.000000000","message":"Since there\u0027s already a PoC patch up, it would be good to include a link to that.\n\nhttps://review.openstack.org/#/c/96467/","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"fb71abe98f1518f8aeb154494df61e4557836cd6","unresolved":false,"context_lines":[{"line_number":192,"context_line":"decide whether to enable this or not (default was and remains ``False``)."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"References"},{"line_number":196,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"http://eventlet.net/doc/threading.html#module-eventlet.tpool"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1ae5cdf2_ce7b0628","line":195,"in_reply_to":"3ae8d1ca_d07a5ef0","updated":"2014-05-30 08:27:50.000000000","message":"Done","commit_id":"a6905254c1300aee8d163edeb34911de31e2332c"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"d29ccd72d891c6f845f49fef5acf03703b51835e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"To make it possible to use oslo.db with ``MySQL-Python`` DB API driver and"},{"line_number":54,"context_line":"eventlet ``tpool.Proxy`` call proxying we need:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"1. Provide a helper that will either call ``DBAPI`` methods directly or use"},{"line_number":57,"context_line":"   ``tpool.Proxy`` to wrap the calls depending on the value of ``use_tpool``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_7364bfb8","line":54,"updated":"2014-06-05 21:37:32.000000000","message":"forgive me if I\u0027m out of band here, but I thought I\u0027d just mention that there are a lot of other MySQL drivers these days: I know that openstack might not be able to make a change anytime soon but it might be something to think about, here\u0027s a great comparison of performance w/ gevent + SQLAlchemy: http://www.diamondtin.com/2014/sqlalchemy-gevent-mysql-python-drivers-comparison/","commit_id":"c515465c7a6389a5339d8931f1a5ccb87e21084d"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"7892c174b76a92321fe9ccc336cd9a345c9ee993","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"To make it possible to use oslo.db with ``MySQL-Python`` DB API driver and"},{"line_number":54,"context_line":"eventlet ``tpool.Proxy`` call proxying we need:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"1. Provide a helper that will either call ``DBAPI`` methods directly or use"},{"line_number":57,"context_line":"   ``tpool.Proxy`` to wrap the calls depending on the value of ``use_tpool``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_e84c51ca","line":54,"in_reply_to":"1ae5cdf2_7364bfb8","updated":"2014-06-06 09:04:03.000000000","message":"Thanks, Mike! This is actually quite interesting comparison. And gevent seems to work with MySQL-Python better than eventlet does. It\u0027s sad we are so tightly coupled to eventlet right now and can\u0027t easily switch to using of gevent.\n\nAt the same, the solution for this problem with blocking queries could be very simple here: just use psycog2 or any pure Python MySQL DB API driver (though, Rackspace guys told us pure Python drivers performance had been a deal breaker for their deployments). PyPy could probably make pure Python DB API drivers perform well, but AFAIK Swift is the only service that can be run on PyPy right now.","commit_id":"c515465c7a6389a5339d8931f1a5ccb87e21084d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"bee282d05081c1e9581614e3d3044a19744d550a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   ensure it\u0027s installed) and ``test-requirements.txt`` (that would prevent us"},{"line_number":67,"context_line":"   from running unit tests on Python 3.x versions; as we don\u0027t need to test"},{"line_number":68,"context_line":"   ``tpool.Proxy`` functionality itself, we could safely mock this class in"},{"line_number":69,"context_line":"   tests)."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_4aaf662a","line":69,"updated":"2014-06-03 17:12:28.000000000","message":"I understand the desire to be able to test with python 3, but we need to test the tpool class somehow. Do you have any ideas for how to handle that?","commit_id":"c515465c7a6389a5339d8931f1a5ccb87e21084d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"69dd8b8bb942649cd086db3105a069810b82bfd1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   ensure it\u0027s installed) and ``test-requirements.txt`` (that would prevent us"},{"line_number":67,"context_line":"   from running unit tests on Python 3.x versions; as we don\u0027t need to test"},{"line_number":68,"context_line":"   ``tpool.Proxy`` functionality itself, we could safely mock this class in"},{"line_number":69,"context_line":"   tests)."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_56d5f6e2","line":69,"in_reply_to":"1ae5cdf2_356092ce","updated":"2014-06-05 19:23:53.000000000","message":"Yeah, we don\u0027t need to test tpool. I left a comment on the other review asking for a comment where eventlet is mocked, but other than that the testing approach taken there looks fine for now.","commit_id":"c515465c7a6389a5339d8931f1a5ccb87e21084d"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"2e7b3aeef03de9d0157af7147d4666b22bb3bc22","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   ensure it\u0027s installed) and ``test-requirements.txt`` (that would prevent us"},{"line_number":67,"context_line":"   from running unit tests on Python 3.x versions; as we don\u0027t need to test"},{"line_number":68,"context_line":"   ``tpool.Proxy`` functionality itself, we could safely mock this class in"},{"line_number":69,"context_line":"   tests)."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_f84b91ae","line":69,"in_reply_to":"1ae5cdf2_4aaf662a","updated":"2014-06-04 08:25:53.000000000","message":"So Andrey implemented this as following: https://review.openstack.org/#/c/96467/12/tests/test_concurrency.py\n\nWe don\u0027t need to test if tpool.Proxy() itself works correctly, but rather only that we use it correctly, so I\u0027d say the testing we have now is sufficient (though, I can\u0027t say I like the number of mocks we need).\n\nDo you think it\u0027s ok to mock eventlet completely in tests? Or we should update the spec and the patch? (I\u0027m ok with both ways actually, just wanted to try \u0027no eventlet in our requirements\u0027 approach first :P)","commit_id":"c515465c7a6389a5339d8931f1a5ccb87e21084d"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"f58e3d7e7b531acfe95d94f0971196c1e9faae46","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   ensure it\u0027s installed) and ``test-requirements.txt`` (that would prevent us"},{"line_number":67,"context_line":"   from running unit tests on Python 3.x versions; as we don\u0027t need to test"},{"line_number":68,"context_line":"   ``tpool.Proxy`` functionality itself, we could safely mock this class in"},{"line_number":69,"context_line":"   tests)."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_356092ce","line":69,"in_reply_to":"1ae5cdf2_ca398df3","updated":"2014-06-04 15:34:03.000000000","message":"I suppose, it\u0027d work, but probably not very reliably (AFAIK, the problem is a race condition). So I\u0027m not sure it\u0027s worthwhile to do that.","commit_id":"c515465c7a6389a5339d8931f1a5ccb87e21084d"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"13efa32fd09a30215f757853c918404ca559a1d4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   ensure it\u0027s installed) and ``test-requirements.txt`` (that would prevent us"},{"line_number":67,"context_line":"   from running unit tests on Python 3.x versions; as we don\u0027t need to test"},{"line_number":68,"context_line":"   ``tpool.Proxy`` functionality itself, we could safely mock this class in"},{"line_number":69,"context_line":"   tests)."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_ca398df3","line":69,"in_reply_to":"1ae5cdf2_f84b91ae","updated":"2014-06-04 15:28:58.000000000","message":"We _can\u0027t_ test that tpool.Proxy works right, can we?  This relies on a patch not in the real eventlet tree, so the behavior wouldn\u0027t be right in the gate anyway.","commit_id":"c515465c7a6389a5339d8931f1a5ccb87e21084d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"69dd8b8bb942649cd086db3105a069810b82bfd1","unresolved":false,"context_lines":[{"line_number":142,"context_line":"----------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Target Milestone for completion:"},{"line_number":145,"context_line":"  Juno-1"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ae5cdf2_d6002668","line":145,"updated":"2014-06-05 19:23:53.000000000","message":"This might be optimistic now.","commit_id":"c515465c7a6389a5339d8931f1a5ccb87e21084d"}]}
