)]}'
{"specs/juno/config-reload-without-restart.rst":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"without service restart."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"For example,"},{"line_number":29,"context_line":"cfg.StrOpt(\u0027filesystem_store_datadirs\u0027,"},{"line_number":30,"context_line":"           help\u003d_(\u0027List of directories and its priorities to which \u0027"},{"line_number":31,"context_line":"               \u0027the Filesystem backend store writes images.\u0027),"},{"line_number":32,"context_line":"           can_update_without_restart\u003dTrue)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_be31c35b","line":29,"updated":"2014-06-05 11:58:39.000000000","message":"I think to fix the doc build error reported by jenkins, you want to move this code sample inside a \"literal block\" using ::\n\nFor example:\n\n  ::\n\n    cfg.StrOpt(\u0027...\n\nSee http://sphinx-doc.org/rest.html#source-code for details.","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":26,"context_line":"without service restart."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"For example,"},{"line_number":29,"context_line":"cfg.StrOpt(\u0027filesystem_store_datadirs\u0027,"},{"line_number":30,"context_line":"           help\u003d_(\u0027List of directories and its priorities to which \u0027"},{"line_number":31,"context_line":"               \u0027the Filesystem backend store writes images.\u0027),"},{"line_number":32,"context_line":"           can_update_without_restart\u003dTrue)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_eeb7f937","line":29,"in_reply_to":"1ae5cdf2_be31c35b","updated":"2014-06-06 13:39:38.000000000","message":"Done","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"process will be continued using old values for those options."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Administrator can configure \"update_without_restart\" to True/False as per"},{"line_number":42,"context_line":"his requirement in configuration file."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add callback handler to validate the reloaded option."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_de592f8f","line":42,"updated":"2014-06-05 11:58:39.000000000","message":"Do you mean here that the administrator can change options like filesystem_store_datadirs, which have can_update_without_restart\u003dTrue, or do you mean that there is a boolean option called update_without_restart that changes the behavior of this feature?","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":39,"context_line":"process will be continued using old values for those options."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Administrator can configure \"update_without_restart\" to True/False as per"},{"line_number":42,"context_line":"his requirement in configuration file."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add callback handler to validate the reloaded option."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_277f3fe1","line":42,"in_reply_to":"1ae5cdf2_de592f8f","updated":"2014-06-06 13:39:38.000000000","message":"Modified specs accordingly","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add callback handler to validate the reloaded option."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"For example,"},{"line_number":47,"context_line":"CONF.register_opts(filesystem_opts, callback_handler\u003dvalidate_reloaded_option)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This callback_handler will be added to each of the option which having"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_5e48bfcb","line":46,"updated":"2014-06-05 11:58:39.000000000","message":"The comment on line 29 applies here, too.","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add callback handler to validate the reloaded option."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"For example,"},{"line_number":47,"context_line":"CONF.register_opts(filesystem_opts, callback_handler\u003dvalidate_reloaded_option)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This callback_handler will be added to each of the option which having"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_ae9891c0","line":46,"in_reply_to":"1ae5cdf2_5e48bfcb","updated":"2014-06-06 13:39:38.000000000","message":"Done","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Add callback handler to validate the reloaded option."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"For example,"},{"line_number":47,"context_line":"CONF.register_opts(filesystem_opts, callback_handler\u003dvalidate_reloaded_option)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This callback_handler will be added to each of the option which having"},{"line_number":50,"context_line":"\"can_update_without_restart\u003dTrue\" in register_opt() method and will be used to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_3edbf37c","line":47,"updated":"2014-06-05 11:58:39.000000000","message":"The name \"callback_handler\" isn\u0027t very descriptive. Maybe something like \"reload_validator\" or \"reload_callback\" would better indicate when the function is going to be called.","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Add callback handler to validate the reloaded option."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"For example,"},{"line_number":47,"context_line":"CONF.register_opts(filesystem_opts, callback_handler\u003dvalidate_reloaded_option)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This callback_handler will be added to each of the option which having"},{"line_number":50,"context_line":"\"can_update_without_restart\u003dTrue\" in register_opt() method and will be used to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_ce931da1","line":47,"in_reply_to":"1ae5cdf2_3edbf37c","updated":"2014-06-06 13:39:38.000000000","message":"Done","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This callback_handler will be added to each of the option which having"},{"line_number":50,"context_line":"\"can_update_without_restart\u003dTrue\" in register_opt() method and will be used to"},{"line_number":51,"context_line":"validate the reloaded option."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Here the original configuration object will be cloned and new namespace will"},{"line_number":54,"context_line":"be added to this cloned configuration object. This cloned configuration object"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_fea7cb08","line":51,"updated":"2014-06-05 11:58:39.000000000","message":"What sort of validation do you expect here? Is the validation also performed when the value is first loaded?","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"This callback_handler will be added to each of the option which having"},{"line_number":50,"context_line":"\"can_update_without_restart\u003dTrue\" in register_opt() method and will be used to"},{"line_number":51,"context_line":"validate the reloaded option."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Here the original configuration object will be cloned and new namespace will"},{"line_number":54,"context_line":"be added to this cloned configuration object. This cloned configuration object"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_4ea1cdf6","line":51,"in_reply_to":"1ae5cdf2_fea7cb08","updated":"2014-06-06 13:39:38.000000000","message":"In case of oslo, we will only check that options which marked with can_update_without_restart\u003dTrue are modified, for other options we will log the warning and continue the processing using old configuration.\n\nThe reolad_callback will be implemented in service specific module (in our case glance filesystem_store) and will be used to validate dependency parameter check as well as other required validations.","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"be added to this cloned configuration object. This cloned configuration object"},{"line_number":55,"context_line":"will be passed along with the old configuration object to"},{"line_number":56,"context_line":"validate_reloaded_option() where validation for dependent parameters and other"},{"line_number":57,"context_line":"necessary checks will be performed for given option."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"If this validation fails for newly changed value, then warning message will be"},{"line_number":60,"context_line":"logged and processing will be continued using old value."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_de25af5c","line":57,"updated":"2014-06-05 11:58:39.000000000","message":"What tells the application it needs to reload its configuration? A UNIX signal, an RPC notification, something else? What function in oslo.config does the application call at that point to take care of the reload operation? You talk about a configuration object being cloned, so maybe it is a method of that object? Is it the existing method reload_config_files()?","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":54,"context_line":"be added to this cloned configuration object. This cloned configuration object"},{"line_number":55,"context_line":"will be passed along with the old configuration object to"},{"line_number":56,"context_line":"validate_reloaded_option() where validation for dependent parameters and other"},{"line_number":57,"context_line":"necessary checks will be performed for given option."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"If this validation fails for newly changed value, then warning message will be"},{"line_number":60,"context_line":"logged and processing will be continued using old value."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_ee8e1978","line":57,"in_reply_to":"1ae5cdf2_de25af5c","updated":"2014-06-06 13:39:38.000000000","message":"Done","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"necessary checks will be performed for given option."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"If this validation fails for newly changed value, then warning message will be"},{"line_number":60,"context_line":"logged and processing will be continued using old value."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_9e2fa73e","line":60,"updated":"2014-06-05 11:58:39.000000000","message":"What happens if several reloadable options are changed, but the validation for only one fails? It seems safest to discard all of the new values.","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":57,"context_line":"necessary checks will be performed for given option."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"If this validation fails for newly changed value, then warning message will be"},{"line_number":60,"context_line":"logged and processing will be continued using old value."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_2eec8129","line":60,"in_reply_to":"1ae5cdf2_9e2fa73e","updated":"2014-06-06 13:39:38.000000000","message":"Done","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Impact on Existing APIs"},{"line_number":68,"context_line":"-----------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"None"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security impact"},{"line_number":73,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_fe226ba1","line":70,"updated":"2014-06-05 11:58:39.000000000","message":"You describe two new options above (can_update_without_restart and callback_handler). Those are backwards compatible API changes, and should be listed here as a summary.","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Impact on Existing APIs"},{"line_number":68,"context_line":"-----------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"None"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Security impact"},{"line_number":73,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_0e8a6563","line":70,"in_reply_to":"1ae5cdf2_fe226ba1","updated":"2014-06-06 13:39:38.000000000","message":"Done","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Performance Impact"},{"line_number":78,"context_line":"------------------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Configuration Impact"},{"line_number":83,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_9e77a79f","line":80,"updated":"2014-06-05 11:58:39.000000000","message":"Should the process that is reloading its options stop doing any other work while the reload and validation is occurring?","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Developer Impact"},{"line_number":88,"context_line":"----------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"None"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Implementation"},{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_feb6ebf7","line":90,"updated":"2014-06-05 11:58:39.000000000","message":"Developers will need to know which options are reloadable, and use those configuration options carefully. For example, the application should not save the configuration value in a local variable inside a class, and should access it from the Config object each time it is needed, in case it changes between accesses.","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Developer Impact"},{"line_number":88,"context_line":"----------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"None"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Implementation"},{"line_number":93,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_6ef20907","line":90,"in_reply_to":"1ae5cdf2_feb6ebf7","updated":"2014-06-06 13:39:38.000000000","message":"Done","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"----------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Target Milestone for completion:"},{"line_number":105,"context_line":"  Juno-1"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Work Items"},{"line_number":108,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_9e3a4797","line":105,"updated":"2014-06-05 11:58:39.000000000","message":"I think Juno-2 is more likely.","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Adoption"},{"line_number":120,"context_line":"--------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"None"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Library"},{"line_number":125,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_be954334","line":122,"updated":"2014-06-05 11:58:39.000000000","message":"Which application needs this feature?","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Adoption"},{"line_number":120,"context_line":"--------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"None"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Library"},{"line_number":125,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_8ef595ee","line":122,"in_reply_to":"1ae5cdf2_be954334","updated":"2014-06-06 13:39:38.000000000","message":"Done","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"da6db2b45c968b1812b4101658037c745a94795b","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Documentation Impact"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"None"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_5eac3f8c","line":137,"updated":"2014-06-05 11:58:39.000000000","message":"We definitely need to document this new feature.","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d58d8ab18a1e63893b0711f12fd8386a70d73b97","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Documentation Impact"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"None"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_ceda3d77","line":137,"in_reply_to":"1ae5cdf2_5eac3f8c","updated":"2014-06-06 13:39:38.000000000","message":"Done","commit_id":"95e8c666c8edabecd15320a9b640fba225985305"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"22825207477b7e700c66e6367f5cf95cac582bef","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"As of now, if administrator has made change in configuration file then"},{"line_number":15,"context_line":"the particular service need to be restarted. This would break users"},{"line_number":16,"context_line":"connected to it abruptly. Administrator shouldn\u0027t need to restart the"},{"line_number":17,"context_line":"service just to reload some simple config options."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_ab710779","line":15,"updated":"2014-06-10 05:58:17.000000000","message":"Administrators also need to stop-and-start restart services to update software for security fixes. Unless we guarantee no security fixes or bugfixes are needed, Administrators will still need to restart services. So this isn\u0027t a particularly big issue IMO.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":9975,"name":"Liyi Meng","email":"liyi.meng@ericsson.com","username":"liyi"},"change_message_id":"0b08fcff4da1f4f2e9e7b0200a7720d60b4d70d4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"As of now, if administrator has made change in configuration file then"},{"line_number":15,"context_line":"the particular service need to be restarted. This would break users"},{"line_number":16,"context_line":"connected to it abruptly. Administrator shouldn\u0027t need to restart the"},{"line_number":17,"context_line":"service just to reload some simple config options."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_beb748d7","line":15,"in_reply_to":"1ae5cdf2_ab710779","updated":"2014-06-11 12:44:44.000000000","message":"Hi Lifeless, \nThe proposal use \"should not\" but not \"must not\", which means restart is avoided if possible to minimize service interruption. But when it has to happen, OPS service is OK to be restarted.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"22825207477b7e700c66e6367f5cf95cac582bef","unresolved":false,"context_lines":[{"line_number":14,"context_line":"As of now, if administrator has made change in configuration file then"},{"line_number":15,"context_line":"the particular service need to be restarted. This would break users"},{"line_number":16,"context_line":"connected to it abruptly. Administrator shouldn\u0027t need to restart the"},{"line_number":17,"context_line":"service just to reload some simple config options."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Proposed change"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_cb6c93a0","line":17,"updated":"2014-06-10 05:58:17.000000000","message":"Secondly because OpenStack is a scaled-out architectur with N \u003e 1 running copies of most services (and the ones where N\u003d1 are bugs that folk are working on), users are not broken when such services are restarted. Services like nova-compute do interrupt active requests on restart, but that should be fixed anyway, because as per above services need to be stop-and-start restarted for bugfix and security fixes. \n\nLastly, its not true that the service has to be stopped and started - there is a specific restart primitive in openstack.common.service which calls reload_config_files(), which reparses all the options and does a graceful shutdown and startup of the worker threads: this shouldn\u0027t break any user requests within the process at all.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":9975,"name":"Liyi Meng","email":"liyi.meng@ericsson.com","username":"liyi"},"change_message_id":"0b08fcff4da1f4f2e9e7b0200a7720d60b4d70d4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"As of now, if administrator has made change in configuration file then"},{"line_number":15,"context_line":"the particular service need to be restarted. This would break users"},{"line_number":16,"context_line":"connected to it abruptly. Administrator shouldn\u0027t need to restart the"},{"line_number":17,"context_line":"service just to reload some simple config options."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Proposed change"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_b983e254","line":17,"in_reply_to":"1ae5cdf2_cb6c93a0","updated":"2014-06-11 12:44:44.000000000","message":"This is a good news, however we still have the case that we don\u0027t want to restart the service but update configuration, e.g. logging level as I have proposed in https://review.openstack.org/#/c/86357/.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":9975,"name":"Liyi Meng","email":"liyi.meng@ericsson.com","username":"liyi"},"change_message_id":"0b08fcff4da1f4f2e9e7b0200a7720d60b4d70d4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Mark options which you can reload without restart with"},{"line_number":23,"context_line":"\"can_update_without_restart\u003dTrue\"."},{"line_number":24,"context_line":"\"can_update_without_restart\u003dTrue\" is not configurable in configuration file."},{"line_number":25,"context_line":"You need to specify it explicitly for those options which need to be reloaded"},{"line_number":26,"context_line":"without service restart."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_d9326ea6","line":23,"updated":"2014-06-11 12:44:44.000000000","message":"Maybe we should go with something a little more flexible and scalable. e.g. \n\"update_take_effect_at\" \u003d \"{cluster_restart, node_restart, service_restart, right_away}\" ?","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":9975,"name":"Liyi Meng","email":"liyi.meng@ericsson.com","username":"liyi"},"change_message_id":"6d1c3e6579d0556a621f0d7bff0192b99914c1ee","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Mark options which you can reload without restart with"},{"line_number":23,"context_line":"\"can_update_without_restart\u003dTrue\"."},{"line_number":24,"context_line":"\"can_update_without_restart\u003dTrue\" is not configurable in configuration file."},{"line_number":25,"context_line":"You need to specify it explicitly for those options which need to be reloaded"},{"line_number":26,"context_line":"without service restart."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_7d58ea8a","line":23,"in_reply_to":"1ae5cdf2_6a65ab1c","updated":"2014-06-16 08:04:00.000000000","message":"The idea is to hint the operator/deployer how much impact on end-user if he/she want to change the configuration, and then take a right plan during operation, e.g. if a config can be updated without any end-user service interruption, operator can go whenever they want;  if a config need to take down the entire cluster to take effect, operator might need to make a careful plan, like rebooting the cluster when end-users are less active.\n  \n- cluster_restart: need to reboot entire openstack \n- node_restart : reboot the node where re-configure services are running \n- service_restart: the re-configured service need to restart\n- right_way: re-config take effect without any service interruption\n  \nI agree this looks complicated for some deployment, especially in a simple deployment require less QoS.  but for some advanced deployment, I believe there is a need.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"704f34a6b256ab7b8f4f93f16985c49357467c25","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Mark options which you can reload without restart with"},{"line_number":23,"context_line":"\"can_update_without_restart\u003dTrue\"."},{"line_number":24,"context_line":"\"can_update_without_restart\u003dTrue\" is not configurable in configuration file."},{"line_number":25,"context_line":"You need to specify it explicitly for those options which need to be reloaded"},{"line_number":26,"context_line":"without service restart."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6a65ab1c","line":23,"in_reply_to":"1ae5cdf2_d9326ea6","updated":"2014-06-13 14:58:03.000000000","message":"Can we tell the difference between all of those cases? That seems like it is adding more complexity than needed.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ed98197fd3e5c170010d2344a7cb6ec23339d831","unresolved":false,"context_lines":[{"line_number":39,"context_line":"process will be continued using old values for those options."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"\"update_without_restart\" is a boolean option which is configurable in the"},{"line_number":42,"context_line":"configuration file which controls the behaviour of this feature."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add callback handler to validate the reloaded option."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_2cba5bc0","line":42,"updated":"2014-06-10 15:18:27.000000000","message":"Why do we need an option to turn this on and off?","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":9975,"name":"Liyi Meng","email":"liyi.meng@ericsson.com","username":"liyi"},"change_message_id":"6d1c3e6579d0556a621f0d7bff0192b99914c1ee","unresolved":false,"context_lines":[{"line_number":39,"context_line":"process will be continued using old values for those options."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"\"update_without_restart\" is a boolean option which is configurable in the"},{"line_number":42,"context_line":"configuration file which controls the behaviour of this feature."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add callback handler to validate the reloaded option."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_9da2164a","line":42,"in_reply_to":"1ae5cdf2_0a7427cd","updated":"2014-06-16 08:04:00.000000000","message":"I fully stand with Doug on this. In stead of turn it on/off, it might be better to hint the operator what impact they change this config parameter.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"02bd8cd858fdc8ffad0344dced20895f34b55800","unresolved":false,"context_lines":[{"line_number":39,"context_line":"process will be continued using old values for those options."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"\"update_without_restart\" is a boolean option which is configurable in the"},{"line_number":42,"context_line":"configuration file which controls the behaviour of this feature."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add callback handler to validate the reloaded option."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6338cdd3","line":42,"in_reply_to":"1ae5cdf2_2cba5bc0","updated":"2014-06-11 12:54:29.000000000","message":"If some one don\u0027t want to use this reload feature at all then he can set it to False.\n\nShall we make it mandatory? In this case this \"update_without_restart\" is not required.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"704f34a6b256ab7b8f4f93f16985c49357467c25","unresolved":false,"context_lines":[{"line_number":39,"context_line":"process will be continued using old values for those options."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"\"update_without_restart\" is a boolean option which is configurable in the"},{"line_number":42,"context_line":"configuration file which controls the behaviour of this feature."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Add callback handler to validate the reloaded option."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_0a7427cd","line":42,"in_reply_to":"1ae5cdf2_6338cdd3","updated":"2014-06-13 14:58:03.000000000","message":"Yes, I don\u0027t think we need to let deployers turn it off. They can just not use the feature, right?","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"22825207477b7e700c66e6367f5cf95cac582bef","unresolved":false,"context_lines":[{"line_number":51,"context_line":"and will be used to perform the validation on the reloaded option."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Note: \"reload_callback\" will be called only at the time of reloading of"},{"line_number":54,"context_line":"configuration and not at the time when service starts."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"A SIGHUP signal handler will call the reload_config_files() method which will"},{"line_number":57,"context_line":"reload the configuration file. Here the original configuration object will be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_eb6b0f83","line":54,"updated":"2014-06-10 05:58:17.000000000","message":"Why not? Validating seems like a useful thing, and this means we\u0027ll have to have two different validators?","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"704f34a6b256ab7b8f4f93f16985c49357467c25","unresolved":false,"context_lines":[{"line_number":51,"context_line":"and will be used to perform the validation on the reloaded option."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Note: \"reload_callback\" will be called only at the time of reloading of"},{"line_number":54,"context_line":"configuration and not at the time when service starts."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"A SIGHUP signal handler will call the reload_config_files() method which will"},{"line_number":57,"context_line":"reload the configuration file. Here the original configuration object will be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_0a5b4754","line":54,"in_reply_to":"1ae5cdf2_eb6b0f83","updated":"2014-06-13 14:58:03.000000000","message":"@lifeless: The reload validation has to verify that the new value makes sense as a change from the old value. That might be different from the sort of validation we do the first time the config is loaded.\n\nThat said, we could still use a single validator, and on the first load we would just pass it None as the old ConfigObj.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"02bd8cd858fdc8ffad0344dced20895f34b55800","unresolved":false,"context_lines":[{"line_number":51,"context_line":"and will be used to perform the validation on the reloaded option."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Note: \"reload_callback\" will be called only at the time of reloading of"},{"line_number":54,"context_line":"configuration and not at the time when service starts."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"A SIGHUP signal handler will call the reload_config_files() method which will"},{"line_number":57,"context_line":"reload the configuration file. Here the original configuration object will be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_43c5918c","line":54,"in_reply_to":"1ae5cdf2_eb6b0f83","updated":"2014-06-11 12:54:29.000000000","message":"No we will not have two different validators. Here we can use existing validation code only.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ed98197fd3e5c170010d2344a7cb6ec23339d831","unresolved":false,"context_lines":[{"line_number":59,"context_line":"This cloned configuration object will be passed along with the old"},{"line_number":60,"context_line":"configuration object to validate_reloaded_option() where validation for"},{"line_number":61,"context_line":"dependent parameters and other necessary checks will be performed for"},{"line_number":62,"context_line":"given option."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If this validation fails for newly changed value, then warning message will be"},{"line_number":65,"context_line":"logged and processing will be continued using old value. In case if several"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6c10e3a8","line":62,"updated":"2014-06-10 15:18:27.000000000","message":"SIGHUP may be the right way to signal to do the reload, but we need to be careful about registering signal handlers from within a library. An application can only have one handler for each signal, and the application itself or another library may need to use SIGHUP. It\u0027s better to let the application register its own signal handler.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"704f34a6b256ab7b8f4f93f16985c49357467c25","unresolved":false,"context_lines":[{"line_number":59,"context_line":"This cloned configuration object will be passed along with the old"},{"line_number":60,"context_line":"configuration object to validate_reloaded_option() where validation for"},{"line_number":61,"context_line":"dependent parameters and other necessary checks will be performed for"},{"line_number":62,"context_line":"given option."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If this validation fails for newly changed value, then warning message will be"},{"line_number":65,"context_line":"logged and processing will be continued using old value. In case if several"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_2d1bbd73","line":62,"in_reply_to":"1ae5cdf2_20dedf3f","updated":"2014-06-13 14:58:03.000000000","message":"Good point, Ben. We cannot redefine what that signal means, so we should pick another signal.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"02bd8cd858fdc8ffad0344dced20895f34b55800","unresolved":false,"context_lines":[{"line_number":59,"context_line":"This cloned configuration object will be passed along with the old"},{"line_number":60,"context_line":"configuration object to validate_reloaded_option() where validation for"},{"line_number":61,"context_line":"dependent parameters and other necessary checks will be performed for"},{"line_number":62,"context_line":"given option."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If this validation fails for newly changed value, then warning message will be"},{"line_number":65,"context_line":"logged and processing will be continued using old value. In case if several"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_a3ec95bc","line":62,"in_reply_to":"1ae5cdf2_20dedf3f","updated":"2014-06-11 12:54:29.000000000","message":"You are right that SIGHUP is used to restart the service, but in this case all its child processes will be terminated abruptly. So we using this SIGHUP signal to only reload the configuration file without restarting the service.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":9975,"name":"Liyi Meng","email":"liyi.meng@ericsson.com","username":"liyi"},"change_message_id":"0b08fcff4da1f4f2e9e7b0200a7720d60b4d70d4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"This cloned configuration object will be passed along with the old"},{"line_number":60,"context_line":"configuration object to validate_reloaded_option() where validation for"},{"line_number":61,"context_line":"dependent parameters and other necessary checks will be performed for"},{"line_number":62,"context_line":"given option."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If this validation fails for newly changed value, then warning message will be"},{"line_number":65,"context_line":"logged and processing will be continued using old value. In case if several"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_1938563c","line":62,"in_reply_to":"1ae5cdf2_6c10e3a8","updated":"2014-06-11 12:44:44.000000000","message":"And we may need create a config client, e.g. a cli like nova-manage to trigger these callbacks and send signal if we decide to use signal,  right?\n\nI think another way is to deliver the new config through massage queue to destination service process, what do you think?","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"01ceb8f16942573a5a13c1350f83f3f1495763e2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"This cloned configuration object will be passed along with the old"},{"line_number":60,"context_line":"configuration object to validate_reloaded_option() where validation for"},{"line_number":61,"context_line":"dependent parameters and other necessary checks will be performed for"},{"line_number":62,"context_line":"given option."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"If this validation fails for newly changed value, then warning message will be"},{"line_number":65,"context_line":"logged and processing will be continued using old value. In case if several"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_20dedf3f","line":62,"in_reply_to":"1ae5cdf2_6c10e3a8","updated":"2014-06-10 15:30:37.000000000","message":"SIGHUP is already used by our service code to trigger a restart of the service.  I don\u0027t think we can use it for this too.\n\nhttps://github.com/openstack/oslo-incubator/blob/master/openstack/common/service.py#L197","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"22825207477b7e700c66e6367f5cf95cac582bef","unresolved":false,"context_lines":[{"line_number":65,"context_line":"logged and processing will be continued using old value. In case if several"},{"line_number":66,"context_line":"reloadable options has changed and validation fails only for single option in"},{"line_number":67,"context_line":"that case warning will be logged all the changes were discarded and processing"},{"line_number":68,"context_line":"will be continued using old values."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_0b675bb8","line":68,"updated":"2014-06-10 05:58:17.000000000","message":"This validation approach seems useful for the existing reload_config_files facility; perhaps its worth speccing independently (because I\u0027d like to see it :)).","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ed98197fd3e5c170010d2344a7cb6ec23339d831","unresolved":false,"context_lines":[{"line_number":65,"context_line":"logged and processing will be continued using old value. In case if several"},{"line_number":66,"context_line":"reloadable options has changed and validation fails only for single option in"},{"line_number":67,"context_line":"that case warning will be logged all the changes were discarded and processing"},{"line_number":68,"context_line":"will be continued using old values."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6c8703d8","line":68,"in_reply_to":"1ae5cdf2_0b675bb8","updated":"2014-06-10 15:18:27.000000000","message":"See also https://review.openstack.org/93149. It would be good to have the two validation approaches work together.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"22825207477b7e700c66e6367f5cf95cac582bef","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"None"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Impact on Existing APIs"},{"line_number":76,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_2b05f7c1","line":73,"updated":"2014-06-10 05:58:17.000000000","message":"What about improving our services to save-and-restore long running tasks via taskflow, so that process restart only has to deal with short lived requests (e.g. API DB lookups) and then no user visible downtime is required for regular restarts? Then we wouldn\u0027t need this complexity at all, and we\u0027d have solved the general case that affects security and bugfies too.\n\nAnother alternative would be to just load a new config and return it as an object - e.g. rather than reload_config_files add a new method \u0027config.load_new_config()\u0027 that return a new config, and let the application validate it, then call e.g. config.update(new_config) to apply it.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"99c7cd0cde8684afb60cbe6ec6ab02d1034467f7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Alternatives"},{"line_number":71,"context_line":"------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"None"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Impact on Existing APIs"},{"line_number":76,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_d963edda","line":73,"in_reply_to":"1ae5cdf2_2b05f7c1","updated":"2014-06-21 05:56:21.000000000","message":"As a biased *commentator* I would also like agree with lifeless here. if we can make all services crash-tolerant (via the aid of taskflow would be great) then configuration reloading imho becomes mute. If services can withstand being shutoff forcefully (robust programs should withstand this; for obvious reasons) then we can use the more traditional mechanism to reload configuration (`service restart`).","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"22825207477b7e700c66e6367f5cf95cac582bef","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Performance Impact"},{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"None"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Configuration Impact"},{"line_number":93,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_4b0883d9","line":90,"updated":"2014-06-10 05:58:17.000000000","message":"There is a performance concern: if the reload takes too long (e.g. ~50ms) then API requests will be delayed while the reload takes place, and that will be user visible. I don\u0027t know if oslo.config is that slow or not.\n\nSecondly, Nova is caching config values in local variables because oslo.config is too slow at lookups, so anyone wanting to use this feature is going to have to have this slow lookup in their codepath. So we need to look at fixing that to make this broadly useful.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"99c7cd0cde8684afb60cbe6ec6ab02d1034467f7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"Performance Impact"},{"line_number":88,"context_line":"------------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"None"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Configuration Impact"},{"line_number":93,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_b968e1ba","line":90,"in_reply_to":"1ae5cdf2_4b0883d9","updated":"2014-06-21 05:56:21.000000000","message":"In my view this caching problem is the key issue/problem here.\n\nA way to think about it is think of the object tree that a single class creates, if any node of that tree is given a variable that was at one point derived from (for example, this includes any substring usage of a string configuration value, any list operation on a list based configuration value...) a configuration value the whole object tree will have to be purged/recreated when that configuration value is changed. \n\nAre most applications capable of doing this, I would say yes, if they are designed with this concept in mind from the start (and the developers as they progressed ensured this concept kept on working and did not get lazy). The hard part I think is that most of the openstack services were not designed with this concept in-mind from the start so it will be difficult to retrofit them into this model (not impossible, just difficult).\n\nOf course a difficult problem can be a fun problem to solve :-)","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"22825207477b7e700c66e6367f5cf95cac582bef","unresolved":false,"context_lines":[{"line_number":100,"context_line":"The application which want to use this feature should not save the"},{"line_number":101,"context_line":"configuration value in a local variable inside a class, and should access it"},{"line_number":102,"context_line":"from the Config object each time it is needed, in case it changes between"},{"line_number":103,"context_line":"accesses."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"Implementation"},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_6b0fffe1","line":103,"updated":"2014-06-10 05:58:17.000000000","message":"Also developers need to explicitly opt into this facility, so the default will be to not be reloadable, and the default tends to be sticky. So this is going to take continual effort to make it be consistently available.\n\nPerhaps making enabling this a global set on the Config, and then allow individual options to opt-out of it would be better.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"}],"specs/juno/index.rst":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"22825207477b7e700c66e6367f5cf95cac582bef","unresolved":false,"context_lines":[{"line_number":6,"context_line":"   :glob:"},{"line_number":7,"context_line":"   :maxdepth: 2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"   *"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_8b128b07","line":9,"updated":"2014-06-10 05:58:17.000000000","message":"This will now conflict, so you need to rebase.","commit_id":"5e8db615fb37307fa3cfbcf8d7f2d4ebe9a1816f"}]}
