)]}'
{"specs/juno/chaining-regexp-filter.rst":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a7c206179a893b01d4cdda8a49dab87da86bb36a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  ionice: ChainingRegExpFilter, ionice, root, ionice, -c[0-3]( -n[0-7])?"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"This filter regards the length of the regular expressions list as the number of"},{"line_number":29,"context_line":"arguments to be checked, and remaining parts are checked by other filters."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Alternatives"},{"line_number":32,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_40a5de02","line":29,"updated":"2014-06-09 14:46:57.000000000","message":"Which regular expression list are you referring to here? (The answer may be obvious to someone more familiar with rootwrap config file syntax than I am.)","commit_id":"a3732627caa274fd9a554c852ae9eb0ef1fae9e7"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"900cf27ebbb6cc9dabc8d8cb10e49f1f9f92d792","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  ionice: ChainingRegExpFilter, ionice, root, ionice, -c[0-3]( -n[0-7])?"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"This filter regards the length of the regular expressions list as the number of"},{"line_number":29,"context_line":"arguments to be checked, and remaining parts are checked by other filters."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Alternatives"},{"line_number":32,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_b06b4b84","line":29,"in_reply_to":"1ae5cdf2_40a5de02","updated":"2014-06-09 16:43:17.000000000","message":"As for this example, \"the regular expression list\" means \"ionice, -c[0-3]( -n[0-7])?\". \nThe format of the config is like:\n\n  filter_name: ChainingRegExpFilter, \u003cRegExp list for the arguments\u003e\n\nI will add this line into the spec. Thanks.","commit_id":"a3732627caa274fd9a554c852ae9eb0ef1fae9e7"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a7c206179a893b01d4cdda8a49dab87da86bb36a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We could implement a specialized filter class for each prefix command like"},{"line_number":35,"context_line":"IpNetnsExecFilter each time it is needed."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Impact on Existing APIs"},{"line_number":38,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_453b30eb","line":35,"updated":"2014-06-09 14:46:57.000000000","message":"Would having a separate class make it easier to reuse the prefix rules between projects? If cinder and neutron both need ionice, for example, and they had a special filter for it, would that be easier to use correctly than having to specify the pattern in the config file in both places?","commit_id":"a3732627caa274fd9a554c852ae9eb0ef1fae9e7"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"900cf27ebbb6cc9dabc8d8cb10e49f1f9f92d792","unresolved":false,"context_lines":[{"line_number":32,"context_line":"------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We could implement a specialized filter class for each prefix command like"},{"line_number":35,"context_line":"IpNetnsExecFilter each time it is needed."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Impact on Existing APIs"},{"line_number":38,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_906e4f95","line":35,"in_reply_to":"1ae5cdf2_453b30eb","updated":"2014-06-09 16:43:17.000000000","message":"Possibly, if a prefix command is found to be sharable among project we can move on to specialized filter class. ChainingRegExpFilter is more generic, so it is still useful until then.","commit_id":"a3732627caa274fd9a554c852ae9eb0ef1fae9e7"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"292720cd63723681d3c6e13ee0b9d899d00e07a3","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Rules for prefix utilities must be written carefully not to allow unchecked"},{"line_number":55,"context_line":"commands executed. For example, it can be dangerous to allowing any string"},{"line_number":56,"context_line":"(\u0027.*\u0027) for the argument that could be interpreted as command to be executed."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Performance Impact"},{"line_number":59,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_e8246861","line":56,"updated":"2014-06-13 13:08:01.000000000","message":"Another security impact is that you need to allow the use of the direct command. Currently cinder does not let you run dd as root if not under ionice. With your change, you\u0027ll have to add a filter definition that lets you run \"dd\" as root, which is overall more permissive than the current situation.\n\nThis is basically why the EnvFilter is not implemented as a ChainingFilter -- so that \"A\u003dfoo command bar\" can be allowed without allowing \"command bar\".","commit_id":"1a3803b163f61275a3c75dd14bc7bfb3a3575073"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"73bfb27cfc9153ca2ec9a2c23afd1864c9e92e72","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Rules for prefix utilities must be written carefully not to allow unchecked"},{"line_number":55,"context_line":"commands executed. For example, it can be dangerous to allowing any string"},{"line_number":56,"context_line":"(\u0027.*\u0027) for the argument that could be interpreted as command to be executed."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Performance Impact"},{"line_number":59,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_ad818dc4","line":56,"in_reply_to":"1ae5cdf2_e8246861","updated":"2014-06-13 15:34:49.000000000","message":"In cinder, \"dd\" is already allowed by CommandFilter for root user by default:\n\n  http://git.openstack.org/cgit/openstack/cinder/tree/etc/cinder/rootwrap.d/volume.filters#n21","commit_id":"1a3803b163f61275a3c75dd14bc7bfb3a3575073"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7703f7ef7ce177189a61cd7bb572137386a3d371","unresolved":false,"context_lines":[{"line_number":22,"context_line":"By adding ChainingRegExpFilter, which is configured by the format below, we"},{"line_number":23,"context_line":"can easily add a new filter that accepts prefix utilities."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    filter_name: ChainingRegExpFilter, \u003cRegExp list for the arguments\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This filter regards the length of the regular expressions list as the number of"},{"line_number":28,"context_line":"arguments to be checked, and remaining parts are checked by other filters."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_f5113354","line":25,"updated":"2014-06-17 14:16:08.000000000","message":"Based on the example below, it seems like this should be:\n\nfilter_name: ChainingRegExpFilter, \u003ccommand\u003e, \u003cuser\u003e, \u003cRegExp list for the arguments\u003e","commit_id":"df7e12bceab5caa0fc7e0ad1a1585177ee3f9ea8"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"104ec04f558fc50dc33a5042c70428d77de4965b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"By adding ChainingRegExpFilter, which is configured by the format below, we"},{"line_number":23,"context_line":"can easily add a new filter that accepts prefix utilities."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    filter_name: ChainingRegExpFilter, \u003cRegExp list for the arguments\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This filter regards the length of the regular expressions list as the number of"},{"line_number":28,"context_line":"arguments to be checked, and remaining parts are checked by other filters."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_0b3920d8","line":25,"in_reply_to":"1ae5cdf2_f5113354","updated":"2014-06-17 15:13:03.000000000","message":"Right. Thank you for pointing this out.","commit_id":"df7e12bceab5caa0fc7e0ad1a1585177ee3f9ea8"}]}
