)]}'
{"oslo_cache/backends/dictionary.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b08d11f10947896b0e5270dbb7ed2ea639a72b2f","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_multi(self, keys):"},{"line_number":59,"context_line":"        \"\"\"Retrieves the value for a list of keys"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        return [self.get(key) for key in keys]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def set(self, key, value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_44cbb653","line":60,"updated":"2015-08-25 01:12:17.000000000","message":"Should be all on one line for single line docstrings (PEP-257). Also a full stop since you\u0027re having to change it :).","commit_id":"ef1c5ced95a2075e32b64f56ce3f8c9cf50a8b72"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"e6c451111c274e9c18afb8bbbbcea7ec9afe4587","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_multi(self, keys):"},{"line_number":59,"context_line":"        \"\"\"Retrieves the value for a list of keys"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        return [self.get(key) for key in keys]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def set(self, key, value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_071e2063","line":60,"in_reply_to":"fa1b9901_44cbb653","updated":"2015-08-25 01:30:42.000000000","message":"Done","commit_id":"ef1c5ced95a2075e32b64f56ce3f8c9cf50a8b72"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b08d11f10947896b0e5270dbb7ed2ea639a72b2f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.cache[key] \u003d (value, timeout)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def set_multi(self, mapping):"},{"line_number":77,"context_line":"        \"\"\"Set multiple values in the cache."},{"line_number":78,"context_line":"        Expunges expired keys during each set."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        :param mapping: dictionary with key/value pairs"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_04c5be3a","line":77,"updated":"2015-08-25 01:12:17.000000000","message":"Missing blank line here (PEP-257).","commit_id":"ef1c5ced95a2075e32b64f56ce3f8c9cf50a8b72"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"e6c451111c274e9c18afb8bbbbcea7ec9afe4587","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.cache[key] \u003d (value, timeout)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def set_multi(self, mapping):"},{"line_number":77,"context_line":"        \"\"\"Set multiple values in the cache."},{"line_number":78,"context_line":"        Expunges expired keys during each set."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        :param mapping: dictionary with key/value pairs"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_8720f09c","line":77,"in_reply_to":"fa1b9901_04c5be3a","updated":"2015-08-25 01:30:42.000000000","message":"Done","commit_id":"ef1c5ced95a2075e32b64f56ce3f8c9cf50a8b72"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"b08d11f10947896b0e5270dbb7ed2ea639a72b2f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if self.expiration_time \u003e 0:"},{"line_number":85,"context_line":"            timeout \u003d timeutils.utcnow_ts() + self.expiration_time"},{"line_number":86,"context_line":"        for key, value in mapping.items():"},{"line_number":87,"context_line":"            self.cache[key] \u003d (value, timeout)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def delete(self, key):"},{"line_number":90,"context_line":"        \"\"\"Deletes the value associated with the key if it exists."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_64f4ba86","line":87,"updated":"2015-08-25 01:12:17.000000000","message":"I think that self.set should back onto set_multi to avoid code duplication.","commit_id":"ef1c5ced95a2075e32b64f56ce3f8c9cf50a8b72"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"e6c451111c274e9c18afb8bbbbcea7ec9afe4587","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if self.expiration_time \u003e 0:"},{"line_number":85,"context_line":"            timeout \u003d timeutils.utcnow_ts() + self.expiration_time"},{"line_number":86,"context_line":"        for key, value in mapping.items():"},{"line_number":87,"context_line":"            self.cache[key] \u003d (value, timeout)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def delete(self, key):"},{"line_number":90,"context_line":"        \"\"\"Deletes the value associated with the key if it exists."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_07bf00fc","line":87,"in_reply_to":"fa1b9901_64f4ba86","updated":"2015-08-25 01:30:42.000000000","message":"good point.","commit_id":"ef1c5ced95a2075e32b64f56ce3f8c9cf50a8b72"}]}
