)]}'
{"id":"openstack%2Foslo.cache~655468","triplet_id":"openstack%2Foslo.cache~stable%2Fqueens~I039dffadeebd0ff4479b9c870c257772c43aba53","project":"openstack/oslo.cache","branch":"stable/queens","topic":"all-the-fixes-stable/rocky-stable/queens","hashtags":[],"change_id":"I039dffadeebd0ff4479b9c870c257772c43aba53","subject":"Fix memcache pool client in monkey-patched environments","status":"MERGED","created":"2019-04-24 15:03:01.000000000","updated":"2019-05-10 15:18:19.000000000","submitted":"2019-05-10 15:18:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"655468-1557501499141-6085ff31","meta_rev_id":"6ea88dc38434ec434e6f0b513edf36fb07f16621","_number":655468,"virtual_id_number":655468,"owner":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-05-10 15:18:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":0,"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"recommended":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":1,"date":"2019-05-07 09:29:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":2,"date":"2019-05-05 18:14:50.000000000","_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-10 13:49:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":0,"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":0,"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-05 18:14:50.000000000","updated_by":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"reviewer":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"state":"REVIEWER"},{"updated":"2019-05-07 09:29:08.000000000","updated_by":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"reviewer":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"state":"REVIEWER"},{"updated":"2019-05-10 13:49:33.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2019-05-10 15:18:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1d4f32d1672c75f2b1c599b2df37782e6a7c6533","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-04-24 15:03:01.000000000","message":"Patch Set 1: Cherry Picked from branch stable/rocky.","accounts_in_message":[],"_revision_number":1},{"id":"7efab4f7087f8378bd99501d7e3a2f15e1a87331","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-24 16:29:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/68/655468/1/check/openstack-tox-pep8/445c8ea/ : SUCCESS in 4m 21s\n- openstack-tox-py27 http://logs.openstack.org/68/655468/1/check/openstack-tox-py27/10894f6/ : SUCCESS in 5m 03s\n- openstack-tox-docs http://logs.openstack.org/68/655468/1/check/openstack-tox-docs/020f694/html/ : SUCCESS in 6m 38s\n- openstack-tox-py35 http://logs.openstack.org/68/655468/1/check/openstack-tox-py35/1d19c3c/ : SUCCESS in 4m 49s\n- tempest-full http://logs.openstack.org/68/655468/1/check/tempest-full/a3382f8/ : SUCCESS in 1h 25m 02s","accounts_in_message":[],"_revision_number":1},{"id":"7aec0e356e0a27128fc9ffe6bb100295aa47537b","author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"date":"2019-05-05 18:14:50.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5eddb3dd92afb2777a0c808eadfe7c595f203459","author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"date":"2019-05-07 09:29:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"44271a4cf6f83b2a8606180251aa0ec249f96a99","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-05-10 13:49:33.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6eabbdc716746bb8bbb9fb1ba7b5e5d43b5a44d6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 13:49:44.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a758d9303954fc8284895340241230a19eeb7c03","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 15:18:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/68/655468/1/gate/openstack-tox-pep8/61b16ff/ : SUCCESS in 6m 49s\n- openstack-tox-py27 http://logs.openstack.org/68/655468/1/gate/openstack-tox-py27/092670b/ : SUCCESS in 6m 19s\n- openstack-tox-docs http://logs.openstack.org/68/655468/1/gate/openstack-tox-docs/d3f30ef/html/ : SUCCESS in 6m 20s\n- openstack-tox-py35 http://logs.openstack.org/68/655468/1/gate/openstack-tox-py35/9f1c1e8/ : SUCCESS in 6m 59s\n- tempest-full http://logs.openstack.org/68/655468/1/gate/tempest-full/e4704eb/ : SUCCESS in 1h 25m 59s","accounts_in_message":[],"_revision_number":1},{"id":"d0524edae20090951ba82d421de85c2552ec971d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 15:18:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"38dcffa904c7d4b5bd61896b972c1e16477fcc56","revisions":{"38dcffa904c7d4b5bd61896b972c1e16477fcc56":{"kind":"REWORK","_number":1,"created":"2019-04-24 15:03:01.000000000","uploader":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"ref":"refs/changes/68/655468/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.cache","ref":"refs/changes/68/655468/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.cache refs/changes/68/655468/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.cache refs/changes/68/655468/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.cache refs/changes/68/655468/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.cache refs/changes/68/655468/1"}}},"commit":{"parents":[{"commit":"e4d14dcb5e5b33ddaf9ff192391f501bc2a75469","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.cache/commit/e4d14dcb5e5b33ddaf9ff192391f501bc2a75469"}]}],"author":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2019-02-26 22:12:23.000000000","tz":0},"committer":{"name":"Ben Nemec","email":"openstack@nemebean.com","date":"2019-04-24 15:03:01.000000000","tz":0},"subject":"Fix memcache pool client in monkey-patched environments","message":"Fix memcache pool client in monkey-patched environments\n\nFirst off, this is an ugly hack, but we\u0027re dealing with code that\nessentially monkey-patches a monkey-patch. You reap what you sow.\n\nPer the linked bug, our connection pool client explodes on python 3\nwith eventlet monkey-patching in force:\n\nTypeError: object() takes no parameters\n\nThis is due to the way __new__ is overridden in the class. We need\nto strip arguments from the call before they get to object(), which\ndoesn\u0027t accept args.\n\nUnfortunately, when we\u0027re _not_ monkey-patched, adding the new\noverride implementation fails with:\n\nTypeError: object.__new__(_MemcacheClient) is not safe,\nuse Client.__new__()\n\nAs such, we need different implementations depending on whether we\nare monkey-patched or not. This change passes both with and without\nmonkey-patching and adds a unit test that exposes the bug.\n\nNote that this is a temporary, backportable fix that will ultimately\nbe replaced by a switch to the pymemcache library which does not\nhave the threading.local problem being worked around here.\n\nChange-Id: I039dffadeebd0ff4479b9c870c257772c43aba53\nPartial-Bug: 1812935\nCloses-Bug: 1812672\n(cherry picked from commit f4a25f642991a7114b86f6eb7d0bac3d599953a6)\n(cherry picked from commit caf5443de8ff4ff353d741a125f782c67f579f52)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.cache/commit/38dcffa904c7d4b5bd61896b972c1e16477fcc56"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.cache/commit/38dcffa904c7d4b5bd61896b972c1e16477fcc56"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}