)]}'
{"id":"openstack%2Foslo.cache~656420","triplet_id":"openstack%2Foslo.cache~stable%2Frocky~I3e335261f749ad065e8abe972f4ac476d334e6b3","project":"openstack/oslo.cache","branch":"stable/rocky","topic":"bug/1819957","hashtags":[],"change_id":"I3e335261f749ad065e8abe972f4ac476d334e6b3","subject":"Pass `flush_on_reconnect` to memcache pooled backend","status":"MERGED","created":"2019-04-29 22:58:11.000000000","updated":"2019-05-02 23:35:22.000000000","submitted":"2019-05-02 23:35:22.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"656420-1556840122354-a663f06a","meta_rev_id":"351af3f591559d4bd8eec13e18f9d06b25119450","_number":656420,"virtual_id_number":656420,"owner":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":2,"date":"2019-05-02 23:35:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"all":[{"value":2,"date":"2019-05-02 19:34:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":1,"date":"2019-05-02 18:22:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":2,"date":"2019-05-01 16:15:41.000000000","_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":1,"date":"2019-04-30 09:59:53.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"all":[{"value":1,"date":"2019-05-02 22:00:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},{"value":0,"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-30 09:59:53.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2019-05-01 16:15:41.000000000","updated_by":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"reviewer":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"state":"REVIEWER"},{"updated":"2019-05-02 18:22:24.000000000","updated_by":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"reviewer":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"state":"REVIEWER"},{"updated":"2019-05-02 22:00:45.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2019-05-02 23:35:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"87f1cb7b94c7879699f7c9fadae26e5fb831e7ed","author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"date":"2019-04-29 22:58:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"06a70bbb34d0588a510a6bc355fc8c3fdbaadd8f","author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"date":"2019-04-29 22:59:09.000000000","message":"Topic changed from rocky/memcache-flush-on-reconnect to bug/1819957","accounts_in_message":[],"_revision_number":1},{"id":"39a98cbb6e19c7ab17c18c1f5d8ff09a48622817","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 00:28:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/656420/1/check/openstack-tox-pep8/439579f/ : SUCCESS in 4m 42s\n- openstack-tox-py27 http://logs.openstack.org/20/656420/1/check/openstack-tox-py27/d873f87/ : SUCCESS in 4m 34s\n- openstack-tox-docs http://logs.openstack.org/20/656420/1/check/openstack-tox-docs/dcb9f8f/html/ : SUCCESS in 6m 21s\n- openstack-tox-py35 http://logs.openstack.org/20/656420/1/check/openstack-tox-py35/7e15720/ : SUCCESS in 4m 34s\n- tempest-full http://logs.openstack.org/20/656420/1/check/tempest-full/248380d/ : SUCCESS in 1h 25m 12s\n- build-openstack-releasenotes http://logs.openstack.org/20/656420/1/check/build-openstack-releasenotes/e6c910b/html/ : SUCCESS in 3m 44s\n- openstack-tox-lower-constraints http://logs.openstack.org/20/656420/1/check/openstack-tox-lower-constraints/6e12491/ : SUCCESS in 5m 56s","accounts_in_message":[],"_revision_number":1},{"id":"0547e0ea6d3f0fe085f33b0c8b33772e1836e300","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-04-30 09:59:53.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"71a59101cdc671ec0ace331abf4d34477c72a2e3","author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"date":"2019-05-01 16:15:41.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b00472882c78bccd139749e6c27d27a390b68112","author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"date":"2019-05-02 18:22:24.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d6185241a453bd8e09c81ae7b3991ebf0d896d9e","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-05-02 19:34:20.000000000","message":"Patch Set 1: Code-Review+2\n\nWill +A once the stein backport merges","accounts_in_message":[],"_revision_number":1},{"id":"45ab913577b475c534c9b4d9a75d2333874bfb88","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-05-02 22:00:45.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"74cf71c7923bd0e851ae09e2ea1afbbc5def2e31","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-02 22:00:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"71bffbfd6a03916ae54b5d5103d6aac7bfcccf3d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-02 23:35:22.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/656420/1/gate/openstack-tox-pep8/2b51a4f/ : SUCCESS in 4m 48s\n- openstack-tox-py27 http://logs.openstack.org/20/656420/1/gate/openstack-tox-py27/51e8824/ : SUCCESS in 4m 52s\n- openstack-tox-docs http://logs.openstack.org/20/656420/1/gate/openstack-tox-docs/18c1933/html/ : SUCCESS in 4m 54s\n- openstack-tox-py35 http://logs.openstack.org/20/656420/1/gate/openstack-tox-py35/5a7b51d/ : SUCCESS in 5m 35s\n- tempest-full http://logs.openstack.org/20/656420/1/gate/tempest-full/aa12017/ : SUCCESS in 1h 30m 12s\n- build-openstack-releasenotes http://logs.openstack.org/20/656420/1/gate/build-openstack-releasenotes/25fbe7a/html/ : SUCCESS in 4m 38s\n- openstack-tox-lower-constraints http://logs.openstack.org/20/656420/1/gate/openstack-tox-lower-constraints/3cbe762/ : SUCCESS in 5m 52s","accounts_in_message":[],"_revision_number":1},{"id":"351af3f591559d4bd8eec13e18f9d06b25119450","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-02 23:35:22.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1d6d08f4911edb50debab4639e6a2825260b9e09","revisions":{"1d6d08f4911edb50debab4639e6a2825260b9e09":{"kind":"REWORK","_number":1,"created":"2019-04-29 22:58:11.000000000","uploader":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"ref":"refs/changes/20/656420/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.cache","ref":"refs/changes/20/656420/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.cache refs/changes/20/656420/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.cache refs/changes/20/656420/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.cache refs/changes/20/656420/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.cache refs/changes/20/656420/1"}}},"commit":{"parents":[{"commit":"4a43379aa06b642d378cae10d6d4d8544053d545","subject":"Merge \"Fix memcache pool client in monkey-patched environments\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.cache/commit/4a43379aa06b642d378cae10d6d4d8544053d545"}]}],"author":{"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","date":"2019-03-22 19:35:16.000000000","tz":-420},"committer":{"name":"Matthew Thode","email":"mthode@mthode.org","date":"2019-04-29 22:57:38.000000000","tz":-300},"subject":"Pass `flush_on_reconnect` to memcache pooled backend","message":"Pass `flush_on_reconnect` to memcache pooled backend\n\nIf a memcache server disappears and then reconnects when multiple memcache\nservers are used (specific to the python-memcached based backends) it is\npossible that the server will contain stale data. The default is now to\nsupply the ``flush_on_reconnect`` optional argument to the backend. This\nmeans that when the service connects to a memcache server, it will flush\nall cached data in the server. The pooled backend is more likely to\nrun into issues with this as it does not explicitly use a thread.local\nfor the client. The non-pooled backend was not touched, it is not\nthe recommended production use-case.\n\nSee the help from python-memcached:\n\n    @param flush_on_reconnect: optional flag which prevents a\n\tscenario that can cause stale data to be read: If there\u0027s more\n\tthan one memcached server and the connection to one is\n\tinterrupted, keys that mapped to that server will get\n\treassigned to another. If the first server comes back, those\n\tkeys will map to it again. If it still has its data, get()s\n\tcan read stale data that was overwritten on another\n\tserver. This flag is off by default for backwards\n\tcompatibility.\n\nChange-Id: I3e335261f749ad065e8abe972f4ac476d334e6b3\ncloses-bug: #1819957\n(cherry picked from commit 1192f185a5fd2fa6177655f157146488a3de81d1)\nSigned-off-by: Matthew Thode \u003cmthode@mthode.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.cache/commit/1d6d08f4911edb50debab4639e6a2825260b9e09"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.cache/commit/1d6d08f4911edb50debab4639e6a2825260b9e09"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}