)]}'
{"oslo_cache/backends/memcache_pool.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"12b196db6bb0f33a813959dcbdcdac7fe7a461d8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027dead_retry\u0027: arguments.get(\u0027dead_retry\u0027, 5 * 60),"},{"line_number":48,"context_line":"                \u0027socket_timeout\u0027: arguments.get(\u0027socket_timeout\u0027, 3.0),"},{"line_number":49,"context_line":"                \u0027server_max_value_length\u0027:"},{"line_number":50,"context_line":"                    arguments.get(\u0027server_max_value_length\u0027),"},{"line_number":51,"context_line":"            },"},{"line_number":52,"context_line":"            maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":53,"context_line":"            unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d3f00194","line":50,"updated":"2019-06-12 13:24:56.000000000","message":"What happen if `server_max_value_length` is not set?\n\nI suppose you need to provide a default value in this case to avoid errors during the retrieve of this key.\n\nPer example something like that:\n```\n arguments.get(\u0027server_max_value_length\u0027, memcache.SERVER_MAX_VALUE_LENGTH),\n```\n\nThoughts?","commit_id":"4ff837998421ad6c78e9b9ab1efbecd8d0f95822"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"e9a301e149bf63326206d3bc1d0b9b04f602c99c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027dead_retry\u0027: arguments.get(\u0027dead_retry\u0027, 5 * 60),"},{"line_number":48,"context_line":"                \u0027socket_timeout\u0027: arguments.get(\u0027socket_timeout\u0027, 3.0),"},{"line_number":49,"context_line":"                \u0027server_max_value_length\u0027:"},{"line_number":50,"context_line":"                    arguments.get(\u0027server_max_value_length\u0027),"},{"line_number":51,"context_line":"            },"},{"line_number":52,"context_line":"            maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":53,"context_line":"            unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_0d4167a9","line":50,"in_reply_to":"9fb8cfa7_42051c10","updated":"2019-06-14 15:56:11.000000000","message":"For reference: https://github.com/linsomniac/python-memcached/blob/bad41222379102e3f18f6f2f7be3ee608de6fbff/memcache.py#L164","commit_id":"4ff837998421ad6c78e9b9ab1efbecd8d0f95822"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"a39bcdfa9eedfbd65c7a176f1f4cbc4ed56629d6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027dead_retry\u0027: arguments.get(\u0027dead_retry\u0027, 5 * 60),"},{"line_number":48,"context_line":"                \u0027socket_timeout\u0027: arguments.get(\u0027socket_timeout\u0027, 3.0),"},{"line_number":49,"context_line":"                \u0027server_max_value_length\u0027:"},{"line_number":50,"context_line":"                    arguments.get(\u0027server_max_value_length\u0027),"},{"line_number":51,"context_line":"            },"},{"line_number":52,"context_line":"            maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":53,"context_line":"            unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_42051c10","line":50,"in_reply_to":"9fb8cfa7_d3f00194","updated":"2019-06-12 14:19:04.000000000","message":"Thank you for review.\nIt will return default None from dict and use default value on python-memcached side.","commit_id":"4ff837998421ad6c78e9b9ab1efbecd8d0f95822"}]}