)]}'
{".zuul.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"809dfc1f69d0fc1e29d476631edb76976ef4656b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      tox_environment:"},{"line_number":31,"context_line":"        OSLO_CACHE_BACKEND: memcached"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- project:"},{"line_number":34,"context_line":"    templates:"},{"line_number":35,"context_line":"      - check-requirements"},{"line_number":36,"context_line":"      - lib-forward-testing-python3"},{"line_number":37,"context_line":"      - openstack-lower-constraints-jobs"},{"line_number":38,"context_line":"      - openstack-python3-train-jobs"},{"line_number":39,"context_line":"      - periodic-stable-jobs"},{"line_number":40,"context_line":"      - publish-openstack-docs-pti"},{"line_number":41,"context_line":"      - release-notes-jobs-python3"},{"line_number":42,"context_line":"    check:"},{"line_number":43,"context_line":"      jobs:"},{"line_number":44,"context_line":"        - oslo.cache-tempest-full-py3-memcached-pool"},{"line_number":45,"context_line":"        - oslo.cache-functional-etcd3gw"},{"line_number":46,"context_line":"        - oslo.cache-functional-memcached"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"df33271e_4a1ab56e","line":46,"range":{"start_line":33,"start_character":2,"end_line":46,"end_character":0},"updated":"2020-03-31 18:22:20.000000000","message":"Job oslo.cache-functional-etcd3gw not defined","commit_id":"dccde926c318f2bf227899765d2fc218ce103739"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1b7aaf83b5477941091c6f03bbbb1e5a008acd01","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      - release-notes-jobs-python3"},{"line_number":26,"context_line":"    check:"},{"line_number":27,"context_line":"      jobs:"},{"line_number":28,"context_line":"        # - oslo.cache-tempest-full-py3-memcached-pool"},{"line_number":29,"context_line":"        - oslo.cache-functional-tox-py37-etcd3gw"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"df33271e_2d788f8d","line":28,"updated":"2020-04-07 17:20:56.000000000","message":"let\u0027s drop it entirely but maybe in memcache_pool part? - to make it less confusing","commit_id":"926e0f1c52f4787d10fd059e0c1620579187162b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"82162bfc31042fb0452d97a8a7d54a82bf509e37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job:"},{"line_number":2,"context_line":"    name: oslo.cache-functional-tox-py37"},{"line_number":3,"context_line":"    parent: openstack-tox-py37"},{"line_number":4,"context_line":"    abstract: true"},{"line_number":5,"context_line":"    pre-run: playbooks/tests/functional/pre.yml"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"ff570b3c_2f2c5998","line":2,"updated":"2020-05-09 12:08:25.000000000","message":"Let\u0027s use py38","commit_id":"fc4f188a145c15f91b391adc4322c6058eea7258"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"9163f7f55e0296de52050d576ea9c3b76bc5a581","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job:"},{"line_number":2,"context_line":"    name: oslo.cache-functional-tox-py37"},{"line_number":3,"context_line":"    parent: openstack-tox-py37"},{"line_number":4,"context_line":"    abstract: true"},{"line_number":5,"context_line":"    pre-run: playbooks/tests/functional/pre.yml"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"ff570b3c_ce5b1585","line":2,"in_reply_to":"ff570b3c_2f2c5998","updated":"2020-05-11 09:54:28.000000000","message":"ack","commit_id":"fc4f188a145c15f91b391adc4322c6058eea7258"}],"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1b7aaf83b5477941091c6f03bbbb1e5a008acd01","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"These changes activate functional tests for oslo.cache."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Functional tests support the following backends for now:"},{"line_number":14,"context_line":"- etcd3gw"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"They introduced:"},{"line_number":17,"context_line":"- related ci jobs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"df33271e_8dcb9ba3","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":9},"updated":"2020-04-07 17:20:56.000000000","message":"to not break the thought flow this should probably be the last paragraph","commit_id":"926e0f1c52f4787d10fd059e0c1620579187162b"}],"bindep.txt":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e43b3571c75ad47bf4b2f406d77a81c031c8f8f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This file contains runtime (non-python) dependencies"},{"line_number":2,"context_line":"# More info at: https://docs.openstack.org/infra/bindep/readme.html"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"etcd [tests-functional-etcd]"},{"line_number":5,"context_line":"memcached [tests-functional-memcached]"}],"source_content_type":"text/plain","patch_set":17,"id":"df33271e_ef9d8dbc","line":5,"range":{"start_line":1,"start_character":0,"end_line":5,"end_character":38},"updated":"2020-04-01 08:35:50.000000000","message":"Nice","commit_id":"9968480ab25ea66472d278adfa833d201977d8b7"}],"oslo_cache/tests/functional/test_cache_backend.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a85f812bc6a54e3ff5deeba4c546f00577e1209c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"NO_VALUE \u003d core.NO_VALUE"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_BACKEND_IN_TESTS \u003d ["},{"line_number":28,"context_line":"    \u0027oslo_cache.etcd3gw\u0027,"},{"line_number":29,"context_line":"    \u0027oslo_cache.memcache_pool\u0027"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"df33271e_00664e52","line":29,"range":{"start_line":28,"start_character":4,"end_line":29,"end_character":30},"updated":"2020-04-06 20:07:00.000000000","message":"we feed short names of backends, not full (and in cache of memcache_pool we give memcached - needs fixing - we should pass the correct backend)","commit_id":"88b73dffe448dcddfa530375bfad9e9ef69cde3f"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"2c3c0330c3f83ef666b905f055b2e75d198dded7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"NO_VALUE \u003d core.NO_VALUE"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_BACKEND_IN_TESTS \u003d ["},{"line_number":28,"context_line":"    \u0027oslo_cache.etcd3gw\u0027,"},{"line_number":29,"context_line":"    \u0027oslo_cache.memcache_pool\u0027"},{"line_number":30,"context_line":"]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"df33271e_dcbf29fa","line":29,"range":{"start_line":28,"start_character":4,"end_line":29,"end_character":30},"in_reply_to":"df33271e_00664e52","updated":"2020-04-07 08:14:17.000000000","message":"Yep I seen thanks.\n\nI modified the code to take care of the short names and replace with the right one before creating a region.\n\nMaybe it could be interesting to rename OSLO_CACHE_BACKEND in something other to avoid collision with cache.backend [1] but it could be improved in a second time.\n\n[1] https://docs.openstack.org/oslo.cache/latest/configuration/index.html#cache.backend","commit_id":"88b73dffe448dcddfa530375bfad9e9ef69cde3f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a85f812bc6a54e3ff5deeba4c546f00577e1209c","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def setUp(self):"},{"line_number":37,"context_line":"        self.backend_to_use \u003d os.getenv(\u0027OSLO_CACHE_BACKEND\u0027,"},{"line_number":38,"context_line":"                                        \u0027oslo_cache.etcd3gw\u0027)"},{"line_number":39,"context_line":"        if self.backend_to_use not in SUPPORTED_BACKEND_IN_TESTS:"},{"line_number":40,"context_line":"            raise Exception("},{"line_number":41,"context_line":"                \"Backend (%s) not supported in tests\" % self.backend_to_use)"}],"source_content_type":"text/x-python","patch_set":25,"id":"df33271e_e0752afc","line":38,"range":{"start_line":38,"start_character":41,"end_line":38,"end_character":59},"updated":"2020-04-06 20:07:00.000000000","message":"let\u0027s not use this as fallback as it will be confusing and can hide real issues","commit_id":"88b73dffe448dcddfa530375bfad9e9ef69cde3f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1b7aaf83b5477941091c6f03bbbb1e5a008acd01","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NO_VALUE \u003d core.NO_VALUE"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_BACKEND_IN_TESTS \u003d ["},{"line_number":28,"context_line":"    \u0027etcd3gw\u0027,"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"df33271e_4d9a33c5","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":26},"updated":"2020-04-07 17:20:56.000000000","message":"TESTABLE_BACKENDS / COVERED_BACKENDS ?","commit_id":"926e0f1c52f4787d10fd059e0c1620579187162b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1b7aaf83b5477941091c6f03bbbb1e5a008acd01","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                \u0027host\u0027: \u0027127.0.0.1\u0027,"},{"line_number":44,"context_line":"                \u0027port\u0027: 2379,"},{"line_number":45,"context_line":"            }"},{"line_number":46,"context_line":"            test_cache.BaseTestCase.setUp(self)"},{"line_number":47,"context_line":"            try:"},{"line_number":48,"context_line":"                urllib3.PoolManager().request("},{"line_number":49,"context_line":"                    \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":31,"id":"df33271e_6d80d747","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":47},"updated":"2020-04-07 17:20:56.000000000","message":"feels like it should not be nested in this \u0027if\u0027 but be level above","commit_id":"926e0f1c52f4787d10fd059e0c1620579187162b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1b7aaf83b5477941091c6f03bbbb1e5a008acd01","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \u0027port\u0027: 2379,"},{"line_number":45,"context_line":"            }"},{"line_number":46,"context_line":"            test_cache.BaseTestCase.setUp(self)"},{"line_number":47,"context_line":"            try:"},{"line_number":48,"context_line":"                urllib3.PoolManager().request("},{"line_number":49,"context_line":"                    \u0027GET\u0027,"},{"line_number":50,"context_line":"                    \u0027%s:%d\u0027 % (self.arguments[\u0027host\u0027], self.arguments[\u0027port\u0027])"},{"line_number":51,"context_line":"                )"},{"line_number":52,"context_line":"                return True"},{"line_number":53,"context_line":"            except urllib3.exceptions.HTTPError:"},{"line_number":54,"context_line":"                self.skipTest(\"skipping this test\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_typical_configuration(self):"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"df33271e_4d835357","line":54,"range":{"start_line":47,"start_character":12,"end_line":54,"end_character":51},"updated":"2020-04-07 17:20:56.000000000","message":"I don\u0027t think we want to skip this test now that we ensure we want to test exactly this - it was useful for the lazy version before the patch we are proposing","commit_id":"926e0f1c52f4787d10fd059e0c1620579187162b"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"9917e121c7cb4b8ebeda6e9cd18df58ff6ab71b7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \u0027port\u0027: 2379,"},{"line_number":45,"context_line":"            }"},{"line_number":46,"context_line":"            test_cache.BaseTestCase.setUp(self)"},{"line_number":47,"context_line":"            try:"},{"line_number":48,"context_line":"                urllib3.PoolManager().request("},{"line_number":49,"context_line":"                    \u0027GET\u0027,"},{"line_number":50,"context_line":"                    \u0027%s:%d\u0027 % (self.arguments[\u0027host\u0027], self.arguments[\u0027port\u0027])"},{"line_number":51,"context_line":"                )"},{"line_number":52,"context_line":"                return True"},{"line_number":53,"context_line":"            except urllib3.exceptions.HTTPError:"},{"line_number":54,"context_line":"                self.skipTest(\"skipping this test\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_typical_configuration(self):"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"df33271e_cd75a3ce","line":54,"range":{"start_line":47,"start_character":12,"end_line":54,"end_character":51},"in_reply_to":"df33271e_4d835357","updated":"2020-04-07 17:50:21.000000000","message":"Yep I agree we don\u0027t need to keep that now","commit_id":"926e0f1c52f4787d10fd059e0c1620579187162b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"96225c43106f0b45fc802195673b7e3d2a951ed4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                \"Backend (%s) not supported in tests\" % self.backend_to_use)"},{"line_number":41,"context_line":"        if self.backend_to_use \u003d\u003d \u0027etcd3gw\u0027:"},{"line_number":42,"context_line":"            self.backend_to_use \u003d \"oslo_cache.etcd3gw\""},{"line_number":43,"context_line":"            self.arguments \u003d {"},{"line_number":44,"context_line":"                \u0027host\u0027: \u0027127.0.0.1\u0027,"},{"line_number":45,"context_line":"                \u0027port\u0027: 2379,"},{"line_number":46,"context_line":"            }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_typical_configuration(self):"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"df33271e_6d3d77dc","line":46,"range":{"start_line":43,"start_character":12,"end_line":46,"end_character":13},"updated":"2020-04-07 17:54:22.000000000","message":"ideally we should parse that from environment - you could slap that as a TODO as this is not that important for practically any case this is going to be applied with really so no need to sweat it early","commit_id":"b696e76d799124c3d483e4ab0e3fb75e40632de2"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"74ae5c7d3e3fe792d688735446c8738b83b25872","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                \"Backend (%s) not supported in tests\" % self.backend_to_use)"},{"line_number":41,"context_line":"        if self.backend_to_use \u003d\u003d \u0027etcd3gw\u0027:"},{"line_number":42,"context_line":"            self.backend_to_use \u003d \"oslo_cache.etcd3gw\""},{"line_number":43,"context_line":"            self.arguments \u003d {"},{"line_number":44,"context_line":"                \u0027host\u0027: \u0027127.0.0.1\u0027,"},{"line_number":45,"context_line":"                \u0027port\u0027: 2379,"},{"line_number":46,"context_line":"            }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_typical_configuration(self):"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"df33271e_f044c049","line":46,"range":{"start_line":43,"start_character":12,"end_line":46,"end_character":13},"in_reply_to":"df33271e_6d3d77dc","updated":"2020-04-07 18:03:37.000000000","message":"I agree, a better version of this module should be based on the config [1].\n\nIdeally functional tests should looks like to the example described in the doc usage [2], I started to write the needed changes to use this type of approach [2] rather than a direct call like that, but surely publish them through a follow up patch too.\n\nBy waiting for these changes I\u0027ll add this TODO as you proposed and to unlock functional tests in a first time.\n\n[1] https://docs.openstack.org/oslo.cache/latest/configuration/index.html\n[2] https://docs.openstack.org/oslo.cache/latest/user/usage.html","commit_id":"b696e76d799124c3d483e4ab0e3fb75e40632de2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5f2a0197bf10eee280ca5afd6ef6250d1910487","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        test_cache.BaseTestCase.setUp(self)"},{"line_number":36,"context_line":"        self.backend_to_use \u003d os.getenv(\u0027OSLO_CACHE_BACKEND\u0027)"},{"line_number":37,"context_line":"        if self.backend_to_use not in TESTABLE_BACKENDS:"},{"line_number":38,"context_line":"            raise Exception("},{"line_number":39,"context_line":"                \"Backend (%s) not supported in tests\" % self.backend_to_use)"}],"source_content_type":"text/x-python","patch_set":35,"id":"1f493fa4_095ef574","line":36,"range":{"start_line":36,"start_character":13,"end_line":36,"end_character":27},"updated":"2020-04-29 10:00:01.000000000","message":"s/backend_to_use/backend/\n\nIt\u0027s more concise, IMO","commit_id":"b451e0345ff9aad5b92de2764a7268a87885b195"}],"oslo_cache/tests/test_cache.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5f2a0197bf10eee280ca5afd6ef6250d1910487","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            # TODO(morganfainberg): Make Cache Testing a separate test case"},{"line_number":26,"context_line":"            # in tempest, and move it out of the base unit tests."},{"line_number":27,"context_line":"            group\u003d\u0027cache\u0027,"},{"line_number":28,"context_line":"            backend\u003d\u0027dogpile.cache.memory\u0027,"},{"line_number":29,"context_line":"            enabled\u003dTrue,"},{"line_number":30,"context_line":"            proxies\u003d[\u0027oslo_cache.testing.CacheIsolatingProxy\u0027])"}],"source_content_type":"text/x-python","patch_set":35,"id":"1f493fa4_e9f2a96f","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":41},"updated":"2020-04-29 10:00:01.000000000","message":"This is the base class for the functional tests also, yes? I don\u0027t see you overriding this and setting it to \u0027oslo_cache.etcd3gw\u0027 there. Shouldn\u0027t you have done that?\n\nTBH, I\u0027d probably move this base class to \u0027oslo_cache/tests/unit\u0027 and just duplicate this setUp function to the functional test class","commit_id":"b451e0345ff9aad5b92de2764a7268a87885b195"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ae56fe7a004cf5e216b75aa773ef509b65d5d36a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            # TODO(morganfainberg): Make Cache Testing a separate test case"},{"line_number":26,"context_line":"            # in tempest, and move it out of the base unit tests."},{"line_number":27,"context_line":"            group\u003d\u0027cache\u0027,"},{"line_number":28,"context_line":"            backend\u003d\u0027dogpile.cache.memory\u0027,"},{"line_number":29,"context_line":"            enabled\u003dTrue,"},{"line_number":30,"context_line":"            proxies\u003d[\u0027oslo_cache.testing.CacheIsolatingProxy\u0027])"}],"source_content_type":"text/x-python","patch_set":35,"id":"1f493fa4_2c8728b9","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":41},"in_reply_to":"1f493fa4_e9f2a96f","updated":"2020-05-04 16:54:07.000000000","message":"Hum not really... etcd3gw\u0027s functional tests already existed before my changes [1], but IIRC they were not runned and no etcd3 backend was ran previously.\n\nAlso the etcd3gw functional tests don\u0027t really take care of this configuration because they configured a region in each test to run [2]... so if I\u0027m right this config is simply ignored by our functional tests. So another approach could be to don\u0027t inherit from this base class at all in the functional part.\n\nMoreover functional machinery is mostly rewritten in the following patch [3] so I don\u0027t think this is something that we want in this patch (due to redundance of the changes needed and due to unused aspect of this config).\n\nThoughts?\n\n[1] https://github.com/openstack/oslo.cache/blob/master/oslo_cache/tests/functional/test_cache_backend_etcd3gw.py\n[2] https://github.com/openstack/oslo.cache/blob/master/oslo_cache/tests/functional/test_cache_backend_etcd3gw.py#L45,L48\n[3] https://review.opendev.org/#/c/718223","commit_id":"b451e0345ff9aad5b92de2764a7268a87885b195"}],"playbooks/tests/functional/pre.yml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e43b3571c75ad47bf4b2f406d77a81c031c8f8f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  vars:"},{"line_number":3,"context_line":"    oslo_cache_backend_daemon: \"{{ tox_environment.OSLO_CACHE_BACKEND_DAEMON | default(tox_environment.OSLO_CACHE_BACKEND) }}\""},{"line_number":4,"context_line":"  roles:"},{"line_number":5,"context_line":"    - role: bindep"},{"line_number":6,"context_line":"      bindep_profile: \"tests-functional-{{ oslo_cache_backend_daemon }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"df33271e_4f6759ea","line":6,"range":{"start_line":1,"start_character":0,"end_line":6,"end_character":72},"updated":"2020-04-01 08:35:50.000000000","message":"Good job!","commit_id":"9968480ab25ea66472d278adfa833d201977d8b7"}],"tools/setup-memcached-env.sh":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"2a9af279e3375b36b9059a289d086e533aa1343c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -eux"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [ -z \"$(which memcached)\" ]; then"},{"line_number":6,"context_line":"    # FIXME: Ubuntu only for now!"},{"line_number":7,"context_line":"    sudo apt-get update"},{"line_number":8,"context_line":"    sudo apt-get -y install memcached"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"$*"}],"source_content_type":"text/x-sh","patch_set":12,"id":"df33271e_efac7bee","line":11,"range":{"start_line":3,"start_character":0,"end_line":11,"end_character":2},"updated":"2020-03-31 17:37:12.000000000","message":"Sorry for the dumb question, isn\u0027t possible to use bindep rather something like that?","commit_id":"22145c9778e985dbbfb0cdb5fd30b5e64594d97f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ec77973c4f642a162553a1ed15712f78ed85ec17","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -eux"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [ -z \"$(which memcached)\" ]; then"},{"line_number":6,"context_line":"    # FIXME: Ubuntu only for now!"},{"line_number":7,"context_line":"    sudo apt-get update"},{"line_number":8,"context_line":"    sudo apt-get -y install memcached"},{"line_number":9,"context_line":"fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"$*"}],"source_content_type":"text/x-sh","patch_set":12,"id":"df33271e_8f616fac","line":11,"range":{"start_line":3,"start_character":0,"end_line":11,"end_character":2},"in_reply_to":"df33271e_efac7bee","updated":"2020-03-31 17:49:30.000000000","message":"It is, I was just inspired by the etcd one. :-) There is no bindep currently. Good idea to introduce.\n\nPS: There are no dumb questions! :D","commit_id":"22145c9778e985dbbfb0cdb5fd30b5e64594d97f"}],"tox.ini":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a85f812bc6a54e3ff5deeba4c546f00577e1209c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"[testenv:functional]"},{"line_number":18,"context_line":"setenv \u003d"},{"line_number":19,"context_line":"    STESTR_TEST_PATH\u003d./oslo_cache/tests/functional/"},{"line_number":20,"context_line":"    OSLO_CACHE_BACKEND\u003d{env:OSLO_CACHE_BACKEND}"},{"line_number":21,"context_line":"commands \u003d"},{"line_number":22,"context_line":"  find . -type f -name \"*.pyc\" -delete"},{"line_number":23,"context_line":"  pifpaf -e OSLO_CACHE_TEST run {env:OSLO_CACHE_BACKEND_DAEMON:{env:OSLO_CACHE_BACKEND}} -- stestr run --slowest"}],"source_content_type":"text/x-properties","patch_set":25,"id":"df33271e_803a5e31","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":47},"updated":"2020-04-06 20:07:00.000000000","message":"passenv \u003d OSLO_CACHE_BACKEND","commit_id":"88b73dffe448dcddfa530375bfad9e9ef69cde3f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"433037a69e8ccba8ce4baa0a0d99310ed83f9ec0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"[testenv:functional]"},{"line_number":18,"context_line":"setenv \u003d"},{"line_number":19,"context_line":"    STESTR_TEST_PATH\u003d./oslo_cache/tests/functional/"},{"line_number":20,"context_line":"    OSLO_CACHE_BACKEND\u003d{env:OSLO_CACHE_BACKEND}"},{"line_number":21,"context_line":"passenv \u003d OSLO_CACHE_BACKEND"},{"line_number":22,"context_line":"commands \u003d"},{"line_number":23,"context_line":"  find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":27,"id":"df33271e_9c2ac129","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":47},"updated":"2020-04-07 08:13:27.000000000","message":"I meant below instead of this :-)","commit_id":"64b25de411bc68395b7f666bf1bd36f51b133596"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1b7aaf83b5477941091c6f03bbbb1e5a008acd01","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[testenv:functional]"},{"line_number":18,"context_line":"setenv \u003d"},{"line_number":19,"context_line":"    STESTR_TEST_PATH\u003d./oslo_cache/tests/functional/"},{"line_number":20,"context_line":"passenv \u003d OSLO_CACHE_BACKEND"},{"line_number":21,"context_line":"commands \u003d"},{"line_number":22,"context_line":"  find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":31,"id":"df33271e_2dd40f47","line":19,"range":{"start_line":19,"start_character":50,"end_line":19,"end_character":51},"updated":"2020-04-07 17:20:56.000000000","message":"nit: looks better without dangling slash","commit_id":"926e0f1c52f4787d10fd059e0c1620579187162b"}]}
