)]}'
{"CONTRIBUTING.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d200f20db7cd690f3ea7232b0dbce09991b9210b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f493fa4_e97bc9f1","updated":"2020-04-29 09:52:02.000000000","message":"Any chance you could keep this as-is and modify https://review.opendev.org/#/c/723044/ instead?","commit_id":"04f9e9ebe32105b1bc3b6b36d024f9ab5aaf4e5a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"30d9d9de362c35cda9f743c4476fb70cf18f34fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f493fa4_97d4dcea","in_reply_to":"1f493fa4_e97bc9f1","updated":"2020-04-29 11:20:39.000000000","message":"Few days ago I already proposed to merge these changes and those of the oslo policy (c.f my comment in [1]), but I agree with Ben\u0027s comment in [1] it could be more appropriate to update the standard contribution guide to highlight some specific parts like the git/gerrit part.\n\nI propose to you the following road map:\n1. we keep only the pre-commit part here (mechanismes + contribution guide related parts);\n2. we merge these changes;\n3. we spread the pre-commit features on oslo.*;\n4. we update the oslo contribution guide [1] with a follow up patch to speak about pre-commit;\n5. we drop the pre-commit doc part here.\n\nThoughts?\n\n[1] https://review.opendev.org/#/c/723044/","commit_id":"04f9e9ebe32105b1bc3b6b36d024f9ab5aaf4e5a"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"da0bc613eb7a189bbf15a02f140a0200c1ab88f4","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Implementation of pre-commit is very fast and saves a lot of disk space"},{"line_number":36,"context_line":"because internally it does cache any linter-version and reuses it between"},{"line_number":37,"context_line":"repositories, as opposed to tox which uses environments unique to each"},{"line_number":38,"context_line":"repository (usually more than one). Also by design pre-commit always pins"},{"line_number":39,"context_line":"linters, making less like to break code because linter released new version."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_16757c64","line":37,"updated":"2020-04-28 21:41:37.000000000","message":"Note that tox doesn\u0027t have to do this. Nova, for example, uses a shared tox environment for linters.","commit_id":"04f9e9ebe32105b1bc3b6b36d024f9ab5aaf4e5a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"30d9d9de362c35cda9f743c4476fb70cf18f34fe","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Implementation of pre-commit is very fast and saves a lot of disk space"},{"line_number":36,"context_line":"because internally it does cache any linter-version and reuses it between"},{"line_number":37,"context_line":"repositories, as opposed to tox which uses environments unique to each"},{"line_number":38,"context_line":"repository (usually more than one). Also by design pre-commit always pins"},{"line_number":39,"context_line":"linters, making less like to break code because linter released new version."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_f708c092","line":37,"in_reply_to":"1f493fa4_16757c64","updated":"2020-04-29 11:20:39.000000000","message":"Thanks for the heads up","commit_id":"04f9e9ebe32105b1bc3b6b36d024f9ab5aaf4e5a"}]}