)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"authentication process, which integrates the application layer and the"},{"line_number":13,"context_line":"system authentication mechanism. However, the current memcached hasn\u0027t"},{"line_number":14,"context_line":"any authenticaction mechanism to protect the user\u0027s data cached in"},{"line_number":15,"context_line":"memcached server."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: 7828bed0febabfa11a0a8f6960f4c7cc8acec841"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"9f560f44_46670e26","line":15,"updated":"2020-08-27 09:30:58.000000000","message":"We also seem to be adding general support for the binary memcached protocol within oslo.cache. Perhaps we should be calling that out here?","commit_id":"0961cce68703ae13852005221614f6d321160964"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"a61764e60f786308ca45a5f79a204bfe055acf70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"e6c3aeb8_f4b58624","updated":"2022-01-12 09:45:32.000000000","message":"Hi Jorhson,\n\nAny update here? Can you fix the test please?","commit_id":"82e76242b8edca2314ac219a098ccb5390b512cc"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"280dea4e6b2ac2ef44481384057fa0baf7800611","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"cfe16cac_3bdb149f","updated":"2022-01-13 12:07:30.000000000","message":"\u003e Patch Set 29:\n\u003e \n\u003e Hello,\n\u003e \n\u003e The tests fails with the following errors:\n\u003e \n\u003e ```\n\u003e oslo_cache.tests.unit.test_connection_pool.TestBMemcacheClientOverrides.test_can_create_with_kwargs\n\u003e ---------------------------------------------------------------------------------------------------\n\u003e \n\u003e Captured traceback:\n\u003e ~~~~~~~~~~~~~~~~~~~\n\u003e     Traceback (most recent call last):\n\u003e \n\u003e       File \"/home/hberaud/dev/redhat/upstream/openstack/oslo/oslo.cache/oslo_cache/tests/unit/test_connection_pool.py\", line 191, in test_can_create_with_kwargs\n\u003e     client \u003d _bmemcache_pool._BMemcacheClient(\u0027foo\u0027, check_keys\u003dFalse)\n\u003e \n\u003e     TypeError: __init__() got an unexpected keyword argument \u0027check_keys\u0027\n\u003e \n\u003e \n\u003e oslo_cache.tests.unit.test_connection_pool.TestBMemcacheClientOverrides.test_client_stripped_of_threading_local\n\u003e ---------------------------------------------------------------------------------------------------------------\n\u003e \n\u003e Captured traceback:\n\u003e ~~~~~~~~~~~~~~~~~~~\n\u003e     Traceback (most recent call last):\n\u003e \n\u003e       File \"/home/hberaud/dev/redhat/upstream/openstack/oslo/oslo.cache/oslo_cache/tests/unit/test_connection_pool.py\", line 174, in test_client_stripped_of_threading_local\n\u003e     self.assertTrue(thread_local is threading.local)\n\u003e \n\u003e       File \"/usr/lib64/python3.8/unittest/case.py\", line 765, in assertTrue\n\u003e     raise self.failureException(msg)\n\u003e \n\u003e     AssertionError: False is not true\n\u003e ```\n\u003e \n\u003e I think that you need to adapt something somewhere in `oslo_cache/_bmemcache_pool.py`.\n\nHello, I have updated the unittest, please help to review the code， thanks","commit_id":"002c3fa5d67b5bc2551936627d7a8bc706a1c257"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d3b3deab499b038b02b5e9c620f979f45530df1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"b4c8635f_03949da0","updated":"2022-01-17 10:21:49.000000000","message":"LGTM","commit_id":"002c3fa5d67b5bc2551936627d7a8bc706a1c257"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8836b477c9f7bbef8858c876b6c02dfac320bf4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"d5e581c4_75eb01af","updated":"2022-04-29 08:34:50.000000000","message":"Thanks for this latest patch set.\nPlease see my inline comments","commit_id":"c19e25d1b3c8c301c24dbb2a0220f1fd22c0e152"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"700ec6dae879801604d833fdba7f098d863b3719","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"5a5577cb_fc7cbfbc","updated":"2022-05-03 09:51:45.000000000","message":"Thanks Jorhson.","commit_id":"d229d3edb73610137d78779b12e6dc226a3c6e61"}],"oslo_cache/_bmemcache_pool.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"49f49210e033c0f82abdbaa18f54e656dde1d9e2","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self._username \u003d arguments.pop(\u0027usrname\u0027)"},{"line_number":209,"context_line":"        self._password \u003d arguments.pop(\u0027password\u0027)"},{"line_number":210,"context_line":"        self._arguments \u003d {"},{"line_number":211,"context_line":"                    \u0027socket_timeout\u0027: arguments.get(\u0027socket_timeout\u0027, 3.0),"},{"line_number":212,"context_line":"        }"},{"line_number":213,"context_line":"        # NOTE(morganfainberg): The host objects expect an int for the"},{"line_number":214,"context_line":"        # deaduntil value. Initialize this at 0 for each host with 0 indicating"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_05e5d1dc","line":211,"updated":"2020-07-21 04:42:25.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"086de293740152b5d1cf30005851905fb8fcfc5a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dc36150ac280aba66188d738831f041a515f0ede","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self._username \u003d arguments.pop(\u0027usrname\u0027)"},{"line_number":209,"context_line":"        self._password \u003d arguments.pop(\u0027password\u0027)"},{"line_number":210,"context_line":"        self._arguments \u003d {"},{"line_number":211,"context_line":"                    \u0027socket_timeout\u0027: arguments.get(\u0027socket_timeout\u0027, 3.0),"},{"line_number":212,"context_line":"        }"},{"line_number":213,"context_line":"        # NOTE(morganfainberg): The host objects expect an int for the"},{"line_number":214,"context_line":"        # deaduntil value. Initialize this at 0 for each host with 0 indicating"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_6c97553c","line":211,"updated":"2020-07-21 09:54:09.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"c552389fa11e787e5831220459b0a069078fcc31"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"522aec5934f62c706472fbeedb9c4ef14a0c5e62","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self._username \u003d arguments.pop(\u0027usrname\u0027)"},{"line_number":209,"context_line":"        self._password \u003d arguments.pop(\u0027password\u0027)"},{"line_number":210,"context_line":"        self._arguments \u003d {"},{"line_number":211,"context_line":"          \u0027socket_timeout\u0027: arguments.get(\u0027socket_timeout\u0027, 3.0),"},{"line_number":212,"context_line":"        }"},{"line_number":213,"context_line":"        # NOTE(morganfainberg): The host objects expect an int for the"},{"line_number":214,"context_line":"        # deaduntil value. Initialize this at 0 for each host with 0 indicating"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_95af482a","line":211,"updated":"2020-07-21 13:11:16.000000000","message":"pep8: E121 continuation line under-indented for hanging indent","commit_id":"d8f19d0bc06f86a4407d02f776d9a5831a495271"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"cb686c43939772cc7f6463c474f9cac8e7b5bee3","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self._username \u003d arguments.pop(\u0027usrname\u0027)"},{"line_number":209,"context_line":"        self._password \u003d arguments.pop(\u0027password\u0027)"},{"line_number":210,"context_line":"        self._arguments \u003d {"},{"line_number":211,"context_line":"          \u0027socket_timeout\u0027: arguments.get(\u0027socket_timeout\u0027, 3.0),"},{"line_number":212,"context_line":"        }"},{"line_number":213,"context_line":"        # NOTE(morganfainberg): The host objects expect an int for the"},{"line_number":214,"context_line":"        # deaduntil value. Initialize this at 0 for each host with 0 indicating"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_dba9f124","line":211,"updated":"2020-07-21 14:48:37.000000000","message":"pep8: E121 continuation line under-indented for hanging indent","commit_id":"a183e4d6765221a15dcafc1efb38b682bc3a8287"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e517de8eea346262f47f09037c0cbdf4857b9392","unresolved":false,"context_lines":[{"line_number":36,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class _BMemcacheClient(bmemcached.Client):"},{"line_number":40,"context_line":"    \"\"\"Thread global memcache client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    As client is inherited from threading.local we have to restore object"},{"line_number":43,"context_line":"    methods overloaded by threading.local so we can reuse clients in"},{"line_number":44,"context_line":"    different threads"},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    __delattr__ \u003d object.__delattr__"},{"line_number":47,"context_line":"    __getattribute__ \u003d object.__getattribute__"},{"line_number":48,"context_line":"    __setattr__ \u003d object.__setattr__"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Hack for lp 1812935"},{"line_number":51,"context_line":"    if eventlet and eventlet.patcher.is_monkey_patched(\u0027thread\u0027):"},{"line_number":52,"context_line":"        # NOTE(bnemec): I\u0027m not entirely sure why this works in a"},{"line_number":53,"context_line":"        # monkey-patched environment and not with vanilla stdlib, but it does."},{"line_number":54,"context_line":"        def __new__(cls, *args, **kwargs):"},{"line_number":55,"context_line":"            return object.__new__(cls)"},{"line_number":56,"context_line":"    else:"},{"line_number":57,"context_line":"        __new__ \u003d object.__new__"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __del__(self):"},{"line_number":60,"context_line":"        pass"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"_PoolItem \u003d collections.namedtuple(\u0027_PoolItem\u0027, [\u0027ttl\u0027, \u0027connection\u0027])"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"class BConnectionPool(queue.Queue):"},{"line_number":67,"context_line":"    \"\"\"Base connection pool class"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    This class implements the basic connection pool logic as an abstract base"},{"line_number":70,"context_line":"    class."},{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, maxsize, unused_timeout, conn_get_timeout\u003dNone):"},{"line_number":74,"context_line":"        \"\"\"Initialize the connection pool."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        :param maxsize: maximum number of client connections for the pool"},{"line_number":77,"context_line":"        :type maxsize: int"},{"line_number":78,"context_line":"        :param unused_timeout: idle time to live for unused clients (in"},{"line_number":79,"context_line":"                               seconds). If a client connection object has been"},{"line_number":80,"context_line":"                               in the pool and idle for longer than the"},{"line_number":81,"context_line":"                               unused_timeout, it will be reaped. This is to"},{"line_number":82,"context_line":"                               ensure resources are released as utilization"},{"line_number":83,"context_line":"                               goes down."},{"line_number":84,"context_line":"        :type unused_timeout: int"},{"line_number":85,"context_line":"        :param conn_get_timeout: maximum time in seconds to wait for a"},{"line_number":86,"context_line":"                                 connection. If set to `None` timeout is"},{"line_number":87,"context_line":"                                 indefinite."},{"line_number":88,"context_line":"        :type conn_get_timeout: int"},{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        # super() cannot be used here because Queue in stdlib is an"},{"line_number":91,"context_line":"        # old-style class"},{"line_number":92,"context_line":"        queue.Queue.__init__(self, maxsize)"},{"line_number":93,"context_line":"        self._unused_timeout \u003d unused_timeout"},{"line_number":94,"context_line":"        self._connection_get_timeout \u003d conn_get_timeout"},{"line_number":95,"context_line":"        self._acquired \u003d 0"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _create_connection(self):"},{"line_number":98,"context_line":"        \"\"\"Returns a connection instance."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        This is called when the pool needs another instance created."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        :returns: a new connection instance"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        raise NotImplementedError"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _destroy_connection(self, conn):"},{"line_number":108,"context_line":"        \"\"\"Destroy and cleanup a connection instance."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        This is called when the pool wishes to get rid of an existing"},{"line_number":111,"context_line":"        connection. This is the opportunity for a subclass to free up"},{"line_number":112,"context_line":"        resources and cleanup after itself."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :param conn: the connection object to destroy"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        \"\"\""},{"line_number":117,"context_line":"        raise NotImplementedError"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def _do_log(self, level, msg, *args, **kwargs):"},{"line_number":120,"context_line":"        if LOG.isEnabledFor(level):"},{"line_number":121,"context_line":"            thread_id \u003d threading.current_thread().ident"},{"line_number":122,"context_line":"            args \u003d (id(self), thread_id) + args"},{"line_number":123,"context_line":"            prefix \u003d \u0027Memcached pool %s, thread %s: \u0027"},{"line_number":124,"context_line":"            LOG.log(level, prefix + msg, *args, **kwargs)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def _debug_logger(self, msg, *args, **kwargs):"},{"line_number":127,"context_line":"        self._do_log(log.DEBUG, msg, *args, **kwargs)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _trace_logger(self, msg, *args, **kwargs):"},{"line_number":130,"context_line":"        self._do_log(log.TRACE, msg, *args, **kwargs)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @contextlib.contextmanager"},{"line_number":133,"context_line":"    def acquire(self):"},{"line_number":134,"context_line":"        self._trace_logger(\u0027Acquiring connection\u0027)"},{"line_number":135,"context_line":"        self._drop_expired_connections()"},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            conn \u003d self.get(timeout\u003dself._connection_get_timeout)"},{"line_number":138,"context_line":"        except queue.Empty:"},{"line_number":139,"context_line":"            raise exception.QueueEmpty("},{"line_number":140,"context_line":"                _(\u0027Unable to get a connection from pool id %(id)s after \u0027"},{"line_number":141,"context_line":"                  \u0027%(seconds)s seconds.\u0027) %"},{"line_number":142,"context_line":"                {\u0027id\u0027: id(self), \u0027seconds\u0027: self._connection_get_timeout})"},{"line_number":143,"context_line":"        self._trace_logger(\u0027Acquired connection %s\u0027, id(conn))"},{"line_number":144,"context_line":"        try:"},{"line_number":145,"context_line":"            yield conn"},{"line_number":146,"context_line":"        finally:"},{"line_number":147,"context_line":"            self._trace_logger(\u0027Releasing connection %s\u0027, id(conn))"},{"line_number":148,"context_line":"            try:"},{"line_number":149,"context_line":"                # super() cannot be used here because Queue in stdlib is an"},{"line_number":150,"context_line":"                # old-style class"},{"line_number":151,"context_line":"                queue.Queue.put(self, conn, block\u003dFalse)"},{"line_number":152,"context_line":"            except queue.Full:"},{"line_number":153,"context_line":"                self._trace_logger(\u0027Reaping exceeding connection %s\u0027, id(conn))"},{"line_number":154,"context_line":"                self._destroy_connection(conn)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _qsize(self):"},{"line_number":157,"context_line":"        if self.maxsize:"},{"line_number":158,"context_line":"            return self.maxsize - self._acquired"},{"line_number":159,"context_line":"        else:"},{"line_number":160,"context_line":"            # A value indicating there is always a free connection"},{"line_number":161,"context_line":"            # if maxsize is None or 0"},{"line_number":162,"context_line":"            return 1"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # NOTE(dstanek): stdlib and eventlet Queue implementations"},{"line_number":165,"context_line":"    # have different names for the qsize method. This ensures"},{"line_number":166,"context_line":"    # that we override both of them."},{"line_number":167,"context_line":"    if not hasattr(queue.Queue, \u0027_qsize\u0027):"},{"line_number":168,"context_line":"        qsize \u003d _qsize"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def _get(self):"},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            conn \u003d self.queue.pop().connection"},{"line_number":173,"context_line":"        except IndexError:"},{"line_number":174,"context_line":"            conn \u003d self._create_connection()"},{"line_number":175,"context_line":"        self._acquired +\u003d 1"},{"line_number":176,"context_line":"        return conn"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def _drop_expired_connections(self):"},{"line_number":179,"context_line":"        \"\"\"Drop all expired connections from the left end of the queue.\"\"\""},{"line_number":180,"context_line":"        now \u003d time.time()"},{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            while self.queue[0].ttl \u003c now:"},{"line_number":183,"context_line":"                conn \u003d self.queue.popleft().connection"},{"line_number":184,"context_line":"                self._trace_logger(\u0027Reaping connection %s\u0027, id(conn))"},{"line_number":185,"context_line":"                self._destroy_connection(conn)"},{"line_number":186,"context_line":"        except IndexError:"},{"line_number":187,"context_line":"            # NOTE(amakarov): This is an expected excepton. so there\u0027s no"},{"line_number":188,"context_line":"            # need to react. We have to handle exceptions instead of"},{"line_number":189,"context_line":"            # checking queue length as IndexError is a result of race"},{"line_number":190,"context_line":"            # condition too as well as of mere queue depletio of mere queue"},{"line_number":191,"context_line":"            # depletionn."},{"line_number":192,"context_line":"            pass"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def _put(self, conn):"},{"line_number":195,"context_line":"        self.queue.append(_PoolItem("},{"line_number":196,"context_line":"            ttl\u003dtime.time() + self._unused_timeout,"},{"line_number":197,"context_line":"            connection\u003dconn,"},{"line_number":198,"context_line":"        ))"},{"line_number":199,"context_line":"        self._acquired -\u003d 1"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"class BMemcacheClientPool(BConnectionPool):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_8c2ac9e4","line":199,"range":{"start_line":39,"start_character":0,"end_line":199,"end_character":27},"updated":"2020-07-27 09:01:15.000000000","message":"The major part of this source code is copy/pasted from _memcache_pool, so to avoid technical debt can\u0027t we mutualize common parts instead of duplicate these classes?","commit_id":"d4fec9c6bab72b5a9f6f113654ea860dff446a0d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e517de8eea346262f47f09037c0cbdf4857b9392","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        self._acquired -\u003d 1"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"class BMemcacheClientPool(BConnectionPool):"},{"line_number":203,"context_line":"    def __init__(self, urls, arguments, **kwargs):"},{"line_number":204,"context_line":"        # super() cannot be used here because Queue in stdlib is an"},{"line_number":205,"context_line":"        # old-style class"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_6ccbf51d","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":43},"updated":"2020-07-27 09:01:15.000000000","message":"It could be interesting to define a common base class and inherite this class here and also in `MemcacheClientPool`. This will allow us to declare `_get` and `_put` in this base class and avoid to duplicate them. I think `_get` and `_put` are identical on the both classes, thoughts?","commit_id":"d4fec9c6bab72b5a9f6f113654ea860dff446a0d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"4048e9489c2dd8e36765f4ea3daca303e4f045e2","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        # does not need the explicit flush_on_reconnect"},{"line_number":94,"context_line":"        return _BMemcacheClient(self.urls, self._username, self._password,"},{"line_number":95,"context_line":"                                **self._arguments)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _destroy_connection(self, conn):"},{"line_number":98,"context_line":"        conn.disconnect_all()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _get(self):"},{"line_number":101,"context_line":"        # super() cannot be used here because Queue in stdlib is an"},{"line_number":102,"context_line":"        # old-style class"},{"line_number":103,"context_line":"        conn \u003d ConnectionPool._get(self)"},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            # Propagate host state known to us to this client\u0027s list"},{"line_number":106,"context_line":"            now \u003d time.time()"},{"line_number":107,"context_line":"            for deaduntil, host in zip(self._hosts_deaduntil, conn.servers):"},{"line_number":108,"context_line":"                if deaduntil \u003e now and host.deaduntil \u003c\u003d now:"},{"line_number":109,"context_line":"                    host.mark_dead(\u0027propagating death mark from the pool\u0027)"},{"line_number":110,"context_line":"                host.deaduntil \u003d deaduntil"},{"line_number":111,"context_line":"        except Exception:"},{"line_number":112,"context_line":"            # We need to be sure that connection doesn\u0027t leak from the pool."},{"line_number":113,"context_line":"            # This code runs before we enter context manager\u0027s try-finally"},{"line_number":114,"context_line":"            # block, so we need to explicitly release it here."},{"line_number":115,"context_line":"            # super() cannot be used here because Queue in stdlib is an"},{"line_number":116,"context_line":"            # old-style class"},{"line_number":117,"context_line":"            ConnectionPool._put(self, conn)"},{"line_number":118,"context_line":"            raise"},{"line_number":119,"context_line":"        return conn"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _put(self, conn):"},{"line_number":122,"context_line":"        try:"},{"line_number":123,"context_line":"            # If this client found that one of the hosts is dead, mark it as"},{"line_number":124,"context_line":"            # such in our internal list"},{"line_number":125,"context_line":"            now \u003d time.time()"},{"line_number":126,"context_line":"            for i, host in zip(itertools.count(), conn.servers):"},{"line_number":127,"context_line":"                deaduntil \u003d self._hosts_deaduntil[i]"},{"line_number":128,"context_line":"                # Do nothing if we already know this host is dead"},{"line_number":129,"context_line":"                if deaduntil \u003c\u003d now:"},{"line_number":130,"context_line":"                    if host.deaduntil \u003e now:"},{"line_number":131,"context_line":"                        self._hosts_deaduntil[i] \u003d host.deaduntil"},{"line_number":132,"context_line":"                        self._debug_logger("},{"line_number":133,"context_line":"                            \u0027Marked host %s dead until %s\u0027,"},{"line_number":134,"context_line":"                            self.urls[i], host.deaduntil)"},{"line_number":135,"context_line":"                    else:"},{"line_number":136,"context_line":"                        self._hosts_deaduntil[i] \u003d 0"},{"line_number":137,"context_line":"            # If all hosts are dead we should forget that they\u0027re dead. This"},{"line_number":138,"context_line":"            # way we won\u0027t get completely shut off until dead_retry seconds"},{"line_number":139,"context_line":"            # pass, but will be checking servers as frequent as we can (over"},{"line_number":140,"context_line":"            # way smaller socket_timeout)"},{"line_number":141,"context_line":"            if all(deaduntil \u003e now for deaduntil in self._hosts_deaduntil):"},{"line_number":142,"context_line":"                self._debug_logger(\u0027All hosts are dead. Marking them as live.\u0027)"},{"line_number":143,"context_line":"                self._hosts_deaduntil[:] \u003d [0] * len(self._hosts_deaduntil)"},{"line_number":144,"context_line":"        finally:"},{"line_number":145,"context_line":"            # super() cannot be used here because Queue in stdlib is an"},{"line_number":146,"context_line":"            # old-style class"},{"line_number":147,"context_line":"            ConnectionPool._put(self, conn)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_67ff3934","line":147,"range":{"start_line":96,"start_character":0,"end_line":147,"end_character":43},"updated":"2020-07-31 09:10:17.000000000","message":"As said in my previous comments, can we declare a parent class that will be common to `BMemcacheClientPool` and `MemcacheClientPool` [1] to avoid to redefine these methods twice?\n\nThey could be centralized and inherited as they are similar in the both class.\n\nIf I\u0027m right only `__init__` and `_create_connection` are different.\n\n[1] https://opendev.org/openstack/oslo.cache/src/branch/master/oslo_cache/_memcache_pool.py#L201","commit_id":"38b96f65d1342b8b7079fdff7973bccf56d489b3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"265c47e8088935c787c357ce0ccb6eef529318c3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Thread-safe connection pool for python-binary-memcached.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import itertools"},{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_c7e0b8cf","line":18,"updated":"2020-07-31 15:46:50.000000000","message":"pep8: F401 \u0027itertools\u0027 imported but unused","commit_id":"3782223fde7ac801aa9f95104a4d0b2e547a980f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"265c47e8088935c787c357ce0ccb6eef529318c3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"Thread-safe connection pool for python-binary-memcached.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import itertools"},{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    import eventlet"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_27e894b2","line":19,"updated":"2020-07-31 15:46:50.000000000","message":"pep8: F401 \u0027time\u0027 imported but unused","commit_id":"3782223fde7ac801aa9f95104a4d0b2e547a980f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"265c47e8088935c787c357ce0ccb6eef529318c3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    eventlet \u003d None"},{"line_number":25,"context_line":"import bmemcached"},{"line_number":26,"context_line":"from oslo_log import log"},{"line_number":27,"context_line":"from six.moves import zip"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from oslo_cache._memcache_pool import MemcacheClientPool"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_07ebd0af","line":27,"updated":"2020-07-31 15:46:50.000000000","message":"pep8: F401 \u0027six.moves.zip\u0027 imported but unused","commit_id":"3782223fde7ac801aa9f95104a4d0b2e547a980f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class BMemcacheClientPool(MemcacheClientPool):"},{"line_number":53,"context_line":"    def __init__(self, urls, arguments, **kwargs):"},{"line_number":54,"context_line":"        # super() cannot be used here because Queue in stdlib is an"},{"line_number":55,"context_line":"        # old-style class"},{"line_number":56,"context_line":"        MemcacheClientPool.__init__(self, urls, arguments, **kwargs)"},{"line_number":57,"context_line":"        self.username \u003d arguments.get(\u0027username\u0027, None)"},{"line_number":58,"context_line":"        self.password \u003d arguments.get(\u0027password\u0027, None)"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_26749afd","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":25},"updated":"2020-08-27 09:30:58.000000000","message":"That\u0027s no longer true since oslo.cache is Python 3 and there are no old-style classes in Python 3","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"6a2f96dc5e8ae0c641f4ae379288d7fb4f622b44","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class BMemcacheClientPool(MemcacheClientPool):"},{"line_number":53,"context_line":"    def __init__(self, urls, arguments, **kwargs):"},{"line_number":54,"context_line":"        # super() cannot be used here because Queue in stdlib is an"},{"line_number":55,"context_line":"        # old-style class"},{"line_number":56,"context_line":"        MemcacheClientPool.__init__(self, urls, arguments, **kwargs)"},{"line_number":57,"context_line":"        self.username \u003d arguments.get(\u0027username\u0027, None)"},{"line_number":58,"context_line":"        self.password \u003d arguments.get(\u0027password\u0027, None)"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_a3d358d5","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":25},"in_reply_to":"9f560f44_26749afd","updated":"2020-08-29 03:36:33.000000000","message":"Hi，Stephen, this is referred by class MemcacheClientPool in _memcache_pool.py, and be consistent with the format。 At the same time, I think we should be compatible with python 2.7","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"f5b5bcce739ba4244660c26417c731bd81ad2a8b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Mirantis Inc"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":31,"id":"64cb0012_e35a75cf","line":1,"updated":"2022-04-27 13:45:25.000000000","message":"Please can you update the copyright here.","commit_id":"002c3fa5d67b5bc2551936627d7a8bc706a1c257"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"f1672eea837f4f8493d5b0030f315cd1df519d52","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Mirantis Inc"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":31,"id":"05bc7027_6e26d1a1","line":1,"in_reply_to":"64cb0012_e35a75cf","updated":"2022-04-28 10:53:01.000000000","message":"Done","commit_id":"002c3fa5d67b5bc2551936627d7a8bc706a1c257"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0b6617119e1ecbfd589e7684cbde10b9be2883e7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Mirantis Inc"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":33,"id":"bbf2a6fa_23b0324b","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":29},"updated":"2022-04-29 08:34:25.000000000","message":"Outdated again (Daniel\u0027s previous comment).","commit_id":"c19e25d1b3c8c301c24dbb2a0220f1fd22c0e152"}],"oslo_cache/_opts.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"49f49210e033c0f82abdbaa18f54e656dde1d9e2","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                   \u0027 ciphers will be available.\u0027),"},{"line_number":143,"context_line":"        cfg.BoolOpt(\u0027memcache_sasl_enable\u0027,"},{"line_number":144,"context_line":"                    default\u003dFalse,"},{"line_number":145,"context_line":"                    help\u003d\u0027Enable the SASL(Simple Authentication and Security Layer) \u0027"},{"line_number":146,"context_line":"                         \u0027if the SALA_enable is true, else disable.\u0027),"},{"line_number":147,"context_line":"        cfg.StrOpt(\u0027memcache_usrname\u0027,"},{"line_number":148,"context_line":"                   default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_e5e9bdb7","line":145,"updated":"2020-07-21 04:42:25.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"086de293740152b5d1cf30005851905fb8fcfc5a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dc36150ac280aba66188d738831f041a515f0ede","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                   \u0027 ciphers will be available.\u0027),"},{"line_number":143,"context_line":"        cfg.BoolOpt(\u0027memcache_sasl_enable\u0027,"},{"line_number":144,"context_line":"                    default\u003dFalse,"},{"line_number":145,"context_line":"                    help\u003d\u0027Enable the SASL(Simple Authentication and Security Layer) \u0027"},{"line_number":146,"context_line":"                         \u0027if the SALA_enable is true, else disable.\u0027),"},{"line_number":147,"context_line":"        cfg.StrOpt(\u0027memcache_usrname\u0027,"},{"line_number":148,"context_line":"                   default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_4c9c115d","line":145,"updated":"2020-07-21 09:54:09.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"c552389fa11e787e5831220459b0a069078fcc31"},{"author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"change_message_id":"84ecb19965a572f8693704f015b778f97d75e0ed","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    default\u003dFalse,"},{"line_number":145,"context_line":"                    help\u003d\u0027Enable the SASL(Simple Authentication and Security\u0027"},{"line_number":146,"context_line":"                    \u0027Layer) if the SASL_enable is true, else disable.\u0027),"},{"line_number":147,"context_line":"        cfg.StrOpt(\u0027memcache_usrname\u0027,"},{"line_number":148,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":149,"context_line":"                   help\u003d\u0027the user name for the memcached which SASL enabled\u0027),"},{"line_number":150,"context_line":"        cfg.StrOpt(\u0027memcache_password\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"9f560f44_a9033f73","line":147,"range":{"start_line":147,"start_character":20,"end_line":147,"end_character":36},"updated":"2020-08-12 11:47:28.000000000","message":"\u0027usrname\u0027 is this a typo?\n\nwhat about:\n\nsasl_enabled\nsasl_username\nsasl_password\n\njust like TLS like options, it doesn\u0027t have to be tied to memcached.","commit_id":"48e74220e7b86b48609494525b3fe7eaf05e9eb1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        # prevent issues with the memory cache ending up in \"production\""},{"line_number":35,"context_line":"        # unintentionally, we register a no-op as the default caching backend."},{"line_number":36,"context_line":"        cfg.StrOpt(\u0027backend\u0027, default\u003d_DEFAULT_BACKEND,"},{"line_number":37,"context_line":"                   choices\u003d[\u0027oslo_cache.memcache_pool\u0027,"},{"line_number":38,"context_line":"                            \u0027oslo_cache.dict\u0027,"},{"line_number":39,"context_line":"                            \u0027oslo_cache.mongo\u0027,"},{"line_number":40,"context_line":"                            \u0027oslo_cache.etcd3gw\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_8646467a","line":37,"updated":"2020-08-27 09:30:58.000000000","message":"Would it make sense to expose a new \u0027bmemcache_pool\u0027 backend, rather than magically enabling the binary protocol when SASL is enabled?","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                    \u0027Layer) if the SASL_enable is true, else disable.\u0027),"},{"line_number":147,"context_line":"        cfg.StrOpt(\u0027memcache_username\u0027,"},{"line_number":148,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":149,"context_line":"                   help\u003d\u0027the user name for the memcached which SASL enabled\u0027),"},{"line_number":150,"context_line":"        cfg.StrOpt(\u0027memcache_password\u0027,"},{"line_number":151,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":152,"context_line":"                   help\u003d\u0027the password for the memcached which SASL enabled\u0027),"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_064196a6","line":149,"range":{"start_line":149,"start_character":25,"end_line":149,"end_character":26},"updated":"2020-08-27 09:30:58.000000000","message":"T","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                   \u0027 the TLS context. It should be a string in the OpenSSL\u0027"},{"line_number":141,"context_line":"                   \u0027 cipher list format. If not specified, all OpenSSL enabled\u0027"},{"line_number":142,"context_line":"                   \u0027 ciphers will be available.\u0027),"},{"line_number":143,"context_line":"        cfg.BoolOpt(\u0027memcache_sasl_enabled\u0027,"},{"line_number":144,"context_line":"                    default\u003dFalse,"},{"line_number":145,"context_line":"                    help\u003d\u0027Enable the SASL(Simple Authentication and Security\u0027"},{"line_number":146,"context_line":"                    \u0027Layer) if the SASL_enable is true, else disable.\u0027),"},{"line_number":147,"context_line":"        cfg.StrOpt(\u0027memcache_username\u0027,"},{"line_number":148,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":149,"context_line":"                   help\u003d\u0027the user name for the memcached which SASL enabled\u0027),"},{"line_number":150,"context_line":"        cfg.StrOpt(\u0027memcache_password\u0027,"},{"line_number":151,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":152,"context_line":"                   help\u003d\u0027the password for the memcached which SASL enabled\u0027),"},{"line_number":153,"context_line":"    ],"},{"line_number":154,"context_line":"}"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_4618aed1","line":152,"range":{"start_line":143,"start_character":0,"end_line":152,"end_character":77},"updated":"2020-08-27 09:30:58.000000000","message":"I\u0027d prefer if these were grouped with the other memcache options above (ending on line 112)","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                   help\u003d\u0027the user name for the memcached which SASL enabled\u0027),"},{"line_number":150,"context_line":"        cfg.StrOpt(\u0027memcache_password\u0027,"},{"line_number":151,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":152,"context_line":"                   help\u003d\u0027the password for the memcached which SASL enabled\u0027),"},{"line_number":153,"context_line":"    ],"},{"line_number":154,"context_line":"}"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_6615f29b","line":152,"range":{"start_line":152,"start_character":25,"end_line":152,"end_character":26},"updated":"2020-08-27 09:30:58.000000000","message":"T","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"27ed71801c5ea6d147dd30e771871f237a2716c6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                   \u0027 the TLS context. It should be a string in the OpenSSL\u0027"},{"line_number":141,"context_line":"                   \u0027 cipher list format. If not specified, all OpenSSL enabled\u0027"},{"line_number":142,"context_line":"                   \u0027 ciphers will be available.\u0027),"},{"line_number":143,"context_line":"        cfg.BoolOpt(\u0027memcache_sasl_enabled\u0027,"},{"line_number":144,"context_line":"                    default\u003dFalse,"},{"line_number":145,"context_line":"                    help\u003d\u0027Enable the SASL(Simple Authentication and Security\u0027"},{"line_number":146,"context_line":"                    \u0027Layer) if the SASL_enable is true, else disable.\u0027),"},{"line_number":147,"context_line":"        cfg.StrOpt(\u0027memcache_username\u0027,"},{"line_number":148,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":149,"context_line":"                   help\u003d\u0027the user name for the memcached which SASL enabled\u0027),"},{"line_number":150,"context_line":"        cfg.StrOpt(\u0027memcache_password\u0027,"},{"line_number":151,"context_line":"                   default\u003d\u0027\u0027,"},{"line_number":152,"context_line":"                   help\u003d\u0027the password for the memcached which SASL enabled\u0027),"},{"line_number":153,"context_line":"    ],"},{"line_number":154,"context_line":"}"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_418cef7e","line":152,"range":{"start_line":143,"start_character":0,"end_line":152,"end_character":77},"in_reply_to":"9f560f44_4618aed1","updated":"2020-08-30 13:07:10.000000000","message":"In Patch set 22, we discuss the parameters\u0027 name. Reusing the current code to simply the code flow, I add the prefix \"memcache_\" in core.py. I also think it\u0027s better to place these parameter here with tls parameter to different the memcache_pool parameter, because it\u0027s protocol parameter.","commit_id":"0961cce68703ae13852005221614f6d321160964"}],"oslo_cache/backends/memcache_pool.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"49f49210e033c0f82abdbaa18f54e656dde1d9e2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from dogpile.cache.backends import memcached as memcached_backend"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_cache import _memcache_pool"},{"line_number":23,"context_line":"from oslo_cache import _bmemcache_pool"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Helper to ease backend refactoring"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_45cea95b","line":23,"updated":"2020-07-21 04:42:25.000000000","message":"pep8: H306: imports not in alphabetical order (oslo_cache._memcache_pool, oslo_cache._bmemcache_pool)","commit_id":"086de293740152b5d1cf30005851905fb8fcfc5a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"49f49210e033c0f82abdbaa18f54e656dde1d9e2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                arguments,"},{"line_number":49,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":50,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":51,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027, 10),"},{"line_number":52,"context_line":"            )"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            self.client_pool \u003d _memcache_pool.MemcacheClientPool("}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_25cbb54a","line":51,"updated":"2020-07-21 04:42:25.000000000","message":"pep8: E501 line too long (82 \u003e 79 characters)","commit_id":"086de293740152b5d1cf30005851905fb8fcfc5a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"49f49210e033c0f82abdbaa18f54e656dde1d9e2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                },"},{"line_number":62,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":63,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":64,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027, 10),"},{"line_number":65,"context_line":"            )"},{"line_number":66,"context_line":"    # Since all methods in backend just call one of methods of client, this"},{"line_number":67,"context_line":"    # lets us avoid need to hack it too much"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_85d8c11e","line":64,"updated":"2020-07-21 04:42:25.000000000","message":"pep8: E501 line too long (82 \u003e 79 characters)","commit_id":"086de293740152b5d1cf30005851905fb8fcfc5a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dc36150ac280aba66188d738831f041a515f0ede","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from dogpile.cache.backends import memcached as memcached_backend"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_cache import _memcache_pool"},{"line_number":23,"context_line":"from oslo_cache import _bmemcache_pool"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Helper to ease backend refactoring"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_aca04d93","line":23,"updated":"2020-07-21 09:54:09.000000000","message":"pep8: H306: imports not in alphabetical order (oslo_cache._memcache_pool, oslo_cache._bmemcache_pool)","commit_id":"c552389fa11e787e5831220459b0a069078fcc31"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dc36150ac280aba66188d738831f041a515f0ede","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                arguments,"},{"line_number":49,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":50,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":51,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027, 10),"},{"line_number":52,"context_line":"            )"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            self.client_pool \u003d _memcache_pool.MemcacheClientPool("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_8c9d8959","line":51,"updated":"2020-07-21 09:54:09.000000000","message":"pep8: E501 line too long (82 \u003e 79 characters)","commit_id":"c552389fa11e787e5831220459b0a069078fcc31"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dc36150ac280aba66188d738831f041a515f0ede","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                },"},{"line_number":62,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":63,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":64,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027, 10),"},{"line_number":65,"context_line":"            )"},{"line_number":66,"context_line":"    # Since all methods in backend just call one of methods of client, this"},{"line_number":67,"context_line":"    # lets us avoid need to hack it too much"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_ecaa456f","line":64,"updated":"2020-07-21 09:54:09.000000000","message":"pep8: E501 line too long (82 \u003e 79 characters)","commit_id":"c552389fa11e787e5831220459b0a069078fcc31"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"522aec5934f62c706472fbeedb9c4ef14a0c5e62","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from dogpile.cache.backends import memcached as memcached_backend"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_cache import _memcache_pool"},{"line_number":23,"context_line":"from oslo_cache import _bmemcache_pool"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Helper to ease backend refactoring"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_75ac3435","line":23,"updated":"2020-07-21 13:11:16.000000000","message":"pep8: H306: imports not in alphabetical order (oslo_cache._memcache_pool, oslo_cache._bmemcache_pool)","commit_id":"d8f19d0bc06f86a4407d02f776d9a5831a495271"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"265c47e8088935c787c357ce0ccb6eef529318c3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            )"},{"line_number":68,"context_line":"    # Since all methods in backend just call one of methods of client, this"},{"line_number":69,"context_line":"    # lets us avoid need to hack it too much"},{"line_number":70,"context_line":"    @property"},{"line_number":71,"context_line":"    def client(self):"},{"line_number":72,"context_line":"        return ClientProxy(self.client_pool)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_e7ddfc14","line":70,"updated":"2020-07-31 15:46:50.000000000","message":"pep8: E301 expected 1 blank line, found 0","commit_id":"3782223fde7ac801aa9f95104a4d0b2e547a980f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def __init__(self, arguments):"},{"line_number":44,"context_line":"        super(PooledMemcachedBackend, self).__init__(arguments)"},{"line_number":45,"context_line":"        if arguments.get(\u0027sasl_enabled\u0027, False):"},{"line_number":46,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":47,"context_line":"                self.url,"},{"line_number":48,"context_line":"                arguments,"},{"line_number":49,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_664df298","line":46,"updated":"2020-08-27 09:30:58.000000000","message":"Is there any reason we wouldn\u0027t want to use the binary memcache protocol even without SASL? It\u0027s more efficient, right?","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"6a2f96dc5e8ae0c641f4ae379288d7fb4f622b44","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def __init__(self, arguments):"},{"line_number":44,"context_line":"        super(PooledMemcachedBackend, self).__init__(arguments)"},{"line_number":45,"context_line":"        if arguments.get(\u0027sasl_enabled\u0027, False):"},{"line_number":46,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":47,"context_line":"                self.url,"},{"line_number":48,"context_line":"                arguments,"},{"line_number":49,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_c3e76cac","line":46,"in_reply_to":"9f560f44_664df298","updated":"2020-08-29 03:36:33.000000000","message":"yeah, it\u0027s more efficient if we only encry the content memcached in that.","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if arguments.get(\u0027sasl_enabled\u0027, False):"},{"line_number":46,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":47,"context_line":"                self.url,"},{"line_number":48,"context_line":"                arguments,"},{"line_number":49,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":50,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":51,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_064876b0","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":25},"updated":"2020-08-27 09:30:58.000000000","message":"Why is it okay to pass arguments unchanged for \u0027BMemcacheClientPool\u0027 but not for \u0027MemcacheClientPool\u0027, when \u0027BMemcacheClientPool\u0027 inherits from \u0027MemcacheClientPool\u0027?","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"6a2f96dc5e8ae0c641f4ae379288d7fb4f622b44","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if arguments.get(\u0027sasl_enabled\u0027, False):"},{"line_number":46,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":47,"context_line":"                self.url,"},{"line_number":48,"context_line":"                arguments,"},{"line_number":49,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":50,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":51,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_63330015","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":25},"in_reply_to":"9f560f44_064876b0","updated":"2020-08-29 03:36:33.000000000","message":"Hi, Stephen, thanks for observant review. I just pass the arguments to MemcacheClientPoll, but the arguments is not used in this class, because the arguments used by \"self._arguments \u003d arguments\"  in  class MemcacheClientPool, and I set the property self._arguments in class BMemcacheClientPool again. So, this just unuseful in MemcacheClientPoll.","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"058b81a7a979297424982e84eb91df0599abcd59","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if arguments.get(\u0027sasl_enabled\u0027, False):"},{"line_number":46,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":47,"context_line":"                self.url,"},{"line_number":48,"context_line":"                arguments,"},{"line_number":49,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":50,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":51,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"1d2e8c4f_c9cad1c7","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":25},"in_reply_to":"9f560f44_63330015","updated":"2022-01-29 06:01:50.000000000","message":"hello，stephen, because we call overwrite the argument in the BMemcacheClientPool class， So this is ok to pass the argument parameter, and will get the parameter from the argument in the BMemcacheClientPool class","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                arguments,"},{"line_number":49,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":50,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":51,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027,"},{"line_number":52,"context_line":"                                               10),"},{"line_number":53,"context_line":"            )"},{"line_number":54,"context_line":"        else:"},{"line_number":55,"context_line":"            self.client_pool \u003d _memcache_pool.MemcacheClientPool("}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_a60b8a7a","line":52,"range":{"start_line":51,"start_character":16,"end_line":52,"end_character":51},"updated":"2020-08-27 09:30:58.000000000","message":"nit:\n\n  conn_get_timeout\u003darguments.get(\n      \u0027pool_connection_get_timeout\u0027, 10),","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"6a2f96dc5e8ae0c641f4ae379288d7fb4f622b44","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                arguments,"},{"line_number":49,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":50,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":51,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027,"},{"line_number":52,"context_line":"                                               10),"},{"line_number":53,"context_line":"            )"},{"line_number":54,"context_line":"        else:"},{"line_number":55,"context_line":"            self.client_pool \u003d _memcache_pool.MemcacheClientPool("}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_1ec4175f","line":52,"range":{"start_line":51,"start_character":16,"end_line":52,"end_character":51},"in_reply_to":"9f560f44_a60b8a7a","updated":"2020-08-29 03:36:33.000000000","message":"this is just to keep the same with the original code, and we can discuss that if needed by another commit.","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                    \u0027dead_retry\u0027: arguments.get(\u0027dead_retry\u0027, 5 * 60),"},{"line_number":59,"context_line":"                    \u0027socket_timeout\u0027: arguments.get(\u0027socket_timeout\u0027, 3.0),"},{"line_number":60,"context_line":"                    \u0027server_max_value_length\u0027:"},{"line_number":61,"context_line":"                    arguments.get(\u0027server_max_value_length\u0027),"},{"line_number":62,"context_line":"                },"},{"line_number":63,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":64,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_261f7ab7","line":61,"updated":"2020-08-27 09:30:58.000000000","message":"ditto","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":64,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":65,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027,"},{"line_number":66,"context_line":"                                               10),"},{"line_number":67,"context_line":"            )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # Since all methods in backend just call one of methods of client, this"}],"source_content_type":"text/x-python","patch_set":26,"id":"9f560f44_860e4689","line":66,"updated":"2020-08-27 09:30:58.000000000","message":"ditto","commit_id":"0961cce68703ae13852005221614f6d321160964"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e2aac934fe840c537d09dc7c923a190b382105f","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        if arguments.get(\u0027sasl_enabled\u0027, False):"},{"line_number":60,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":61,"context_line":"                self.url,"},{"line_number":62,"context_line":"                arguments,"},{"line_number":63,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":64,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":65,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":31,"id":"6f5de93b_6892571c","line":62,"updated":"2022-01-28 11:01:17.000000000","message":"Why are you able to pass through \u0027arguments\u0027 unmodified here, but not below? BMemcacheClientPool is a subclass of MemcacheClientPool so surely we should be doing the same thing in both places?","commit_id":"002c3fa5d67b5bc2551936627d7a8bc706a1c257"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"2da282363d9b12ecdef7bf48620bd83482003af9","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        if arguments.get(\u0027sasl_enabled\u0027, False):"},{"line_number":60,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":61,"context_line":"                self.url,"},{"line_number":62,"context_line":"                arguments,"},{"line_number":63,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":64,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":65,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":31,"id":"7e596877_1658b87a","line":62,"in_reply_to":"6f5de93b_6892571c","updated":"2022-01-29 06:05:32.000000000","message":"hello, stephen, I think is ok to pass the argument in order to keep same parament formal with the MemcacheClientPool. And I deal the argument in the MemcacheClientPool class, So there will not any problem.\nThanks.","commit_id":"002c3fa5d67b5bc2551936627d7a8bc706a1c257"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e3cbb871ca7b80921b8eba35e3d8ec463ef0a559","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        if arguments.get(\u0027sasl_enabled\u0027, False):"},{"line_number":60,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":61,"context_line":"                self.url,"},{"line_number":62,"context_line":"                arguments,"},{"line_number":63,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":64,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":65,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":31,"id":"b8f90638_3a0cc265","line":62,"in_reply_to":"7e596877_1658b87a","updated":"2022-04-28 11:13:55.000000000","message":"Indeed I think Stephen\u0027s comment is relevant.\nI\u0027d argue that the arguments should be passed the same way to the both classes.\nOnly the classes should differ depending on if we enabled or not sasl.","commit_id":"002c3fa5d67b5bc2551936627d7a8bc706a1c257"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"21e5c0baa9c34c6dfeb94353aae2c0ae70db58f7","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        if arguments.get(\u0027sasl_enabled\u0027, False):"},{"line_number":60,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":61,"context_line":"                self.url,"},{"line_number":62,"context_line":"                arguments,"},{"line_number":63,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":64,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"},{"line_number":65,"context_line":"                conn_get_timeout\u003darguments.get(\u0027pool_connection_get_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":31,"id":"3cefbf62_beabf0e9","line":62,"in_reply_to":"b8f90638_3a0cc265","updated":"2022-04-29 01:36:02.000000000","message":"I deal with the arguments like follow：‘ self.client_pool \u003d _memcache_pool.MemcacheClientPool’ (line 71), and this will be more logical.","commit_id":"002c3fa5d67b5bc2551936627d7a8bc706a1c257"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0b6617119e1ecbfd589e7684cbde10b9be2883e7","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":61,"context_line":"                self.url,"},{"line_number":62,"context_line":"                arguments\u003d{"},{"line_number":63,"context_line":"                    \u0027username\u0027: arguments.get(\u0027username\u0027, None),"},{"line_number":64,"context_line":"                    \u0027password\u0027: arguments.get(\u0027password\u0027, None),"},{"line_number":65,"context_line":"                    \u0027tls_context\u0027: arguments.get(\u0027tls_context\u0027, None)"},{"line_number":66,"context_line":"                },"},{"line_number":67,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":68,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"}],"source_content_type":"text/x-python","patch_set":33,"id":"0503be45_a780378b","line":65,"range":{"start_line":63,"start_character":20,"end_line":65,"end_character":69},"updated":"2022-04-29 08:34:25.000000000","message":"As this class is inherited from the memcache poll client I think you also need to pass the other arguments: `dead_retry`, `socket_timeout` etc... as did below.\n\nMy previous comment was related to these args.","commit_id":"c19e25d1b3c8c301c24dbb2a0220f1fd22c0e152"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"74415200f40949feb464aa90c544ce833327fbab","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            self.client_pool \u003d _bmemcache_pool.BMemcacheClientPool("},{"line_number":61,"context_line":"                self.url,"},{"line_number":62,"context_line":"                arguments\u003d{"},{"line_number":63,"context_line":"                    \u0027username\u0027: arguments.get(\u0027username\u0027, None),"},{"line_number":64,"context_line":"                    \u0027password\u0027: arguments.get(\u0027password\u0027, None),"},{"line_number":65,"context_line":"                    \u0027tls_context\u0027: arguments.get(\u0027tls_context\u0027, None)"},{"line_number":66,"context_line":"                },"},{"line_number":67,"context_line":"                maxsize\u003darguments.get(\u0027pool_maxsize\u0027, 10),"},{"line_number":68,"context_line":"                unused_timeout\u003darguments.get(\u0027pool_unused_timeout\u0027, 60),"}],"source_content_type":"text/x-python","patch_set":33,"id":"72529ac7_60c33bb5","line":65,"range":{"start_line":63,"start_character":20,"end_line":65,"end_character":69},"in_reply_to":"0503be45_a780378b","updated":"2022-05-03 03:06:08.000000000","message":"hello, the BMemcacheClientPool is inherited from MemcacheClientPool, but the two class has diffrent parameters, and the parameters in MemcacheClientPool are not used if the sasl is enabled. \n\nI just pass the arguments, and deal the arguments in respective class, which will be more clearer for these parameters, thank for your review.","commit_id":"c19e25d1b3c8c301c24dbb2a0220f1fd22c0e152"}],"oslo_cache/core.py":[{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"301fe949ce7ce2c3139714bab39a1bafd8155e33","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                         conf.cache.memcache_servers)"},{"line_number":144,"context_line":"    for arg in (\u0027dead_retry\u0027, \u0027socket_timeout\u0027, \u0027pool_maxsize\u0027,"},{"line_number":145,"context_line":"                \u0027pool_unused_timeout\u0027, \u0027pool_connection_get_timeout\u0027,"},{"line_number":146,"context_line":"                \u0027sasl_enable\u0027, \u0027usrname\u0027, \u0027password\u0027):"},{"line_number":147,"context_line":"        value \u003d getattr(conf.cache, \u0027memcache_\u0027 + arg)"},{"line_number":148,"context_line":"        conf_dict[\u0027%s.arguments.%s\u0027 % (prefix, arg)] \u003d value"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9f560f44_cb12de09","line":146,"range":{"start_line":146,"start_character":16,"end_line":146,"end_character":54},"updated":"2020-08-13 01:22:02.000000000","message":"Hi, Moisés, I remember why I use the prefix \"memcache_\". Because I want reuse the code flow here. There will be better to use the \"memcache_sasl_\" as the prefix.","commit_id":"48e74220e7b86b48609494525b3fe7eaf05e9eb1"}],"oslo_cache/tests/functional/memcache_pool/test_cache_backend.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f1a08e01d19694ff9ef59771d4f69ee2d8e96d86","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        # the current backend in use."},{"line_number":32,"context_line":"        super(TestMemcachePoolCacheBackend, self).setUp()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class TestBMemcachePoolCacheBackend(test_base.BaseTestCaseCacheBackend):"},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        MEMCACHED_PORT \u003d os.getenv(\"OSLO_CACHE_TEST_MEMCACHED_PORT\", \"11211\")"},{"line_number":37,"context_line":"        self.config_fixture.config("}],"source_content_type":"text/x-python","patch_set":27,"id":"bd8314c6_06573886","line":34,"updated":"2021-03-10 09:07:00.000000000","message":"The pep8 failed, because you should keep two blan lines on the class.","commit_id":"a52838513d0602be8f8778f7130a671bf8ee0cd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e2aac934fe840c537d09dc7c923a190b382105f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        # the current backend in use."},{"line_number":32,"context_line":"        super(TestMemcachePoolCacheBackend, self).setUp()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class TestBMemcachePoolCacheBackend(test_base.BaseTestCaseCacheBackend):"},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        MEMCACHED_PORT \u003d os.getenv(\"OSLO_CACHE_TEST_MEMCACHED_PORT\", \"11211\")"},{"line_number":37,"context_line":"        self.config_fixture.config("}],"source_content_type":"text/x-python","patch_set":27,"id":"21c0aa09_c015c97c","line":34,"in_reply_to":"bd8314c6_06573886","updated":"2022-01-28 11:01:17.000000000","message":"Done","commit_id":"a52838513d0602be8f8778f7130a671bf8ee0cd3"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f1a08e01d19694ff9ef59771d4f69ee2d8e96d86","unresolved":true,"context_lines":[{"line_number":40,"context_line":"            enabled\u003dTrue,"},{"line_number":41,"context_line":"            memcache_servers\u003d[f\u0027localhost:{MEMCACHED_PORT}\u0027]"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        super(TestBMemcachePoolCacheBackend, self).setUp()"}],"source_content_type":"text/x-python","patch_set":27,"id":"59d943f2_7c1fbc15","line":43,"updated":"2021-03-10 09:07:00.000000000","message":"In the end of file should have a blank line.","commit_id":"a52838513d0602be8f8778f7130a671bf8ee0cd3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9e2aac934fe840c537d09dc7c923a190b382105f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            enabled\u003dTrue,"},{"line_number":41,"context_line":"            memcache_servers\u003d[f\u0027localhost:{MEMCACHED_PORT}\u0027]"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        super(TestBMemcachePoolCacheBackend, self).setUp()"}],"source_content_type":"text/x-python","patch_set":27,"id":"385411d5_5b26f648","line":43,"in_reply_to":"59d943f2_7c1fbc15","updated":"2022-01-28 11:01:17.000000000","message":"Done","commit_id":"a52838513d0602be8f8778f7130a671bf8ee0cd3"}],"releasenotes/notes/enable-sasl-protocol-46d11530b87e7832.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d70cdbba17c1362b0e80c5045ed7a7dfe013ad9a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add the feature to support SASL for olso.cache to improve the security"},{"line_number":5,"context_line":"    of authority."}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9f560f44_a6e70aac","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":17},"updated":"2020-08-27 09:30:58.000000000","message":"This is very generic. Could we be more specific about the issues it helps avoid?\n\n  Add support for SASL to the memcached backend. This provides a\n  security layer between the client protocol and connection.","commit_id":"0961cce68703ae13852005221614f6d321160964"}]}