)]}'
{".zuul.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ba1a1b7d19516d2cd3ace65db0c84521b75c2d44","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      tox_environment:"},{"line_number":38,"context_line":"          OSLO_BACKEND: dogpile_cache_bmemcached"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- project:"},{"line_number":41,"context_line":"    templates:"},{"line_number":42,"context_line":"      - check-requirements"},{"line_number":43,"context_line":"      - lib-forward-testing-python3"},{"line_number":44,"context_line":"      - openstack-lower-constraints-jobs"},{"line_number":45,"context_line":"      - openstack-python3-victoria-jobs"},{"line_number":46,"context_line":"      - periodic-stable-jobs"},{"line_number":47,"context_line":"      - publish-openstack-docs-pti"},{"line_number":48,"context_line":"      - release-notes-jobs-python3"},{"line_number":49,"context_line":"    check:"},{"line_number":50,"context_line":"      jobs:"},{"line_number":51,"context_line":"        - oslo.cache-functional-etcd3gw"},{"line_number":52,"context_line":"        - oslo.cache-functional-dogpile_cache_bmemcached"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9f560f44_5b5d9313","line":52,"range":{"start_line":40,"start_character":2,"end_line":52,"end_character":0},"updated":"2020-08-20 12:40:44.000000000","message":"Job oslo.cache-functional-dogpile_cache_bmemcached not defined","commit_id":"2daeb65b9fddd159a8ccb3177b0a35fc73694a68"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"6e92b19ea4a97daad7cb0cd13d0602632d2aefca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"## Functional Tests env vars"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# PIFPAF_DAEMON:"},{"line_number":4,"context_line":"#   The binary to be installed by bindep filtered with"},{"line_number":5,"context_line":"#   [tests-functional-{PIFPAF_DAEMON}] and executed by pifpaf."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# OSLO_BACKEND:"},{"line_number":8,"context_line":"#   The functional test directory to pass to STESTR_TEST_PATH"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- job:"},{"line_number":11,"context_line":"    name: oslo.cache-functional"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_81ffbea9","line":8,"range":{"start_line":1,"start_character":0,"end_line":8,"end_character":61},"updated":"2020-08-20 14:16:14.000000000","message":"Good idea to summarize that here","commit_id":"a11cde4cc323e14c28c884684417bc5cfc2e9549"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2ab828358a971a654c15752f71e1dc05d0aa59bf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"## Functional Tests env vars"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# PIFPAF_DAEMON:"},{"line_number":4,"context_line":"#   The binary to be installed by bindep filtered with"},{"line_number":5,"context_line":"#   [tests-functional-{PIFPAF_DAEMON}] and executed by pifpaf."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# OSLO_BACKEND:"},{"line_number":8,"context_line":"#   The functional test directory to pass to STESTR_TEST_PATH"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- job:"},{"line_number":11,"context_line":"    name: oslo.cache-functional"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9f560f44_1e33b263","line":8,"range":{"start_line":1,"start_character":0,"end_line":8,"end_character":61},"in_reply_to":"9f560f44_81ffbea9","updated":"2020-08-26 09:46:07.000000000","message":"+1","commit_id":"a11cde4cc323e14c28c884684417bc5cfc2e9549"}],"oslo_cache/tests/functional/dogpile_cache_bmemcached/test_cache_backend.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ac16fce6fefb8b102509201320f33a004d984bc9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class TestDogpileCacheBMemcachedBackend(test_base.BaseTestCaseCacheBackend):"},{"line_number":19,"context_line":"    def setUp(self):"},{"line_number":20,"context_line":"        self.config_fixture.config("},{"line_number":21,"context_line":"            group\u003d\"cache\","},{"line_number":22,"context_line":"            backend\u003d\"dogpile.cache.bmemcached\","},{"line_number":23,"context_line":"            memcache_servers\u003d\"localhost:11212\","},{"line_number":24,"context_line":"        )"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        # NOTE(hberaud): super must be called after all to ensure that"},{"line_number":27,"context_line":"        # config fixture is properly initialized with value related to"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_36c6f69b","line":24,"range":{"start_line":20,"start_character":0,"end_line":24,"end_character":9},"updated":"2020-08-20 13:33:56.000000000","message":"I wonder if we test the right things here.\n\nBy looking more deeply to these changes, I think we have some mistakes here and I think we need more work here.\n\nbmemcached was introduced to allow us to use SASL with memcache and especially with our memcache_pool backend (which is the one that use memcached) (c.f I40b9f4eac518f34a3dfb710b5c4ab3a76da7c00c).\n\nHere, by doing this (`backend\u003d\"dogpile.cache.bmemcached\"`) we will test bmemcached with dogpile and we will not test our memcache_pool backend.\n\nIMO Functional tests should testing our drivers, and our backends only.\n\nTo implement the right test I think we should use something like this:\n\n```\nbackend\u003d\"oslo_cache.memcache_pool\"\nmemcache_sasl_enabled\u003dTrue\nmemcache_username\u003dsomething\nmemcache_password\u003d*****\n```\n\nSorry to missed that during my previous reviews.\n\n[1] https://review.opendev.org/#/c/742060/25/oslo_cache/backends/memcache_pool.py","commit_id":"a11cde4cc323e14c28c884684417bc5cfc2e9549"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cf951135cd0ee89bcaf7f920eb9ce9a29c046597","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class TestDogpileCacheBMemcachedBackend(test_base.BaseTestCaseCacheBackend):"},{"line_number":19,"context_line":"    def setUp(self):"},{"line_number":20,"context_line":"        self.config_fixture.config("},{"line_number":21,"context_line":"            group\u003d\"cache\","},{"line_number":22,"context_line":"            backend\u003d\"dogpile.cache.bmemcached\","},{"line_number":23,"context_line":"            memcache_servers\u003d\"localhost:11212\","},{"line_number":24,"context_line":"        )"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        # NOTE(hberaud): super must be called after all to ensure that"},{"line_number":27,"context_line":"        # config fixture is properly initialized with value related to"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_b605e6c4","line":24,"range":{"start_line":20,"start_character":0,"end_line":24,"end_character":9},"in_reply_to":"9f560f44_36c6f69b","updated":"2020-08-20 13:36:12.000000000","message":"I mean I think the semantic behind https://review.opendev.org/#/c/742060 is that I described previously","commit_id":"a11cde4cc323e14c28c884684417bc5cfc2e9549"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"bf0eba42be512d37ed1290bfec4bfe68d8b9c09e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class TestDogpileCacheBMemcachedBackend(test_base.BaseTestCaseCacheBackend):"},{"line_number":19,"context_line":"    def setUp(self):"},{"line_number":20,"context_line":"        self.config_fixture.config("},{"line_number":21,"context_line":"            group\u003d\"cache\","},{"line_number":22,"context_line":"            backend\u003d\"dogpile.cache.bmemcached\","},{"line_number":23,"context_line":"            memcache_servers\u003d\"localhost:11212\","},{"line_number":24,"context_line":"        )"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        # NOTE(hberaud): super must be called after all to ensure that"},{"line_number":27,"context_line":"        # config fixture is properly initialized with value related to"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_367ef618","line":24,"range":{"start_line":20,"start_character":0,"end_line":24,"end_character":9},"in_reply_to":"9f560f44_b605e6c4","updated":"2020-08-20 13:44:23.000000000","message":"sorry ignore my comment I was thinking that this patch was related to https://review.opendev.org/#/c/742060","commit_id":"a11cde4cc323e14c28c884684417bc5cfc2e9549"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2ab828358a971a654c15752f71e1dc05d0aa59bf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            memcache_servers\u003d\"localhost:11212\","},{"line_number":24,"context_line":"        )"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        # NOTE(hberaud): super must be called after all to ensure that"},{"line_number":27,"context_line":"        # config fixture is properly initialized with value related to"},{"line_number":28,"context_line":"        # the current backend in use."},{"line_number":29,"context_line":"        super().setUp()"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f560f44_5e29aae3","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":37},"updated":"2020-08-26 09:46:07.000000000","message":"nit: not really necessary? I always assume super is to be called in these situations\n\nLater: I see this is copied from the next file. Fair","commit_id":"a11cde4cc323e14c28c884684417bc5cfc2e9549"}]}