)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8dee9c3a457d803f980b65c017d67029ab2c690d","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"I have made several tests with keystone and here is what I saw when all memcached backends were unreachable:"},{"line_number":13,"context_line":"1. memcached services were stopped but their hosts were alive(keystone received \u0027connection refused\u0027) - everything was working fine"},{"line_number":14,"context_line":"2. memcached backends and their hosts were completely unreachable(keystone received \u0027no route to host\u0027) - the whole keystone stopped responding"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Keystone should be working fine even if all memcached backends are down. In this case it wasn\u0027t."},{"line_number":17,"context_line":"Afer I deleted the discussed functionality from the code, keystone was finally able to handle failure of all memcached backends."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"229b0e5d_29dddc41","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":21},"updated":"2022-04-28 14:19:44.000000000","message":"Does the `memcached backends` are the same thing that `memcached services` above (scenario 1).\n\nIf yes that mean that the python-memcached lib handle dead hosts (the server that host the memcachend backend) differently than when the backend is stopped/unreachable (dead service and not dead host).\n\nSo, what do you think about checking the reason [1] behind the fault and handling that as needed rather than dropping this code snippet?\n\nI\u0027m a bit nervous about removing this snippets and I\u0027m not sure to measure the possible side effects that it could trigger.\n\nHandling specific kind of failure could help us to solve the problem you identified without triggering a cascade of unexpected side effects.\n\nThoughts?\n\n[1] https://github.com/linsomniac/python-memcached/blob/master/memcache.py#L1385","commit_id":"fcf960cc9c0f571d1a04b2f61767c4aee595295b"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8dee9c3a457d803f980b65c017d67029ab2c690d","unresolved":true,"context_lines":[{"line_number":14,"context_line":"2. memcached backends and their hosts were completely unreachable(keystone received \u0027no route to host\u0027) - the whole keystone stopped responding"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Keystone should be working fine even if all memcached backends are down. In this case it wasn\u0027t."},{"line_number":17,"context_line":"Afer I deleted the discussed functionality from the code, keystone was finally able to handle failure of all memcached backends."},{"line_number":18,"context_line":"I believe this issue is not only limited to keystone, I just used it as an example."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib3e3028d967c166d21b60cf4cb7c9d5dc82a8fe7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d38e3cc0_a9e5fb7a","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":4},"updated":"2022-04-28 14:19:44.000000000","message":"After","commit_id":"fcf960cc9c0f571d1a04b2f61767c4aee595295b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"534d8db963aeab87a23f45839b66496f1e73cd4f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f1e80f52_73759f41","updated":"2023-02-17 14:52:31.000000000","message":"hmm, there are some errors related to allowlist_externals.\nIs gating broken?","commit_id":"357df19cc1e88f5db7d235366c725265709b0c0d"},{"author":{"_account_id":32666,"name":"Damian Dąbrowski","email":"damian@dabrowski.cloud","username":"ddabrowski"},"change_message_id":"292dbaf85f2a646ec0411d66c0e7e86a6fa8ddd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"45961708_952b074e","updated":"2023-07-06 15:42:23.000000000","message":"Nice to see that this change passed CI\nI\u0027d appreciate W+1","commit_id":"e34fbe29250a328377f44b67167e12de2da72b12"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"dc5f0667c0cb840d906c080b7925ab690a10a4a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e2add388_7b233beb","updated":"2023-07-06 12:06:49.000000000","message":"recheck","commit_id":"e34fbe29250a328377f44b67167e12de2da72b12"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5f448deda94608cb914926a28e28c83348f6dda7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a0d37864_4773d82b","updated":"2024-01-05 10:08:21.000000000","message":"recheck - tempest full failed likely intermitently","commit_id":"e34fbe29250a328377f44b67167e12de2da72b12"}]}