)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cc4264c1377497067a8a15dcbb4b6be8c3172366","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6862a0a0_61f5b04a","updated":"2022-01-27 08:24:10.000000000","message":"I think one single approval is enough for this patch (authored by a core and backported by a core).","commit_id":"ac170557938984f136ab5d343a0fe4a1368b38db"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"28a98e8947e1c99baec939ca2302f44267af113f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"99f241b3_46d3ab46","updated":"2022-02-02 10:50:39.000000000","message":"I don\u0027t think we can backport this. There\u0027s a dependency bump (in \u0027test-requirements.txt\u0027) and it is very much a feature rather than a bug fix. Is it possible to backport this downstream instead, assuming it\u0027s needed for a customer issue?\n\n-2 is to stop this merging until we\u0027ve determined whether it\u0027s feasible or not.","commit_id":"2ad2d52f4ecb63d9edfe3ae64cd9b7dece5330a0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e8cec0201e04759b570f8c22624960ffdf88e52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"25bbfcaf_0302e5fd","updated":"2022-02-02 12:15:13.000000000","message":"Okay, this is unfortunate but since I missed this previously, I guess we\u0027re stuck fixing it now","commit_id":"2ad2d52f4ecb63d9edfe3ae64cd9b7dece5330a0"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"ac7944c90cfe2adb3e3daf28ba53bec97bf5557b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7483ac94_5e2cafc2","updated":"2022-02-01 10:16:18.000000000","message":"Seems good for me.","commit_id":"2ad2d52f4ecb63d9edfe3ae64cd9b7dece5330a0"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0a85d57c9f65a2db77a8cbc5ccdd7e6e6d0324f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93ce8abb_3307e2c1","updated":"2022-02-01 16:57:31.000000000","message":"The versions of the libs required by this series of patches are now supported on this branch:\n- https://review.opendev.org/c/openstack/requirements/+/827256\n- https://review.opendev.org/c/openstack/requirements/+/827255","commit_id":"2ad2d52f4ecb63d9edfe3ae64cd9b7dece5330a0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e8cec0201e04759b570f8c22624960ffdf88e52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d323b656_1bad080a","in_reply_to":"6052c22e_f743da23","updated":"2022-02-02 12:15:13.000000000","message":"Hmm, okay, so this feature backport is needed because we did another feature backport. I guess we all know what the lesson here is (me included - I reviewed all those backports also) 😄 Fair enough though","commit_id":"2ad2d52f4ecb63d9edfe3ae64cd9b7dece5330a0"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7ec1d6caf8cf5d67d00417e5a08a34698e2f3d9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6052c22e_f743da23","in_reply_to":"99f241b3_46d3ab46","updated":"2022-02-02 11:44:51.000000000","message":"Well, the dependency bump was solved yesterday by a requirement patch[1] (merged). Same for Wallaby, the requirements have been adapted (merged too).\n\nAlso we should notice that the initial changes that introduced the described bug were related to a backport of a feature on stable branches [2][3]. Adding the support of new backend to a stable branch (dogpile.cache.pymemcache) is a new feature too. So even if these changes are a new feature, they are optional and well isolated and they will fix a bad situation introduced by another new feature also backported previously [2][3].\n\nAlso we should notice that some mechanisms have been introduced to ignore this backend if the version of dogpile.cache doesn\u0027t match our needs [4], so from Victoria I\u0027d suggest to drop the reqs bump and to rely on this mechanism at least by relying on dogpile.cache 1.1.5 rather than 1.1.2\n\nLet me know what you think about this.\n\n[1] https://review.opendev.org/c/openstack/requirements/+/826995\n[2] https://review.opendev.org/q/topic:memcached-tls\n[3] https://review.opendev.org/c/openstack/oslo.cache/+/773904\n[4] https://opendev.org/openstack/oslo.cache/commit/3e3037886e8021911e10f492c0502951bff5104e","commit_id":"2ad2d52f4ecb63d9edfe3ae64cd9b7dece5330a0"}],"oslo_cache/core.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e8cec0201e04759b570f8c22624960ffdf88e52","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        # As with the TLS context above, the config dict below will be"},{"line_number":210,"context_line":"        # consumed by dogpile.cache that will be used as a proxy between"},{"line_number":211,"context_line":"        # oslo.cache and pymemcache."},{"line_number":212,"context_line":"        conf_dict[\u0027%s.arguments.socket_keepalive\u0027 % prefix] \u003d socket_keepalive"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    return conf_dict"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"17af24e3_d5ae08d3","line":212,"updated":"2022-02-02 12:15:13.000000000","message":"This is fine. dogpile.cache expects this to be a dict and silently ignores anything it doesn\u0027t recognize [1][2] (using the 1.1.2 release intentionally so we can verify it won\u0027t break anything for users with this older release)\n\n[1] https://github.com/sqlalchemy/dogpile.cache/blob/rel_1_1_2/dogpile/cache/backends/memcached.py#L136-L146\n[2] https://github.com/sqlalchemy/dogpile.cache/blob/rel_1_1_2/dogpile/cache/backends/memcached.py#L506-L511","commit_id":"2ad2d52f4ecb63d9edfe3ae64cd9b7dece5330a0"}]}