)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"65defc4e210c81a01f9c0d81956f8e63847af4cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6f51fd48_aaf7f7e6","updated":"2022-10-03 13:03:59.000000000","message":"Hi Corey,\n\nI think this makes sense since \"memcache_sasl_enabled\" is set to False by default, there shouldn\u0027t be a hard requirement on having this package installed in the system.\n\nI left a comment inline.\n\nThanks,","commit_id":"052cc2b0abdbeb9d964432404dc6236f00cbb310"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"dbadf421e889c782254051f1bfb11e22109befb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"973d57f9_c127cbf0","updated":"2022-10-03 13:11:04.000000000","message":"Thanks Felipe, good catch","commit_id":"052cc2b0abdbeb9d964432404dc6236f00cbb310"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7a807d017a6dbd0712fca2c94993cafdb7141342","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ef45b066_12ce6af4","updated":"2022-10-03 13:34:54.000000000","message":"However, that could be worth to also publish a release note to socialize this point.\nPlease, can you add one?","commit_id":"3a5ae4678759bdf875156a01a422fa514d93bc05"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"71fb777562e07aa493a6b5f303927656e7fc6a4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54e9822c_5480ab1a","updated":"2022-10-03 13:33:10.000000000","message":"LGTM.","commit_id":"3a5ae4678759bdf875156a01a422fa514d93bc05"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0ea0153cd26f365e522b8eb03babf45771c071ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"46d1da31_dc229f37","updated":"2022-10-03 13:33:47.000000000","message":"Looks sensible, Felipe\u0027s previous comment have been addressed.\nLGTM.","commit_id":"3a5ae4678759bdf875156a01a422fa514d93bc05"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"fb1dd13e951da7aea04ed5eb581955863f455cc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6177245_b2b5c840","updated":"2022-10-03 14:32:56.000000000","message":"Thanks for the reviews. I\u0027ve added a release note.","commit_id":"3a5ae4678759bdf875156a01a422fa514d93bc05"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"493cbee9ea4670c317cb62df8648d9a835043b36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0d901a44_c46666fe","updated":"2022-10-03 14:36:46.000000000","message":"Thanks","commit_id":"b2a769d81b270b0a81e2e2c7ecdda3ad0e72b1a7"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"d211674269574369cf1639e532badecc0b0acdc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ecab2d7c_50b4d34b","updated":"2023-02-23 14:55:08.000000000","message":"tox-4 issues fixed by https://review.opendev.org/c/openstack/oslo.cache/+/874216","commit_id":"b2a769d81b270b0a81e2e2c7ecdda3ad0e72b1a7"}],"oslo_cache/backends/memcache_pool.py":[{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"65defc4e210c81a01f9c0d81956f8e63847af4cf","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    from oslo_cache import _bmemcache_pool"},{"line_number":24,"context_line":"except ImportError as e:"},{"line_number":25,"context_line":"    if str(e) \u003d\u003d \"No module named \u0027bmemcached\u0027\":"},{"line_number":26,"context_line":"        _bmemcache_pool \u003d None"},{"line_number":27,"context_line":"from oslo_cache import _memcache_pool"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2e971f5c_180f47b2","line":26,"updated":"2022-10-03 13:03:59.000000000","message":"we should have an \u0027else\u0027 section to re-raise any other import error, otherwise it will be suppressed.","commit_id":"052cc2b0abdbeb9d964432404dc6236f00cbb310"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"dbadf421e889c782254051f1bfb11e22109befb3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    from oslo_cache import _bmemcache_pool"},{"line_number":24,"context_line":"except ImportError as e:"},{"line_number":25,"context_line":"    if str(e) \u003d\u003d \"No module named \u0027bmemcached\u0027\":"},{"line_number":26,"context_line":"        _bmemcache_pool \u003d None"},{"line_number":27,"context_line":"from oslo_cache import _memcache_pool"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a79be52e_d512202f","line":26,"in_reply_to":"2e971f5c_180f47b2","updated":"2022-10-03 13:11:04.000000000","message":"Ack","commit_id":"052cc2b0abdbeb9d964432404dc6236f00cbb310"},{"author":{"_account_id":2424,"name":"Felipe Reyes","email":"felipe.reyes@canonical.com","username":"freyes"},"change_message_id":"71fb777562e07aa493a6b5f303927656e7fc6a4a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    if str(e) \u003d\u003d \"No module named \u0027bmemcached\u0027\":"},{"line_number":26,"context_line":"        _bmemcache_pool \u003d None"},{"line_number":27,"context_line":"    else:"},{"line_number":28,"context_line":"        raise"},{"line_number":29,"context_line":"from oslo_cache import _memcache_pool"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5e4c4040_89f2532f","line":28,"updated":"2022-10-03 13:33:10.000000000","message":"👍","commit_id":"3a5ae4678759bdf875156a01a422fa514d93bc05"}]}
