)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64a2cfda66d39bf2788f08c9000e91aafdf4d108","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Matus Jenca \u003cmatus.jenca@dnation.cloud\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-31 09:56:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":":Implement backend for Redis Sentinel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack supports Redis but not Redis Sentinel"},{"line_number":10,"context_line":"which is used in Kolla for high availability"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ab432738_96112bb0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"updated":"2024-01-31 09:25:40.000000000","message":"remove this","commit_id":"77d3f5405fcf14f1c70f249edf59a4f13d5aa12e"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"03c37bd0c997c72d03305c09780ad07f7392eac4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Matus Jenca \u003cmatus.jenca@dnation.cloud\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-31 09:56:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":":Implement backend for Redis Sentinel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack supports Redis but not Redis Sentinel"},{"line_number":10,"context_line":"which is used in Kolla for high availability"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df482db0_1a115972","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"in_reply_to":"ab432738_96112bb0","updated":"2024-01-31 10:34:18.000000000","message":"Yes agree please remove this from commit message.","commit_id":"77d3f5405fcf14f1c70f249edf59a4f13d5aa12e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"c54932f5c2ccd1e9ccf0efedcdd34381f8363367","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0b786bf_4e0be686","updated":"2024-02-05 10:20:37.000000000","message":"I think that patch is now invalid with the new patch from Takashi.","commit_id":"77d3f5405fcf14f1c70f249edf59a4f13d5aa12e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64a2cfda66d39bf2788f08c9000e91aafdf4d108","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"16ec4362_23c07cae","updated":"2024-01-31 09:25:40.000000000","message":"Leaving my initial (too early) feedback","commit_id":"77d3f5405fcf14f1c70f249edf59a4f13d5aa12e"}],"oslo_cache/_opts.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64a2cfda66d39bf2788f08c9000e91aafdf4d108","unresolved":true,"context_lines":[{"line_number":38,"context_line":"                            \u0027oslo_cache.dict\u0027,"},{"line_number":39,"context_line":"                            \u0027oslo_cache.mongo\u0027,"},{"line_number":40,"context_line":"                            \u0027oslo_cache.etcd3gw\u0027,"},{"line_number":41,"context_line":"                            \u0027oslo_cache.redis_sentinel\u0027,"},{"line_number":42,"context_line":"                            \u0027dogpile.cache.pymemcache\u0027,"},{"line_number":43,"context_line":"                            \u0027dogpile.cache.memcached\u0027,"},{"line_number":44,"context_line":"                            \u0027dogpile.cache.pylibmc\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"65730864_eb0c91cf","line":41,"range":{"start_line":41,"start_character":29,"end_line":41,"end_character":54},"updated":"2024-01-31 09:25:40.000000000","message":"Can\u0027t we use the dogpile implementation instead of adding our own code ?\n\n[1] https://dogpilecache.sqlalchemy.org/en/latest/api.html#dogpile.cache.backends.redis.RedisSentinelBackend","commit_id":"77d3f5405fcf14f1c70f249edf59a4f13d5aa12e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"91391bdedc8938f3860340084c5967c5486b7446","unresolved":true,"context_lines":[{"line_number":38,"context_line":"                            \u0027oslo_cache.dict\u0027,"},{"line_number":39,"context_line":"                            \u0027oslo_cache.mongo\u0027,"},{"line_number":40,"context_line":"                            \u0027oslo_cache.etcd3gw\u0027,"},{"line_number":41,"context_line":"                            \u0027oslo_cache.redis_sentinel\u0027,"},{"line_number":42,"context_line":"                            \u0027dogpile.cache.pymemcache\u0027,"},{"line_number":43,"context_line":"                            \u0027dogpile.cache.memcached\u0027,"},{"line_number":44,"context_line":"                            \u0027dogpile.cache.pylibmc\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e5e4cc19_5418269c","line":41,"range":{"start_line":41,"start_character":29,"end_line":41,"end_character":54},"in_reply_to":"65730864_eb0c91cf","updated":"2024-01-31 09:30:47.000000000","message":"Hmm ok this looks a bit complicated because of how design our options vs how sentinel backend accepts arguments. Let me try a few possible changes.","commit_id":"77d3f5405fcf14f1c70f249edf59a4f13d5aa12e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"692c103ef3a08716ac3b40aa7d5fe37da742ad98","unresolved":true,"context_lines":[{"line_number":38,"context_line":"                            \u0027oslo_cache.dict\u0027,"},{"line_number":39,"context_line":"                            \u0027oslo_cache.mongo\u0027,"},{"line_number":40,"context_line":"                            \u0027oslo_cache.etcd3gw\u0027,"},{"line_number":41,"context_line":"                            \u0027oslo_cache.redis_sentinel\u0027,"},{"line_number":42,"context_line":"                            \u0027dogpile.cache.pymemcache\u0027,"},{"line_number":43,"context_line":"                            \u0027dogpile.cache.memcached\u0027,"},{"line_number":44,"context_line":"                            \u0027dogpile.cache.pylibmc\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ac792f85_0963d869","line":41,"range":{"start_line":41,"start_character":29,"end_line":41,"end_character":54},"in_reply_to":"e5e4cc19_5418269c","updated":"2024-01-31 16:06:24.000000000","message":"How about this approach ? https://review.opendev.org/c/openstack/oslo.cache/+/907336","commit_id":"77d3f5405fcf14f1c70f249edf59a4f13d5aa12e"}],"oslo_cache/backends/redis.py":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0aa62ce4ce2cddb5495183e61f7b889c1eaeddc9","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        # Reformat sentinels into (ip \u003cstring\u003e, port \u003cint\u003e)"},{"line_number":42,"context_line":"        # as required by dogpile.cahce.redis_sentinel"},{"line_number":43,"context_line":"        sentinels \u003d ["},{"line_number":44,"context_line":"            (host, int(port))"},{"line_number":45,"context_line":"            for host, port in ["}],"source_content_type":"text/x-python","patch_set":2,"id":"6898bf78_7b480feb","line":42,"range":{"start_line":42,"start_character":33,"end_line":42,"end_character":38},"updated":"2024-01-31 14:04:30.000000000","message":"typo: cache","commit_id":"77d3f5405fcf14f1c70f249edf59a4f13d5aa12e"}],"oslo_cache/core.py":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"03c37bd0c997c72d03305c09780ad07f7392eac4","unresolved":true,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # This removes username and password that"},{"line_number":166,"context_line":"    # are needed for redis_sentinel backend"},{"line_number":167,"context_line":"    if conf.cache.backend !\u003d \"oslo_cache.redis_sentinel\":"},{"line_number":168,"context_line":"        for arg in (\u0027dead_retry\u0027, \u0027socket_timeout\u0027, \u0027pool_maxsize\u0027,"},{"line_number":169,"context_line":"                    \u0027pool_unused_timeout\u0027, \u0027pool_connection_get_timeout\u0027,"},{"line_number":170,"context_line":"                    \u0027pool_flush_on_reconnect\u0027, \u0027sasl_enabled\u0027, \u0027username\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e07d28d1_e9aa204e","line":167,"updated":"2024-01-31 10:34:18.000000000","message":"Sorry can you explain what you want here please? The comment is a bit confusing for me. We don\u0027t remove the username and password here.","commit_id":"77d3f5405fcf14f1c70f249edf59a4f13d5aa12e"},{"author":{"_account_id":36624,"name":"Matúš Jenča","email":"matus.jenca@dnation.cloud","username":"matusjenca"},"change_message_id":"2f6ef50ba0657744b8e5c5074d0b42869b8b07cf","unresolved":true,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    # This removes username and password that"},{"line_number":166,"context_line":"    # are needed for redis_sentinel backend"},{"line_number":167,"context_line":"    if conf.cache.backend !\u003d \"oslo_cache.redis_sentinel\":"},{"line_number":168,"context_line":"        for arg in (\u0027dead_retry\u0027, \u0027socket_timeout\u0027, \u0027pool_maxsize\u0027,"},{"line_number":169,"context_line":"                    \u0027pool_unused_timeout\u0027, \u0027pool_connection_get_timeout\u0027,"},{"line_number":170,"context_line":"                    \u0027pool_flush_on_reconnect\u0027, \u0027sasl_enabled\u0027, \u0027username\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"762c8ed2_0f0fa206","line":167,"in_reply_to":"e07d28d1_e9aa204e","updated":"2024-02-02 11:06:49.000000000","message":"Maybe you don\u0027t remove them intentionally, without the if statement it removes them, or rather they don\u0027t appear in the final `config_dict` this function returns.","commit_id":"77d3f5405fcf14f1c70f249edf59a4f13d5aa12e"}]}