)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"fa06c65b737bd4e7233a8b82aab852839cb9faed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"29b91f94_1610ef53","updated":"2024-02-12 13:42:14.000000000","message":"I\u0027ll address the comments in a separate follow-up patch so will merge this now.","commit_id":"f1950fdaa950fffdd50caced12c80b03137eaba8"}],"oslo_cache/core.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"71963d287330f56134060958857d0333852851dd","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        value \u003d getattr(conf.cache, \u0027memcache_\u0027 + arg)"},{"line_number":169,"context_line":"        conf_dict[\u0027%s.arguments.%s\u0027 % (prefix, arg)] \u003d value"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    if conf.cache.tls_enabled:"},{"line_number":172,"context_line":"        if conf.cache.backend in (\u0027dogpile.cache.bmemcache\u0027,"},{"line_number":173,"context_line":"                \u0027dogpile.cache.pymemcache\u0027, \u0027oslo_cache.memcache_pool\u0027):"},{"line_number":174,"context_line":"            _LOG.debug(\u0027Oslo Cache TLS - CA: %s\u0027, conf.cache.tls_cafile)"},{"line_number":175,"context_line":"            tls_context \u003d ssl.create_default_context("},{"line_number":176,"context_line":"                cafile\u003dconf.cache.tls_cafile)"}],"source_content_type":"text/x-python","patch_set":6,"id":"46b69e35_e695c6cd","line":173,"range":{"start_line":171,"start_character":30,"end_line":173,"end_character":72},"updated":"2024-01-31 16:10:34.000000000","message":"Note for reviewers:\n\nWe can revert the logic to avoid the indentation changes below, but I decided this approach because of the subsequent changes.","commit_id":"1e33b5c89c118995dedb4495abae21ea07cbda49"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"9f296c383f6c16405b9a75ae43d8a307eb32d202","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            msg \u003d _("},{"line_number":211,"context_line":"                \"TLS setting via [cache] tls_enabled is not supported by this \""},{"line_number":212,"context_line":"                \"backend.\""},{"line_number":213,"context_line":"            )"},{"line_number":214,"context_line":"            raise exception.ConfigurationError(msg)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5e5bf526_881b47f7","line":212,"range":{"start_line":212,"start_character":16,"end_line":212,"end_character":25},"updated":"2024-02-12 10:15:09.000000000","message":"Here is a couple of suggestions for a more friendly user message that provide some guidances.\n\nWhat do you think of the following sentence:\n\n```\nTLS is not supported by this backend ({backend_name}).\n\nShowing this error mean that the backend you provided in `[cache] tls_enabled` do not\nsupport TLS features.\n\nOnly the following backends supports TLS:\n- dogpile.cache.bmemcache\n- dogpile.cache.pymemcache\n- oslo_cache.memcache_pool\n\nIf you want to enable TLS please choose one of these backends, else to do not see this error no more further, please .\n```\n\nIt provides to users suggestions of actions.\n\nAlso, I think it could be worth to indicate the backend name in the error message by refering to `conf.cache.backend`.\n\nI do not want to block the merge of this patch, so if you think my suggestions are worth retaining, then do not hesitate to propose a follow up patch.","commit_id":"f1950fdaa950fffdd50caced12c80b03137eaba8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a8a273c2fb107517da92a56aa3575aef2d43872e","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            msg \u003d _("},{"line_number":211,"context_line":"                \"TLS setting via [cache] tls_enabled is not supported by this \""},{"line_number":212,"context_line":"                \"backend.\""},{"line_number":213,"context_line":"            )"},{"line_number":214,"context_line":"            raise exception.ConfigurationError(msg)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"d089e622_8f5d9d0f","line":212,"range":{"start_line":212,"start_character":16,"end_line":212,"end_character":25},"in_reply_to":"5e5bf526_881b47f7","updated":"2024-02-12 11:30:55.000000000","message":"Because this appears in log, It\u0027d be better to avoid multi-line document. I think the detail should be documented in config option instead of logs.\n\nI agree with showing backend name in logs would be useful.\n\nTo avoid wiping +2 on this, I\u0027ll address these by a separate change.\n https://review.opendev.org/c/openstack/oslo.cache/+/908770","commit_id":"f1950fdaa950fffdd50caced12c80b03137eaba8"}]}