)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"e27de838bc1989eb482ca2ac63646dd27f358cbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"11eb4c52_62730859","updated":"2024-02-14 10:27:39.000000000","message":"Hi,\n\nFor me it\u0027s not easier to read.","commit_id":"4b17c1908ed6680c8d434c14d2f0b139fc1ed467"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac3b46d51ee3c4b586c6f4d91a57614aebf5b321","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48f77496_ebf46c7f","updated":"2026-03-15 16:46:32.000000000","message":"I\u0027ll abandon this due to inactivity after several -1s. If you aim to continue your work please feel free to restore this.","commit_id":"4b17c1908ed6680c8d434c14d2f0b139fc1ed467"}],"oslo_cache/backends/dictionary.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"234f16c8f65da4925ad5d24b5944c8aca65050f5","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        now \u003d timeutils.utcnow_ts()"},{"line_number":103,"context_line":"        for k in list(self.cache):"},{"line_number":104,"context_line":"            (_value, timeout) \u003d self.cache[k]"},{"line_number":105,"context_line":"            if timeout \u003e 0 and now \u003e\u003d timeout:"},{"line_number":106,"context_line":"                del self.cache[k]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9dd989cd_3f8b16ab","side":"PARENT","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":46},"updated":"2024-02-14 10:24:25.000000000","message":"these two comparisons have different meaning. The first one is check whether timeout is requested, and the second one is check whether the cache should be deleted. So squashing these two hides that intention.","commit_id":"33244f6aae01fbace89bf8a84b45b668f317d218"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ac3b46d51ee3c4b586c6f4d91a57614aebf5b321","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        now \u003d timeutils.utcnow_ts()"},{"line_number":103,"context_line":"        for k in list(self.cache):"},{"line_number":104,"context_line":"            (_value, timeout) \u003d self.cache[k]"},{"line_number":105,"context_line":"            if timeout \u003e 0 and now \u003e\u003d timeout:"},{"line_number":106,"context_line":"                del self.cache[k]"}],"source_content_type":"text/x-python","patch_set":2,"id":"66b0e4b0_c8c9ce4a","side":"PARENT","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":46},"in_reply_to":"4eda17ee_927f41f2","updated":"2026-03-15 16:46:32.000000000","message":"IMHO current usage of and is clear enough and separating the whole if clauses has no real benefit.","commit_id":"33244f6aae01fbace89bf8a84b45b668f317d218"},{"author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"change_message_id":"7762a287320269cac301f4ea04837acb51fa3eaa","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        now \u003d timeutils.utcnow_ts()"},{"line_number":103,"context_line":"        for k in list(self.cache):"},{"line_number":104,"context_line":"            (_value, timeout) \u003d self.cache[k]"},{"line_number":105,"context_line":"            if timeout \u003e 0 and now \u003e\u003d timeout:"},{"line_number":106,"context_line":"                del self.cache[k]"}],"source_content_type":"text/x-python","patch_set":2,"id":"4eda17ee_927f41f2","side":"PARENT","line":105,"range":{"start_line":105,"start_character":12,"end_line":105,"end_character":46},"in_reply_to":"9dd989cd_3f8b16ab","updated":"2024-02-19 09:17:44.000000000","message":"if these two have different meanings, they should be separated into 2 if clauses for more clearance, don\u0027t you think? I could do that along with some comments on their purpose","commit_id":"33244f6aae01fbace89bf8a84b45b668f317d218"}]}