)]}'
{"oslo_cache/_opts.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d4778e9a133bcc852a45e586c6331325ed2ae27b","unresolved":true,"context_lines":[{"line_number":100,"context_line":"                     \u0027 (dogpile.cache.memcache and oslo_cache.memcache_pool\u0027"},{"line_number":101,"context_line":"                     \u0027 backends only).\u0027),"},{"line_number":102,"context_line":"        cfg.IntOpt(\u0027memcache_expire_time\u0027,"},{"line_number":103,"context_line":"                   default\u003d3600,"},{"line_number":104,"context_line":"                   help\u003d\u0027Max number of seconds an item is held in memcached\\\u0027s\u0027"},{"line_number":105,"context_line":"                   \u0027 cache. (oslo_cache.memcache_pool backend only).\u0027),"},{"line_number":106,"context_line":"        cfg.IntOpt(\u0027memcache_pool_maxsize\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ce68569f_527d84bf","line":103,"range":{"start_line":103,"start_character":27,"end_line":103,"end_character":31},"updated":"2024-06-17 11:43:18.000000000","message":"this would break the deployment with expiration_time \u003e 3600. I\u0027d suggest having no default and require users to define this parameter in case active expiration is needed.","commit_id":"449a232d8aa6400755f06f0e5ec6021ac9955435"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8ff951587496b5bfc63be15a10623625449f78fe","unresolved":true,"context_lines":[{"line_number":100,"context_line":"                     \u0027 (dogpile.cache.memcache and oslo_cache.memcache_pool\u0027"},{"line_number":101,"context_line":"                     \u0027 backends only).\u0027),"},{"line_number":102,"context_line":"        cfg.IntOpt(\u0027memcache_expire_time\u0027,"},{"line_number":103,"context_line":"                   default\u003d3600,"},{"line_number":104,"context_line":"                   help\u003d\u0027Max number of seconds an item is held in memcached\\\u0027s\u0027"},{"line_number":105,"context_line":"                   \u0027 cache. (oslo_cache.memcache_pool backend only).\u0027),"},{"line_number":106,"context_line":"        cfg.IntOpt(\u0027memcache_pool_maxsize\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b52f7a2f_4c63d4c4","line":103,"range":{"start_line":103,"start_character":27,"end_line":103,"end_character":31},"in_reply_to":"61a775bd_ba6db529","updated":"2024-06-17 14:32:10.000000000","message":"If you have a deployment with older version and have [cache] expiration_time\u003d10800, then the extended expiration does not work because the expiration at backend level is set at 3600. This does not break the functionality immediately though it can cause performance degradation.\n\nWe at least should document the upgrade impact in a release note, along with the new option.","commit_id":"449a232d8aa6400755f06f0e5ec6021ac9955435"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"8c3045401fbec17e4500ba04281a302908b249a4","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                     \u0027 (dogpile.cache.memcache and oslo_cache.memcache_pool\u0027"},{"line_number":101,"context_line":"                     \u0027 backends only).\u0027),"},{"line_number":102,"context_line":"        cfg.IntOpt(\u0027memcache_expire_time\u0027,"},{"line_number":103,"context_line":"                   default\u003d3600,"},{"line_number":104,"context_line":"                   help\u003d\u0027Max number of seconds an item is held in memcached\\\u0027s\u0027"},{"line_number":105,"context_line":"                   \u0027 cache. (oslo_cache.memcache_pool backend only).\u0027),"},{"line_number":106,"context_line":"        cfg.IntOpt(\u0027memcache_pool_maxsize\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"61a775bd_ba6db529","line":103,"range":{"start_line":103,"start_character":27,"end_line":103,"end_character":31},"in_reply_to":"ce68569f_527d84bf","updated":"2024-06-17 14:08:12.000000000","message":"Having no default is the current situation and it\u0027s causing problems. Having a default doesn\u0027t cause any damage since it can be overwritten by a higher value.","commit_id":"449a232d8aa6400755f06f0e5ec6021ac9955435"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d4778e9a133bcc852a45e586c6331325ed2ae27b","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        cfg.IntOpt(\u0027memcache_expire_time\u0027,"},{"line_number":103,"context_line":"                   default\u003d3600,"},{"line_number":104,"context_line":"                   help\u003d\u0027Max number of seconds an item is held in memcached\\\u0027s\u0027"},{"line_number":105,"context_line":"                   \u0027 cache. (oslo_cache.memcache_pool backend only).\u0027),"},{"line_number":106,"context_line":"        cfg.IntOpt(\u0027memcache_pool_maxsize\u0027,"},{"line_number":107,"context_line":"                   default\u003d10,"},{"line_number":108,"context_line":"                   help\u003d\u0027Max total number of open connections to every\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ed95be4_23edb219","line":105,"range":{"start_line":105,"start_character":29,"end_line":105,"end_character":53},"updated":"2024-06-17 11:43:18.000000000","message":"Is this parameter really implemented in oslo_cache.memcache_pool ? I don\u0027t see any reference in https://github.com/openstack/oslo.cache/blob/master/oslo_cache/_memcache_pool.py#L228-L235 .","commit_id":"449a232d8aa6400755f06f0e5ec6021ac9955435"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"908912a363ab9180b1dd10a48d63fb7bbe3d5d79","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        cfg.IntOpt(\u0027memcache_expire_time\u0027,"},{"line_number":103,"context_line":"                   default\u003d3600,"},{"line_number":104,"context_line":"                   help\u003d\u0027Max number of seconds an item is held in memcached\\\u0027s\u0027"},{"line_number":105,"context_line":"                   \u0027 cache. (oslo_cache.memcache_pool backend only).\u0027),"},{"line_number":106,"context_line":"        cfg.IntOpt(\u0027memcache_pool_maxsize\u0027,"},{"line_number":107,"context_line":"                   default\u003d10,"},{"line_number":108,"context_line":"                   help\u003d\u0027Max total number of open connections to every\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"801c3297_5c67bbc0","line":105,"range":{"start_line":105,"start_character":29,"end_line":105,"end_character":53},"in_reply_to":"1ed95be4_23edb219","updated":"2024-06-17 12:04:59.000000000","message":"Further investigation revealed that this inherits the implementation of MemcachedBackend from dogpile.cache. We probably have to mention not only oslo_cache.memcache_pool but also\n - dogpile.cache.memcached\n - dogpile.cache.pylibmc\n - dogpile.cache.pymemcache","commit_id":"449a232d8aa6400755f06f0e5ec6021ac9955435"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"8c3045401fbec17e4500ba04281a302908b249a4","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        cfg.IntOpt(\u0027memcache_expire_time\u0027,"},{"line_number":103,"context_line":"                   default\u003d3600,"},{"line_number":104,"context_line":"                   help\u003d\u0027Max number of seconds an item is held in memcached\\\u0027s\u0027"},{"line_number":105,"context_line":"                   \u0027 cache. (oslo_cache.memcache_pool backend only).\u0027),"},{"line_number":106,"context_line":"        cfg.IntOpt(\u0027memcache_pool_maxsize\u0027,"},{"line_number":107,"context_line":"                   default\u003d10,"},{"line_number":108,"context_line":"                   help\u003d\u0027Max total number of open connections to every\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"8757e499_64d51058","line":105,"range":{"start_line":105,"start_character":29,"end_line":105,"end_character":53},"in_reply_to":"801c3297_5c67bbc0","updated":"2024-06-17 14:08:12.000000000","message":"It will be.","commit_id":"449a232d8aa6400755f06f0e5ec6021ac9955435"}],"oslo_cache/core.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"908912a363ab9180b1dd10a48d63fb7bbe3d5d79","unresolved":true,"context_lines":[{"line_number":220,"context_line":"        for arg in (\u0027dead_retry\u0027, \u0027socket_timeout\u0027, \u0027pool_maxsize\u0027,"},{"line_number":221,"context_line":"                    \u0027pool_unused_timeout\u0027, \u0027pool_connection_get_timeout\u0027,"},{"line_number":222,"context_line":"                    \u0027pool_flush_on_reconnect\u0027, \u0027sasl_enabled\u0027, \u0027username\u0027,"},{"line_number":223,"context_line":"                    \u0027password\u0027, \u0027expire_time\u0027):"},{"line_number":224,"context_line":"            value \u003d getattr(conf.cache, \u0027memcache_\u0027 + arg)"},{"line_number":225,"context_line":"            conf_dict[\u0027%s.arguments.%s\u0027 % (prefix, arg)] \u003d value"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ad0b9b2_24db159b","line":223,"range":{"start_line":223,"start_character":33,"end_line":223,"end_character":44},"updated":"2024-06-17 12:04:59.000000000","message":"this may not work because the actual argument which defines backend expiration is memcached_expire_time.","commit_id":"449a232d8aa6400755f06f0e5ec6021ac9955435"},{"author":{"_account_id":35125,"name":"Mauricio Harley","email":"mharley@redhat.com","username":"mharley-rh"},"change_message_id":"8c3045401fbec17e4500ba04281a302908b249a4","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        for arg in (\u0027dead_retry\u0027, \u0027socket_timeout\u0027, \u0027pool_maxsize\u0027,"},{"line_number":221,"context_line":"                    \u0027pool_unused_timeout\u0027, \u0027pool_connection_get_timeout\u0027,"},{"line_number":222,"context_line":"                    \u0027pool_flush_on_reconnect\u0027, \u0027sasl_enabled\u0027, \u0027username\u0027,"},{"line_number":223,"context_line":"                    \u0027password\u0027, \u0027expire_time\u0027):"},{"line_number":224,"context_line":"            value \u003d getattr(conf.cache, \u0027memcache_\u0027 + arg)"},{"line_number":225,"context_line":"            conf_dict[\u0027%s.arguments.%s\u0027 % (prefix, arg)] \u003d value"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f4c04d8c_fe11c982","line":223,"range":{"start_line":223,"start_character":33,"end_line":223,"end_character":44},"in_reply_to":"1ad0b9b2_24db159b","updated":"2024-06-17 14:08:12.000000000","message":"Thanks for raising this. It will be fixed.","commit_id":"449a232d8aa6400755f06f0e5ec6021ac9955435"}]}