)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"08dfe25074e6e537573616e990e997e009480d4c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add memcached_expire_time to the configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a default configuration to avoid items being"},{"line_number":10,"context_line":"held on memcached\u0027s memspace endlessly occupying memory. More"},{"line_number":11,"context_line":"information on [1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://bugs.launchpad.net/keystone/+bug/1901124"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f33dcb6f_15535856","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":19},"updated":"2024-06-18 14:43:33.000000000","message":"I wonder if it is not a bit a duplication of https://docs.openstack.org/oslo.cache/latest/configuration/index.html#cache.expiration_time\n\nIf I correctly remember, dogpile is behind every backends provided by oslo.cache.","commit_id":"30cec77a7667b42a7f8f31b7f0e06eb968ef243a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"36db2dc6bdc61a83f66c4705d496799fd3afc412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0f6b876_1aa844d6","updated":"2024-10-13 15:10:33.000000000","message":"oslo.cache supports additional cache_time definition for specific region. This definitely breaks the case where any of the cache_time is expected to be longer than the core expiration_time. IMO we should not set the backend expiration automatically but let users select the value they definitely need. See https://review.opendev.org/c/openstack/oslo.cache/+/932301 .","commit_id":"c5df0e534ab82262a870439db6f3a1941bf7048a"}],"oslo_cache/_opts.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"08dfe25074e6e537573616e990e997e009480d4c","unresolved":true,"context_lines":[{"line_number":100,"context_line":"                     \u0027 (dogpile.cache.memcache and oslo_cache.memcache_pool\u0027"},{"line_number":101,"context_line":"                     \u0027 backends only).\u0027),"},{"line_number":102,"context_line":"        cfg.IntOpt(\u0027memcached_expire_time\u0027,"},{"line_number":103,"context_line":"                   default\u003d3600,"},{"line_number":104,"context_line":"                   help\u003d\u0027Max number of seconds an item is held in memcached\\\u0027s\u0027"},{"line_number":105,"context_line":"                   \u0027 cache. (oslo_cache.memcache_pool backend only,\u0027"},{"line_number":106,"context_line":"                   \u0027 dogpile.cache.memcached, dogpile.cache.pylibmc,\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"e61161e5_b309ef1b","line":103,"range":{"start_line":103,"start_character":19,"end_line":103,"end_character":32},"updated":"2024-06-18 14:43:33.000000000","message":"If I correctly understand this patch, this configuration will be applied to all the values stored in memcached, exact?\n\nThe memcache doc (https://github.com/memcached/memcached/wiki/Commands#standard-protocol) seems to indicate that it exists a way to configure expiration but data by data rather than globally, so I wonder which one would be preferable in our case.\n\nI also wonder if we shouldn\u0027t default this to `O` (zero), to avoid side effect with the introduction of such threshold... Some services may not want such expiration, isn\u0027t?","commit_id":"30cec77a7667b42a7f8f31b7f0e06eb968ef243a"}],"oslo_cache/core.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"08dfe25074e6e537573616e990e997e009480d4c","unresolved":true,"context_lines":[{"line_number":218,"context_line":"                    \u0027password\u0027):"},{"line_number":219,"context_line":"            value \u003d getattr(conf.cache, \u0027memcache_\u0027 + arg)"},{"line_number":220,"context_line":"            conf_dict[f\u0027{prefix}.arguments.{arg}\u0027] \u003d value"},{"line_number":221,"context_line":"        value \u003d getattr(conf.cache, \u0027memcached_expire_time\u0027)"},{"line_number":222,"context_line":"        conf_dict[f\u0027{prefix}.arguments.memcached_expire_time\u0027] \u003d value"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    if conf.cache.tls_enabled:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4fc6c5c_c1ad1b64","line":221,"updated":"2024-06-18 14:43:33.000000000","message":"Would be good, if it do not bother you, to add an empty line before this one to make the reading more enjoyable.","commit_id":"30cec77a7667b42a7f8f31b7f0e06eb968ef243a"}],"releasenotes/notes/bug-1901124-5655e4053ece7f2b.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"08dfe25074e6e537573616e990e997e009480d4c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    In some scenarios, items can last forever in memcached\u0027s cache, which"},{"line_number":6,"context_line":"    results in incremental RAM usage. With the suggested configuration option,"},{"line_number":7,"context_line":"    all cached items receive a maximum expiration time."},{"line_number":8,"context_line":"    "},{"line_number":9,"context_line":"    Deployments with memcached old releases may face performance degradation"},{"line_number":10,"context_line":"    since the default being set for this configuration parameter is established"},{"line_number":11,"context_line":"    on the backend."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"04f1aeaa_83f74014","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":4},"updated":"2024-06-18 14:43:33.000000000","message":"Blank space","commit_id":"30cec77a7667b42a7f8f31b7f0e06eb968ef243a"}]}