)]}'
{".zuul.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"81965de1bf5eb21be495089b03e6e2fbbcdbb80b","unresolved":true,"context_lines":[{"line_number":118,"context_line":"        - oslo.cache-functional-dogpile.cache.redis"},{"line_number":119,"context_line":"        - oslo.cache-functional-dogpile.cache.redis_sentinel"},{"line_number":120,"context_line":"        - oslo.cache-functional-dogpile.cache.valkey"},{"line_number":121,"context_line":"        # TODO(tkajinam): Disabled due to https://github.com/jd/pifpaf/issues/202"},{"line_number":122,"context_line":"        # - oslo.cache-functional-dogpile.cache.valkey_sentinel"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bc6d6802_ed912483","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":81},"updated":"2025-09-29 09:17:38.000000000","message":"Apparently that seems closed.","commit_id":"8c1ee274ede1188e8d729469b48be40189d01f29"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"017e5a6ad154e5824f59e97a09de75f37c3494cd","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        - oslo.cache-functional-dogpile.cache.redis"},{"line_number":119,"context_line":"        - oslo.cache-functional-dogpile.cache.redis_sentinel"},{"line_number":120,"context_line":"        - oslo.cache-functional-dogpile.cache.valkey"},{"line_number":121,"context_line":"        # TODO(tkajinam): Disabled due to https://github.com/jd/pifpaf/issues/202"},{"line_number":122,"context_line":"        # - oslo.cache-functional-dogpile.cache.valkey_sentinel"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"203db734_c2b094f4","line":121,"range":{"start_line":121,"start_character":8,"end_line":121,"end_character":81},"in_reply_to":"bc6d6802_ed912483","updated":"2025-10-01 06:05:31.000000000","message":"Done","commit_id":"8c1ee274ede1188e8d729469b48be40189d01f29"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"836bf90ffc83fe73daa5d10deba9d23243ce8681","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4b9c8fe6_cfde78cd","updated":"2025-02-11 01:37:58.000000000","message":"recheck","commit_id":"0feaa9e35a5d08e31de5be6845a17240d1cdbbb8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90630efecd69cde1546cc07256afde814a5c78ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"583f8f9f_5876b2da","updated":"2025-02-11 14:23:23.000000000","message":"recheck","commit_id":"0feaa9e35a5d08e31de5be6845a17240d1cdbbb8"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"81965de1bf5eb21be495089b03e6e2fbbcdbb80b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8963efcc_b276b7d4","updated":"2025-09-29 09:17:38.000000000","message":"LGTM, just an inline comment","commit_id":"8c1ee274ede1188e8d729469b48be40189d01f29"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d59dbc6776fde049565dea86fb0df2cb78bc8ff7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"3deda537_98170663","updated":"2025-10-30 01:31:26.000000000","message":"recheck","commit_id":"cda27f46b5da36835d317cae45cc1fc14612dc73"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"39a520b913b28646d35fab0198c8cab4973e4e88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"df88b3b6_f1a5e3cc","updated":"2025-10-29 14:59:16.000000000","message":"recheck req check was fixed.","commit_id":"cda27f46b5da36835d317cae45cc1fc14612dc73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"429863f7dda709a500b0c1e76e265902b7a18e9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"bd26f871_83b045d8","updated":"2026-03-23 16:38:11.000000000","message":"@kajinamit@oss.nttdata.com I can review this if you want to respin it.","commit_id":"c2d9a11f2f782ee73fac6317c993f0f3a0b41a95"}],"oslo_cache/_opts.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"35b10785d14822bfb0b5a910cce329e96445534d","unresolved":true,"context_lines":[{"line_number":208,"context_line":"        ),"},{"line_number":209,"context_line":"        # redis/valkey options"},{"line_number":210,"context_line":"        cfg.StrOpt("},{"line_number":211,"context_line":"            \u0027redis_server\u0027,"},{"line_number":212,"context_line":"            default\u003d\u0027localhost:6379\u0027,"},{"line_number":213,"context_line":"            help\u003d\u0027Redis server in the format of \"host:port\"\u0027,"},{"line_number":214,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":23,"id":"30e3bc3d_e920bdec","line":211,"range":{"start_line":211,"start_character":13,"end_line":211,"end_character":25},"updated":"2026-03-08 15:58:45.000000000","message":"In earlier version I added separate options for valkey, but I\u0027m wondering if we can reuse the ones for redis, because these two are quite similar (though these can diverge at some point)","commit_id":"c2d9a11f2f782ee73fac6317c993f0f3a0b41a95"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"44d7c3831cc75559da3a44d53f044c0ca79314e9","unresolved":true,"context_lines":[{"line_number":208,"context_line":"        ),"},{"line_number":209,"context_line":"        # redis/valkey options"},{"line_number":210,"context_line":"        cfg.StrOpt("},{"line_number":211,"context_line":"            \u0027redis_server\u0027,"},{"line_number":212,"context_line":"            default\u003d\u0027localhost:6379\u0027,"},{"line_number":213,"context_line":"            help\u003d\u0027Redis server in the format of \"host:port\"\u0027,"},{"line_number":214,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":23,"id":"2ffd1b63_201fcfa2","line":211,"range":{"start_line":211,"start_character":13,"end_line":211,"end_character":25},"in_reply_to":"30e3bc3d_e920bdec","updated":"2026-03-23 16:39:07.000000000","message":"I\u0027m happy with either approach, though I suspect different opts might be simpler for end-users even if it\u0027s slightly more code? We may end up removing redis at some point too, given the license issues.","commit_id":"c2d9a11f2f782ee73fac6317c993f0f3a0b41a95"}],"oslo_cache/core.py":[{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"8fb96e92678f4697428d7fecbd581ff9615d955e","unresolved":true,"context_lines":[{"line_number":359,"context_line":"        elif conf.cache.backend in (\u0027dogpile.cache.redis\u0027,"},{"line_number":360,"context_line":"                                    \u0027dogpile.cache.redis_sentinel\u0027,"},{"line_number":361,"context_line":"                                    \u0027dogpile.cache.valkey\u0027,"},{"line_number":362,"context_line":"                                    \u0027dogpile.cache.vakley_sentinel\u0027):"},{"line_number":363,"context_line":"            socket_keepalive_options \u003d {"},{"line_number":364,"context_line":"                socket.TCP_KEEPIDLE: conf.cache.socket_keepalive_idle,"},{"line_number":365,"context_line":"                socket.TCP_KEEPINTVL: conf.cache.socket_keepalive_interval,"}],"source_content_type":"text/x-python","patch_set":14,"id":"1560f7f8_0170e697","line":362,"range":{"start_line":362,"start_character":51,"end_line":362,"end_character":66},"updated":"2025-10-01 20:28:38.000000000","message":"```suggestion\n                                    \u0027dogpile.cache.valkey_sentinel\u0027):\n```","commit_id":"009585e66f6f058c38498b553bc07dd03f393c6a"},{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"ce643e5b633d6d9bb852ad78accc54b4c65252ef","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        elif conf.cache.backend in (\u0027dogpile.cache.redis\u0027,"},{"line_number":360,"context_line":"                                    \u0027dogpile.cache.redis_sentinel\u0027,"},{"line_number":361,"context_line":"                                    \u0027dogpile.cache.valkey\u0027,"},{"line_number":362,"context_line":"                                    \u0027dogpile.cache.vakley_sentinel\u0027):"},{"line_number":363,"context_line":"            socket_keepalive_options \u003d {"},{"line_number":364,"context_line":"                socket.TCP_KEEPIDLE: conf.cache.socket_keepalive_idle,"},{"line_number":365,"context_line":"                socket.TCP_KEEPINTVL: conf.cache.socket_keepalive_interval,"}],"source_content_type":"text/x-python","patch_set":14,"id":"57f7aaee_09206e62","line":362,"range":{"start_line":362,"start_character":51,"end_line":362,"end_character":66},"in_reply_to":"1560f7f8_0170e697","updated":"2025-10-02 07:04:10.000000000","message":"Done","commit_id":"009585e66f6f058c38498b553bc07dd03f393c6a"}]}