)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e869bb73d2a40d30d38e68fb0756c084f1e2a64b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"85cf8946_47c92955","updated":"2026-03-05 11:28:01.000000000","message":"-1 just to catch your eye","commit_id":"b80275660d4dab4b4f968895fcbfd88af5ccc3f4"}],"oslo_cache/core.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e869bb73d2a40d30d38e68fb0756c084f1e2a64b","unresolved":true,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        _LOG.debug(\u0027Oslo Cache Config: %s\u0027, conf_dict)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    if conf.cache.backend in ("},{"line_number":172,"context_line":"        \u0027dogpile.cache.redis\u0027,"},{"line_number":173,"context_line":"        \u0027dogpile.cache.redis_sentinel\u0027,"},{"line_number":174,"context_line":"    ):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a8fbcd6_cd932335","line":171,"updated":"2026-03-05 11:28:01.000000000","message":"Before, for `dogpile.cache.redis` we would set:\n\n* `{prefix}.arguments.url`\n* `{prefix}.arguments.socket_timeout`\n\nAnd now we will set:\n\n* `{prefix}.arguments.username`\n* `{prefix}.arguments.password`\n* `{prefix}.arguments.socket_timeout`\n* `{prefix}.arguments.db`\n* `{prefix}.arguments.host`\n* `{prefix}.arguments.port`\n* `{prefix}.arguments.ssl` (done below)\n\nThis is a pretty large change but I\u0027m guessing that it\u0027s functionally identical since we were providing all of this information in the URL first, right?\n  \nAnd for completeness\u0027 sake, for `dogpile.cache.redis_sentinel` we would set:\n\n* `{prefix}.arguments.username`\n* `{prefix}.arguments.password`\n* `{prefix}.arguments.socket_timeout`\n* `{prefix}.arguments.db`\n* `{prefix}.arguments.service_name`\n* `{prefix}.arguments.sentinels` (optional)\n\nAnd now we will set:\n\n* `{prefix}.arguments.username`\n* `{prefix}.arguments.password`\n* `{prefix}.arguments.socket_timeout`\n* `{prefix}.arguments.db`\n* `{prefix}.arguments.service_name`\n* `{prefix}.arguments.sentinels` (optional)\n* `{prefix}.arguments.ssl` (done below)\n\nWhich is identical bar the `ssl` argument. I assume the sentinel backend can handle SSL connectivity?\n\nAssuming my \"decoder\" above is correct, could we get that added to the commit message for future reviewers?","commit_id":"b80275660d4dab4b4f968895fcbfd88af5ccc3f4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"69200d72e359dc353df22f54c61c6a6249af4a1b","unresolved":true,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        _LOG.debug(\u0027Oslo Cache Config: %s\u0027, conf_dict)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    if conf.cache.backend in ("},{"line_number":172,"context_line":"        \u0027dogpile.cache.redis\u0027,"},{"line_number":173,"context_line":"        \u0027dogpile.cache.redis_sentinel\u0027,"},{"line_number":174,"context_line":"    ):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa4a54f_787d353c","line":171,"in_reply_to":"12d3ff39_4f17e033","updated":"2026-03-05 15:54:25.000000000","message":"Okay, that makes sense.\n\nCould you add the above to the commit message? With or without the decoder, depending on whether you find it useful or not.","commit_id":"b80275660d4dab4b4f968895fcbfd88af5ccc3f4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dbdc4abdd81b6efba7656c8a03f93979640d68b1","unresolved":true,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        _LOG.debug(\u0027Oslo Cache Config: %s\u0027, conf_dict)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    if conf.cache.backend in ("},{"line_number":172,"context_line":"        \u0027dogpile.cache.redis\u0027,"},{"line_number":173,"context_line":"        \u0027dogpile.cache.redis_sentinel\u0027,"},{"line_number":174,"context_line":"    ):"}],"source_content_type":"text/x-python","patch_set":2,"id":"12d3ff39_4f17e033","line":171,"in_reply_to":"1a8fbcd6_cd932335","updated":"2026-03-05 13:11:05.000000000","message":"\u003e This is a pretty large change but I\u0027m guessing that it\u0027s functionally identical since we were providing all of this information in the URL first, right?\n\nYes. That\u0027s correct. redis-py internally parses url and break it into these pieces.\n\n\u003e Which is identical bar the ssl argument.\nThe `{prefix}.arguments.ssl` is read by Redis backend to override the ssl key in connection_kwargs and has no effect for RedisSentinel backed. I think it\u0027s more consistent to set the key within connection_kwargs, so I updated the option accordingly.\n\nhttps://dogpilecache.sqlalchemy.org/en/latest/api.html#dogpile.cache.backends.redis.RedisBackend.params.ssl","commit_id":"b80275660d4dab4b4f968895fcbfd88af5ccc3f4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f0942caeabb47ebcccb4f83fc75464bede7da2a8","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        _LOG.debug(\u0027Oslo Cache Config: %s\u0027, conf_dict)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    if conf.cache.backend in ("},{"line_number":172,"context_line":"        \u0027dogpile.cache.redis\u0027,"},{"line_number":173,"context_line":"        \u0027dogpile.cache.redis_sentinel\u0027,"},{"line_number":174,"context_line":"    ):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5baddf83_3e311734","line":171,"in_reply_to":"baa4a54f_787d353c","updated":"2026-03-05 16:05:20.000000000","message":"Done","commit_id":"b80275660d4dab4b4f968895fcbfd88af5ccc3f4"}]}