)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"3ab4f7ecff30416dc6a8bbb4209585fdef84f6d2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Run /usr/bin/prlimit with no parameter once to check if the program"},{"line_number":14,"context_line":"is available and works."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I07a4605a624d4eff8cdb65b8309c0592a8589702"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dae33548_777acff2","line":15,"updated":"2016-02-16 17:24:44.000000000","message":"why do this at all? There\u0027s no bug or blueprint to describe what this is fixing.","commit_id":"d80b490f42dd568681a84589bb079721c03e26c8"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"ffb5739eac469d22ea3fe17efde8d7760fcbf08a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Run /usr/bin/prlimit with no parameter once to check if the program"},{"line_number":14,"context_line":"is available and works."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I07a4605a624d4eff8cdb65b8309c0592a8589702"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dae33548_26c0127b","line":15,"in_reply_to":"dae33548_777acff2","updated":"2016-02-16 19:18:57.000000000","message":"Oh sorry, it\u0027s related to this security vulnerability:\nhttps://bugs.launchpad.net/ossa/+bug/1449062","commit_id":"d80b490f42dd568681a84589bb079721c03e26c8"}],"oslo_concurrency/processutils.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"df01137d8a7bec632a759dfbe771faa0a5b624cf","unresolved":false,"context_lines":[{"line_number":121,"context_line":"LOG_FINAL_ERROR \u003d LogErrors.FINAL"},{"line_number":122,"context_line":"LOG_DEFAULT_ERROR \u003d LogErrors.DEFAULT"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Absolute path to the prlimit program"},{"line_number":125,"context_line":"_PRLIMIT_PROGRAM \u003d \u0027/usr/bin/prlimit\u0027"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# Does the system have /usr/bin/prlimit?"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_62395d41","line":124,"updated":"2016-02-16 22:52:50.000000000","message":"comments should tell the reader why the code is here since the code already tells the reader what it is.","commit_id":"d80b490f42dd568681a84589bb079721c03e26c8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"df01137d8a7bec632a759dfbe771faa0a5b624cf","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    try:"},{"line_number":135,"context_line":"        execute(_PRLIMIT_PROGRAM)"},{"line_number":136,"context_line":"    except ProcessExecutionError as exc:"},{"line_number":137,"context_line":"        LOG.info(\u0027prlimit program is missing: %s returned %s exit code\u0027,"},{"line_number":138,"context_line":"                 _PRLIMIT_PROGRAM, exc.exit_code)"},{"line_number":139,"context_line":"        return False"},{"line_number":140,"context_line":"    except Exception as exc:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e2c0cd2c","line":137,"updated":"2016-02-16 22:52:50.000000000","message":"since this is logged at info level we have to assume that operators are going to be reading it and trying to figure out what to do about it. We need to provide more info to them because this doesn\u0027t say what they\u0027re supposed to do about it or what problem it\u0027s going to cause.\n\nThis applies to the LOG.warn below.","commit_id":"d80b490f42dd568681a84589bb079721c03e26c8"}],"oslo_concurrency/tests/unit/test_processutils.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"df01137d8a7bec632a759dfbe771faa0a5b624cf","unresolved":false,"context_lines":[{"line_number":846,"context_line":"        fake_popen.returncode \u003d 0"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"        modname \u003d \u0027oslo_concurrency.processutils.subprocess\u0027"},{"line_number":849,"context_line":"        with mock.patch(modname) as subprocess:"},{"line_number":850,"context_line":"            subprocess.Popen.return_value \u003d fake_popen"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"            # missing prlimit command: use Python implementation"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_e24a8dab","line":849,"updated":"2016-02-16 22:52:50.000000000","message":"if mock.patch.object was used then 2 lines wouldn\u0027t be required.","commit_id":"d80b490f42dd568681a84589bb079721c03e26c8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"df01137d8a7bec632a759dfbe771faa0a5b624cf","unresolved":false,"context_lines":[{"line_number":850,"context_line":"            subprocess.Popen.return_value \u003d fake_popen"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"            # missing prlimit command: use Python implementation"},{"line_number":853,"context_line":"            with mock.patch(\u0027oslo_concurrency.processutils._HAVE_PRLMIT\u0027,"},{"line_number":854,"context_line":"                            False):"},{"line_number":855,"context_line":"                stdout, stderr \u003d processutils.execute(\u0027/bin/true\u0027,"},{"line_number":856,"context_line":"                                                      prlimit\u003dprlimit)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_82a0e144","line":853,"updated":"2016-02-16 22:52:50.000000000","message":"if http://docs.openstack.org/developer/oslotest/api/oslotest.mockpatch.html was used then wouldn\u0027t need to indent so much.","commit_id":"d80b490f42dd568681a84589bb079721c03e26c8"}]}