)]}'
{"oslo_concurrency/tests/unit/test_processutils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c684c9d29e721e41242f935a7123459e0d3bb71d","unresolved":false,"context_lines":[{"line_number":791,"context_line":"        self.check_limit(prlimit, \u0027RLIMIT_AS\u0027, prlimit.address_space)"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def test_core_size(self):"},{"line_number":794,"context_line":"        size \u003d self.soft_limit(resource.RLIMIT_CORE, 1, 1024)"},{"line_number":795,"context_line":"        prlimit \u003d processutils.ProcessLimits(core_file_size\u003dsize)"},{"line_number":796,"context_line":"        self.check_limit(prlimit, \u0027RLIMIT_CORE\u0027, prlimit.core_file_size)"},{"line_number":797,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_6dcd8b84","line":794,"range":{"start_line":794,"start_character":56,"end_line":794,"end_character":60},"updated":"2016-04-20 08:26:27.000000000","message":"A core dump of 1024 bytes is a little bit small, I would suggest to use a more realistic value like 100 MB: 100 * 1024 * 1024.","commit_id":"8af826953d1ad2cab2ecf360e0c794de70a367c3"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e5e93759eee97a89eff9956bb8926fe74fd92f7d","unresolved":false,"context_lines":[{"line_number":791,"context_line":"        self.check_limit(prlimit, \u0027RLIMIT_AS\u0027, prlimit.address_space)"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def test_core_size(self):"},{"line_number":794,"context_line":"        size \u003d self.soft_limit(resource.RLIMIT_CORE, 1, 1024)"},{"line_number":795,"context_line":"        prlimit \u003d processutils.ProcessLimits(core_file_size\u003dsize)"},{"line_number":796,"context_line":"        self.check_limit(prlimit, \u0027RLIMIT_CORE\u0027, prlimit.core_file_size)"},{"line_number":797,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_aaf54ecc","line":794,"range":{"start_line":794,"start_character":56,"end_line":794,"end_character":60},"in_reply_to":"1a122d0e_6dcd8b84","updated":"2016-04-22 09:21:34.000000000","message":"We\u0027re not actually testing core dump functionality - we just need to prove that the limit gets changed, so this is fine. Likewise all the other tests","commit_id":"8af826953d1ad2cab2ecf360e0c794de70a367c3"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c684c9d29e721e41242f935a7123459e0d3bb71d","unresolved":false,"context_lines":[{"line_number":796,"context_line":"        self.check_limit(prlimit, \u0027RLIMIT_CORE\u0027, prlimit.core_file_size)"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"    def test_cpu_time(self):"},{"line_number":799,"context_line":"        time \u003d self.soft_limit(resource.RLIMIT_CPU, 1, 1024)"},{"line_number":800,"context_line":"        prlimit \u003d processutils.ProcessLimits(cpu_time\u003dtime)"},{"line_number":801,"context_line":"        self.check_limit(prlimit, \u0027RLIMIT_CPU\u0027, prlimit.cpu_time)"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_ad15e3e5","line":799,"range":{"start_line":799,"start_character":55,"end_line":799,"end_character":59},"updated":"2016-04-20 08:26:27.000000000","message":"1024 looks like a strange number of seconds. I would expect something like 60 or 60*60.","commit_id":"8af826953d1ad2cab2ecf360e0c794de70a367c3"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c684c9d29e721e41242f935a7123459e0d3bb71d","unresolved":false,"context_lines":[{"line_number":806,"context_line":"        self.check_limit(prlimit, \u0027RLIMIT_DATA\u0027, max_memory)"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"    def test_file_size(self):"},{"line_number":809,"context_line":"        size \u003d self.soft_limit(resource.RLIMIT_FSIZE, 1, 1024)"},{"line_number":810,"context_line":"        prlimit \u003d processutils.ProcessLimits(file_size\u003dsize)"},{"line_number":811,"context_line":"        self.check_limit(prlimit, \u0027RLIMIT_FSIZE\u0027, prlimit.file_size)"},{"line_number":812,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_ad716346","line":809,"range":{"start_line":809,"start_character":57,"end_line":809,"end_character":61},"updated":"2016-04-20 08:26:27.000000000","message":"Ditto, a file limit of 1024 bytes looks too small. I suggest at least 1 MB: 1024 * 1024.","commit_id":"8af826953d1ad2cab2ecf360e0c794de70a367c3"}]}