)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63ca54589d83a33cf6dda363a931848fd211461d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Some test cleanup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Tests are based on oslotest.base.BaseTestCase, which uses the"},{"line_number":10,"context_line":"  NestedTempFile fixture, which uses the TempDir fixture, which adds a"},{"line_number":11,"context_line":"  cleanup routine to remove the base temporary directory it creates."},{"line_number":12,"context_line":"  There\u0027s therefore no need for tests to clean up this directory, so all"},{"line_number":13,"context_line":"  the code that does that is removed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_5747ba4c","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":16},"updated":"2019-09-18 08:50:33.000000000","message":"https://github.com/openstack/oslotest/blob/3.8.1/oslotest/base.py#L122","commit_id":"fe86f5e4ae8aee42d685dcedb574b95a5c5ce85a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63ca54589d83a33cf6dda363a931848fd211461d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Some test cleanup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Tests are based on oslotest.base.BaseTestCase, which uses the"},{"line_number":10,"context_line":"  NestedTempFile fixture, which uses the TempDir fixture, which adds a"},{"line_number":11,"context_line":"  cleanup routine to remove the base temporary directory it creates."},{"line_number":12,"context_line":"  There\u0027s therefore no need for tests to clean up this directory, so all"},{"line_number":13,"context_line":"  the code that does that is removed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_17a062f4","line":10,"range":{"start_line":10,"start_character":41,"end_line":10,"end_character":48},"updated":"2019-09-18 08:50:33.000000000","message":"https://github.com/testing-cabal/fixtures/blob/3.0.0/fixtures/_fixtures/tempdir.py#L56-L68","commit_id":"fe86f5e4ae8aee42d685dcedb574b95a5c5ce85a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63ca54589d83a33cf6dda363a931848fd211461d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Tests are based on oslotest.base.BaseTestCase, which uses the"},{"line_number":10,"context_line":"  NestedTempFile fixture, which uses the TempDir fixture, which adds a"},{"line_number":11,"context_line":"  cleanup routine to remove the base temporary directory it creates."},{"line_number":12,"context_line":"  There\u0027s therefore no need for tests to clean up this directory, so all"},{"line_number":13,"context_line":"  the code that does that is removed."},{"line_number":14,"context_line":"- The eventlet incarnation of tests was trying to make use of the `env`"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_77ae76e8","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":68},"updated":"2019-09-18 08:50:33.000000000","message":"https://github.com/testing-cabal/fixtures/blob/3.0.0/fixtures/_fixtures/tempdir.py#L66-L67","commit_id":"fe86f5e4ae8aee42d685dcedb574b95a5c5ce85a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63ca54589d83a33cf6dda363a931848fd211461d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  NestedTempFile fixture, which uses the TempDir fixture, which adds a"},{"line_number":11,"context_line":"  cleanup routine to remove the base temporary directory it creates."},{"line_number":12,"context_line":"  There\u0027s therefore no need for tests to clean up this directory, so all"},{"line_number":13,"context_line":"  the code that does that is removed."},{"line_number":14,"context_line":"- The eventlet incarnation of tests was trying to make use of the `env`"},{"line_number":15,"context_line":"  external without whitelisting it, resulting in an ugly red deprecation"},{"line_number":16,"context_line":"  warning. This commit adds `env` to whitelist_externals in [testenv]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_d782ca4f","line":13,"updated":"2019-09-18 08:50:33.000000000","message":"This obviously doesn\u0027t behave the exact same way it did before since those temp files will not be deleted until the machine is rebooted (assuming you\u0027re creating them in a tmpfs-backed location), but that doesn\u0027t seem like much of an issue","commit_id":"fe86f5e4ae8aee42d685dcedb574b95a5c5ce85a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cd94da94391bc843ab83b774567fd6b0235b9cbb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  NestedTempFile fixture, which uses the TempDir fixture, which adds a"},{"line_number":11,"context_line":"  cleanup routine to remove the base temporary directory it creates."},{"line_number":12,"context_line":"  There\u0027s therefore no need for tests to clean up this directory, so all"},{"line_number":13,"context_line":"  the code that does that is removed."},{"line_number":14,"context_line":"- The eventlet incarnation of tests was trying to make use of the `env`"},{"line_number":15,"context_line":"  external without whitelisting it, resulting in an ugly red deprecation"},{"line_number":16,"context_line":"  warning. This commit adds `env` to whitelist_externals in [testenv]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_4f7de21a","line":13,"in_reply_to":"3fa7e38b_7d73b781","updated":"2019-09-18 12:01:46.000000000","message":"Nope, I missed something. This line, specifically:\n\nhttps://github.com/testing-cabal/fixtures/blob/3.0.0/fixtures/_fixtures/tempdir.py#L44\n\nMy bad","commit_id":"fe86f5e4ae8aee42d685dcedb574b95a5c5ce85a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"23de527c8f7e5fb1ae52f106f32f1cd627d771ce","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  NestedTempFile fixture, which uses the TempDir fixture, which adds a"},{"line_number":11,"context_line":"  cleanup routine to remove the base temporary directory it creates."},{"line_number":12,"context_line":"  There\u0027s therefore no need for tests to clean up this directory, so all"},{"line_number":13,"context_line":"  the code that does that is removed."},{"line_number":14,"context_line":"- The eventlet incarnation of tests was trying to make use of the `env`"},{"line_number":15,"context_line":"  external without whitelisting it, resulting in an ugly red deprecation"},{"line_number":16,"context_line":"  warning. This commit adds `env` to whitelist_externals in [testenv]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_7d73b781","line":13,"in_reply_to":"3fa7e38b_d782ca4f","updated":"2019-09-18 10:46:00.000000000","message":"Wdym? They\u0027ll be removed by the fixture\u0027s cleanup when the test ends. That\u0027s the point. Did I miss something?","commit_id":"fe86f5e4ae8aee42d685dcedb574b95a5c5ce85a"}]}