)]}'
{"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"17fddddc0ff1c4e97320a0e1cf0f9b5e752d5778","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.0"},{"line_number":3,"context_line":"envlist \u003d py27,py37,pep8"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[testenv]"},{"line_number":6,"context_line":"basepython \u003d python3"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_c5b3aa99","line":3,"updated":"2019-12-23 12:48:31.000000000","message":"Missing ignore_basepython_conflict and minversion bump","commit_id":"2faeb55a9d0aba8dcf0a18ae9b3ca530f575caf0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"17fddddc0ff1c4e97320a0e1cf0f9b5e752d5778","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  lockutils-wrapper stestr run --slowest {posargs}"},{"line_number":16,"context_line":"  env TEST_EVENTLET\u003d1 lockutils-wrapper stestr run --slowest {posargs}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[testenv:py27]"},{"line_number":19,"context_line":"basepython \u003d python2.7"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[testenv:pep8]"},{"line_number":22,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_85adb233","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":22},"updated":"2019-12-23 12:48:31.000000000","message":"This could go too","commit_id":"2faeb55a9d0aba8dcf0a18ae9b3ca530f575caf0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"884387b5608122693cd9c7742b717ba6cba4cbbe","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"basepython \u003d python3"},{"line_number":8,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":9,"context_line":"deps \u003d"},{"line_number":10,"context_line":"  -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":11,"context_line":"  -r{toxinidir}/test-requirements.txt"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3fa7e38b_b1cba5a5","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":47},"updated":"2020-01-14 11:54:47.000000000","message":"unrelated: this could go too","commit_id":"fc2106146013bb0881aaf5ce8f8eca45a48ef167"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"884387b5608122693cd9c7742b717ba6cba4cbbe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"whitelist_externals \u003d env"},{"line_number":15,"context_line":"commands \u003d"},{"line_number":16,"context_line":"  lockutils-wrapper stestr run --slowest {posargs}"},{"line_number":17,"context_line":"  env TEST_EVENTLET\u003d1 lockutils-wrapper stestr run --slowest {posargs}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[testenv:pep8]"},{"line_number":20,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3fa7e38b_31bfb5fe","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":22},"updated":"2020-01-14 11:54:47.000000000","message":"unrelated: we could use \u0027setenv\u0027 instead of this hack","commit_id":"fc2106146013bb0881aaf5ce8f8eca45a48ef167"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"74f6443c226627a18d25b3c66bbc2dbed8759399","unresolved":false,"context_lines":[{"line_number":14,"context_line":"whitelist_externals \u003d env"},{"line_number":15,"context_line":"commands \u003d"},{"line_number":16,"context_line":"  lockutils-wrapper stestr run --slowest {posargs}"},{"line_number":17,"context_line":"  env TEST_EVENTLET\u003d1 lockutils-wrapper stestr run --slowest {posargs}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[testenv:pep8]"},{"line_number":20,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3fa7e38b_e06054d3","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":22},"in_reply_to":"3fa7e38b_31bfb5fe","updated":"2020-01-15 08:50:32.000000000","message":"Not sure we can use setenv here because we need to read that like:\n\n```\nenv TEST_EVENTLET\u003d0 lockutils-wrapper stestr run --slowest {posargs}\nenv TEST_EVENTLET\u003d1 lockutils-wrapper stestr run --slowest {posargs}\n```\n\nThis is a similar situation than https://github.com/openstack/oslo.db/blob/master/tox.ini#L22,L23\n\nIf I\u0027m right setenv only allow us to setup only once value for a defined env var, else it will be updated with the second value.\n\nMaybe it can be useful to add the \"env TEST_EVENTLET\u003d0\" to avoid confusion here.\n\nThoughts?","commit_id":"fc2106146013bb0881aaf5ce8f8eca45a48ef167"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9f334c306adf536292ad898e346aa94732df5a13","unresolved":false,"context_lines":[{"line_number":14,"context_line":"whitelist_externals \u003d env"},{"line_number":15,"context_line":"commands \u003d"},{"line_number":16,"context_line":"  lockutils-wrapper stestr run --slowest {posargs}"},{"line_number":17,"context_line":"  env TEST_EVENTLET\u003d1 lockutils-wrapper stestr run --slowest {posargs}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[testenv:pep8]"},{"line_number":20,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3fa7e38b_c46a0581","line":17,"range":{"start_line":17,"start_character":2,"end_line":17,"end_character":22},"in_reply_to":"3fa7e38b_e06054d3","updated":"2020-01-15 15:20:13.000000000","message":"Yup, setting it explicitly makes this much clearer. I see you\u0027ve done that in the next patch. Thanks! :)","commit_id":"fc2106146013bb0881aaf5ce8f8eca45a48ef167"}]}