)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8eabc17606ba430b6207f5f08aec5073801c49f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e38fbe8a_6aaef7ee","updated":"2024-11-14 11:12:28.000000000","message":"In all the case thes changes do not introduce problems, my previous comments are  related to a logic that exists since many years.\nIn short I\u0027ve no objections against this refactor.","commit_id":"2fe6b9290672734a4f86c1890a5b604f6b12fe9e"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c4f4ef86ebcc5a5e5e046c5e1b823e670988bcc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fae9e955_047b8f1d","updated":"2024-11-14 10:32:55.000000000","message":"do you mind if we attach this patch to the \"eventlet-removal\" topic?","commit_id":"2fe6b9290672734a4f86c1890a5b604f6b12fe9e"}],"oslo_concurrency/processutils.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"02f0067eb3d1694fa4a6b6495e149e92d0c7b7ed","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    # stdout/stderr when passing data through stdin. We need to make"},{"line_number":54,"context_line":"    # sure that *native* threads will be used as pipes are blocking"},{"line_number":55,"context_line":"    # on Windows."},{"line_number":56,"context_line":"    subprocess \u003d eventlet.patcher.original(\u0027subprocess\u0027)"},{"line_number":57,"context_line":"    subprocess.threading \u003d eventlet.patcher.original(\u0027threading\u0027)"},{"line_number":58,"context_line":"else:"},{"line_number":59,"context_line":"    import subprocess"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1e5171e0_7db6308c","line":57,"range":{"start_line":56,"start_character":4,"end_line":57,"end_character":65},"updated":"2024-11-14 11:04:08.000000000","message":"Is windows still supported? AFAIK support of window have been dropped in many places. You authored several patches around windows removal\n\nhttps://github.com/search?q\u003dorg%3Aopenstack+windows\u0026type\u003dcommits\n\nI ask the question because, the problem of this kind of tricks is that they irremediably lead to the problem described here https://greenlet.readthedocs.io/en/stable/python_threads.html\n\nThis is the same thing that the problem observed with the oslo.messaging `heartbeat_in_pthread`.\n\nDepending on the state of service using oslo.concurrency, patched or not, this can lead to unexpected behaviour.\n\nAs this trick is strongly related to windows, should we not simply removed it?","commit_id":"2fe6b9290672734a4f86c1890a5b604f6b12fe9e"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f41fbc15aabdf5645836804649eb445e8c783635","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    # stdout/stderr when passing data through stdin. We need to make"},{"line_number":54,"context_line":"    # sure that *native* threads will be used as pipes are blocking"},{"line_number":55,"context_line":"    # on Windows."},{"line_number":56,"context_line":"    subprocess \u003d eventlet.patcher.original(\u0027subprocess\u0027)"},{"line_number":57,"context_line":"    subprocess.threading \u003d eventlet.patcher.original(\u0027threading\u0027)"},{"line_number":58,"context_line":"else:"},{"line_number":59,"context_line":"    import subprocess"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2b4eb189_0459a169","line":57,"range":{"start_line":56,"start_character":4,"end_line":57,"end_character":65},"in_reply_to":"1e5171e0_7db6308c","updated":"2024-11-14 11:05:53.000000000","message":"Ignore my comment, I missed your following patch. But in this case I do not see the needs of this patch.","commit_id":"2fe6b9290672734a4f86c1890a5b604f6b12fe9e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3fcf7cd7982ae43f07ac2cdf18b05a80f177800e","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    # stdout/stderr when passing data through stdin. We need to make"},{"line_number":54,"context_line":"    # sure that *native* threads will be used as pipes are blocking"},{"line_number":55,"context_line":"    # on Windows."},{"line_number":56,"context_line":"    subprocess \u003d eventlet.patcher.original(\u0027subprocess\u0027)"},{"line_number":57,"context_line":"    subprocess.threading \u003d eventlet.patcher.original(\u0027threading\u0027)"},{"line_number":58,"context_line":"else:"},{"line_number":59,"context_line":"    import subprocess"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2fdd8fa3_77226f4a","line":57,"range":{"start_line":56,"start_character":4,"end_line":57,"end_character":65},"in_reply_to":"2b4eb189_0459a169","updated":"2024-11-14 14:43:15.000000000","message":"I just kept the windows removal separate just in case it is controversial. We can squash these two if we want but it may not worth doing if we can merge these two quickly.","commit_id":"2fe6b9290672734a4f86c1890a5b604f6b12fe9e"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"32b6cfeadcd59938e8a8d7d051ca8b2d296a3138","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    # stdout/stderr when passing data through stdin. We need to make"},{"line_number":54,"context_line":"    # sure that *native* threads will be used as pipes are blocking"},{"line_number":55,"context_line":"    # on Windows."},{"line_number":56,"context_line":"    subprocess \u003d eventlet.patcher.original(\u0027subprocess\u0027)"},{"line_number":57,"context_line":"    subprocess.threading \u003d eventlet.patcher.original(\u0027threading\u0027)"},{"line_number":58,"context_line":"else:"},{"line_number":59,"context_line":"    import subprocess"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"51328d6b_79d864dc","line":57,"range":{"start_line":56,"start_character":4,"end_line":57,"end_character":65},"in_reply_to":"2fdd8fa3_77226f4a","updated":"2024-11-14 15:05:59.000000000","message":"Ah I see, indeed, that\u0027s a good idea. Thanks for doing that.","commit_id":"2fe6b9290672734a4f86c1890a5b604f6b12fe9e"}]}