)]}'
{"oslo_config/cfg.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"e81caeef342d2f1d62b96cb24cb57065cbf2f684","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"        namespace._parser._add_parsed_config_file(sections, normalized)"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"        for opt, group in sorted(self._conf._all_cli_opts(),"},{"line_number":1599,"context_line":"                                 key\u003dlambda x: x[0].name):"},{"line_number":1600,"context_line":"            group_name \u003d group.name if group is not None else None"},{"line_number":1601,"context_line":"            try:"},{"line_number":1602,"context_line":"                value \u003d opt._get_from_namespace(namespace, group_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_99fa72bc","line":1599,"updated":"2015-06-08 13:56:33.000000000","message":"According to the error, the issue that you can\u0027t compare this kind of object. I think adding the comparison methods would be cleaner.","commit_id":"6e7a6fd28b48c35f9e7f998e6e3e4e70218d7529"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fbae5ce2cd813d1c40d626eea4448790f7917cf9","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"        namespace._parser._add_parsed_config_file(sections, normalized)"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"        for opt, group in sorted(self._conf._all_cli_opts(),"},{"line_number":1599,"context_line":"                                 key\u003dlambda x: x[0].name):"},{"line_number":1600,"context_line":"            group_name \u003d group.name if group is not None else None"},{"line_number":1601,"context_line":"            try:"},{"line_number":1602,"context_line":"                value \u003d opt._get_from_namespace(namespace, group_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_b9852e08","line":1599,"in_reply_to":"3afb71cf_99fa72bc","updated":"2015-06-08 14:01:17.000000000","message":"If these objects are only compared at this line, it\u0027s simpler to use a key function than adding comparison methods.","commit_id":"6e7a6fd28b48c35f9e7f998e6e3e4e70218d7529"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"11f6c4d60878ef68982429ff7c54e685b9b3f37f","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"        namespace._parser._add_parsed_config_file(sections, normalized)"},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"        for opt, group in sorted(self._conf._all_cli_opts(),"},{"line_number":1599,"context_line":"                                 key\u003dlambda x: x[0].name):"},{"line_number":1600,"context_line":"            group_name \u003d group.name if group is not None else None"},{"line_number":1601,"context_line":"            try:"},{"line_number":1602,"context_line":"                value \u003d opt._get_from_namespace(namespace, group_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_79ac5635","line":1599,"in_reply_to":"3afb71cf_b9852e08","updated":"2015-06-08 14:07:36.000000000","message":"I don\u0027t think simpler is a correct argument, but I don\u0027t vehemently oppose neither. :p\n\nCan we also remove __lt__ then?","commit_id":"6e7a6fd28b48c35f9e7f998e6e3e4e70218d7529"}],"oslo_config/tests/test_cfg.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"4b1209ca11fecd79c477145806c34883873b4ee6","unresolved":false,"context_lines":[{"line_number":1434,"context_line":"    def test_conf_file_sorted_group(self):"},{"line_number":1435,"context_line":"        # Create enough groups for the sorted problem to appear"},{"line_number":1436,"context_line":"        for i in range(10):"},{"line_number":1437,"context_line":"            group1 \u003d cfg.OptGroup(\u0027group\u0027 + str(i), \u0027options\u0027)"},{"line_number":1438,"context_line":"            self.conf.register_group(group1)"},{"line_number":1439,"context_line":"            self.conf.register_cli_opt(cfg.StrOpt(\u0027opt1\u0027), group\u003dgroup1)"},{"line_number":1440,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_deb450f3","line":1437,"updated":"2015-06-08 13:41:32.000000000","message":"You should rename group1 to group.\n\nYou can replace \"group\"+str(i) with \"group%s\" % i.","commit_id":"098e2aee1c4ef8357309247abd55a8fee1399b19"}]}
