)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"4bac2979eec92a8868b6bacc97d22f2eb13b0d01","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add enforce_type option when setting an override"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027override\u0027 value of an option is currenty stored and retrieved"},{"line_number":10,"context_line":"with the exact value that is set through set_override method - not"},{"line_number":11,"context_line":"taking into account the type of that option. Sometimes we want the type"},{"line_number":12,"context_line":"of the override value to be the same as the option type and therefore"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_61f04d67","line":9,"updated":"2015-06-27 15:17:36.000000000","message":"s/currenty/currently","commit_id":"313287a57ac62cd1c653c9c7fde46f47a329dad8"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"59e837642e89b92edeec489f27d5a735c7ce8784","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add enforce_type option when setting an override"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The \u0027override\u0027 value of an option is currenty stored and retrieved"},{"line_number":10,"context_line":"with the exact value that is set through set_override method - not"},{"line_number":11,"context_line":"taking into account the type of that option. Sometimes we want the type"},{"line_number":12,"context_line":"of the override value to be the same as the option type and therefore"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_f1bbee0c","line":9,"in_reply_to":"fa32b979_61f04d67","updated":"2015-06-29 19:18:12.000000000","message":"Done","commit_id":"313287a57ac62cd1c653c9c7fde46f47a329dad8"}],"tests/test_cfg.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"ff080caf8a1c4417a917d88aa1ca6d97d2744251","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"        self.conf([])"},{"line_number":2516,"context_line":"        self.assertFalse(self.conf.blaa.foo)"},{"line_number":2517,"context_line":"        self.conf.clear_override(\u0027foo\u0027, group\u003d\u0027blaa\u0027)"},{"line_number":2518,"context_line":"        self.assertIsNone(self.conf.blaa.foo)"},{"line_number":2519,"context_line":""},{"line_number":2520,"context_line":""},{"line_number":2521,"context_line":"class ResetAndClearTestCase(BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_d2111755","line":2518,"updated":"2015-07-10 13:02:16.000000000","message":"Better add test for  StrOpt with parameter choices like :\n\n\n    def test_set_override_in_choices(self):\n        self.conf.register_group(cfg.OptGroup(\u0027f\u0027))\n        self.conf.register_cli_opt(cfg.StrOpt(\u0027oo\u0027, choices\u003d(\u0027a\u0027, \u0027b\u0027)),\n                                   group\u003d\u0027f\u0027)\n        self.conf.set_override(\u0027oo\u0027, \u0027b\u0027, \u0027f\u0027, enforce_type\u003dTrue)\n        self.assertEqual(\u0027b\u0027, self.conf.f.oo)\n\n    def test_set_override_not_in_choices(self):\n        self.conf.register_group(cfg.OptGroup(\u0027f\u0027))\n        self.conf.register_cli_opt(cfg.StrOpt(\u0027oo\u0027, choices\u003d(\u0027a\u0027, \u0027b\u0027)),\n                                   group\u003d\u0027f\u0027)\n        self.assertRaises(ValueError, self.conf.set_override, \u0027oo\u0027, \u0027c\u0027, \u0027f\u0027, True)","commit_id":"e9458be0cf43dad010fbd0ac6bd6fe036deb25e8"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"677c38109a55db12d1bebde6d99dfbb344f5ab6f","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"        self.conf([])"},{"line_number":2516,"context_line":"        self.assertFalse(self.conf.blaa.foo)"},{"line_number":2517,"context_line":"        self.conf.clear_override(\u0027foo\u0027, group\u003d\u0027blaa\u0027)"},{"line_number":2518,"context_line":"        self.assertIsNone(self.conf.blaa.foo)"},{"line_number":2519,"context_line":""},{"line_number":2520,"context_line":""},{"line_number":2521,"context_line":"class ResetAndClearTestCase(BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_af308e08","line":2518,"in_reply_to":"9a41bdd9_224850cc","updated":"2015-07-17 14:06:42.000000000","message":"Roxana,\n\nThink of it this way, enforce_type feature should work with choices attribute used typically with StrOpt and you are adding a test to make sure it does.\n\nAlso, it just so happens that with your patch, choices does report failure if enforce_type\u003dTrue and folks use \u0027c\u0027 instead of valid choices which are \u0027a\u0027 and \u0027b\u0027. However we need to makes sure this continues to work in the future as intended. Hence the request for additional tests.\n\nthanks,\ndims","commit_id":"e9458be0cf43dad010fbd0ac6bd6fe036deb25e8"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"8cc2f5ee501cd64de17e97312e653ce454639b9f","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"        self.conf([])"},{"line_number":2516,"context_line":"        self.assertFalse(self.conf.blaa.foo)"},{"line_number":2517,"context_line":"        self.conf.clear_override(\u0027foo\u0027, group\u003d\u0027blaa\u0027)"},{"line_number":2518,"context_line":"        self.assertIsNone(self.conf.blaa.foo)"},{"line_number":2519,"context_line":""},{"line_number":2520,"context_line":""},{"line_number":2521,"context_line":"class ResetAndClearTestCase(BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_003149ec","line":2518,"in_reply_to":"9a41bdd9_af308e08","updated":"2015-07-17 14:47:20.000000000","message":"Done","commit_id":"e9458be0cf43dad010fbd0ac6bd6fe036deb25e8"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"8cc2f5ee501cd64de17e97312e653ce454639b9f","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"        self.conf([])"},{"line_number":2516,"context_line":"        self.assertFalse(self.conf.blaa.foo)"},{"line_number":2517,"context_line":"        self.conf.clear_override(\u0027foo\u0027, group\u003d\u0027blaa\u0027)"},{"line_number":2518,"context_line":"        self.assertIsNone(self.conf.blaa.foo)"},{"line_number":2519,"context_line":""},{"line_number":2520,"context_line":""},{"line_number":2521,"context_line":"class ResetAndClearTestCase(BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_e03305f5","line":2518,"in_reply_to":"ba3cc151_d2111755","updated":"2015-07-17 14:47:20.000000000","message":"Done","commit_id":"e9458be0cf43dad010fbd0ac6bd6fe036deb25e8"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"7ab3ee5b2b67cb172a7add3090fcd2df7cb31054","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"        self.conf([])"},{"line_number":2516,"context_line":"        self.assertFalse(self.conf.blaa.foo)"},{"line_number":2517,"context_line":"        self.conf.clear_override(\u0027foo\u0027, group\u003d\u0027blaa\u0027)"},{"line_number":2518,"context_line":"        self.assertIsNone(self.conf.blaa.foo)"},{"line_number":2519,"context_line":""},{"line_number":2520,"context_line":""},{"line_number":2521,"context_line":"class ResetAndClearTestCase(BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_224850cc","line":2518,"in_reply_to":"ba3cc151_d2111755","updated":"2015-07-16 14:31:35.000000000","message":"I don\u0027t feel like this is really testing the set_override method with enforce_type set to True. I feel like the tests you suggested are testing \u0027choices\u0027 attribute for StrOpt, so I don\u0027t think it\u0027s related to my change. My tests should test converting the Opt to the right type when using set_override with enforce_type\u003dTrue.","commit_id":"e9458be0cf43dad010fbd0ac6bd6fe036deb25e8"}]}