)]}'
{"oslo_config/fixture.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ed4f5805e1467f517e4bcccf136dbfca22f98715","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def set_default(self, name, default, group\u003dNone):"},{"line_number":182,"context_line":"        \"\"\"Set a default value for an option."},{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        self.conf.set_default(name, default, group)"},{"line_number":185,"context_line":"        self.addCleanup(lambda: self.conf.clear_default(name, group))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_bd13bfb7","line":183,"updated":"2015-06-30 20:47:32.000000000","message":"Nit: For one line docstrings pep 257 says really-on-one-line. (https://www.python.org/dev/peps/pep-0257/#one-line-docstrings second bullet point)","commit_id":"118f76439f09961b58b5648ef41cde7a84a12e7b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6925c52e258dd33ecd04689dff19a9dc61218101","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def set_default(self, name, default, group\u003dNone):"},{"line_number":182,"context_line":"        \"\"\"Set a default value for an option."},{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        self.conf.set_default(name, default, group)"},{"line_number":185,"context_line":"        self.addCleanup(lambda: self.conf.clear_default(name, group))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_ae862711","line":183,"in_reply_to":"ba3cc151_bd13bfb7","updated":"2015-06-30 21:42:23.000000000","message":"Done","commit_id":"118f76439f09961b58b5648ef41cde7a84a12e7b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ed4f5805e1467f517e4bcccf136dbfca22f98715","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        \"\"\"Set a default value for an option."},{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        self.conf.set_default(name, default, group)"},{"line_number":185,"context_line":"        self.addCleanup(lambda: self.conf.clear_default(name, group))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_3dfa4f76","line":185,"updated":"2015-06-30 20:47:32.000000000","message":"There\u0027s no need for a lambda here unless you are allowing \u0027conf\u0027 to be rebound.\n\n self.addCleanup(self.conf.clear_default, name, group)","commit_id":"118f76439f09961b58b5648ef41cde7a84a12e7b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6925c52e258dd33ecd04689dff19a9dc61218101","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        \"\"\"Set a default value for an option."},{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":"        self.conf.set_default(name, default, group)"},{"line_number":185,"context_line":"        self.addCleanup(lambda: self.conf.clear_default(name, group))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_4e7e7b1a","line":185,"in_reply_to":"ba3cc151_3dfa4f76","updated":"2015-06-30 21:42:23.000000000","message":"Done","commit_id":"118f76439f09961b58b5648ef41cde7a84a12e7b"}],"oslo_config/tests/test_fixture.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"1c81fa30b095779cbf4d16820506658d30583131","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            default\u003d\u0027alternate_value\u0027,"},{"line_number":165,"context_line":"        )"},{"line_number":166,"context_line":"        self.assertEqual(\u0027alternate_value\u0027, conf.new_test_opt)"},{"line_number":167,"context_line":"        f.cleanUp()"},{"line_number":168,"context_line":"        self.assertEqual(\u0027initial_value\u0027, conf.new_test_opt)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_set_default_group(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_bdde5f0f","line":167,"updated":"2015-06-30 20:45:42.000000000","message":"So here again - this would be clearer perhaps as with, if _make_fixture() didn\u0027t call setUp:\n\n with f:\n     opt \u003d cfg.StrOpt(\u0027new_test_opt\u0027, default\u003d\u0027initial_value\u0027)\n     conf.register_opt(opt)\n     f.set_default(\t162\n            name\u003d\u0027new_test_opt\u0027,\t163\n            default\u003d\u0027alternate_value\u0027,\t164\n        )\n     self.assertEqual(\u0027alternate_value\u0027, conf.new_test_opt)\n\n self.assertEqual(\u0027initial_value\u0027, conf.new_test_opt)","commit_id":"118f76439f09961b58b5648ef41cde7a84a12e7b"}]}