)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a37beb4abbc2b7136fd1235c3e9721b824f795bc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"checking of the default value to the Opt and logged a warning. This"},{"line_number":11,"context_line":"change now raises an exception as per the comment in the original"},{"line_number":12,"context_line":"change."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9b806efc750009d64b08a5583449bebbf10e3fb4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_2a866fdb","line":13,"updated":"2015-09-28 21:33:11.000000000","message":"This needs a bug since it\u0027s a breaking change.","commit_id":"db8acef2b518cb1bd172f8a5aec31fd505ce4491"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"a4aeca2f17705e87193ad98f3b1d4d589b800190","unresolved":false,"context_lines":[{"line_number":10,"context_line":"checking of the default value to the Opt and logged a warning. This"},{"line_number":11,"context_line":"change now raises an exception as per the comment in the original"},{"line_number":12,"context_line":"change."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9b806efc750009d64b08a5583449bebbf10e3fb4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_e6aec7e6","line":13,"in_reply_to":"9a1a9d01_2a866fdb","updated":"2015-10-02 09:53:35.000000000","message":"Done","commit_id":"db8acef2b518cb1bd172f8a5aec31fd505ce4491"}],"oslo_config/cfg.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"dad3541b13df12e7180afea63178d906ea11535c","unresolved":false,"context_lines":[{"line_number":710,"context_line":"                and not self.type.is_base_type(self.default)):"},{"line_number":711,"context_line":"            expected_types \u003d \", \".join("},{"line_number":712,"context_line":"                [t.__name__ for t in self.type.BASE_TYPES])"},{"line_number":713,"context_line":"            raise AttributeError((\u0027Expected default value of type(s) \u0027"},{"line_number":714,"context_line":"                                  \u0027%(extypes)s but got %(default)r of \u0027"},{"line_number":715,"context_line":"                                  \u0027type %(deftypes)s\u0027) %"},{"line_number":716,"context_line":"                                 {\u0027extypes\u0027: expected_types,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_cfba7723","line":713,"updated":"2015-10-15 10:45:18.000000000","message":"Hum, it looks more to a TypeError, or maybe a ValueError, than an AttributeError to me.","commit_id":"b896b169895c62885fa606ee2ad4d5f2b1b1d5a9"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c794fe01e7658fd128ad673cc6c7f3b34772d9c6","unresolved":false,"context_lines":[{"line_number":710,"context_line":"                and not self.type.is_base_type(self.default)):"},{"line_number":711,"context_line":"            expected_types \u003d \", \".join("},{"line_number":712,"context_line":"                [t.__name__ for t in self.type.BASE_TYPES])"},{"line_number":713,"context_line":"            raise TypeError((\u0027Expected default value of type(s) \u0027"},{"line_number":714,"context_line":"                                  \u0027%(extypes)s but got %(default)r of \u0027"},{"line_number":715,"context_line":"                                  \u0027type %(deftypes)s\u0027) %"},{"line_number":716,"context_line":"                                 {\u0027extypes\u0027: expected_types,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_63025c71","line":713,"updated":"2015-10-15 12:04:54.000000000","message":"No need for double parenthesis here.","commit_id":"23cf1140086d7e79ecfeacd8c05bfe57f811efa0"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c794fe01e7658fd128ad673cc6c7f3b34772d9c6","unresolved":false,"context_lines":[{"line_number":711,"context_line":"            expected_types \u003d \", \".join("},{"line_number":712,"context_line":"                [t.__name__ for t in self.type.BASE_TYPES])"},{"line_number":713,"context_line":"            raise TypeError((\u0027Expected default value of type(s) \u0027"},{"line_number":714,"context_line":"                                  \u0027%(extypes)s but got %(default)r of \u0027"},{"line_number":715,"context_line":"                                  \u0027type %(deftypes)s\u0027) %"},{"line_number":716,"context_line":"                                 {\u0027extypes\u0027: expected_types,"},{"line_number":717,"context_line":"                                  \u0027default\u0027: self.default,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_a3087492","line":714,"updated":"2015-10-15 12:04:54.000000000","message":"The indentation is a little bit weird.","commit_id":"23cf1140086d7e79ecfeacd8c05bfe57f811efa0"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"5e91d690349afefac74e43d1c13ff10e24aec9ba","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        the name shown as the argument to a CLI option in --help output"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    .. py:attribute:: help"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"        a string explaining how the option\u0027s value is used"},{"line_number":676,"context_line":"    \"\"\""},{"line_number":677,"context_line":"    multi \u003d False"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_88099e86","line":674,"updated":"2015-10-16 10:56:11.000000000","message":"Can you please add here:\n\n.. versionchanged:: 2.6\n   An exception is now raised if the default value has the wrong type.","commit_id":"8b84d511dc684a2f78b67c5a1f2ca22c424cb0e1"}],"oslo_config/tests/test_cfg.py":[{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"2458dd19b172a50c4c2e8afbbe3bf6efc70a6fa7","unresolved":false,"context_lines":[{"line_number":943,"context_line":"        self.assertTrue(hasattr(self.conf, \u0027foo\u0027))"},{"line_number":944,"context_line":"        self.assertEqual(self.conf.foo, 666)"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    def test_conf_file_int_wrong_default(self):"},{"line_number":947,"context_line":"        self.assertRaises(AttributeError, cfg.IntOpt, \u0027foo\u0027, default\u003d\u0027666\u0027)"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    def test_conf_file_int_value(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_5ac07f2a","line":946,"updated":"2015-09-27 14:10:00.000000000","message":"by the way, can we change the name of this method to \"test_conf_file_int_default_wrong_type\", as float and list does.","commit_id":"db8acef2b518cb1bd172f8a5aec31fd505ce4491"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"a4aeca2f17705e87193ad98f3b1d4d589b800190","unresolved":false,"context_lines":[{"line_number":943,"context_line":"        self.assertTrue(hasattr(self.conf, \u0027foo\u0027))"},{"line_number":944,"context_line":"        self.assertEqual(self.conf.foo, 666)"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"    def test_conf_file_int_wrong_default(self):"},{"line_number":947,"context_line":"        self.assertRaises(AttributeError, cfg.IntOpt, \u0027foo\u0027, default\u003d\u0027666\u0027)"},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"    def test_conf_file_int_value(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_06ac1bec","line":946,"in_reply_to":"9a1a9d01_5ac07f2a","updated":"2015-10-02 09:53:35.000000000","message":"Done","commit_id":"db8acef2b518cb1bd172f8a5aec31fd505ce4491"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"a37beb4abbc2b7136fd1235c3e9721b824f795bc","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"                             \u0027but got %(default)r of type %(deftypes)s\u0027 %"},{"line_number":1095,"context_line":"                             {\u0027extypes\u0027: \u0027list\u0027,"},{"line_number":1096,"context_line":"                              \u0027default\u0027: 25,"},{"line_number":1097,"context_line":"                              \u0027deftypes\u0027: \u0027int\u0027}, str(ae))"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    def test_conf_file_list_value(self):"},{"line_number":1100,"context_line":"        self.conf.register_opt(cfg.ListOpt(\u0027foo\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_6acea72f","line":1097,"updated":"2015-09-28 21:33:11.000000000","message":"suggest use assertRaises rather than reimplement it, or assertRaisesRegex if you\u0027re ok with regex matching instead.","commit_id":"db8acef2b518cb1bd172f8a5aec31fd505ce4491"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"a4aeca2f17705e87193ad98f3b1d4d589b800190","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"                             \u0027but got %(default)r of type %(deftypes)s\u0027 %"},{"line_number":1095,"context_line":"                             {\u0027extypes\u0027: \u0027list\u0027,"},{"line_number":1096,"context_line":"                              \u0027default\u0027: 25,"},{"line_number":1097,"context_line":"                              \u0027deftypes\u0027: \u0027int\u0027}, str(ae))"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    def test_conf_file_list_value(self):"},{"line_number":1100,"context_line":"        self.conf.register_opt(cfg.ListOpt(\u0027foo\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_c6b5c331","line":1097,"in_reply_to":"9a1a9d01_6acea72f","updated":"2015-10-02 09:53:35.000000000","message":"Done","commit_id":"db8acef2b518cb1bd172f8a5aec31fd505ce4491"}]}
