)]}'
{"oslo_config/cfg.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"88e9b490ff25958194f260a4249940209cdee99a","unresolved":false,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"class URLOpt(Opt):"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    \"\"\"Opt with IPAddress type"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"    Option with ``type`` :class:`oslo_config.types.IPAddress`"},{"line_number":1116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_3bb02343","line":1113,"updated":"2015-10-04 21:49:52.000000000","message":"s/IPAddress/ URL","commit_id":"b4c6da0a75be7ee134f2c5c08b6ebc5a70ee84bf"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"fe5ded00de0f96540bb63c249ba811e6481ff947","unresolved":false,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"class URLOpt(Opt):"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    \"\"\"Opt with IPAddress type"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"    Option with ``type`` :class:`oslo_config.types.IPAddress`"},{"line_number":1116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_8fb6c988","line":1113,"in_reply_to":"9a1a9d01_3bb02343","updated":"2015-10-05 07:04:54.000000000","message":"Good catch. I forgot to fix it.","commit_id":"b4c6da0a75be7ee134f2c5c08b6ebc5a70ee84bf"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"88e9b490ff25958194f260a4249940209cdee99a","unresolved":false,"context_lines":[{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    \"\"\"Opt with IPAddress type"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"    Option with ``type`` :class:`oslo_config.types.IPAddress`"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    :param version: one of either ``4``, ``6``, or ``None`` to specify"},{"line_number":1118,"context_line":"       either version."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5bab97d6","line":1115,"updated":"2015-10-04 21:49:52.000000000","message":"s/types.IPAddress/types.URL","commit_id":"b4c6da0a75be7ee134f2c5c08b6ebc5a70ee84bf"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"fe5ded00de0f96540bb63c249ba811e6481ff947","unresolved":false,"context_lines":[{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    \"\"\"Opt with IPAddress type"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"    Option with ``type`` :class:`oslo_config.types.IPAddress`"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    :param version: one of either ``4``, ``6``, or ``None`` to specify"},{"line_number":1118,"context_line":"       either version."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_afb94d7b","line":1115,"in_reply_to":"9a1a9d01_5bab97d6","updated":"2015-10-05 07:04:54.000000000","message":"Done","commit_id":"b4c6da0a75be7ee134f2c5c08b6ebc5a70ee84bf"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"4e39f841d31135f833e73b74862a1bbc63af5279","unresolved":false,"context_lines":[{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"class URIOpt(Opt):"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    \"\"\"Opt with URI type"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"    Option with ``type`` :class:`oslo_config.types.URI`"},{"line_number":1119,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_0f1710ee","line":1116,"updated":"2015-10-15 10:27:28.000000000","message":"Please mention \"Value will be validated as RFC 3986.\" or add a link to URI type document.","commit_id":"5e678a0ae3f7d8a8a7aa64b79544f2e17a1174b8"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"4e39f841d31135f833e73b74862a1bbc63af5279","unresolved":false,"context_lines":[{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    \"\"\"Opt with URI type"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"    Option with ``type`` :class:`oslo_config.types.URI`"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    \"\"\""},{"line_number":1121,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_4f6f4892","line":1118,"updated":"2015-10-15 10:27:28.000000000","message":"You should add:\n\n.. versionadded:: 2.6\n\nFor the generated documentation.\n\nFYI I wrote the change Ieb8b3cbb1cb71a98cb714c410635b5c45f1afb08 to add versionadded/versionchanged in the whole oslo.config module.","commit_id":"5e678a0ae3f7d8a8a7aa64b79544f2e17a1174b8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"15ae34b6ce46bb92944f71b36e61320f437af356","unresolved":false,"context_lines":[{"line_number":1271,"context_line":"    \"\"\"Opt with URI type"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"    Option with ``type`` :class:`oslo_config.types.URI`"},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"    \"\"\""},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"    def __init__(self, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_88d1425a","line":1274,"updated":"2016-04-18 22:15:08.000000000","message":"needs .. versionadded:: \u003cwhatever\u003e","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"137b5e75b5843999b69a241324410817ca66c7f1","unresolved":false,"context_lines":[{"line_number":1271,"context_line":"    \"\"\"Opt with URI type"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"    Option with ``type`` :class:`oslo_config.types.URI`"},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"    \"\"\""},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"    def __init__(self, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_9885f008","line":1274,"in_reply_to":"1a122d0e_88d1425a","updated":"2016-05-14 02:36:09.000000000","message":"Done","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"f78466765e59dcf927f305eb7cead7c7f8dec7ed","unresolved":false,"context_lines":[{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"    Option with ``type`` :class:`oslo_config.types.URI`"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"    .. versionadded:: 3.9"},{"line_number":1278,"context_line":"    \"\"\""},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"    def __init__(self, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_0ecd515d","line":1277,"range":{"start_line":1277,"start_character":22,"end_line":1277,"end_character":25},"updated":"2016-05-30 12:28:02.000000000","message":"this should be 3.10 now, use git tag to get latest tag name.","commit_id":"43d31d4eee0d8b4caf7547b2ab515c8540d04c31"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"f178c39b1cf0f4439d7fa535e0923b61a8077c0d","unresolved":false,"context_lines":[{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"    Option with ``type`` :class:`oslo_config.types.URI`"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"    .. versionadded:: 3.10"},{"line_number":1278,"context_line":"    \"\"\""},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"    def __init__(self, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9abb7d3a_a4640ae5","line":1277,"range":{"start_line":1277,"start_character":24,"end_line":1277,"end_character":26},"updated":"2016-05-31 04:38:51.000000000","message":"sorry , this should be 3.11 now, we just released 3.10.","commit_id":"ed704f957495aba8d401183e7522cb5665f6b697"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"41b908b3f427db6162f87dc81d0aa6777017597a","unresolved":false,"context_lines":[{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"    Option with ``type`` :class:`oslo_config.types.URI`"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"    .. versionadded:: 3.10"},{"line_number":1278,"context_line":"    \"\"\""},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"    def __init__(self, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9abb7d3a_4161cb38","line":1277,"range":{"start_line":1277,"start_character":24,"end_line":1277,"end_character":26},"in_reply_to":"9abb7d3a_a4640ae5","updated":"2016-05-31 07:18:18.000000000","message":"Thanks!","commit_id":"ed704f957495aba8d401183e7522cb5665f6b697"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"40df0600e50efb24c40df39efd32fdfadec2d54f","unresolved":false,"context_lines":[{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"    Option with ``type`` :class:`oslo_config.types.URI`"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"    .. versionadded:: 3.11"},{"line_number":1278,"context_line":"    \"\"\""},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"    def __init__(self, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_6ee56bda","line":1277,"updated":"2016-06-14 16:54:52.000000000","message":"3.11 was released on 9 June 2016. Should probably update this and then gently ping cores on IRC to merge this before 3.12 or 3.13.","commit_id":"ead47180580d51cd7882bc6dec9a0a274e22875d"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"95d3721a91eb6e27a245801621423fa3dec96052","unresolved":false,"context_lines":[{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"    Option with ``type`` :class:`oslo_config.types.URI`"},{"line_number":1276,"context_line":""},{"line_number":1277,"context_line":"    .. versionadded:: 3.11"},{"line_number":1278,"context_line":"    \"\"\""},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"    def __init__(self, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7aa08908_2551ab62","line":1277,"in_reply_to":"7aa08908_6ee56bda","updated":"2016-06-15 02:48:11.000000000","message":"yes, need update this.","commit_id":"ead47180580d51cd7882bc6dec9a0a274e22875d"}],"oslo_config/generator.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"d910a9d2a4891780d68a937156954f75282230ff","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        elif (isinstance(opt, cfg.StrOpt) or"},{"line_number":81,"context_line":"              isinstance(opt, cfg.IPOpt) or"},{"line_number":82,"context_line":"              isinstance(opt, cfg.HostnameOpt) or"},{"line_number":83,"context_line":"              isinstance(opt, cfg.URIOpt)):"},{"line_number":84,"context_line":"            default_str \u003d opt.default"},{"line_number":85,"context_line":"        elif isinstance(opt, cfg.BoolOpt):"},{"line_number":86,"context_line":"            default_str \u003d str(opt.default).lower()"}],"source_content_type":"text/x-python","patch_set":18,"id":"9abb7d3a_c3165bf0","line":83,"range":{"start_line":83,"start_character":34,"end_line":83,"end_character":40},"updated":"2016-05-31 09:09:14.000000000","message":"Hum, we can replace the 4 calls to isinstance with a single call using a tuple: isinstance(opt, (cfg.StrOpt, cfg.IPOpt, ...)).","commit_id":"4eec9fd0ba5156a23ab4d71724c4c6e9c069e824"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"da370c5da4a808e06b85921f9e9bd6c904761ff2","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        elif (isinstance(opt, cfg.StrOpt) or"},{"line_number":81,"context_line":"              isinstance(opt, cfg.IPOpt) or"},{"line_number":82,"context_line":"              isinstance(opt, cfg.HostnameOpt) or"},{"line_number":83,"context_line":"              isinstance(opt, cfg.URIOpt)):"},{"line_number":84,"context_line":"            default_str \u003d opt.default"},{"line_number":85,"context_line":"        elif isinstance(opt, cfg.BoolOpt):"},{"line_number":86,"context_line":"            default_str \u003d str(opt.default).lower()"}],"source_content_type":"text/x-python","patch_set":18,"id":"9abb7d3a_b3c6d297","line":83,"range":{"start_line":83,"start_character":34,"end_line":83,"end_character":40},"in_reply_to":"9abb7d3a_c3165bf0","updated":"2016-06-01 00:34:33.000000000","message":"Good point.","commit_id":"4eec9fd0ba5156a23ab4d71724c4c6e9c069e824"}],"oslo_config/tests/test_cfg.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"8b68a6d563e3a73216c31ddf699daaccfbcbdb96","unresolved":false,"context_lines":[{"line_number":623,"context_line":"                          [\u0027key1:blaa,key2:bar\u0027],"},{"line_number":624,"context_line":"                          {\u0027key1\u0027: \u0027blaa\u0027, \u0027key2\u0027: \u0027bar\u0027})"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def test_positional_uri_arg(self):"},{"line_number":627,"context_line":"        self._do_pos_test(cfg.URIOpt, \"http://example.com\", [],"},{"line_number":628,"context_line":"                          \"http://example.com\")"},{"line_number":629,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_195ed9e9","line":626,"updated":"2015-10-05 23:46:48.000000000","message":"The test name is a little misleading.  The _arg indicating it should test the args parameter, but you have passed an empty list [].\n\nAlso, why not have a test for default and non_default?","commit_id":"ee503ad328143be51405317f0aac4428c42ced5d"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"b64923bc546f6e05bd259f0036a510cec11dbe2b","unresolved":false,"context_lines":[{"line_number":623,"context_line":"                          [\u0027key1:blaa,key2:bar\u0027],"},{"line_number":624,"context_line":"                          {\u0027key1\u0027: \u0027blaa\u0027, \u0027key2\u0027: \u0027bar\u0027})"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def test_positional_uri_arg(self):"},{"line_number":627,"context_line":"        self._do_pos_test(cfg.URIOpt, \"http://example.com\", [],"},{"line_number":628,"context_line":"                          \"http://example.com\")"},{"line_number":629,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_cb8964cc","line":626,"in_reply_to":"7a2fa921_195ed9e9","updated":"2015-10-06 00:49:52.000000000","message":"Thank you for comment.\nI will remove this and add tests for default and non_default.","commit_id":"ee503ad328143be51405317f0aac4428c42ced5d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7bf9ed69f6968bb93d236e92f95ad9dd254ebf6e","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    multi_int \u003d functools.partial(cfg.MultiOpt, item_type\u003dtypes.Integer())"},{"line_number":292,"context_line":"    multi_float \u003d functools.partial(cfg.MultiOpt, item_type\u003dtypes.Float())"},{"line_number":293,"context_line":"    multi_string \u003d functools.partial(cfg.MultiOpt, item_type\u003dtypes.String())"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    scenarios \u003d ["},{"line_number":296,"context_line":"        (\u0027str_default\u0027,"},{"line_number":297,"context_line":"         dict(opt_class\u003dcfg.StrOpt, default\u003dNone, cli_args\u003d[], value\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_146f49c6","line":294,"updated":"2015-10-07 00:36:23.000000000","message":"URIOpt should probably be added to the scenarios here.","commit_id":"42bc2aaf5d0b7cfe0180f2c3fd98b1044a5b5521"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"20cde230380cdba11fbccf596c24507fdcbc1a1f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    multi_int \u003d functools.partial(cfg.MultiOpt, item_type\u003dtypes.Integer())"},{"line_number":292,"context_line":"    multi_float \u003d functools.partial(cfg.MultiOpt, item_type\u003dtypes.Float())"},{"line_number":293,"context_line":"    multi_string \u003d functools.partial(cfg.MultiOpt, item_type\u003dtypes.String())"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    scenarios \u003d ["},{"line_number":296,"context_line":"        (\u0027str_default\u0027,"},{"line_number":297,"context_line":"         dict(opt_class\u003dcfg.StrOpt, default\u003dNone, cli_args\u003d[], value\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_0fa09242","line":294,"in_reply_to":"7a2fa921_146f49c6","updated":"2015-10-07 01:56:31.000000000","message":"I see.","commit_id":"42bc2aaf5d0b7cfe0180f2c3fd98b1044a5b5521"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7bf9ed69f6968bb93d236e92f95ad9dd254ebf6e","unresolved":false,"context_lines":[{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def test_positional_uri_none_default(self):"},{"line_number":631,"context_line":"        self._do_pos_test(cfg.URIOpt, None, [], None)"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    def test_positional_multistr_none_default(self):"},{"line_number":634,"context_line":"        self._do_pos_test(cfg.MultiStrOpt, None, [], None)"},{"line_number":635,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_345b6530","line":632,"updated":"2015-10-07 00:36:23.000000000","message":"Why no test for test_positional_uri_arg?","commit_id":"42bc2aaf5d0b7cfe0180f2c3fd98b1044a5b5521"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"20cde230380cdba11fbccf596c24507fdcbc1a1f","unresolved":false,"context_lines":[{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    def test_positional_uri_none_default(self):"},{"line_number":631,"context_line":"        self._do_pos_test(cfg.URIOpt, None, [], None)"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    def test_positional_multistr_none_default(self):"},{"line_number":634,"context_line":"        self._do_pos_test(cfg.MultiStrOpt, None, [], None)"},{"line_number":635,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_8f94a2e2","line":632,"in_reply_to":"7a2fa921_345b6530","updated":"2015-10-07 01:56:31.000000000","message":"Done","commit_id":"42bc2aaf5d0b7cfe0180f2c3fd98b1044a5b5521"}],"oslo_config/tests/test_generator.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"04b45fd10a1e8858cb43f3a20a9fc7cc2448cde6","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                                        help\u003d\u0027a hostname\u0027),"},{"line_number":148,"context_line":"        \u0027uri_opt\u0027: cfg.URIOpt(\u0027uri_opt\u0027,"},{"line_number":149,"context_line":"                              default\u003d\u0027http://example.com\u0027,"},{"line_number":150,"context_line":"                              help\u003d\u0027a hostname\u0027),"},{"line_number":151,"context_line":"        \u0027multi_opt\u0027: cfg.MultiStrOpt(\u0027multi_opt\u0027,"},{"line_number":152,"context_line":"                                     default\u003d[\u00271\u0027, \u00272\u0027, \u00273\u0027],"},{"line_number":153,"context_line":"                                     help\u003d\u0027multiple strings\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a18252c_c3d7f521","line":150,"updated":"2016-04-12 08:24:05.000000000","message":"Hostname, really? I don\u0027t recall using an URL to identify a hostname. I guess that you mean \"an url\"?","commit_id":"4647186ecd2ee249dbe1d3799522655322f5aec8"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"15ae34b6ce46bb92944f71b36e61320f437af356","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                                        help\u003d\u0027a hostname\u0027),"},{"line_number":148,"context_line":"        \u0027uri_opt\u0027: cfg.URIOpt(\u0027uri_opt\u0027,"},{"line_number":149,"context_line":"                              default\u003d\u0027http://example.com\u0027,"},{"line_number":150,"context_line":"                              help\u003d\u0027a hostname\u0027),"},{"line_number":151,"context_line":"        \u0027multi_opt\u0027: cfg.MultiStrOpt(\u0027multi_opt\u0027,"},{"line_number":152,"context_line":"                                     default\u003d[\u00271\u0027, \u00272\u0027, \u00273\u0027],"},{"line_number":153,"context_line":"                                     help\u003d\u0027multiple strings\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_68d78623","line":150,"range":{"start_line":150,"start_character":38,"end_line":150,"end_character":46},"updated":"2016-04-18 22:15:08.000000000","message":"URI","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"137b5e75b5843999b69a241324410817ca66c7f1","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                                        help\u003d\u0027a hostname\u0027),"},{"line_number":148,"context_line":"        \u0027uri_opt\u0027: cfg.URIOpt(\u0027uri_opt\u0027,"},{"line_number":149,"context_line":"                              default\u003d\u0027http://example.com\u0027,"},{"line_number":150,"context_line":"                              help\u003d\u0027a hostname\u0027),"},{"line_number":151,"context_line":"        \u0027multi_opt\u0027: cfg.MultiStrOpt(\u0027multi_opt\u0027,"},{"line_number":152,"context_line":"                                     default\u003d[\u00271\u0027, \u00272\u0027, \u00273\u0027],"},{"line_number":153,"context_line":"                                     help\u003d\u0027multiple strings\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_3877a43b","line":150,"range":{"start_line":150,"start_character":38,"end_line":150,"end_character":46},"in_reply_to":"1a122d0e_68d78623","updated":"2016-05-14 02:36:09.000000000","message":"Done","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"}],"oslo_config/tests/test_types.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"15ae34b6ce46bb92944f71b36e61320f437af356","unresolved":false,"context_lines":[{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def test_uri(self):"},{"line_number":628,"context_line":"        self.assertConvertedValue(\u0027http://example.com\u0027, \u0027http://example.com\u0027)"},{"line_number":629,"context_line":"        self.assertInvalid(\u0027invalid\u0027)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def test_repr(self):"},{"line_number":632,"context_line":"        self.assertEqual(\u0027URI\u0027, repr(types.URI()))"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_28c58e5a","line":629,"updated":"2016-04-18 22:15:08.000000000","message":"there should be a comment explaining why the value is invalid.","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"137b5e75b5843999b69a241324410817ca66c7f1","unresolved":false,"context_lines":[{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    def test_uri(self):"},{"line_number":628,"context_line":"        self.assertConvertedValue(\u0027http://example.com\u0027, \u0027http://example.com\u0027)"},{"line_number":629,"context_line":"        self.assertInvalid(\u0027invalid\u0027)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def test_repr(self):"},{"line_number":632,"context_line":"        self.assertEqual(\u0027URI\u0027, repr(types.URI()))"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_d89e5853","line":629,"in_reply_to":"1a122d0e_28c58e5a","updated":"2016-05-14 02:36:09.000000000","message":"Done","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"d910a9d2a4891780d68a937156954f75282230ff","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    def test_uri(self):"},{"line_number":646,"context_line":"        self.assertConvertedValue(\u0027http://example.com\u0027, \u0027http://example.com\u0027)"},{"line_number":647,"context_line":"        self.assertInvalid(\u0027invalid\u0027)  # it doesn\u0027t include a scheme"},{"line_number":648,"context_line":"        self.assertInvalid(\u0027http://\u0027)  # it doesn\u0027t include a authority"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def test_repr(self):"},{"line_number":651,"context_line":"        self.assertEqual(\u0027URI\u0027, repr(types.URI()))"}],"source_content_type":"text/x-python","patch_set":18,"id":"9abb7d3a_63b5efec","line":648,"range":{"start_line":648,"start_character":60,"end_line":648,"end_character":61},"updated":"2016-05-31 09:09:14.000000000","message":"typo, an authority?","commit_id":"4eec9fd0ba5156a23ab4d71724c4c6e9c069e824"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"da370c5da4a808e06b85921f9e9bd6c904761ff2","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    def test_uri(self):"},{"line_number":646,"context_line":"        self.assertConvertedValue(\u0027http://example.com\u0027, \u0027http://example.com\u0027)"},{"line_number":647,"context_line":"        self.assertInvalid(\u0027invalid\u0027)  # it doesn\u0027t include a scheme"},{"line_number":648,"context_line":"        self.assertInvalid(\u0027http://\u0027)  # it doesn\u0027t include a authority"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def test_repr(self):"},{"line_number":651,"context_line":"        self.assertEqual(\u0027URI\u0027, repr(types.URI()))"}],"source_content_type":"text/x-python","patch_set":18,"id":"9abb7d3a_333942a5","line":648,"range":{"start_line":648,"start_character":60,"end_line":648,"end_character":61},"in_reply_to":"9abb7d3a_63b5efec","updated":"2016-06-01 00:34:33.000000000","message":"I made a mistake.","commit_id":"4eec9fd0ba5156a23ab4d71724c4c6e9c069e824"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"41e1bfdfaf1f6d505048fa4e583a16020f84e678","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    def test_uri(self):"},{"line_number":646,"context_line":"        self.assertConvertedValue(\u0027http://example.com\u0027, \u0027http://example.com\u0027)"},{"line_number":647,"context_line":"        self.assertInvalid(\u0027invalid\u0027)  # it doesn\u0027t include a scheme"},{"line_number":648,"context_line":"        self.assertInvalid(\u0027http://\u0027)  # it doesn\u0027t include a authority"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def test_repr(self):"},{"line_number":651,"context_line":"        self.assertEqual(\u0027URI\u0027, repr(types.URI()))"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_e0b3ade7","line":648,"range":{"start_line":648,"start_character":60,"end_line":648,"end_character":61},"updated":"2016-06-07 07:08:22.000000000","message":"s/a/an","commit_id":"c0863091d76ae0c7b1d0f9e4708d7e8d31078adb"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"1330e78b5df8f3b0ef1d179bc592e1f2398e28f2","unresolved":false,"context_lines":[{"line_number":645,"context_line":"    def test_uri(self):"},{"line_number":646,"context_line":"        self.assertConvertedValue(\u0027http://example.com\u0027, \u0027http://example.com\u0027)"},{"line_number":647,"context_line":"        self.assertInvalid(\u0027invalid\u0027)  # it doesn\u0027t include a scheme"},{"line_number":648,"context_line":"        self.assertInvalid(\u0027http://\u0027)  # it doesn\u0027t include a authority"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def test_repr(self):"},{"line_number":651,"context_line":"        self.assertEqual(\u0027URI\u0027, repr(types.URI()))"}],"source_content_type":"text/x-python","patch_set":19,"id":"7aa08908_ac66784e","line":648,"range":{"start_line":648,"start_character":60,"end_line":648,"end_character":61},"in_reply_to":"7aa08908_e0b3ade7","updated":"2016-06-08 07:34:56.000000000","message":"Thank you.","commit_id":"c0863091d76ae0c7b1d0f9e4708d7e8d31078adb"}],"oslo_config/types.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"88e9b490ff25958194f260a4249940209cdee99a","unresolved":false,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    \"\"\"URL type"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    Represents URL."},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    \"\"\""},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_fbb94b2f","line":442,"updated":"2015-10-04 21:49:52.000000000","message":"This doesn\u0027t really say much.","commit_id":"b4c6da0a75be7ee134f2c5c08b6ebc5a70ee84bf"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"fe5ded00de0f96540bb63c249ba811e6481ff947","unresolved":false,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    \"\"\"URL type"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    Represents URL."},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    \"\"\""},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_cf636119","line":442,"in_reply_to":"9a1a9d01_fbb94b2f","updated":"2015-10-05 07:04:54.000000000","message":"I will add some description.","commit_id":"b4c6da0a75be7ee134f2c5c08b6ebc5a70ee84bf"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"4e39f841d31135f833e73b74862a1bbc63af5279","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    \"\"\"URI type"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    Represents URI. Value will be validated as RFC 3986."},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"    \"\"\""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    BASE_TYPES \u003d six.string_types"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a2ca52d_cf3038a1","line":468,"updated":"2015-10-15 10:27:28.000000000","message":"You should add \".. versionadded:: 2.6\".","commit_id":"5e678a0ae3f7d8a8a7aa64b79544f2e17a1174b8"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"04b45fd10a1e8858cb43f3a20a9fc7cc2448cde6","unresolved":false,"context_lines":[{"line_number":667,"context_line":"    BASE_TYPES \u003d six.string_types"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def __call__(self, value):"},{"line_number":670,"context_line":"        value \u003d str(value)"},{"line_number":671,"context_line":"        if not value:"},{"line_number":672,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":673,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a18252c_c3ba55c0","line":670,"updated":"2016-04-12 08:24:05.000000000","message":"Hum, I\u0027m not sure that it\u0027s the best choice to accept Unicode on Python 2. Do you want to support Unicode URI on Python 2?","commit_id":"4647186ecd2ee249dbe1d3799522655322f5aec8"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"65567e40324c8d001587b049ce1cb1ee47117895","unresolved":false,"context_lines":[{"line_number":667,"context_line":"    BASE_TYPES \u003d six.string_types"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def __call__(self, value):"},{"line_number":670,"context_line":"        value \u003d str(value)"},{"line_number":671,"context_line":"        if not value:"},{"line_number":672,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":673,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a18252c_669a3765","line":670,"in_reply_to":"5a18252c_c3ba55c0","updated":"2016-04-13 07:17:50.000000000","message":"Thank you for your comment.\nI will fix it not to use str() same as other types.","commit_id":"4647186ecd2ee249dbe1d3799522655322f5aec8"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"04b45fd10a1e8858cb43f3a20a9fc7cc2448cde6","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        return \"URI\""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def __eq__(self, other):"},{"line_number":681,"context_line":"        return self.__class__ \u003d\u003d other.__class__"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a18252c_83733d4d","line":681,"range":{"start_line":681,"start_character":20,"end_line":681,"end_character":29},"updated":"2016-04-12 08:24:05.000000000","message":"This __eq__() method is a little bit strange, it doesn\u0027t test the value, only the type. But it looks like many other config types use the same method body, so I think that it\u0027s ok.","commit_id":"4647186ecd2ee249dbe1d3799522655322f5aec8"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"65567e40324c8d001587b049ce1cb1ee47117895","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        return \"URI\""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def __eq__(self, other):"},{"line_number":681,"context_line":"        return self.__class__ \u003d\u003d other.__class__"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a18252c_06ba63c0","line":681,"range":{"start_line":681,"start_character":20,"end_line":681,"end_character":29},"in_reply_to":"5a18252c_83733d4d","updated":"2016-04-13 07:17:50.000000000","message":"I think URI string should be compared here.","commit_id":"4647186ecd2ee249dbe1d3799522655322f5aec8"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e4f37808ddd629a64259927ef953d3dd8a934620","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        return \"URI\""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def __eq__(self, other):"},{"line_number":681,"context_line":"        return self.value \u003d\u003d other.value"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a18252c_b57d931e","line":681,"updated":"2016-04-13 08:56:19.000000000","message":"Hum, you should still compare the type (or obj.__class__), otherwise you get an attribute error. For example, try to compare an URI to an integer.","commit_id":"f84cd97cc0870004a98ee6cfece3d0e753dd0866"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"513edf86ac85fccd2c3725f2a6613a3a262657ee","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        return \"URI\""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def __eq__(self, other):"},{"line_number":681,"context_line":"        return self.value \u003d\u003d other.value"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a18252c_f54a6bc4","line":681,"in_reply_to":"5a18252c_b57d931e","updated":"2016-04-13 08:58:01.000000000","message":"Unit tests fail on Python 3.4 because the .value attribute is not set. I suggest to restore the previous implementaton of __eq__() (self.__class__ \u003d\u003d other.__class__).","commit_id":"f84cd97cc0870004a98ee6cfece3d0e753dd0866"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"68f0dbd69328201301e00cd148c78b98867cff73","unresolved":false,"context_lines":[{"line_number":678,"context_line":"        return \"URI\""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def __eq__(self, other):"},{"line_number":681,"context_line":"        return self.value \u003d\u003d other.value"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a18252c_bd038841","line":681,"in_reply_to":"5a18252c_f54a6bc4","updated":"2016-04-14 00:25:00.000000000","message":"It is my mistake. I will fix it.\nThank you for your comment.","commit_id":"f84cd97cc0870004a98ee6cfece3d0e753dd0866"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"756ac16ca68a2ffa346db41bf505b03d45899a2a","unresolved":false,"context_lines":[{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    \"\"\"URI type"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    Represents URI. Value will be validated as RFC 3986."},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a18252c_de89f527","line":663,"updated":"2016-04-14 14:38:32.000000000","message":"There are many ways a URI may be valid. The documentation here should list what you\u0027re validating. I would suggest that this should say:\n\n    \"\"\"Type representing a URI.\n\n    Valid URIs must contain a scheme (e.g, ``http://``), and an\n    authority (e.g., ``localhost:8080``).\n    \"\"\"\n\nIf possible (and consistent with the rest of oslo.config) this might also want to allow the user to specify whether a scheme and path are required. I can see a case where a library might want to supply it\u0027s own scheme but require a path for Keystone, e.g., wanting the user to supply something like ``10.239.0.10:5000/v2`` instead of ``http://10.239.0.10:5000`` or likewise.","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"15ae34b6ce46bb92944f71b36e61320f437af356","unresolved":false,"context_lines":[{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    BASE_TYPES \u003d six.string_types"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def __call__(self, value):"},{"line_number":670,"context_line":"        self.value \u003d value"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_e8fef636","line":667,"updated":"2016-04-18 22:15:08.000000000","message":"what is this doing here?","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"137b5e75b5843999b69a241324410817ca66c7f1","unresolved":false,"context_lines":[{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    BASE_TYPES \u003d six.string_types"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def __call__(self, value):"},{"line_number":670,"context_line":"        self.value \u003d value"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_f8d19cfc","line":667,"in_reply_to":"1a122d0e_e8fef636","updated":"2016-05-14 02:36:09.000000000","message":"It doesn\u0027t make sense.\nI will remove it.","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"15ae34b6ce46bb92944f71b36e61320f437af356","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def __call__(self, value):"},{"line_number":670,"context_line":"        self.value \u003d value"},{"line_number":671,"context_line":"        if len(value) \u003d\u003d 0:"},{"line_number":672,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":673,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue):"},{"line_number":674,"context_line":"            raise ValueError(\u0027invalid URI\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_e878b62d","line":671,"updated":"2016-04-18 22:15:08.000000000","message":"Add a comment why this check is needed.","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"137b5e75b5843999b69a241324410817ca66c7f1","unresolved":false,"context_lines":[{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def __call__(self, value):"},{"line_number":670,"context_line":"        self.value \u003d value"},{"line_number":671,"context_line":"        if len(value) \u003d\u003d 0:"},{"line_number":672,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":673,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue):"},{"line_number":674,"context_line":"            raise ValueError(\u0027invalid URI\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_b8355447","line":671,"in_reply_to":"1a122d0e_e878b62d","updated":"2016-05-14 02:36:09.000000000","message":"The message in L672 shows the reason. Isn\u0027t it enough?","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"15ae34b6ce46bb92944f71b36e61320f437af356","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        if len(value) \u003d\u003d 0:"},{"line_number":672,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":673,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue):"},{"line_number":674,"context_line":"            raise ValueError(\u0027invalid URI\u0027)"},{"line_number":675,"context_line":"        return value"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_08a532a1","line":674,"updated":"2016-04-18 22:15:08.000000000","message":"typically the value is put in the string (see line 640, etc.","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"137b5e75b5843999b69a241324410817ca66c7f1","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        if len(value) \u003d\u003d 0:"},{"line_number":672,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":673,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue):"},{"line_number":674,"context_line":"            raise ValueError(\u0027invalid URI\u0027)"},{"line_number":675,"context_line":"        return value"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_d82138fe","line":674,"in_reply_to":"1a122d0e_08a532a1","updated":"2016-05-14 02:36:09.000000000","message":"Done","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"15ae34b6ce46bb92944f71b36e61320f437af356","unresolved":false,"context_lines":[{"line_number":675,"context_line":"        return value"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def __repr__(self):"},{"line_number":678,"context_line":"        return \"URI\""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def __eq__(self, other):"},{"line_number":681,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_c8b17ae3","line":678,"updated":"2016-04-18 22:15:08.000000000","message":"use \u0027 for consistency.","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"137b5e75b5843999b69a241324410817ca66c7f1","unresolved":false,"context_lines":[{"line_number":675,"context_line":"        return value"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def __repr__(self):"},{"line_number":678,"context_line":"        return \"URI\""},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def __eq__(self, other):"},{"line_number":681,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_d8681824","line":678,"in_reply_to":"1a122d0e_c8b17ae3","updated":"2016-05-14 02:36:09.000000000","message":"Done","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"15ae34b6ce46bb92944f71b36e61320f437af356","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        return ("},{"line_number":682,"context_line":"            (self.__class__ \u003d\u003d other.__class__) and"},{"line_number":683,"context_line":"            (self.value \u003d\u003d other.value)"},{"line_number":684,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_28462ebf","line":684,"updated":"2016-04-18 22:15:08.000000000","message":"I wonder how other classes get by with return self.__class__ \u003d\u003d other.__class__ ?","commit_id":"52588e63c47a4d892b8a1d840281417d0a4ee607"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"260f9d026f1ea76fd4840eaf25f7834c5f3f0e15","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        self.value \u003d value"},{"line_number":669,"context_line":"        if len(value) \u003d\u003d 0:"},{"line_number":670,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":671,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue):"},{"line_number":672,"context_line":"            raise ValueError(\u0027invalid URI: %s\u0027 % value)"},{"line_number":673,"context_line":"        return value"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"dab17558_9299167c","line":671,"updated":"2016-05-16 15:20:03.000000000","message":"You do realize that value can be one of:\n\n    \u003ctext\u003e://\n    \u003ctext\u003e:/\n    \u003ctext\u003e:\n\nThat is because a URI is very different from what you might be expecting and what most users will expect. I preseme you don\u0027t just want a scheme though, yes?\n\nIf you add require_authority\u003dTrue you\u0027ll be much further along than this and it will require\n\n    \u003cscheme\u003e://\u003cauthority\u003e\n\nYou should add far more tests to account for all of this.","commit_id":"ba811a281f84e760a8bc5925ee50ae9d2176616c"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"a2b05e3034bfb5de4e899f9df3eba46c9c22706e","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        self.value \u003d value"},{"line_number":669,"context_line":"        if len(value) \u003d\u003d 0:"},{"line_number":670,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":671,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue):"},{"line_number":672,"context_line":"            raise ValueError(\u0027invalid URI: %s\u0027 % value)"},{"line_number":673,"context_line":"        return value"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_836a73ec","line":671,"in_reply_to":"dab17558_9299167c","updated":"2016-05-20 13:04:41.000000000","message":"Thank you for telling me about require_authority.\nI added it and tests for it.","commit_id":"ba811a281f84e760a8bc5925ee50ae9d2176616c"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"a41baeec2fbe94cbcd6b728942c7aadb0337e1e6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"import six"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from rfc3986 import is_valid_uri"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class ConfigType(object):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_14e2ff2e","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":32},"updated":"2016-05-23 09:11:37.000000000","message":"nit :This is third party library ,please move this line above \u0027import six\u0027.","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"3e10a2a0d66ecd3d6a4514cf0e701b76fc9494f5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"import six"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from rfc3986 import is_valid_uri"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class ConfigType(object):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_a2d2e759","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":32},"in_reply_to":"bab6814e_14e2ff2e","updated":"2016-05-27 02:20:56.000000000","message":"Done","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"a41baeec2fbe94cbcd6b728942c7aadb0337e1e6","unresolved":false,"context_lines":[{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    \"\"\"URI type"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    Represents URI. Value will be validated as RFC 3986."},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_74638b42","line":663,"range":{"start_line":663,"start_character":0,"end_line":663,"end_character":56},"updated":"2016-05-23 09:11:37.000000000","message":"please add  parameter description as we did in other types.","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"3e10a2a0d66ecd3d6a4514cf0e701b76fc9494f5","unresolved":false,"context_lines":[{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    \"\"\"URI type"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    Represents URI. Value will be validated as RFC 3986."},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_02701371","line":663,"range":{"start_line":663,"start_character":0,"end_line":663,"end_character":56},"in_reply_to":"bab6814e_74638b42","updated":"2016-05-27 02:20:56.000000000","message":"Done","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"a41baeec2fbe94cbcd6b728942c7aadb0337e1e6","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    Represents URI. Value will be validated as RFC 3986."},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def __call__(self, value):"},{"line_number":668,"context_line":"        self.value \u003d value"},{"line_number":669,"context_line":"        if len(value) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_47d69b4f","line":666,"updated":"2016-05-23 09:11:37.000000000","message":"Please add __init__ function with parameter type_name","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"3e10a2a0d66ecd3d6a4514cf0e701b76fc9494f5","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    Represents URI. Value will be validated as RFC 3986."},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def __call__(self, value):"},{"line_number":668,"context_line":"        self.value \u003d value"},{"line_number":669,"context_line":"        if len(value) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_626bdf85","line":666,"in_reply_to":"bab6814e_47d69b4f","updated":"2016-05-27 02:20:56.000000000","message":"Done","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"a41baeec2fbe94cbcd6b728942c7aadb0337e1e6","unresolved":false,"context_lines":[{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def __call__(self, value):"},{"line_number":668,"context_line":"        self.value \u003d value"},{"line_number":669,"context_line":"        if len(value) \u003d\u003d 0:"},{"line_number":670,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":671,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_54f48759","line":668,"range":{"start_line":668,"start_character":0,"end_line":668,"end_character":26},"updated":"2016-05-23 09:11:37.000000000","message":"move this to line 673 ?","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"3e10a2a0d66ecd3d6a4514cf0e701b76fc9494f5","unresolved":false,"context_lines":[{"line_number":665,"context_line":"    \"\"\""},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def __call__(self, value):"},{"line_number":668,"context_line":"        self.value \u003d value"},{"line_number":669,"context_line":"        if len(value) \u003d\u003d 0:"},{"line_number":670,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":671,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_6202bfb5","line":668,"range":{"start_line":668,"start_character":0,"end_line":668,"end_character":26},"in_reply_to":"bab6814e_54f48759","updated":"2016-05-27 02:20:56.000000000","message":"I didn\u0027t notice this. Thank you.","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"a41baeec2fbe94cbcd6b728942c7aadb0337e1e6","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        return ("},{"line_number":681,"context_line":"            (self.__class__ \u003d\u003d other.__class__) and"},{"line_number":682,"context_line":"            (self.value \u003d\u003d other.value)"},{"line_number":683,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_275557c5","line":683,"range":{"start_line":683,"start_character":8,"end_line":683,"end_character":9},"updated":"2016-05-23 09:11:37.000000000","message":"Please add a member function _formatter.","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"3e10a2a0d66ecd3d6a4514cf0e701b76fc9494f5","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        return ("},{"line_number":681,"context_line":"            (self.__class__ \u003d\u003d other.__class__) and"},{"line_number":682,"context_line":"            (self.value \u003d\u003d other.value)"},{"line_number":683,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_8231a3a4","line":683,"range":{"start_line":683,"start_character":8,"end_line":683,"end_character":9},"in_reply_to":"bab6814e_275557c5","updated":"2016-05-27 02:20:56.000000000","message":"Done","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"019bddfa855b56d9ef059f86da8271a297ed7343","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        return ("},{"line_number":681,"context_line":"            (self.__class__ \u003d\u003d other.__class__) and"},{"line_number":682,"context_line":"            (self.value \u003d\u003d other.value)"},{"line_number":683,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_65859758","line":683,"range":{"start_line":683,"start_character":8,"end_line":683,"end_character":9},"in_reply_to":"bab6814e_275557c5","updated":"2016-05-23 09:33:51.000000000","message":"just add default one for CongfigType in https://review.openstack.org/#/c/319792/","commit_id":"dfeaeae36a667366a2b465b990cb6043f13921e0"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"cfa0efa0ac242908ed00af2026779ea5291e414e","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import abc"},{"line_number":27,"context_line":"import netaddr"},{"line_number":28,"context_line":"from rfc3986 import is_valid_uri"},{"line_number":29,"context_line":"import six"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_febef6d2","line":28,"updated":"2016-05-27 15:32:00.000000000","message":"I\u0027m also a bit surprised that hacking isn\u0027t giving you an error for importing a function from a module instead of just importing the module.","commit_id":"43d31d4eee0d8b4caf7547b2ab515c8540d04c31"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"f78466765e59dcf927f305eb7cead7c7f8dec7ed","unresolved":false,"context_lines":[{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def __call__(self, value):"},{"line_number":673,"context_line":"        if len(value) \u003d\u003d 0:"},{"line_number":674,"context_line":"            raise ValueError(\u0027URI cannot be an empty string\u0027)"},{"line_number":675,"context_line":"        if not is_valid_uri(value, require_scheme\u003dTrue,"},{"line_number":676,"context_line":"                            require_authority\u003dTrue):"},{"line_number":677,"context_line":"            raise ValueError(\u0027invalid URI: %s\u0027 % value)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9abb7d3a_42644de4","line":674,"range":{"start_line":674,"start_character":59,"end_line":674,"end_character":61},"updated":"2016-05-30 12:28:02.000000000","message":"\u003e\u003e\u003e rfc3986.is_valid_uri(\u0027\u0027, rquire_scheme\u003dTrue, require_authority\u003dTrue)\nFalse\n\nso don\u0027t need handle empty string specifically, or you just  want to a different exception value ?","commit_id":"43d31d4eee0d8b4caf7547b2ab515c8540d04c31"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"d910a9d2a4891780d68a937156954f75282230ff","unresolved":false,"context_lines":[{"line_number":663,"context_line":"    Represents URI. Value will be validated as RFC 3986."},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    :param type_name: Type name to be used in the sample config file."},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    \"\"\""},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"    def __init__(self, type_name\u003d\u0027uri value\u0027):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9abb7d3a_c3c49b60","line":666,"updated":"2016-05-31 09:09:14.000000000","message":"this empty line looks useless","commit_id":"4eec9fd0ba5156a23ab4d71724c4c6e9c069e824"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"d910a9d2a4891780d68a937156954f75282230ff","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    def __call__(self, value):"},{"line_number":673,"context_line":"        if not rfc3986.is_valid_uri(value, require_scheme\u003dTrue,"},{"line_number":674,"context_line":"                                    require_authority\u003dTrue):"},{"line_number":675,"context_line":"            raise ValueError(\u0027invalid URI: \"%s\"\u0027 % value)"},{"line_number":676,"context_line":"        self.value \u003d value"},{"line_number":677,"context_line":"        return value"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9abb7d3a_a396b749","line":675,"updated":"2016-05-31 09:09:14.000000000","message":"Hum, I suggest to use %r rather than \"%s\" to escape quote characters","commit_id":"4eec9fd0ba5156a23ab4d71724c4c6e9c069e824"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"da370c5da4a808e06b85921f9e9bd6c904761ff2","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    def __call__(self, value):"},{"line_number":673,"context_line":"        if not rfc3986.is_valid_uri(value, require_scheme\u003dTrue,"},{"line_number":674,"context_line":"                                    require_authority\u003dTrue):"},{"line_number":675,"context_line":"            raise ValueError(\u0027invalid URI: \"%s\"\u0027 % value)"},{"line_number":676,"context_line":"        self.value \u003d value"},{"line_number":677,"context_line":"        return value"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9abb7d3a_93dc6e74","line":675,"in_reply_to":"9abb7d3a_a396b749","updated":"2016-06-01 00:34:33.000000000","message":"I didn\u0027t know that. Thank you.","commit_id":"4eec9fd0ba5156a23ab4d71724c4c6e9c069e824"}],"requirements.txt":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"88e9b490ff25958194f260a4249940209cdee99a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"netaddr!\u003d0.7.16,\u003e\u003d0.7.12"},{"line_number":7,"context_line":"six\u003e\u003d1.9.0"},{"line_number":8,"context_line":"stevedore\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":9,"context_line":"Django\u003e\u003d1.7,\u003c1.9"}],"source_content_type":"text/plain","patch_set":2,"id":"9a1a9d01_bb82f350","line":9,"updated":"2015-10-04 21:49:52.000000000","message":"I don\u0027t think a web UI framework requirement should be included just as a means to do URL validation.","commit_id":"b4c6da0a75be7ee134f2c5c08b6ebc5a70ee84bf"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"fe5ded00de0f96540bb63c249ba811e6481ff947","unresolved":false,"context_lines":[{"line_number":6,"context_line":"netaddr!\u003d0.7.16,\u003e\u003d0.7.12"},{"line_number":7,"context_line":"six\u003e\u003d1.9.0"},{"line_number":8,"context_line":"stevedore\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":9,"context_line":"Django\u003e\u003d1.7,\u003c1.9"}],"source_content_type":"text/plain","patch_set":2,"id":"9a1a9d01_8f6d6906","line":9,"in_reply_to":"9a1a9d01_bb82f350","updated":"2015-10-05 07:04:54.000000000","message":"I see. I will use rfc3986 instead of Django.","commit_id":"b4c6da0a75be7ee134f2c5c08b6ebc5a70ee84bf"}]}
