)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97ee1895f020767bec65df212ae2280e861cc914","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enable inline comments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit enables the usage of the hash (#) symbol to work for"},{"line_number":10,"context_line":"in-line commenting of config files."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"e.g."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a8ffd7b_ca70d074","line":10,"updated":"2015-12-03 07:53:20.000000000","message":"I expect a change in the documentation. But I don\u0027t know what is the best place to put this information. Maybe here?\nhttp://docs.openstack.org/developer/oslo.config/cfg.html#loading-config-files","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"}],"oslo_config/iniparser.py":[{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"364cc3547dd0f8c764a30b0df0e034b289e16bfe","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        escaped \u003d False"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        for i, c in enumerate(line):"},{"line_number":68,"context_line":"            if in_quotes:"},{"line_number":69,"context_line":"                if c in quotes and not escaped:"},{"line_number":70,"context_line":"                    if c \u003d\u003d quote_type:"},{"line_number":71,"context_line":"                        in_quotes \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_346dc032","line":68,"updated":"2015-10-02 13:07:12.000000000","message":"should condense this if\n\n    if (in_quotes and c in quotes and not esacped\n        and c \u003d\u003d quote_type):\n          in_quotes \u003d False","commit_id":"5fcea6c9fd137e4d05c629e194c940e05b9808bf"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"d9cf0e37b63c7702d5ae1d3839cdfe224ca8976c","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _strip_comment(self, line):"},{"line_number":60,"context_line":"        quotes \u003d [\u0027\"\u0027, \"\u0027\"]"},{"line_number":61,"context_line":"        comments \u003d [\"#\"]"},{"line_number":62,"context_line":"        escape \u003d \"\\\\\""},{"line_number":63,"context_line":"        in_quotes \u003d False"},{"line_number":64,"context_line":"        quote_type \u003d quotes[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_ca589e33","line":61,"updated":"2015-10-10 14:49:24.000000000","message":"Why is this a list and not just a str of one char?  Are other comment chars planned in the future?","commit_id":"66c5f359fe86d2f5f3c7b013780aa27f3e153994"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"69c0973d15fd6dc70dd8b3426527f9a5f504ba0e","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _strip_comment(self, line):"},{"line_number":60,"context_line":"        quotes \u003d [\u0027\"\u0027, \"\u0027\"]"},{"line_number":61,"context_line":"        comments \u003d [\"#\"]"},{"line_number":62,"context_line":"        escape \u003d \"\\\\\""},{"line_number":63,"context_line":"        in_quotes \u003d False"},{"line_number":64,"context_line":"        quote_type \u003d quotes[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_13179855","line":61,"in_reply_to":"7a2fa921_ca589e33","updated":"2015-10-15 11:22:44.000000000","message":"I\u0027ve seen examples using ; as a comment, but I will change this to a single string as this is obviously confusing at the moment.","commit_id":"66c5f359fe86d2f5f3c7b013780aa27f3e153994"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97ee1895f020767bec65df212ae2280e861cc914","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def __str__(self):"},{"line_number":23,"context_line":"        return \u0027at line %d, %s: %r\u0027 % (self.lineno, self.msg, self.line)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class BaseParser(object):"},{"line_number":27,"context_line":"    lineno \u003d 0"},{"line_number":28,"context_line":"    parse_exc \u003d ParseError"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_0a281832","line":25,"updated":"2015-12-03 07:53:20.000000000","message":"Oh, this class has no docstring :-(\n\nWould you like to write a short docstring? Example: \"Parser for configuration file.\"\n\nIt would be nice to put a a versionchanged markup:\n\n .. versionchanged:: 3.1\n    Strip comments after \" #\".","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"a1aa4a6468dab00eb4f2876a11d462c46821802d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def __str__(self):"},{"line_number":23,"context_line":"        return \u0027at line %d, %s: %r\u0027 % (self.lineno, self.msg, self.line)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class BaseParser(object):"},{"line_number":27,"context_line":"    lineno \u003d 0"},{"line_number":28,"context_line":"    parse_exc \u003d ParseError"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_6f3625b6","line":25,"updated":"2016-01-07 23:08:40.000000000","message":"This would be nice to have","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"a1aa4a6468dab00eb4f2876a11d462c46821802d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if in_quotes:"},{"line_number":70,"context_line":"                if c \u003d\u003d quote_type and not escaped:"},{"line_number":71,"context_line":"                    in_quotes \u003d False"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                if (previous_char \u003d\u003d \u0027 \u0027 and c \u003d\u003d comment_char"},{"line_number":74,"context_line":"                        and not escaped and not in_quotes):"},{"line_number":75,"context_line":"                    self.comment(line[(i+1):])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_8f3b599c","line":72,"updated":"2016-01-07 23:08:40.000000000","message":"I agree with Victor on this. This could be simpler with an elif.","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97ee1895f020767bec65df212ae2280e861cc914","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if in_quotes:"},{"line_number":70,"context_line":"                if c \u003d\u003d quote_type and not escaped:"},{"line_number":71,"context_line":"                    in_quotes \u003d False"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                if (previous_char \u003d\u003d \u0027 \u0027 and c \u003d\u003d comment_char"},{"line_number":74,"context_line":"                        and not escaped and not in_quotes):"},{"line_number":75,"context_line":"                    self.comment(line[(i+1):])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_ea1cb467","line":72,"updated":"2015-12-03 07:53:20.000000000","message":"Why not using elif at the same level than this else: to avoid an indentation level?\n\nyou should put \"if escaped: escaped \u003d False\" there, to avoid testing \"not escaped\" in following if.","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"a1aa4a6468dab00eb4f2876a11d462c46821802d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    in_quotes \u003d False"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                if (previous_char \u003d\u003d \u0027 \u0027 and c \u003d\u003d comment_char"},{"line_number":74,"context_line":"                        and not escaped and not in_quotes):"},{"line_number":75,"context_line":"                    self.comment(line[(i+1):])"},{"line_number":76,"context_line":"                    return line[:i].rstrip()"},{"line_number":77,"context_line":"                elif c in quotes and not escaped:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_2f402d07","line":74,"updated":"2016-01-07 23:08:40.000000000","message":"I agree with Victor. This seems like an extra check.","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97ee1895f020767bec65df212ae2280e861cc914","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    in_quotes \u003d False"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                if (previous_char \u003d\u003d \u0027 \u0027 and c \u003d\u003d comment_char"},{"line_number":74,"context_line":"                        and not escaped and not in_quotes):"},{"line_number":75,"context_line":"                    self.comment(line[(i+1):])"},{"line_number":76,"context_line":"                    return line[:i].rstrip()"},{"line_number":77,"context_line":"                elif c in quotes and not escaped:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_0f46ea7a","line":74,"updated":"2015-12-03 07:53:20.000000000","message":"why do you test again \"not in_quotes\", it\u0027s already tested above no?","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97ee1895f020767bec65df212ae2280e861cc914","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    quote_type \u003d c"},{"line_number":79,"context_line":"                    in_quotes \u003d True"},{"line_number":80,"context_line":"                elif c \u003d\u003d escape and not escaped:"},{"line_number":81,"context_line":"                    escaped \u003d True"},{"line_number":82,"context_line":"                elif escaped:"},{"line_number":83,"context_line":"                    escaped \u003d False"},{"line_number":84,"context_line":"            previous_char \u003d c"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_2ad15c57","line":81,"updated":"2015-12-03 07:53:20.000000000","message":"Hum, does it mean that \\ is only supported outside strings? What about \u0027Let\\\u0027s test inside strings\u0027?","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"}],"oslo_config/tests/test_iniparser.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"d9cf0e37b63c7702d5ae1d3839cdfe224ca8976c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.parser.parse(lines)"},{"line_number":175,"context_line":"        self.assertEqual(self.parser.values,"},{"line_number":176,"context_line":"                         {\u0027\u0027: {\u0027foo\u0027: [\u0027\\\" bar#not-a-comment \\\" \u0027]}})"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class ExceptionTestCase(unittest.TestCase):"},{"line_number":180,"context_line":"    def test_parseerror(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_aa7a0275","line":177,"updated":"2015-10-10 14:49:24.000000000","message":"Please add a test with a string with a # in it without quotes as one word.  This is supported today, and I think this change breaks it.  For example:\n\ngroup_desc_attribute \u003d descri#ption\n\nI get:\n\n015-10-10 14:43:05.899 25380 DEBUG keystone.openstack.common.service [-] ldap.group_desc_attribute      \u003d des\ncri#ption log_opt_values /usr/lib/python2.7/dist-packages/oslo_config/cfg.py:2197","commit_id":"66c5f359fe86d2f5f3c7b013780aa27f3e153994"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"69c0973d15fd6dc70dd8b3426527f9a5f504ba0e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.parser.parse(lines)"},{"line_number":175,"context_line":"        self.assertEqual(self.parser.values,"},{"line_number":176,"context_line":"                         {\u0027\u0027: {\u0027foo\u0027: [\u0027\\\" bar#not-a-comment \\\" \u0027]}})"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class ExceptionTestCase(unittest.TestCase):"},{"line_number":180,"context_line":"    def test_parseerror(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_52a05043","line":177,"in_reply_to":"7a2fa921_aa7a0275","updated":"2015-10-15 11:22:44.000000000","message":"This is expected behaviour. It would be confusing to consider \"foo#not-comment\" differently from \"foo #comment\" because of the space before the #.","commit_id":"66c5f359fe86d2f5f3c7b013780aa27f3e153994"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"3fb355153cad842e2392d53d507eede90e181238","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    def test_assignment_hash_no_quote(self):"},{"line_number":179,"context_line":"        lines \u003d [\"foo \u003d bar#comment\"]"},{"line_number":180,"context_line":"        self.parser.parse(lines)"},{"line_number":181,"context_line":"        self.assertEqual(self.parser.values, {\u0027\u0027: {\u0027foo\u0027: [\u0027bar\u0027]}})"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class ExceptionTestCase(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_8891c7f3","line":181,"updated":"2015-10-15 15:30:54.000000000","message":"This is my concern with this change.  Now StrOpts can no longer have a # in them.  And I can see it be very common with password StrOpts.  The value returned needs to be bar#comment in order to preserve backwards compatibility.","commit_id":"33b2dd876f0bf2c83c8dffd124e0fba7088b8186"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97ee1895f020767bec65df212ae2280e861cc914","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def test_no_section_name(self):"},{"line_number":59,"context_line":"        self._assertParseError(\"[]\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class ParserTestCase(unittest.TestCase):"},{"line_number":63,"context_line":"    def setUp(self):"},{"line_number":64,"context_line":"        self.parser \u003d TestParser()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_4aef001e","line":61,"updated":"2015-12-03 07:53:20.000000000","message":"IMHO it\u0027s worth to write a new test case just for comments.","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97ee1895f020767bec65df212ae2280e861cc914","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                         {\u0027\u0027: {\u0027foo\u0027: [\u0027 bar#not-a-comment \u0027]}})"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_assignment_space_double_quote_w_hash_inside(self):"},{"line_number":162,"context_line":"        lines \u003d [\"foo \u003d \\\" bar#not-a-comment \\\" # comment\"]"},{"line_number":163,"context_line":"        self.parser.parse(lines)"},{"line_number":164,"context_line":"        self.assertEqual(self.parser.values,"},{"line_number":165,"context_line":"                         {\u0027\u0027: {\u0027foo\u0027: [\u0027 bar#not-a-comment \u0027]}})"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_2a839c57","line":162,"updated":"2015-12-03 07:53:20.000000000","message":"Can you please write \u0027foo \u003d \" bar#not-a-comment \" # comment\u0027 to avoid slash?\n\nI was confused by the slash.","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"97ee1895f020767bec65df212ae2280e861cc914","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        lines \u003d [\"foo \u003d bar#comment\"]"},{"line_number":180,"context_line":"        self.parser.parse(lines)"},{"line_number":181,"context_line":"        self.assertEqual(self.parser.values, {\u0027\u0027: {\u0027foo\u0027: [\u0027bar#comment\u0027]}})"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class ExceptionTestCase(unittest.TestCase):"},{"line_number":185,"context_line":"    def test_parseerror(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_ca6690ec","line":182,"updated":"2015-12-03 07:53:20.000000000","message":"It lacks unit tests for:\n\n* \\#\n* \\ inside and outside strings","commit_id":"1a947024ae54ef4f2db87ebb26f2a96b424dcafe"}]}
