)]}'
{"oslo_config/cfg.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"113bca474e56622d07e67f19012942c67fb5cbb0","unresolved":false,"context_lines":[{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"class PortOpt(Opt):"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    \"\"\"Opt for a TCP/IP port number"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"    Option with ``type`` :class:`oslo_config.types.Integer`"},{"line_number":1119,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_001a876e","line":1116,"updated":"2015-10-15 08:37:37.000000000","message":"You should document that the port number must be in range [1; 65535] (port 0 is invalid).","commit_id":"8bae70b9ea2d9754dad59865ebde96ef8dfbbf08"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"c576b80544eaa40467b6c1880371c0fc7e84ba70","unresolved":false,"context_lines":[{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"class PortOpt(Opt):"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    \"\"\"Opt for a TCP/IP port number"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"    Option with ``type`` :class:`oslo_config.types.Integer`"},{"line_number":1119,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_56e584d9","line":1116,"in_reply_to":"5a2ca52d_001a876e","updated":"2015-10-15 21:15:01.000000000","message":"Done","commit_id":"8bae70b9ea2d9754dad59865ebde96ef8dfbbf08"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"113bca474e56622d07e67f19012942c67fb5cbb0","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"    \"\"\"Opt for a TCP/IP port number"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"    Option with ``type`` :class:`oslo_config.types.Integer`"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    \"\"\""},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def __init__(self, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_807217ac","line":1119,"updated":"2015-10-15 08:37:37.000000000","message":"You should add:\n\n.. versionadded:: 2.6\n\nFor the generated documentation.","commit_id":"8bae70b9ea2d9754dad59865ebde96ef8dfbbf08"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"c576b80544eaa40467b6c1880371c0fc7e84ba70","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"    \"\"\"Opt for a TCP/IP port number"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"    Option with ``type`` :class:`oslo_config.types.Integer`"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    \"\"\""},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def __init__(self, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_36d1e8fa","line":1119,"in_reply_to":"5a2ca52d_807217ac","updated":"2015-10-15 21:15:01.000000000","message":"Done","commit_id":"8bae70b9ea2d9754dad59865ebde96ef8dfbbf08"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"278c6fa5471f4634ccdb568ec8fc20d03573ad27","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"    \"\"\"Opt for a TCP/IP port number"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":"    Option with ``type`` :class:`oslo_config.types.Integer`"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"    \"\"\""},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def __init__(self, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_4f48a82d","line":1119,"in_reply_to":"5a2ca52d_807217ac","updated":"2015-10-15 10:25:20.000000000","message":"FYI I wrote the change Ieb8b3cbb1cb71a98cb714c410635b5c45f1afb08 to add versionadded/versionchanged in the whole oslo.config module.","commit_id":"8bae70b9ea2d9754dad59865ebde96ef8dfbbf08"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"90b9d22211da060bc89e2e20822629642ec4cd59","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"                                    **kwargs)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"class PortOpt(Opt):"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    \"\"\"Option for a TCP/IP port number.  Ports can range from 1 to 65535."},{"line_number":1117,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_560a647a","line":1114,"updated":"2015-10-15 21:16:55.000000000","message":"Why not extend IntOpt?","commit_id":"0b4a26b4f723a3be246e6794794a23786065dc60"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1147facdeb7729e885dd43d4fea8e3a66ef30685","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"                                    **kwargs)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"class PortOpt(Opt):"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    \"\"\"Option for a TCP/IP port number.  Ports can range from 1 to 65535."},{"line_number":1117,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_b9d7294a","line":1114,"in_reply_to":"5a2ca52d_560a647a","updated":"2015-10-15 21:31:34.000000000","message":"Good point","commit_id":"0b4a26b4f723a3be246e6794794a23786065dc60"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8d8b773ab267cef9244216511dea0aa9bb0b2860","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"    \"\"\""},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def __init__(self, name, **kwargs):"},{"line_number":1124,"context_line":"        super(PortOpt, self).__init__(name, min\u003d1, max\u003d65535, **kwargs)"},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"class MultiOpt(Opt):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_cfb245e5","line":1124,"updated":"2015-10-16 07:44:23.000000000","message":"In certain case 0 might be a good value, but let\u0027s ignore that.","commit_id":"ee2bab65e9a2f38bb915f106a4da1520e4b5060c"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c90befe3b1153080de8a0cc596160e77a9aafab4","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"    \"\"\""},{"line_number":1122,"context_line":""},{"line_number":1123,"context_line":"    def __init__(self, name, **kwargs):"},{"line_number":1124,"context_line":"        super(PortOpt, self).__init__(name, min\u003d1, max\u003d65535, **kwargs)"},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"class MultiOpt(Opt):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a2ca52d_08c6ee67","line":1124,"in_reply_to":"5a2ca52d_cfb245e5","updated":"2015-10-16 13:29:53.000000000","message":"Port 0 means that Linux takes a \"random\" available port. But how does the client knows the port number? Is there an OpenStack service using a random port? Maybe using a first known port to send the second port number to the client?\n\nIf the use case arise, it will be easy to add an optional parameter to allow it, no? Ex: add accept_funny_random_port\u003dFalse.","commit_id":"ee2bab65e9a2f38bb915f106a4da1520e4b5060c"}],"oslo_config/tests/test_cfg.py":[{"author":{"_account_id":12952,"name":"ice yao","email":"yao3690093@gmail.com","username":"xiabing.yao"},"change_message_id":"7929f6537ee99554877c2992429bcb1850d878f7","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        self._do_pos_test(cfg.PortOpt, 80, [], None)"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def test_positional_port_arg(self):"},{"line_number":633,"context_line":"        self._do_pos_test(cfg.PortOpt, None, [\u0027443\u0027], 443)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def test_positional_multistr_none_default(self):"},{"line_number":636,"context_line":"        self._do_pos_test(cfg.MultiStrOpt, None, [], None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_7f06ca21","line":633,"updated":"2015-10-06 04:04:05.000000000","message":"add more unit test to ensure the expected result when port number is outside the range of 1 and 65535.","commit_id":"52e14098070983774d440e7b4d0e2a8add8175a0"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"b8194546891dd6fbc354228b8f6f231ed4e95fc9","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        self._do_pos_test(cfg.PortOpt, 80, [], None)"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def test_positional_port_arg(self):"},{"line_number":633,"context_line":"        self._do_pos_test(cfg.PortOpt, None, [\u0027443\u0027], 443)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def test_positional_multistr_none_default(self):"},{"line_number":636,"context_line":"        self._do_pos_test(cfg.MultiStrOpt, None, [], None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_d8926d9f","line":633,"in_reply_to":"7a2fa921_7f06ca21","updated":"2015-10-06 20:31:15.000000000","message":"Done","commit_id":"52e14098070983774d440e7b4d0e2a8add8175a0"}]}