)]}'
{"oslo/config/cfg.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3c4a2c516de14b35011d4ab11d946c9b7fa2f37f","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"                                                     default_config_files)"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        self._setup(project, prog, version, usage, default_config_files)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        self._cli_values \u003d self._parse_cli_opts(args)"},{"line_number":1178,"context_line":""},{"line_number":1179,"context_line":"        self._parse_config_files()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F88U%3D","line":1176,"updated":"2013-03-05 14:13:28.000000000","message":"This should be\n\n  self._cli_values \u003d self._parse_cli_opts(args if args is not None else sys.argv[:1])\n\nThe explicit check for None protects against an empty argument list, which is a valid value.","commit_id":"67ae136fb1728492f91f369c4b8f9854c21ab566"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"unresolved":false,"context_lines":[{"line_number":1173,"context_line":"                                                     default_config_files)"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        self._setup(project, prog, version, usage, default_config_files)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":"        self._cli_values \u003d self._parse_cli_opts(args)"},{"line_number":1178,"context_line":""},{"line_number":1179,"context_line":"        self._parse_config_files()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F8io%3D","line":1176,"in_reply_to":"AAAAN3%2F%2F88U%3D","updated":"2013-03-05 16:53:31.000000000","message":"Good call on handling None vs []\n\nLine too long :(","commit_id":"67ae136fb1728492f91f369c4b8f9854c21ab566"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3c4a2c516de14b35011d4ab11d946c9b7fa2f37f","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"        :raises: SystemExit, DuplicateOptError"},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"        \"\"\""},{"line_number":1682,"context_line":"        self._args \u003d args if args else sys.argv[1:]"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"        for opt, group in sorted(self._all_cli_opts()):"},{"line_number":1685,"context_line":"            opt._add_to_cli(self._oparser, group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F88k%3D","line":1682,"updated":"2013-03-05 14:13:28.000000000","message":"But come to think of it, shouldn\u0027t the check be done by the caller? As it is, this embeds a default value in an internal method, instead of in the external interface.","commit_id":"67ae136fb1728492f91f369c4b8f9854c21ab566"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3c4a2c516de14b35011d4ab11d946c9b7fa2f37f","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"        :raises: SystemExit, DuplicateOptError"},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"        \"\"\""},{"line_number":1682,"context_line":"        self._args \u003d args if args else sys.argv[1:]"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"        for opt, group in sorted(self._all_cli_opts()):"},{"line_number":1685,"context_line":"            opt._add_to_cli(self._oparser, group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F89A%3D","line":1682,"updated":"2013-03-05 14:10:44.000000000","message":"This can just be\n\n  args or sys.argv[1:]","commit_id":"67ae136fb1728492f91f369c4b8f9854c21ab566"}]}