)]}'
{"oslo_config/cfg.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b8c9f07389431341feb0be5f4c51161574bc4add","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"        try:"},{"line_number":1762,"context_line":"            return self._get_cli_value(names, positional)"},{"line_number":1763,"context_line":"        except KeyError:"},{"line_number":1764,"context_line":"            pass"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"        names \u003d [(g if g is not None else \u0027DEFAULT\u0027, n) for g, n in names]"},{"line_number":1767,"context_line":"        values \u003d self._parser._get(names, multi\u003dmulti, normalized\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_a30a1b77","side":"PARENT","line":1764,"updated":"2015-11-20 08:07:59.000000000","message":"What is wrong with this code? It seems valid to me.","commit_id":"ea085578f8dc2743dc341b5819afb0d0ed8b7fe0"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"424f7ac97427cc70e571aba79dddf21eed4fdfb9","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"        try:"},{"line_number":1762,"context_line":"            return self._get_cli_value(names, positional)"},{"line_number":1763,"context_line":"        except KeyError:"},{"line_number":1764,"context_line":"            pass"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"        names \u003d [(g if g is not None else \u0027DEFAULT\u0027, n) for g, n in names]"},{"line_number":1767,"context_line":"        values \u003d self._parser._get(names, multi\u003dmulti, normalized\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_50a9a17a","side":"PARENT","line":1764,"in_reply_to":"ba8a016a_a30a1b77","updated":"2015-11-20 13:50:40.000000000","message":"It really is an \"if/else\". My change does not affect the behaviour, it merely refactors the control flow. A side effect is that it removes a \"try: ... except: pass\" which is seen as a potential issue by bandit, since it explicitely ignores an error.","commit_id":"ea085578f8dc2743dc341b5819afb0d0ed8b7fe0"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b8c9f07389431341feb0be5f4c51161574bc4add","unresolved":false,"context_lines":[{"line_number":2347,"context_line":"        if namespace is None:"},{"line_number":2348,"context_line":"            try:"},{"line_number":2349,"context_line":"                return self.__cache[key]"},{"line_number":2350,"context_line":"            except KeyError:  # nosec"},{"line_number":2351,"context_line":"                pass"},{"line_number":2352,"context_line":"        value \u003d self._do_get(name, group, namespace)"},{"line_number":2353,"context_line":"        self.__cache[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_632993e5","line":2350,"updated":"2015-11-20 08:07:59.000000000","message":"What is wrong with getting a value from a dict? Can you please elaborate?","commit_id":"6d86b8f53de38a6e947811aa594bff0d7fb00cb9"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"424f7ac97427cc70e571aba79dddf21eed4fdfb9","unresolved":false,"context_lines":[{"line_number":2347,"context_line":"        if namespace is None:"},{"line_number":2348,"context_line":"            try:"},{"line_number":2349,"context_line":"                return self.__cache[key]"},{"line_number":2350,"context_line":"            except KeyError:  # nosec"},{"line_number":2351,"context_line":"                pass"},{"line_number":2352,"context_line":"        value \u003d self._do_get(name, group, namespace)"},{"line_number":2353,"context_line":"        self.__cache[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_30c3bd3a","line":2350,"in_reply_to":"ba8a016a_632993e5","updated":"2015-11-20 13:50:40.000000000","message":"K, I\u0027ll add comments.","commit_id":"6d86b8f53de38a6e947811aa594bff0d7fb00cb9"}]}
