)]}'
{"oslo_config/cfg.py":[{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"bd981ff75e67902e58bf6557e669483574192630","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"        values previously loaded. To prevent this, unset \u0027name\u0027 first."},{"line_number":1682,"context_line":""},{"line_number":1683,"context_line":"        :param name: a (section, name) tuple"},{"line_number":1684,"context_line":"        :param value: The value to store. MUST be a list."},{"line_number":1685,"context_line":"        \"\"\""},{"line_number":1686,"context_line":""},{"line_number":1687,"context_line":"        if type(value) is not list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_efe527a8","line":1684,"updated":"2015-12-04 11:56:16.000000000","message":"This is a lie! as \u0027value \u003d [value]\u0027. Why not raise an exception rather than a warning?","commit_id":"a7131c2b67e12a6ba71538d746edd91bde295b1f"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"d93d747c92ec3fd065e402dfc63745e11053d217","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"        values previously loaded. To prevent this, unset \u0027name\u0027 first."},{"line_number":1682,"context_line":""},{"line_number":1683,"context_line":"        :param name: a (section, name) tuple"},{"line_number":1684,"context_line":"        :param value: The value to store. MUST be a list."},{"line_number":1685,"context_line":"        \"\"\""},{"line_number":1686,"context_line":""},{"line_number":1687,"context_line":"        if type(value) is not list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_675abb85","line":1684,"in_reply_to":"7a740942_efe527a8","updated":"2015-12-04 12:55:29.000000000","message":"Yeah I was on the fence about this... I\u0027ll change it","commit_id":"a7131c2b67e12a6ba71538d746edd91bde295b1f"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"70a3d2690e5e0bd1b2fcd9d3d86b808e2632f41f","unresolved":false,"context_lines":[{"line_number":1685,"context_line":"        :raises: ValueError"},{"line_number":1686,"context_line":"        \"\"\""},{"line_number":1687,"context_line":""},{"line_number":1688,"context_line":"        if type(value) is not list:"},{"line_number":1689,"context_line":"            raise ValueError(\"Non-list value passed to MultiConfigParser#set\")"},{"line_number":1690,"context_line":"        if value is None:"},{"line_number":1691,"context_line":"            raise ValueError(\"Use unset to remove keys\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_80e22d02","line":1688,"updated":"2015-12-04 13:43:46.000000000","message":"type(None) is not list \u003d\u003d True, the next if is redundant.","commit_id":"f5d693b6d721c51657b01bc6e1c7c84ef5197b4e"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"5bc4a898797f66426910f0010c434e7e354dbf9a","unresolved":false,"context_lines":[{"line_number":1685,"context_line":"        :raises: ValueError"},{"line_number":1686,"context_line":"        \"\"\""},{"line_number":1687,"context_line":""},{"line_number":1688,"context_line":"        if type(value) is not list:"},{"line_number":1689,"context_line":"            raise ValueError(\"Non-list value passed to MultiConfigParser#set\")"},{"line_number":1690,"context_line":""},{"line_number":1691,"context_line":"        secname, optname \u003d name"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a710552_f0169ea6","line":1688,"updated":"2015-12-14 17:46:37.000000000","message":"Use:\n\n  isinstance(value, list)\n\nI didn\u0027t think it was recommended to use this format anymore.\n\nProbably also raise a type error and not a value error right?\n\nhttps://docs.python.org/2/library/exceptions.html#exceptions.TypeError","commit_id":"9e5cf5141a1ad271f1aa63a4e45e98a1b2fcdf27"}]}
