)]}'
{"oslo_config/generator.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e41fb4707c05d8c7dea7830830d51fa816fe7452","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            if group not in clean[namespace]:"},{"line_number":252,"context_line":"                clean[namespace][group] \u003d collections.OrderedDict()"},{"line_number":253,"context_line":"            for opt in opts:"},{"line_number":254,"context_line":"                if opt.dest not in clean[namespace][group]:"},{"line_number":255,"context_line":"                    clean[namespace][group][opt.dest] \u003d opt"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    # recreate the list of (namespace, [(group, [opt_1, opt_2])]) tuples"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_b63d882c","line":254,"updated":"2016-01-25 21:52:58.000000000","message":"You don\u0027t need this check. It\u0027s OK if we want to preserve \"first occurrence wins\" behavior, but we could just as easily say \"last occurrence wins\" and always store the value.","commit_id":"261eafb20a49c202bdf1320290989d54636665c2"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e41fb4707c05d8c7dea7830830d51fa816fe7452","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                    clean[namespace][group][opt.dest] \u003d opt"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    # recreate the list of (namespace, [(group, [opt_1, opt_2])]) tuples"},{"line_number":258,"context_line":"    # from the cleaned structure."},{"line_number":259,"context_line":"    cleaned_opts \u003d []"},{"line_number":260,"context_line":"    for namespace in clean:"},{"line_number":261,"context_line":"        groups_opts \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_76df10d6","line":258,"updated":"2016-01-25 21:52:58.000000000","message":"This section could be something like\n\n  cleaned_opts \u003d [\n    (namespace, [(group, list(clean[namespace][group].values()))\n                           for group in clean[namespace]]),\n    for namespace in clean\n  ]","commit_id":"261eafb20a49c202bdf1320290989d54636665c2"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"967d6fd69440b4b578a1da21e25de8f4a022a5ac","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                    clean[namespace][group][opt.dest] \u003d opt"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    # recreate the list of (namespace, [(group, [opt_1, opt_2])]) tuples"},{"line_number":258,"context_line":"    # from the cleaned structure."},{"line_number":259,"context_line":"    cleaned_opts \u003d []"},{"line_number":260,"context_line":"    for namespace in clean:"},{"line_number":261,"context_line":"        groups_opts \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_21539418","line":258,"in_reply_to":"9a68dd71_76df10d6","updated":"2016-01-25 21:56:44.000000000","message":"Thanks. I was\u0027t quite sure of the multiple nesting syntax but that\u0027s what I was hoping in feedback.","commit_id":"261eafb20a49c202bdf1320290989d54636665c2"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"07ff742cacf81093ca05a4097b19e02a51a502d4","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    :param read_opts: a list (namespace, [(group, [opt_1, opt_2])]) tuples"},{"line_number":244,"context_line":"    :returns: a list of (namespace, [(group, [opt_1, opt_2])]) tuples"},{"line_number":245,"context_line":"    \"\"\""},{"line_number":246,"context_line":"    clean \u003d collections.OrderedDict()"},{"line_number":247,"context_line":"    for namespace, listing in read_opts:"},{"line_number":248,"context_line":"        if namespace not in clean:"},{"line_number":249,"context_line":"            clean[namespace] \u003d collections.OrderedDict()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_2705e40f","line":246,"updated":"2016-01-25 22:45:24.000000000","message":"Just a thought, but maybe put a comment that the usage of ordereddict is very much on purpose in this class, to avoid future people removing it :)","commit_id":"3153065dbca52c338d85ee9cc872181ef60c4de6"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"33c31997f453df9b181a8352f81783c7287d0c2e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    :param read_opts: a list (namespace, [(group, [opt_1, opt_2])]) tuples"},{"line_number":244,"context_line":"    :returns: a list of (namespace, [(group, [opt_1, opt_2])]) tuples"},{"line_number":245,"context_line":"    \"\"\""},{"line_number":246,"context_line":"    clean \u003d collections.OrderedDict()"},{"line_number":247,"context_line":"    for namespace, listing in read_opts:"},{"line_number":248,"context_line":"        if namespace not in clean:"},{"line_number":249,"context_line":"            clean[namespace] \u003d collections.OrderedDict()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_e7834c01","line":246,"in_reply_to":"9a68dd71_2705e40f","updated":"2016-01-25 22:55:09.000000000","message":"good suggestion","commit_id":"3153065dbca52c338d85ee9cc872181ef60c4de6"}],"oslo_config/tests/test_generator.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e41fb4707c05d8c7dea7830830d51fa816fe7452","unresolved":false,"context_lines":[{"line_number":790,"context_line":"    }"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def test_cleanup_opts(self):"},{"line_number":793,"context_line":"        l \u003d list(self.opts.values())"},{"line_number":794,"context_line":"        o \u003d [(\"namespace1\", ["},{"line_number":795,"context_line":"              (\"group1\", l)])]"},{"line_number":796,"context_line":"        self.assertEqual(o, generator._cleanup_opts(o), \"opts\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_369bd819","line":793,"updated":"2016-01-25 21:52:58.000000000","message":"values() does not guarantee a particular order. opts should either be an OrderedDict() or a list of tuples to ensure consistent order.","commit_id":"261eafb20a49c202bdf1320290989d54636665c2"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e41fb4707c05d8c7dea7830830d51fa816fe7452","unresolved":false,"context_lines":[{"line_number":798,"context_line":"              (\"group1\", l + [self.opts[\u0027foo\u0027]])])]"},{"line_number":799,"context_line":"        e \u003d [(\"namespace1\", ["},{"line_number":800,"context_line":"              (\"group1\", l)])]"},{"line_number":801,"context_line":"        self.assertEqual(e, generator._cleanup_opts(o), \"duplicate opt\")"},{"line_number":802,"context_line":"        o \u003d [(\"namespace1\", ["},{"line_number":803,"context_line":"              (\"group1\", l),"},{"line_number":804,"context_line":"              (\"group2\", l)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_d6b4bc82","line":801,"updated":"2016-01-25 21:52:58.000000000","message":"Normally I would want to make each of these tests a different method, so if some pass and some fail we can tell that.","commit_id":"261eafb20a49c202bdf1320290989d54636665c2"}],"test-requirements.txt":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"f448afbcdf5ccfea0e6beeed4b48c9cb4a0f0414","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a68dd71_3b6654bb","updated":"2016-01-26 04:53:18.000000000","message":"The change to this file isn\u0027t necessary.  Just rebase","commit_id":"da7457b9102547e39c450f03dfd6c18b88d70e4e"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"779fdcfa68100267af81e6fcff2a859c8eda56e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a68dd71_d6501361","in_reply_to":"9a68dd71_3b6654bb","updated":"2016-01-26 15:31:24.000000000","message":"I am really not sure how this got into my patch. not something I manually did.","commit_id":"da7457b9102547e39c450f03dfd6c18b88d70e4e"}]}
