)]}'
{"oslo_config/cfg.py":[{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"420755d213e5e060d6333148bc95e8e73df2e935","unresolved":false,"context_lines":[{"line_number":2833,"context_line":"        self._warn_immutability()"},{"line_number":2834,"context_line":"        fresh \u003d self._diff_ns(old_mutate_ns, self._mutable_ns)"},{"line_number":2835,"context_line":"        for (secname, optname), (old, new) in fresh.items():"},{"line_number":2836,"context_line":"            secname \u003d secname or \u0027DEFAULT\u0027"},{"line_number":2837,"context_line":"            LOG.info(\"Option %s.%s changed from: %s\", secname, optname, old)"},{"line_number":2838,"context_line":"            LOG.info(\"Option %s.%s changed to  : %s\", secname, optname, new)"},{"line_number":2839,"context_line":"        return fresh"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_090d0290","line":2836,"range":{"start_line":2836,"start_character":22,"end_line":2836,"end_character":29},"updated":"2016-01-28 14:56:27.000000000","message":"Is there a reason why you chose to not call this groupname as with other functions, e.g. the next few lines of code.","commit_id":"2b719ea2177367443e88fde98aacb7d619db5ef5"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"e1cbad3e694870227d2fe0d31c66e51cbc7d4812","unresolved":false,"context_lines":[{"line_number":2833,"context_line":"        self._warn_immutability()"},{"line_number":2834,"context_line":"        fresh \u003d self._diff_ns(old_mutate_ns, self._mutable_ns)"},{"line_number":2835,"context_line":"        for (secname, optname), (old, new) in fresh.items():"},{"line_number":2836,"context_line":"            secname \u003d secname or \u0027DEFAULT\u0027"},{"line_number":2837,"context_line":"            LOG.info(\"Option %s.%s changed from: %s\", secname, optname, old)"},{"line_number":2838,"context_line":"            LOG.info(\"Option %s.%s changed to  : %s\", secname, optname, new)"},{"line_number":2839,"context_line":"        return fresh"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_10351ed9","line":2836,"range":{"start_line":2836,"start_character":22,"end_line":2836,"end_character":29},"in_reply_to":"7a5de9d1_090d0290","updated":"2016-01-28 16:35:48.000000000","message":"not really, I thought I\u0027d used secname before but I can change this","commit_id":"2b719ea2177367443e88fde98aacb7d619db5ef5"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"dd465802052d613faaa3919b810156fd597f82c4","unresolved":false,"context_lines":[{"line_number":2833,"context_line":"        self._warn_immutability()"},{"line_number":2834,"context_line":"        fresh \u003d self._diff_ns(old_mutate_ns, self._mutable_ns)"},{"line_number":2835,"context_line":"        for (secname, optname), (old, new) in fresh.items():"},{"line_number":2836,"context_line":"            secname \u003d secname or \u0027DEFAULT\u0027"},{"line_number":2837,"context_line":"            LOG.info(\"Option %s.%s changed from: %s\", secname, optname, old)"},{"line_number":2838,"context_line":"            LOG.info(\"Option %s.%s changed to  : %s\", secname, optname, new)"},{"line_number":2839,"context_line":"        return fresh"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_cd7044df","line":2836,"range":{"start_line":2836,"start_character":22,"end_line":2836,"end_character":29},"in_reply_to":"7a5de9d1_10351ed9","updated":"2016-01-28 19:25:18.000000000","message":"this is your coding preference, however we (as developers) should always strive to make code consistent and readable (and easier to debug/modify the next time).  I am pointing out my observation, preference and what is more common in oslo.config.","commit_id":"2b719ea2177367443e88fde98aacb7d619db5ef5"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"420755d213e5e060d6333148bc95e8e73df2e935","unresolved":false,"context_lines":[{"line_number":2835,"context_line":"        for (secname, optname), (old, new) in fresh.items():"},{"line_number":2836,"context_line":"            secname \u003d secname or \u0027DEFAULT\u0027"},{"line_number":2837,"context_line":"            LOG.info(\"Option %s.%s changed from: %s\", secname, optname, old)"},{"line_number":2838,"context_line":"            LOG.info(\"Option %s.%s changed to  : %s\", secname, optname, new)"},{"line_number":2839,"context_line":"        return fresh"},{"line_number":2840,"context_line":""},{"line_number":2841,"context_line":"    def _warn_immutability(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_295ebe76","line":2838,"range":{"start_line":2838,"start_character":31,"end_line":2838,"end_character":33},"updated":"2016-01-28 14:56:27.000000000","message":"I do not see the reason we need two log lines of near duplicated information. It\u0027s much easier to grep and see the old and new values on one line.","commit_id":"2b719ea2177367443e88fde98aacb7d619db5ef5"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"e1cbad3e694870227d2fe0d31c66e51cbc7d4812","unresolved":false,"context_lines":[{"line_number":2835,"context_line":"        for (secname, optname), (old, new) in fresh.items():"},{"line_number":2836,"context_line":"            secname \u003d secname or \u0027DEFAULT\u0027"},{"line_number":2837,"context_line":"            LOG.info(\"Option %s.%s changed from: %s\", secname, optname, old)"},{"line_number":2838,"context_line":"            LOG.info(\"Option %s.%s changed to  : %s\", secname, optname, new)"},{"line_number":2839,"context_line":"        return fresh"},{"line_number":2840,"context_line":""},{"line_number":2841,"context_line":"    def _warn_immutability(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_50cf167f","line":2838,"range":{"start_line":2838,"start_character":31,"end_line":2838,"end_character":33},"in_reply_to":"7a5de9d1_295ebe76","updated":"2016-01-28 16:35:48.000000000","message":"Most of the value is in the \"old\" and \"new\". I chose to use two lines so they line up and you can compare them easily in the log file. I\u0027m definitely open for input here though as I wrote in the commit message.","commit_id":"2b719ea2177367443e88fde98aacb7d619db5ef5"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"dd465802052d613faaa3919b810156fd597f82c4","unresolved":false,"context_lines":[{"line_number":2835,"context_line":"        for (secname, optname), (old, new) in fresh.items():"},{"line_number":2836,"context_line":"            secname \u003d secname or \u0027DEFAULT\u0027"},{"line_number":2837,"context_line":"            LOG.info(\"Option %s.%s changed from: %s\", secname, optname, old)"},{"line_number":2838,"context_line":"            LOG.info(\"Option %s.%s changed to  : %s\", secname, optname, new)"},{"line_number":2839,"context_line":"        return fresh"},{"line_number":2840,"context_line":""},{"line_number":2841,"context_line":"    def _warn_immutability(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_2dab181f","line":2838,"range":{"start_line":2838,"start_character":31,"end_line":2838,"end_character":33},"in_reply_to":"7a5de9d1_50cf167f","updated":"2016-01-28 19:25:18.000000000","message":"I believe the answer is in how an operator views logs (and individual log messages) and how for example a centralized logging systems view this.\n\nWhile in debugging it may look easier for you to see while tailing a log, speaking as an operations person previously I want a log line to be encompassing and not having to search for other lines to get an answer to what does this log message mean.\n\nWhat is best for OS operators is a discussion I suggest you have with OS operators.","commit_id":"2b719ea2177367443e88fde98aacb7d619db5ef5"}]}
