)]}'
{"oslo_config/tests/test_cfg.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"a2c0229161d13e5675932b2a21008fcba3b09111","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"        self.conf([\u0027--config-file\u0027, paths[0]])"},{"line_number":1763,"context_line":"        # We access the value once before mutating it to ensure the"},{"line_number":1764,"context_line":"        # cache is populated."},{"line_number":1765,"context_line":"        self.assertEqual(\u0027old_foo\u0027, self.conf.foo)"},{"line_number":1766,"context_line":""},{"line_number":1767,"context_line":"        shutil.copy(paths[1], paths[0])"},{"line_number":1768,"context_line":"        self.conf.mutate_config_files()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_5242ee68","line":1765,"updated":"2016-02-23 16:45:44.000000000","message":"this line could be added to the #_test_conf_files_mutate helper, then we could use that here","commit_id":"dae14cc1976db93e103760884790709d06e9bea6"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"82e525878d0192227bdf37f452a3d58dbbe6f922","unresolved":false,"context_lines":[{"line_number":1762,"context_line":"        self.conf([\u0027--config-file\u0027, paths[0]])"},{"line_number":1763,"context_line":"        # We access the value once before mutating it to ensure the"},{"line_number":1764,"context_line":"        # cache is populated."},{"line_number":1765,"context_line":"        self.assertEqual(\u0027old_foo\u0027, self.conf.foo)"},{"line_number":1766,"context_line":""},{"line_number":1767,"context_line":"        shutil.copy(paths[1], paths[0])"},{"line_number":1768,"context_line":"        self.conf.mutate_config_files()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_38010b6b","line":1765,"in_reply_to":"bae84128_5242ee68","updated":"2016-02-23 17:16:01.000000000","message":"I don\u0027t like helper functions in tests. They grow all sorts of complexity that makes it harder to understand the side-effects of changing them. In this case, the trigger for populating the cache would be far removed from the test code assuming it, which makes it more likely someone would try to change the helper without understanding why tests relied on it behaving in a specific way.","commit_id":"dae14cc1976db93e103760884790709d06e9bea6"}]}