)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8a9b61a93f00174275aa3f8cb11cfefb34f6af8c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ConfigOpts\u0027s internal attribute like \u0027project\u0027, CONF.project return"},{"line_number":11,"context_line":"attribute value instead of option value without any error."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"That means internal attribute override user\u0027s config option in \u0027DEFAULT\u0027"},{"line_number":14,"context_line":"group , the attribute list is: project, prog, version, usage, default_config_files."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit disallow illegal name in \u0027DEFAULT\u0027 group before registering it."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I5531092d4899e565176ed3a31821decb35ddfdc9"},{"line_number":19,"context_line":"Closes-Bug: #1550859"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_9eb30be9","line":16,"range":{"start_line":13,"start_character":0,"end_line":16,"end_character":75},"updated":"2016-03-09 13:40:52.000000000","message":"nit: wrapping","commit_id":"05802fb4c1172bbe1e30c816672721daa6697331"}],"oslo_config/cfg.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"384149a965b24c253e0c881920e38ac1fee526bb","unresolved":false,"context_lines":[{"line_number":2031,"context_line":"    :oslo.config:option:`config_dir` options."},{"line_number":2032,"context_line":""},{"line_number":2033,"context_line":"    \"\"\""},{"line_number":2034,"context_line":"    disallow_names \u003d (\u0027project\u0027, \u0027prog\u0027, \u0027version\u0027, \u0027usage\u0027,"},{"line_number":2035,"context_line":"                      \u0027default_config_files\u0027, \u0027default_config_files\u0027)"},{"line_number":2036,"context_line":""},{"line_number":2037,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_8c8f9ccb","line":2034,"updated":"2016-03-08 16:00:30.000000000","message":"I wonder if it wouldn\u0027t be better to move these names to private attributes (rename \"project\" to \"_project\" for example)? We use private attributes for a lot of the other values already. I don\u0027t know if these are meant to be public for some reason or if they were just not made private as an oversight.","commit_id":"05802fb4c1172bbe1e30c816672721daa6697331"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"1eed7b38d7a5d1bf8927c4246a2dc8b068d38eb6","unresolved":false,"context_lines":[{"line_number":2031,"context_line":"    :oslo.config:option:`config_dir` options."},{"line_number":2032,"context_line":""},{"line_number":2033,"context_line":"    \"\"\""},{"line_number":2034,"context_line":"    disallow_names \u003d (\u0027project\u0027, \u0027prog\u0027, \u0027version\u0027, \u0027usage\u0027,"},{"line_number":2035,"context_line":"                      \u0027default_config_files\u0027, \u0027default_config_files\u0027)"},{"line_number":2036,"context_line":""},{"line_number":2037,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_e721044f","line":2034,"in_reply_to":"5aef4532_8c8f9ccb","updated":"2016-03-09 00:56:05.000000000","message":"I did code search and confirm downstream projects use these properties like \u0027project\u0027.\nhttp://codesearch.openstack.org/?q\u003dCONF\\.project\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\n\nso we can\u0027t  rename it with prefix \u0027_\u0027.","commit_id":"05802fb4c1172bbe1e30c816672721daa6697331"},{"author":{"_account_id":7109,"name":"Dmitry Mescheryakov (dmitryme)","email":"dmescheryakov@mirantis.com","username":"dmitryme"},"change_message_id":"d7f97361296bbe597f7479ce525c3fb7dc54b3a9","unresolved":false,"context_lines":[{"line_number":2032,"context_line":""},{"line_number":2033,"context_line":"    \"\"\""},{"line_number":2034,"context_line":"    disallow_names \u003d (\u0027project\u0027, \u0027prog\u0027, \u0027version\u0027, \u0027usage\u0027,"},{"line_number":2035,"context_line":"                      \u0027default_config_files\u0027, \u0027default_config_files\u0027)"},{"line_number":2036,"context_line":""},{"line_number":2037,"context_line":"    def __init__(self):"},{"line_number":2038,"context_line":"        \"\"\"Construct a ConfigOpts object.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_7e0f662e","line":2035,"updated":"2016-03-14 08:39:07.000000000","message":"default_config_files is duplicated","commit_id":"8c09627d8a40e7d3d3b15864ee61a2669b7924b9"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"50fbae8396e30b70da9113780c008cc0661bd834","unresolved":false,"context_lines":[{"line_number":2032,"context_line":""},{"line_number":2033,"context_line":"    \"\"\""},{"line_number":2034,"context_line":"    disallow_names \u003d (\u0027project\u0027, \u0027prog\u0027, \u0027version\u0027, \u0027usage\u0027,"},{"line_number":2035,"context_line":"                      \u0027default_config_files\u0027, \u0027default_config_files\u0027)"},{"line_number":2036,"context_line":""},{"line_number":2037,"context_line":"    def __init__(self):"},{"line_number":2038,"context_line":"        \"\"\"Construct a ConfigOpts object.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_018020bf","line":2035,"in_reply_to":"3afc51ec_7e0f662e","updated":"2016-03-18 05:39:06.000000000","message":"Done","commit_id":"8c09627d8a40e7d3d3b15864ee61a2669b7924b9"}]}