)]}'
{"oslo/config/cfg.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"fca14dcd427d9f6cc405d0e145c7e232f2094b57","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        if deprecated_name is not None:"},{"line_number":561,"context_line":"            deprecated_name \u003d deprecated_name.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.deprecated_opts \u003d deprecated_opts if deprecated_opts else []"},{"line_number":564,"context_line":"        self.deprecated_opts.append(dict({\u0027name\u0027: deprecated_name,"},{"line_number":565,"context_line":"                                          \u0027group\u0027: deprecated_group}))"},{"line_number":566,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F7O8%3D","line":563,"updated":"2013-05-20 03:47:59.000000000","message":"self.deprecated_opts \u003d deprecated_opts or []","commit_id":"ea77e1a5f65e3d8b91021eb2ba19244ed77b641d"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"3494ea11dd223f45eda1dbbba5f3de688acb01bb","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        if deprecated_name is not None:"},{"line_number":561,"context_line":"            deprecated_name \u003d deprecated_name.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.deprecated_opts \u003d deprecated_opts if deprecated_opts else []"},{"line_number":564,"context_line":"        self.deprecated_opts.append(dict({\u0027name\u0027: deprecated_name,"},{"line_number":565,"context_line":"                                          \u0027group\u0027: deprecated_group}))"},{"line_number":566,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F6uY%3D","line":563,"in_reply_to":"AAAAPH%2F%2F7O8%3D","updated":"2013-05-20 11:28:00.000000000","message":"Done","commit_id":"ea77e1a5f65e3d8b91021eb2ba19244ed77b641d"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"ad83f7b18685efa165259bd56f0934c35b309e9a","unresolved":false,"context_lines":[{"line_number":542,"context_line":"        :param required: true iff a value must be supplied for this option"},{"line_number":543,"context_line":"        :param deprecated_name: deprecated name option.  Acts like an alias"},{"line_number":544,"context_line":"        :param deprecated_group: the group containing a deprecated alias"},{"line_number":545,"context_line":"        :param deprecated_opts: list of dict, each containing name and group"},{"line_number":546,"context_line":"                                of a deprecated option"},{"line_number":547,"context_line":"        \"\"\""},{"line_number":548,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F424%3D","line":545,"updated":"2013-05-20 22:20:19.000000000","message":"needs updating","commit_id":"6cd3443ec788e8fa7f238aebaedd6db8d9cc73e8"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"48ca06c5ac856103ae631e826b9f4f0845e443d5","unresolved":false,"context_lines":[{"line_number":542,"context_line":"        :param required: true iff a value must be supplied for this option"},{"line_number":543,"context_line":"        :param deprecated_name: deprecated name option.  Acts like an alias"},{"line_number":544,"context_line":"        :param deprecated_group: the group containing a deprecated alias"},{"line_number":545,"context_line":"        :param deprecated_opts: list of dict, each containing name and group"},{"line_number":546,"context_line":"                                of a deprecated option"},{"line_number":547,"context_line":"        \"\"\""},{"line_number":548,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F4nM%3D","line":545,"in_reply_to":"AAAAPH%2F%2F424%3D","updated":"2013-05-21 01:00:21.000000000","message":"Done","commit_id":"6cd3443ec788e8fa7f238aebaedd6db8d9cc73e8"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"ad83f7b18685efa165259bd56f0934c35b309e9a","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        if deprecated_name is not None:"},{"line_number":561,"context_line":"            deprecated_name \u003d deprecated_name.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.deprecated_opts \u003d deprecated_opts or []"},{"line_number":564,"context_line":"        dopt \u003d DeprecatedOpt(deprecated_name, group\u003ddeprecated_group)"},{"line_number":565,"context_line":"        if dopt not in self.deprecated_opts:"},{"line_number":566,"context_line":"            self.deprecated_opts.append(dopt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F418%3D","line":563,"updated":"2013-05-20 22:20:19.000000000","message":"Let\u0027s make a copy of this list rather than potentially modifying the one that\u0027s passed in","commit_id":"6cd3443ec788e8fa7f238aebaedd6db8d9cc73e8"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"48ca06c5ac856103ae631e826b9f4f0845e443d5","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        if deprecated_name is not None:"},{"line_number":561,"context_line":"            deprecated_name \u003d deprecated_name.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.deprecated_opts \u003d deprecated_opts or []"},{"line_number":564,"context_line":"        dopt \u003d DeprecatedOpt(deprecated_name, group\u003ddeprecated_group)"},{"line_number":565,"context_line":"        if dopt not in self.deprecated_opts:"},{"line_number":566,"context_line":"            self.deprecated_opts.append(dopt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F4mw%3D","line":563,"in_reply_to":"AAAAPH%2F%2F418%3D","updated":"2013-05-21 01:00:21.000000000","message":"Done","commit_id":"6cd3443ec788e8fa7f238aebaedd6db8d9cc73e8"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"ad83f7b18685efa165259bd56f0934c35b309e9a","unresolved":false,"context_lines":[{"line_number":561,"context_line":"            deprecated_name \u003d deprecated_name.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.deprecated_opts \u003d deprecated_opts or []"},{"line_number":564,"context_line":"        dopt \u003d DeprecatedOpt(deprecated_name, group\u003ddeprecated_group)"},{"line_number":565,"context_line":"        if dopt not in self.deprecated_opts:"},{"line_number":566,"context_line":"            self.deprecated_opts.append(dopt)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F420%3D","line":564,"updated":"2013-05-20 22:20:19.000000000","message":"Hmm, if deprecated_name, deprecated_group and deprecated_opts are all None, then I\u0027d expect deprecated_opts to be empty","commit_id":"6cd3443ec788e8fa7f238aebaedd6db8d9cc73e8"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"48ca06c5ac856103ae631e826b9f4f0845e443d5","unresolved":false,"context_lines":[{"line_number":561,"context_line":"            deprecated_name \u003d deprecated_name.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        self.deprecated_opts \u003d deprecated_opts or []"},{"line_number":564,"context_line":"        dopt \u003d DeprecatedOpt(deprecated_name, group\u003ddeprecated_group)"},{"line_number":565,"context_line":"        if dopt not in self.deprecated_opts:"},{"line_number":566,"context_line":"            self.deprecated_opts.append(dopt)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F4ms%3D","line":564,"in_reply_to":"AAAAPH%2F%2F420%3D","updated":"2013-05-21 01:00:21.000000000","message":"There\u0027s code down the line that depends on this behavior. Let me see if it is worth adding more code below just to add a if condition here :)","commit_id":"6cd3443ec788e8fa7f238aebaedd6db8d9cc73e8"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"ad83f7b18685efa165259bd56f0934c35b309e9a","unresolved":false,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"class DeprecatedOpt(object):"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    \"\"\"Represents a Deprecated option"},{"line_number":722,"context_line":"    \"\"\""},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def __init__(self, name, group\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F42Y%3D","line":721,"updated":"2013-05-20 22:20:19.000000000","message":"An example of how to use this would be good here","commit_id":"6cd3443ec788e8fa7f238aebaedd6db8d9cc73e8"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"48ca06c5ac856103ae631e826b9f4f0845e443d5","unresolved":false,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"class DeprecatedOpt(object):"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    \"\"\"Represents a Deprecated option"},{"line_number":722,"context_line":"    \"\"\""},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def __init__(self, name, group\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F4nE%3D","line":721,"in_reply_to":"AAAAPH%2F%2F42Y%3D","updated":"2013-05-21 01:00:21.000000000","message":"Done","commit_id":"6cd3443ec788e8fa7f238aebaedd6db8d9cc73e8"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"17726ce7c3c57ee3f235ecc0f39562825e9fa620","unresolved":false,"context_lines":[{"line_number":586,"context_line":"            dname, dgroup \u003d opt.name, opt.group"},{"line_number":587,"context_line":"            if dname or dgroup:"},{"line_number":588,"context_line":"                names.append((dgroup if dgroup else section,"},{"line_number":589,"context_line":"                              dname if dname else self.dest))"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        return cparser.get(names, multi)"},{"line_number":592,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F1NY%3D","line":589,"updated":"2013-05-22 03:47:51.000000000","message":"how about (dgroup or section, dname or self.dest) ?","commit_id":"e1f884174eb65895ade604933b25ed245fb45942"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"6729fff9666b1d7bb705d30b6ae1ba7660903ea0","unresolved":false,"context_lines":[{"line_number":586,"context_line":"            dname, dgroup \u003d opt.name, opt.group"},{"line_number":587,"context_line":"            if dname or dgroup:"},{"line_number":588,"context_line":"                names.append((dgroup if dgroup else section,"},{"line_number":589,"context_line":"                              dname if dname else self.dest))"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        return cparser.get(names, multi)"},{"line_number":592,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0tY%3D","line":589,"in_reply_to":"AAAAPH%2F%2F0t0%3D","updated":"2013-05-22 08:41:05.000000000","message":"Sure. Thanks!","commit_id":"e1f884174eb65895ade604933b25ed245fb45942"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"67ceea2a2a3c13529962b4a703b3269e6c0c6f35","unresolved":false,"context_lines":[{"line_number":586,"context_line":"            dname, dgroup \u003d opt.name, opt.group"},{"line_number":587,"context_line":"            if dname or dgroup:"},{"line_number":588,"context_line":"                names.append((dgroup if dgroup else section,"},{"line_number":589,"context_line":"                              dname if dname else self.dest))"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        return cparser.get(names, multi)"},{"line_number":592,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0t0%3D","line":589,"in_reply_to":"AAAAPH%2F%2F1NY%3D","updated":"2013-05-22 08:37:51.000000000","message":"This was existing code. I may have another review coming up in this area. can i please address this during that?","commit_id":"e1f884174eb65895ade604933b25ed245fb45942"}]}
