)]}'
{"oslo_config/cfg.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a55d1275035ddac220f002855fefa40fa0546b1e","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    opts \u003d ["},{"line_number":369,"context_line":"        cfg.StrOpt(\u0027option1\u0027, default\u003d\u0027default_value\u0027,"},{"line_number":370,"context_line":"                    advanced\u003dTrue, help\u003d\u0027This is help"},{"line_number":371,"context_line":"                    text.\u0027),"},{"line_number":372,"context_line":"        cfg.PortOpt(\u0027option2\u0027, default\u003d\u0027default_value\u0027,"},{"line_number":373,"context_line":"                     help\u003d\u0027This is help text.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_b77b11f4","line":370,"updated":"2016-05-23 18:34:34.000000000","message":"Might want to make this example proper python.  Currently there\u0027s a huge amount of space after help.  I suggest using a multi-line string:\n\nhelp\u003d\u0027This is help \u0027\n\u0027text.\u0027),","commit_id":"4eaacab2bc64f8baa5ba685ba36e6cb2062519db"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"17434e7dbf28eb5833f7cf318675a94f8a1266c2","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    opts \u003d ["},{"line_number":369,"context_line":"        cfg.StrOpt(\u0027option1\u0027, default\u003d\u0027default_value\u0027,"},{"line_number":370,"context_line":"                    advanced\u003dTrue, help\u003d\u0027This is help"},{"line_number":371,"context_line":"                    text.\u0027),"},{"line_number":372,"context_line":"        cfg.PortOpt(\u0027option2\u0027, default\u003d\u0027default_value\u0027,"},{"line_number":373,"context_line":"                     help\u003d\u0027This is help text.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_cd049a7f","line":370,"in_reply_to":"bab6814e_b77b11f4","updated":"2016-05-26 14:59:31.000000000","message":"Done","commit_id":"4eaacab2bc64f8baa5ba685ba36e6cb2062519db"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a55d1275035ddac220f002855fefa40fa0546b1e","unresolved":false,"context_lines":[{"line_number":696,"context_line":"                              a future release. Silently ignored if"},{"line_number":697,"context_line":"                              deprecated_for_removal is False"},{"line_number":698,"context_line":"    :param mutable: True if this option may be reloaded"},{"line_number":699,"context_line":"    :param advanced: True if this option is has advanced usage and is not"},{"line_number":700,"context_line":"                              normally used by majority of users"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    An Opt object has no public methods, but has a number of public properties:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_b762f13b","line":699,"updated":"2016-05-23 18:34:34.000000000","message":"\"if this option has advanced...\" - remove \"is\"","commit_id":"4eaacab2bc64f8baa5ba685ba36e6cb2062519db"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"17434e7dbf28eb5833f7cf318675a94f8a1266c2","unresolved":false,"context_lines":[{"line_number":696,"context_line":"                              a future release. Silently ignored if"},{"line_number":697,"context_line":"                              deprecated_for_removal is False"},{"line_number":698,"context_line":"    :param mutable: True if this option may be reloaded"},{"line_number":699,"context_line":"    :param advanced: True if this option is has advanced usage and is not"},{"line_number":700,"context_line":"                              normally used by majority of users"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    An Opt object has no public methods, but has a number of public properties:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_8dd8d21f","line":699,"in_reply_to":"bab6814e_b762f13b","updated":"2016-05-26 14:59:31.000000000","message":"Done","commit_id":"4eaacab2bc64f8baa5ba685ba36e6cb2062519db"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a55d1275035ddac220f002855fefa40fa0546b1e","unresolved":false,"context_lines":[{"line_number":756,"context_line":"       Added *deprecated_reason* parameter."},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    .. versionchanged:: 3.5"},{"line_number":759,"context_line":"       Added *mutable* parameter."},{"line_number":760,"context_line":"    \"\"\""},{"line_number":761,"context_line":"    multi \u003d False"},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_b72dd1ff","line":759,"updated":"2016-05-23 18:34:34.000000000","message":"Add *advanced* as a new parameter here with version its introduced.","commit_id":"4eaacab2bc64f8baa5ba685ba36e6cb2062519db"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"17434e7dbf28eb5833f7cf318675a94f8a1266c2","unresolved":false,"context_lines":[{"line_number":756,"context_line":"       Added *deprecated_reason* parameter."},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    .. versionchanged:: 3.5"},{"line_number":759,"context_line":"       Added *mutable* parameter."},{"line_number":760,"context_line":"    \"\"\""},{"line_number":761,"context_line":"    multi \u003d False"},{"line_number":762,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_ad095697","line":759,"in_reply_to":"bab6814e_b72dd1ff","updated":"2016-05-26 14:59:31.000000000","message":"Done","commit_id":"4eaacab2bc64f8baa5ba685ba36e6cb2062519db"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0ec7b26553e6c958b9e97c4830a209fc4a8a31f5","unresolved":false,"context_lines":[{"line_number":360,"context_line":"Advanced Option"},{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users::"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    from oslo_config import cfg"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_7d03190e","line":364,"range":{"start_line":363,"start_character":0,"end_line":364,"end_character":42},"updated":"2016-06-02 21:11:53.000000000","message":"You\u0027re noting here, that advanced means just minority of users, while in 390-393 is information that it can have effects on stability or performance.\n\nThis sentence gives different meaning than description from config. Are you sure we\u0027d like to have this kind of connotation?","commit_id":"d70c5f854cedd6d19334be5f14e31b0caf86beea"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"a6565b5da9069329a2c94e5f7dc8a554ac00136e","unresolved":false,"context_lines":[{"line_number":360,"context_line":"Advanced Option"},{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users::"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    from oslo_config import cfg"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_f71b741a","line":364,"range":{"start_line":363,"start_character":0,"end_line":364,"end_character":42},"in_reply_to":"9abb7d3a_7d03190e","updated":"2016-06-03 15:44:35.000000000","message":"Done","commit_id":"d70c5f854cedd6d19334be5f14e31b0caf86beea"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"b5d276a193fdbe5c7535de8a9c731025eb86d8fd","unresolved":false,"context_lines":[{"line_number":360,"context_line":"Advanced Option"},{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users::"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    from oslo_config import cfg"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_c0717ee2","line":364,"range":{"start_line":363,"start_character":0,"end_line":364,"end_character":42},"in_reply_to":"9abb7d3a_7d03190e","updated":"2016-06-02 21:38:32.000000000","message":"I kind of prefer this explanation more than the one below, but they both make sense.","commit_id":"d70c5f854cedd6d19334be5f14e31b0caf86beea"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"36d86e4ddb42c964810ba186e1707f1ae83fcb50","unresolved":false,"context_lines":[{"line_number":360,"context_line":"Advanced Option"},{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users::"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    from oslo_config import cfg"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_a56c239d","line":364,"range":{"start_line":363,"start_character":0,"end_line":364,"end_character":42},"in_reply_to":"9abb7d3a_7d03190e","updated":"2016-06-03 13:30:52.000000000","message":"I think both explanations go hand in hand. Here we have an explanation for why you might want to label an option as advanced (to indicate an advanced/niche use case). Below is a warning that use of an advanced option can have consequences that need to be understood before doing so. The first is aimed at developers, the second at operators - if I\u0027m understanding correctly.","commit_id":"d70c5f854cedd6d19334be5f14e31b0caf86beea"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"a6565b5da9069329a2c94e5f7dc8a554ac00136e","unresolved":false,"context_lines":[{"line_number":360,"context_line":"Advanced Option"},{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users::"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    from oslo_config import cfg"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_97d30838","line":364,"range":{"start_line":363,"start_character":0,"end_line":364,"end_character":42},"in_reply_to":"9abb7d3a_a56c239d","updated":"2016-06-03 15:44:35.000000000","message":"Done","commit_id":"d70c5f854cedd6d19334be5f14e31b0caf86beea"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"a6565b5da9069329a2c94e5f7dc8a554ac00136e","unresolved":false,"context_lines":[{"line_number":360,"context_line":"Advanced Option"},{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users::"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    from oslo_config import cfg"},{"line_number":367,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_37169cf1","line":364,"range":{"start_line":363,"start_character":0,"end_line":364,"end_character":42},"in_reply_to":"9abb7d3a_c0717ee2","updated":"2016-06-03 15:44:35.000000000","message":"Done","commit_id":"d70c5f854cedd6d19334be5f14e31b0caf86beea"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"b5ca678dc01b5a208d96db91b6ac249f79119e21","unresolved":false,"context_lines":[{"line_number":759,"context_line":"    .. versionchanged:: 3.5"},{"line_number":760,"context_line":"       Added *mutable* parameter."},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    .. versionchanged:: 3.11"},{"line_number":763,"context_line":"       Added *advanced* parameter."},{"line_number":764,"context_line":"    \"\"\""},{"line_number":765,"context_line":"    multi \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_858f4d22","line":762,"range":{"start_line":762,"start_character":26,"end_line":762,"end_character":28},"updated":"2016-06-11 00:18:50.000000000","message":"Unfortunately this should be 3.12 now.  3.11 was just released.","commit_id":"0f60bc8624ffb0559f90c0775fcba42d85d3de38"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"93e859b591090a0b9aefc2257f746ea767982158","unresolved":false,"context_lines":[{"line_number":759,"context_line":"    .. versionchanged:: 3.5"},{"line_number":760,"context_line":"       Added *mutable* parameter."},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    .. versionchanged:: 3.11"},{"line_number":763,"context_line":"       Added *advanced* parameter."},{"line_number":764,"context_line":"    \"\"\""},{"line_number":765,"context_line":"    multi \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_18227452","line":762,"range":{"start_line":762,"start_character":26,"end_line":762,"end_character":28},"in_reply_to":"7aa08908_858f4d22","updated":"2016-06-13 14:26:20.000000000","message":"Done","commit_id":"0f60bc8624ffb0559f90c0775fcba42d85d3de38"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"b69eee88d14ab3b96563eb95490c20db8eaaa27e","unresolved":false,"context_lines":[{"line_number":698,"context_line":"                              deprecated_for_removal is False"},{"line_number":699,"context_line":"    :param mutable: True if this option may be reloaded"},{"line_number":700,"context_line":"    :param advanced: True if this option has advanced usage and is not"},{"line_number":701,"context_line":"                              normally used by majority of users"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    An Opt object has no public methods, but has a number of public properties:"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_44d360d5","line":701,"range":{"start_line":701,"start_character":44,"end_line":701,"end_character":56},"updated":"2016-06-13 22:58:11.000000000","message":"NIT: by the majority","commit_id":"bb7bd88f2e05ede892b20e1208c8a4c676f4e1ab"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"ec0251ccde586bdc6c00ee2369aa116826675753","unresolved":false,"context_lines":[{"line_number":698,"context_line":"                              deprecated_for_removal is False"},{"line_number":699,"context_line":"    :param mutable: True if this option may be reloaded"},{"line_number":700,"context_line":"    :param advanced: True if this option has advanced usage and is not"},{"line_number":701,"context_line":"                              normally used by majority of users"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    An Opt object has no public methods, but has a number of public properties:"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_018ac363","line":701,"range":{"start_line":701,"start_character":44,"end_line":701,"end_character":56},"in_reply_to":"7aa08908_44d360d5","updated":"2016-06-14 14:30:52.000000000","message":"Done","commit_id":"bb7bd88f2e05ede892b20e1208c8a4c676f4e1ab"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1e58a4950cc6232357637ae594d6c952151ab52c","unresolved":false,"context_lines":[{"line_number":360,"context_line":"Advanced Option"},{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users and might have significant"},{"line_number":365,"context_line":"effects to stability and/or performance::"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_7d3c072f","line":363,"range":{"start_line":363,"start_character":0,"end_line":363,"end_character":2},"updated":"2016-06-14 16:09:15.000000000","message":"Use if ...","commit_id":"60a96bec5714a0f28767d24de278ec50f9f840f2"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"fb00d312c21775c4dd53344d4a57d46c053c4fed","unresolved":false,"context_lines":[{"line_number":360,"context_line":"Advanced Option"},{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users and might have significant"},{"line_number":365,"context_line":"effects to stability and/or performance::"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_97ccf58b","line":363,"range":{"start_line":363,"start_character":0,"end_line":363,"end_character":2},"in_reply_to":"7aa08908_7d3c072f","updated":"2016-06-15 15:35:22.000000000","message":"Done","commit_id":"60a96bec5714a0f28767d24de278ec50f9f840f2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1e58a4950cc6232357637ae594d6c952151ab52c","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users and might have significant"},{"line_number":365,"context_line":"effects to stability and/or performance::"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    from oslo_config import cfg"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_7dffe733","line":365,"range":{"start_line":365,"start_character":0,"end_line":365,"end_character":7},"updated":"2016-06-14 16:09:15.000000000","message":"Think maybe \"effects\" should be singular as \"effect\", but not a big deal","commit_id":"60a96bec5714a0f28767d24de278ec50f9f840f2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6d74fadd3aae94564402878ae2ffe9a9245bb8ae","unresolved":false,"context_lines":[{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users and might have significant"},{"line_number":365,"context_line":"effects to stability and/or performance::"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    from oslo_config import cfg"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_d5716bad","line":365,"range":{"start_line":364,"start_character":47,"end_line":365,"end_character":10},"updated":"2016-06-15 09:49:46.000000000","message":"might significantly affect?","commit_id":"60a96bec5714a0f28767d24de278ec50f9f840f2"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"fb00d312c21775c4dd53344d4a57d46c053c4fed","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users and might have significant"},{"line_number":365,"context_line":"effects to stability and/or performance::"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    from oslo_config import cfg"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_b7c3f156","line":365,"range":{"start_line":365,"start_character":0,"end_line":365,"end_character":7},"in_reply_to":"7aa08908_7dffe733","updated":"2016-06-15 15:35:22.000000000","message":"Done","commit_id":"60a96bec5714a0f28767d24de278ec50f9f840f2"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"fb00d312c21775c4dd53344d4a57d46c053c4fed","unresolved":false,"context_lines":[{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"If you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users and might have significant"},{"line_number":365,"context_line":"effects to stability and/or performance::"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    from oslo_config import cfg"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_179f6566","line":365,"range":{"start_line":364,"start_character":47,"end_line":365,"end_character":10},"in_reply_to":"7aa08908_d5716bad","updated":"2016-06-15 15:35:22.000000000","message":"Done","commit_id":"60a96bec5714a0f28767d24de278ec50f9f840f2"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f85d309fbcb2d690d5fa0a58f5c9fc9f7a74146b","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"Use if you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users and might have a significant"},{"line_number":365,"context_line":"affect to stability and/or performance::"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    from oslo_config import cfg"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_ade2802d","line":365,"range":{"start_line":365,"start_character":0,"end_line":365,"end_character":6},"updated":"2016-06-15 16:07:26.000000000","message":"This should be either \"...might have a significant effect on stability...\" or \"...might significantly affect stability...\"","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2234656a37edde51fccf987bd17043c2eaf3fa7d","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"Use if you need to label an option as advanced, indicating the option is"},{"line_number":364,"context_line":"not normally used by the majority of users and might have a significant"},{"line_number":365,"context_line":"affect to stability and/or performance::"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    from oslo_config import cfg"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_29764bd8","line":365,"range":{"start_line":365,"start_character":0,"end_line":365,"end_character":6},"in_reply_to":"7aa08908_ade2802d","updated":"2016-06-16 15:25:56.000000000","message":"Done","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f85d309fbcb2d690d5fa0a58f5c9fc9f7a74146b","unresolved":false,"context_lines":[{"line_number":379,"context_line":""},{"line_number":380,"context_line":"This will result in the option being pushed to the bottom of the"},{"line_number":381,"context_line":"namespace and labeled as advanced in sample files, with a notation"},{"line_number":382,"context_line":"about possible affects::"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    [DEFAULT]"},{"line_number":385,"context_line":"    ..."}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_4d24bc5f","line":382,"range":{"start_line":382,"start_character":15,"end_line":382,"end_character":22},"updated":"2016-06-15 16:07:26.000000000","message":"effects","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2234656a37edde51fccf987bd17043c2eaf3fa7d","unresolved":false,"context_lines":[{"line_number":379,"context_line":""},{"line_number":380,"context_line":"This will result in the option being pushed to the bottom of the"},{"line_number":381,"context_line":"namespace and labeled as advanced in sample files, with a notation"},{"line_number":382,"context_line":"about possible affects::"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    [DEFAULT]"},{"line_number":385,"context_line":"    ..."}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_6980538c","line":382,"range":{"start_line":382,"start_character":15,"end_line":382,"end_character":22},"in_reply_to":"7aa08908_4d24bc5f","updated":"2016-06-16 15:25:56.000000000","message":"Done","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f85d309fbcb2d690d5fa0a58f5c9fc9f7a74146b","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    ..."},{"line_number":391,"context_line":"    # This is help text. (string value)"},{"line_number":392,"context_line":"    # Advanced Option: not used by majority of users and"},{"line_number":393,"context_line":"    # might have a significant affect to stability and/or"},{"line_number":394,"context_line":"    # performance."},{"line_number":395,"context_line":"    # option1 \u003d default_value"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_cd18ac21","line":393,"range":{"start_line":393,"start_character":6,"end_line":393,"end_character":40},"updated":"2016-06-15 16:07:26.000000000","message":"Ditto my comment on L365","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2234656a37edde51fccf987bd17043c2eaf3fa7d","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    ..."},{"line_number":391,"context_line":"    # This is help text. (string value)"},{"line_number":392,"context_line":"    # Advanced Option: not used by majority of users and"},{"line_number":393,"context_line":"    # might have a significant affect to stability and/or"},{"line_number":394,"context_line":"    # performance."},{"line_number":395,"context_line":"    # option1 \u003d default_value"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_497bd7be","line":393,"range":{"start_line":393,"start_character":6,"end_line":393,"end_character":40},"in_reply_to":"7aa08908_cd18ac21","updated":"2016-06-16 15:25:56.000000000","message":"Done","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"e919db83d71067ac0f55c223c9732c174bd7e218","unresolved":false,"context_lines":[{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    .. versionchanged:: 3.12"},{"line_number":770,"context_line":"       Added *deprecated_since* parameter."},{"line_number":771,"context_line":"       Added *advanced* parameter."},{"line_number":772,"context_line":"    \"\"\""},{"line_number":773,"context_line":"    multi \u003d False"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_3a5df679","line":771,"updated":"2016-06-28 15:00:59.000000000","message":"This should be part of a version 3.13 now","commit_id":"ee443e9712479f0247d03ef6018d491246355034"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"3a609b9e4ee43f624e9838266785b42646c4e819","unresolved":false,"context_lines":[{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    .. versionchanged:: 3.12"},{"line_number":770,"context_line":"       Added *deprecated_since* parameter."},{"line_number":771,"context_line":"       Added *advanced* parameter."},{"line_number":772,"context_line":"    \"\"\""},{"line_number":773,"context_line":"    multi \u003d False"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_d555a3c6","line":771,"in_reply_to":"3aaa91ec_3a5df679","updated":"2016-06-28 15:08:56.000000000","message":"Done","commit_id":"ee443e9712479f0247d03ef6018d491246355034"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"00277b59484580068cc437885e89576629b512c0","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    CONF.register_opts(opts)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"This will result in the option being pushed to the bottom of the"},{"line_number":381,"context_line":"namespace and labeled as advanced in sample files, with a notation"},{"line_number":382,"context_line":"about possible effects::"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_4e808f8b","line":381,"range":{"start_line":381,"start_character":34,"end_line":381,"end_character":49},"updated":"2016-06-30 15:40:31.000000000","message":"would be easier to follow if it was mentioned first that this section is about sample files.","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"cb777a95f1e62672f12e6eadb3bb494351909407","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    CONF.register_opts(opts)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"This will result in the option being pushed to the bottom of the"},{"line_number":381,"context_line":"namespace and labeled as advanced in sample files, with a notation"},{"line_number":382,"context_line":"about possible effects::"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_8e46174d","line":381,"range":{"start_line":381,"start_character":34,"end_line":381,"end_character":49},"in_reply_to":"3aaa91ec_4e808f8b","updated":"2016-07-06 13:58:31.000000000","message":"Done","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"00277b59484580068cc437885e89576629b512c0","unresolved":false,"context_lines":[{"line_number":389,"context_line":"    \u003cpush to bottom of section\u003e"},{"line_number":390,"context_line":"    ..."},{"line_number":391,"context_line":"    # This is help text. (string value)"},{"line_number":392,"context_line":"    # Advanced Option: not used by majority of users and"},{"line_number":393,"context_line":"    # might have a significant effect on stability and/or"},{"line_number":394,"context_line":"    # performance."},{"line_number":395,"context_line":"    # option1 \u003d default_value"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_894f116a","line":392,"updated":"2016-06-30 15:40:31.000000000","message":"People reading this are probably going to wonder what \"Advanced Option:\" means. I think it\u0027s best to avoid unexpected punctuation and just write it in English. as in,\n\nThis option is intended for advanced users and is not used\nby the majority of users and may have a significant effect\non stability and/or performance.\n\nIt would be better if the help text actually said what the impact is, so maybe would be better to be able to allow the application to be able to change the message that is shown here.","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"cb777a95f1e62672f12e6eadb3bb494351909407","unresolved":false,"context_lines":[{"line_number":389,"context_line":"    \u003cpush to bottom of section\u003e"},{"line_number":390,"context_line":"    ..."},{"line_number":391,"context_line":"    # This is help text. (string value)"},{"line_number":392,"context_line":"    # Advanced Option: not used by majority of users and"},{"line_number":393,"context_line":"    # might have a significant effect on stability and/or"},{"line_number":394,"context_line":"    # performance."},{"line_number":395,"context_line":"    # option1 \u003d default_value"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_ee751b98","line":392,"in_reply_to":"3aaa91ec_894f116a","updated":"2016-07-06 13:58:31.000000000","message":"Done","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"00277b59484580068cc437885e89576629b512c0","unresolved":false,"context_lines":[{"line_number":704,"context_line":"                             strings are encouraged. Silently ignored if"},{"line_number":705,"context_line":"                             deprecated_for_removal is False"},{"line_number":706,"context_line":"    :param mutable: True if this option may be reloaded"},{"line_number":707,"context_line":"    :param advanced: True if this option has advanced usage and is not"},{"line_number":708,"context_line":"                              normally used by the majority of users"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    An Opt object has no public methods, but has a number of public properties:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_b1ffcf64","line":707,"updated":"2016-06-30 15:40:31.000000000","message":"should also document the type.","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"cb777a95f1e62672f12e6eadb3bb494351909407","unresolved":false,"context_lines":[{"line_number":704,"context_line":"                             strings are encouraged. Silently ignored if"},{"line_number":705,"context_line":"                             deprecated_for_removal is False"},{"line_number":706,"context_line":"    :param mutable: True if this option may be reloaded"},{"line_number":707,"context_line":"    :param advanced: True if this option has advanced usage and is not"},{"line_number":708,"context_line":"                              normally used by the majority of users"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    An Opt object has no public methods, but has a number of public properties:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_ce7adf87","line":707,"in_reply_to":"3aaa91ec_b1ffcf64","updated":"2016-07-06 13:58:31.000000000","message":"Done","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"00277b59484580068cc437885e89576629b512c0","unresolved":false,"context_lines":[{"line_number":747,"context_line":"    .. py:attribute:: help"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        a string explaining how the option\u0027s value is used"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    .. versionchanged:: 1.2"},{"line_number":752,"context_line":"       Added *deprecated_opts* parameter."},{"line_number":753,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_912d7300","line":750,"updated":"2016-06-30 15:40:31.000000000","message":"also document the attribute.","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"cb777a95f1e62672f12e6eadb3bb494351909407","unresolved":false,"context_lines":[{"line_number":747,"context_line":"    .. py:attribute:: help"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        a string explaining how the option\u0027s value is used"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    .. versionchanged:: 1.2"},{"line_number":752,"context_line":"       Added *deprecated_opts* parameter."},{"line_number":753,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_2e6c43cf","line":750,"in_reply_to":"3aaa91ec_912d7300","updated":"2016-07-06 13:58:31.000000000","message":"Done","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"00277b59484580068cc437885e89576629b512c0","unresolved":false,"context_lines":[{"line_number":770,"context_line":"       Added *deprecated_since* parameter."},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    .. versionchanged:: 3.13"},{"line_number":773,"context_line":"       Added *advanced* parameter."},{"line_number":774,"context_line":"    \"\"\""},{"line_number":775,"context_line":"    multi \u003d False"},{"line_number":776,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_911453a0","line":773,"updated":"2016-06-30 15:40:31.000000000","message":"parameter and attribute.","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"cb777a95f1e62672f12e6eadb3bb494351909407","unresolved":false,"context_lines":[{"line_number":770,"context_line":"       Added *deprecated_since* parameter."},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    .. versionchanged:: 3.13"},{"line_number":773,"context_line":"       Added *advanced* parameter."},{"line_number":774,"context_line":"    \"\"\""},{"line_number":775,"context_line":"    multi \u003d False"},{"line_number":776,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_0e7187a8","line":773,"in_reply_to":"3aaa91ec_911453a0","updated":"2016-07-06 13:58:31.000000000","message":"Done","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"4335e6841df787d29c22405789be18b468da27a9","unresolved":false,"context_lines":[{"line_number":360,"context_line":"Advanced Option"},{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"In olso-generator sample files, use if you need to label an option as advanced,"},{"line_number":364,"context_line":"indicating the option is not normally used by the majority of users and might"},{"line_number":365,"context_line":"have a significant effect on stability and/or performance::"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_7308d8da","line":363,"range":{"start_line":363,"start_character":0,"end_line":363,"end_character":31},"updated":"2016-07-06 21:58:53.000000000","message":"This first part of the sentence I don\u0027t think is needed or needs to be reworded.","commit_id":"b73f885265859190d961104f8b8720fca275ef5b"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"4a6eb238054b3519292efc9aab0f9e3d2014bb2e","unresolved":false,"context_lines":[{"line_number":360,"context_line":"Advanced Option"},{"line_number":361,"context_line":"---------------"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"In olso-generator sample files, use if you need to label an option as advanced,"},{"line_number":364,"context_line":"indicating the option is not normally used by the majority of users and might"},{"line_number":365,"context_line":"have a significant effect on stability and/or performance::"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_0adc6e45","line":363,"range":{"start_line":363,"start_character":0,"end_line":363,"end_character":31},"in_reply_to":"1aa78d24_7308d8da","updated":"2016-07-08 02:07:12.000000000","message":"Done","commit_id":"b73f885265859190d961104f8b8720fca275ef5b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"4335e6841df787d29c22405789be18b468da27a9","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    CONF.register_opts(opts)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"This will result in the option being pushed to the bottom of the"},{"line_number":381,"context_line":"namespace and labeled as advanced in sample files, with a notation"},{"line_number":382,"context_line":"about possible effects::"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_533ddc8d","line":381,"range":{"start_line":381,"start_character":34,"end_line":381,"end_character":36},"updated":"2016-07-06 21:58:53.000000000","message":"in the","commit_id":"b73f885265859190d961104f8b8720fca275ef5b"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"4a6eb238054b3519292efc9aab0f9e3d2014bb2e","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    CONF.register_opts(opts)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"This will result in the option being pushed to the bottom of the"},{"line_number":381,"context_line":"namespace and labeled as advanced in sample files, with a notation"},{"line_number":382,"context_line":"about possible effects::"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_eae002fd","line":381,"range":{"start_line":381,"start_character":34,"end_line":381,"end_character":36},"in_reply_to":"1aa78d24_533ddc8d","updated":"2016-07-08 02:07:12.000000000","message":"Done","commit_id":"b73f885265859190d961104f8b8720fca275ef5b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"4335e6841df787d29c22405789be18b468da27a9","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    # This is help text. (string value)"},{"line_number":387,"context_line":"    # option2 \u003d default_value"},{"line_number":388,"context_line":"    ..."},{"line_number":389,"context_line":"    \u003cpush to bottom of section\u003e"},{"line_number":390,"context_line":"    ..."},{"line_number":391,"context_line":"    # This is help text. (string value)"},{"line_number":392,"context_line":"    # Advanced Option: intended for advanced users and not used"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_33be50ff","line":389,"range":{"start_line":389,"start_character":5,"end_line":389,"end_character":9},"updated":"2016-07-06 21:58:53.000000000","message":"pushed","commit_id":"b73f885265859190d961104f8b8720fca275ef5b"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"4a6eb238054b3519292efc9aab0f9e3d2014bb2e","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    # This is help text. (string value)"},{"line_number":387,"context_line":"    # option2 \u003d default_value"},{"line_number":388,"context_line":"    ..."},{"line_number":389,"context_line":"    \u003cpush to bottom of section\u003e"},{"line_number":390,"context_line":"    ..."},{"line_number":391,"context_line":"    # This is help text. (string value)"},{"line_number":392,"context_line":"    # Advanced Option: intended for advanced users and not used"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_4ae67617","line":389,"range":{"start_line":389,"start_character":5,"end_line":389,"end_character":9},"in_reply_to":"1aa78d24_33be50ff","updated":"2016-07-08 02:07:12.000000000","message":"Done","commit_id":"b73f885265859190d961104f8b8720fca275ef5b"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"de00f2d315fa8cf778885c766238183f16429be2","unresolved":false,"context_lines":[{"line_number":773,"context_line":"    .. versionchanged:: 3.12"},{"line_number":774,"context_line":"       Added *deprecated_since* parameter."},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    .. versionchanged:: 3.13"},{"line_number":777,"context_line":"       Added *advanced* parameter and attribute."},{"line_number":778,"context_line":"    \"\"\""},{"line_number":779,"context_line":"    multi \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_4fd65228","line":776,"range":{"start_line":776,"start_character":24,"end_line":776,"end_character":28},"updated":"2016-07-14 18:31:13.000000000","message":"3.14 now","commit_id":"f4b4436a7af462f372ef27afc9ff6a96bd68d698"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"781c6c6e8b54ba7fec54d7dc90ce7c4e058881d1","unresolved":false,"context_lines":[{"line_number":773,"context_line":"    .. versionchanged:: 3.12"},{"line_number":774,"context_line":"       Added *deprecated_since* parameter."},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    .. versionchanged:: 3.13"},{"line_number":777,"context_line":"       Added *advanced* parameter and attribute."},{"line_number":778,"context_line":"    \"\"\""},{"line_number":779,"context_line":"    multi \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aa78d24_2c282a33","line":776,"range":{"start_line":776,"start_character":24,"end_line":776,"end_character":28},"in_reply_to":"1aa78d24_4fd65228","updated":"2016-07-14 22:01:49.000000000","message":"Done","commit_id":"f4b4436a7af462f372ef27afc9ff6a96bd68d698"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"96c93724e7c125af602ee53437c02cecd48cfe49","unresolved":false,"context_lines":[{"line_number":773,"context_line":"    .. versionchanged:: 3.12"},{"line_number":774,"context_line":"       Added *deprecated_since* parameter."},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    .. versionchanged:: 3.14"},{"line_number":777,"context_line":"       Added *advanced* parameter and attribute."},{"line_number":778,"context_line":"    \"\"\""},{"line_number":779,"context_line":"    multi \u003d False"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_443f71d6","line":776,"range":{"start_line":776,"start_character":24,"end_line":776,"end_character":28},"updated":"2016-08-02 18:37:51.000000000","message":"Sorry, 3.15 now","commit_id":"2f8038ccddd316156a55ceaa48d955ec2291cbe3"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"21bdd12770bb07030297d3b7117983d601516bf4","unresolved":false,"context_lines":[{"line_number":773,"context_line":"    .. versionchanged:: 3.12"},{"line_number":774,"context_line":"       Added *deprecated_since* parameter."},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    .. versionchanged:: 3.14"},{"line_number":777,"context_line":"       Added *advanced* parameter and attribute."},{"line_number":778,"context_line":"    \"\"\""},{"line_number":779,"context_line":"    multi \u003d False"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_55af197d","line":776,"range":{"start_line":776,"start_character":24,"end_line":776,"end_character":28},"in_reply_to":"bacf61ea_443f71d6","updated":"2016-08-02 19:40:40.000000000","message":"Done","commit_id":"2f8038ccddd316156a55ceaa48d955ec2291cbe3"}],"oslo_config/generator.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"5226fbe0b48518dc2fc48401e1c801898692cd9b","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        if opt.advanced:"},{"line_number":229,"context_line":"            lines.append("},{"line_number":230,"context_line":"                \u0027# Advanced Option: modifying/enabling this option might\\n\u0027"},{"line_number":231,"context_line":"                \u0027# have significant effects on stability or performance.\\n\u0027"},{"line_number":232,"context_line":"            )"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if hasattr(opt.type, \u0027format_defaults\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_89865711","line":231,"updated":"2016-04-13 19:49:49.000000000","message":"\"significant effects\" is strong language. Where are you envisioning this new flag being used?","commit_id":"5eea3a8412b21444c389dbf1b9e89677a4e60946"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"9d2150ae9e91971432bc8b91b28ad86695955da4","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        if opt.advanced:"},{"line_number":229,"context_line":"            lines.append("},{"line_number":230,"context_line":"                \u0027# Advanced Option: modifying/enabling this option might\\n\u0027"},{"line_number":231,"context_line":"                \u0027# have significant effects on stability or performance.\\n\u0027"},{"line_number":232,"context_line":"            )"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if hasattr(opt.type, \u0027format_defaults\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_d92f7386","line":231,"in_reply_to":"5a18252c_89865711","updated":"2016-04-14 03:43:34.000000000","message":"\"might\" is earlier on, but really, language to denote that modifying or setting this option is not normal and it\u0027s possible the effects can be profound.","commit_id":"5eea3a8412b21444c389dbf1b9e89677a4e60946"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"5226fbe0b48518dc2fc48401e1c801898692cd9b","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        advanced_opts \u003d []"},{"line_number":371,"context_line":"        f.write(\u0027\\n#\\n# From %s\\n#\\n\u0027 % namespace)"},{"line_number":372,"context_line":"        for opt in opts:"},{"line_number":373,"context_line":"            if opt.advanced:"},{"line_number":374,"context_line":"                advanced_opts.append(opt)"},{"line_number":375,"context_line":"            else:"},{"line_number":376,"context_line":"                _output_opts_format(f, opt)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_69bbfbe5","line":373,"updated":"2016-04-13 19:49:49.000000000","message":"Instead of doing 2 loops here, you could change the sort key function on line 369 to take the true/false value into account.","commit_id":"5eea3a8412b21444c389dbf1b9e89677a4e60946"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"9d2150ae9e91971432bc8b91b28ad86695955da4","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        advanced_opts \u003d []"},{"line_number":371,"context_line":"        f.write(\u0027\\n#\\n# From %s\\n#\\n\u0027 % namespace)"},{"line_number":372,"context_line":"        for opt in opts:"},{"line_number":373,"context_line":"            if opt.advanced:"},{"line_number":374,"context_line":"                advanced_opts.append(opt)"},{"line_number":375,"context_line":"            else:"},{"line_number":376,"context_line":"                _output_opts_format(f, opt)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_b9439741","line":373,"in_reply_to":"5a18252c_69bbfbe5","updated":"2016-04-14 03:43:34.000000000","message":"Agreed, that would reduce some code here and collapse the split out method.","commit_id":"5eea3a8412b21444c389dbf1b9e89677a4e60946"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"9ea14928c1f042294f42ef2d90f6dc7554258676","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        advanced_opts \u003d []"},{"line_number":371,"context_line":"        f.write(\u0027\\n#\\n# From %s\\n#\\n\u0027 % namespace)"},{"line_number":372,"context_line":"        for opt in opts:"},{"line_number":373,"context_line":"            if opt.advanced:"},{"line_number":374,"context_line":"                advanced_opts.append(opt)"},{"line_number":375,"context_line":"            else:"},{"line_number":376,"context_line":"                _output_opts_format(f, opt)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_8f2a928e","line":373,"in_reply_to":"5a18252c_69bbfbe5","updated":"2016-04-14 21:26:45.000000000","message":"Done","commit_id":"5eea3a8412b21444c389dbf1b9e89677a4e60946"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"a55d1275035ddac220f002855fefa40fa0546b1e","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        if opt.advanced:"},{"line_number":229,"context_line":"            lines.append("},{"line_number":230,"context_line":"                \u0027# Advanced Option: modifying/enabling this option might\\n\u0027"},{"line_number":231,"context_line":"                \u0027# have significant effects on stability or performance.\\n\u0027"},{"line_number":232,"context_line":"            )"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if hasattr(opt.type, \u0027format_defaults\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_774d29c3","line":231,"updated":"2016-05-23 18:34:34.000000000","message":"stability and/or performance","commit_id":"4eaacab2bc64f8baa5ba685ba36e6cb2062519db"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"17434e7dbf28eb5833f7cf318675a94f8a1266c2","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        if opt.advanced:"},{"line_number":229,"context_line":"            lines.append("},{"line_number":230,"context_line":"                \u0027# Advanced Option: modifying/enabling this option might\\n\u0027"},{"line_number":231,"context_line":"                \u0027# have significant effects on stability or performance.\\n\u0027"},{"line_number":232,"context_line":"            )"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if hasattr(opt.type, \u0027format_defaults\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_8d4612be","line":231,"in_reply_to":"bab6814e_774d29c3","updated":"2016-05-26 14:59:31.000000000","message":"Done","commit_id":"4eaacab2bc64f8baa5ba685ba36e6cb2062519db"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0ec7b26553e6c958b9e97c4830a209fc4a8a31f5","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    for (namespace, opts) in sorted(namespaces,"},{"line_number":359,"context_line":"                                    key\u003doperator.itemgetter(0)):"},{"line_number":360,"context_line":"        f.write(\u0027\\n#\\n# From %s\\n#\\n\u0027 % namespace)"},{"line_number":361,"context_line":"        for opt in sorted(opts, key\u003doperator.attrgetter(\u0027advanced\u0027)):"},{"line_number":362,"context_line":"            f.write(\u0027\\n\u0027)"},{"line_number":363,"context_line":"            try:"},{"line_number":364,"context_line":"                f.format(opt)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_3d17d1ee","line":361,"range":{"start_line":361,"start_character":8,"end_line":361,"end_character":69},"updated":"2016-06-02 21:11:53.000000000","message":"Nice job.","commit_id":"d70c5f854cedd6d19334be5f14e31b0caf86beea"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"b69eee88d14ab3b96563eb95490c20db8eaaa27e","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if opt.advanced:"},{"line_number":229,"context_line":"            lines.append("},{"line_number":230,"context_line":"                \u0027# Advanced Option: not used by majority of users and might\\n\u0027"},{"line_number":231,"context_line":"                \u0027# have significant effects on stability and/or performance.\\n\u0027"},{"line_number":232,"context_line":"            )"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_64e5bca2","line":230,"range":{"start_line":230,"start_character":45,"end_line":230,"end_character":56},"updated":"2016-06-13 22:58:11.000000000","message":"NIT: by the majority","commit_id":"bb7bd88f2e05ede892b20e1208c8a4c676f4e1ab"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"ec0251ccde586bdc6c00ee2369aa116826675753","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if opt.advanced:"},{"line_number":229,"context_line":"            lines.append("},{"line_number":230,"context_line":"                \u0027# Advanced Option: not used by majority of users and might\\n\u0027"},{"line_number":231,"context_line":"                \u0027# have significant effects on stability and/or performance.\\n\u0027"},{"line_number":232,"context_line":"            )"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_81f4f3f0","line":230,"range":{"start_line":230,"start_character":45,"end_line":230,"end_character":56},"in_reply_to":"7aa08908_64e5bca2","updated":"2016-06-14 14:30:52.000000000","message":"Done","commit_id":"bb7bd88f2e05ede892b20e1208c8a4c676f4e1ab"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f85d309fbcb2d690d5fa0a58f5c9fc9f7a74146b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        if opt.advanced:"},{"line_number":238,"context_line":"            lines.append("},{"line_number":239,"context_line":"                \u0027# Advanced Option: not used by the majority of users and\\n\u0027"},{"line_number":240,"context_line":"                \u0027# might have a significant affect to stability and/or\\n\u0027"},{"line_number":241,"context_line":"                \u0027# performance.\\n\u0027"},{"line_number":242,"context_line":"            )"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_8de5040c","line":240,"range":{"start_line":240,"start_character":30,"end_line":240,"end_character":53},"updated":"2016-06-15 16:07:26.000000000","message":"Ditto comments in cfg.py","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2234656a37edde51fccf987bd17043c2eaf3fa7d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        if opt.advanced:"},{"line_number":238,"context_line":"            lines.append("},{"line_number":239,"context_line":"                \u0027# Advanced Option: not used by the majority of users and\\n\u0027"},{"line_number":240,"context_line":"                \u0027# might have a significant affect to stability and/or\\n\u0027"},{"line_number":241,"context_line":"                \u0027# performance.\\n\u0027"},{"line_number":242,"context_line":"            )"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_894bff85","line":240,"range":{"start_line":240,"start_character":30,"end_line":240,"end_character":53},"in_reply_to":"7aa08908_8de5040c","updated":"2016-06-16 15:25:56.000000000","message":"Done","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"f0e3b4d23a5eea3ce4d7821747162cbf688b9e03","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    for (namespace, opts) in sorted(group_data[\u0027namespaces\u0027],"},{"line_number":397,"context_line":"                                    key\u003doperator.itemgetter(0)):"},{"line_number":398,"context_line":"        f.write(\u0027\\n#\\n# From %s\\n#\\n\u0027 % namespace)"},{"line_number":399,"context_line":"        for opt in sorted(opts, key\u003doperator.attrgetter(\u0027advanced\u0027)):"},{"line_number":400,"context_line":"            try:"},{"line_number":401,"context_line":"                if minimal and not opt.required:"},{"line_number":402,"context_line":"                    pass"}],"source_content_type":"text/x-python","patch_set":13,"id":"1aa78d24_5edc2a74","line":399,"range":{"start_line":399,"start_character":0,"end_line":399,"end_character":69},"updated":"2016-07-15 07:42:46.000000000","message":"can we replace sort with other approach in order to get better performance?","commit_id":"2f8038ccddd316156a55ceaa48d955ec2291cbe3"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"576ee3263b607d5e55bc773ecb5f81fef3beeaca","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    for (namespace, opts) in sorted(group_data[\u0027namespaces\u0027],"},{"line_number":397,"context_line":"                                    key\u003doperator.itemgetter(0)):"},{"line_number":398,"context_line":"        f.write(\u0027\\n#\\n# From %s\\n#\\n\u0027 % namespace)"},{"line_number":399,"context_line":"        for opt in sorted(opts, key\u003doperator.attrgetter(\u0027advanced\u0027)):"},{"line_number":400,"context_line":"            try:"},{"line_number":401,"context_line":"                if minimal and not opt.required:"},{"line_number":402,"context_line":"                    pass"}],"source_content_type":"text/x-python","patch_set":13,"id":"fad55976_715fe70e","line":399,"range":{"start_line":399,"start_character":0,"end_line":399,"end_character":69},"in_reply_to":"1aa78d24_5edc2a74","updated":"2016-07-15 16:25:37.000000000","message":"What would you suggest? This seems reasonable to me","commit_id":"2f8038ccddd316156a55ceaa48d955ec2291cbe3"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"dcf21e958f8f366bc0beb06c857b8283ab4ec78a","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    for (namespace, opts) in sorted(group_data[\u0027namespaces\u0027],"},{"line_number":397,"context_line":"                                    key\u003doperator.itemgetter(0)):"},{"line_number":398,"context_line":"        f.write(\u0027\\n#\\n# From %s\\n#\\n\u0027 % namespace)"},{"line_number":399,"context_line":"        for opt in sorted(opts, key\u003doperator.attrgetter(\u0027advanced\u0027)):"},{"line_number":400,"context_line":"            try:"},{"line_number":401,"context_line":"                if minimal and not opt.required:"},{"line_number":402,"context_line":"                    pass"}],"source_content_type":"text/x-python","patch_set":13,"id":"fad55976_11578b03","line":399,"range":{"start_line":399,"start_character":0,"end_line":399,"end_character":69},"in_reply_to":"1aa78d24_5edc2a74","updated":"2016-07-15 16:24:04.000000000","message":"i\u0027m not sure this is a worthwhile effort.","commit_id":"2f8038ccddd316156a55ceaa48d955ec2291cbe3"}],"oslo_config/sphinxext.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"b69eee88d14ab3b96563eb95490c20db8eaaa27e","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                              (opt.dest, err))"},{"line_number":142,"context_line":"        if opt.advanced:"},{"line_number":143,"context_line":"            yield _indent("},{"line_number":144,"context_line":"                \u0027:Advanced Option: not used by majority of users and might\u0027,)"},{"line_number":145,"context_line":"            yield _indent("},{"line_number":146,"context_line":"                \u0027:have significant effects on stability and/or performance.\u0027,"},{"line_number":147,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_a4032441","line":144,"range":{"start_line":144,"start_character":44,"end_line":144,"end_character":55},"updated":"2016-06-13 22:58:11.000000000","message":"NIT: by the majority","commit_id":"bb7bd88f2e05ede892b20e1208c8a4c676f4e1ab"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"ec0251ccde586bdc6c00ee2369aa116826675753","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                              (opt.dest, err))"},{"line_number":142,"context_line":"        if opt.advanced:"},{"line_number":143,"context_line":"            yield _indent("},{"line_number":144,"context_line":"                \u0027:Advanced Option: not used by majority of users and might\u0027,)"},{"line_number":145,"context_line":"            yield _indent("},{"line_number":146,"context_line":"                \u0027:have significant effects on stability and/or performance.\u0027,"},{"line_number":147,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_81cb53a3","line":144,"range":{"start_line":144,"start_character":44,"end_line":144,"end_character":55},"in_reply_to":"7aa08908_a4032441","updated":"2016-06-14 14:30:52.000000000","message":"Done","commit_id":"bb7bd88f2e05ede892b20e1208c8a4c676f4e1ab"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f85d309fbcb2d690d5fa0a58f5c9fc9f7a74146b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            yield _indent("},{"line_number":144,"context_line":"                \u0027:Advanced Option: not used by the majority of users and\u0027,)"},{"line_number":145,"context_line":"            yield _indent("},{"line_number":146,"context_line":"                \u0027:might have a significant affect to stability and/or\u0027,"},{"line_number":147,"context_line":"                )"},{"line_number":148,"context_line":"            yield _indent("},{"line_number":149,"context_line":"                \u0027:performance.\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_adc3a056","line":146,"range":{"start_line":146,"start_character":20,"end_line":146,"end_character":58},"updated":"2016-06-15 16:07:26.000000000","message":"Ditto comments in cfg.py","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2234656a37edde51fccf987bd17043c2eaf3fa7d","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            yield _indent("},{"line_number":144,"context_line":"                \u0027:Advanced Option: not used by the majority of users and\u0027,)"},{"line_number":145,"context_line":"            yield _indent("},{"line_number":146,"context_line":"                \u0027:might have a significant affect to stability and/or\u0027,"},{"line_number":147,"context_line":"                )"},{"line_number":148,"context_line":"            yield _indent("},{"line_number":149,"context_line":"                \u0027:performance.\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_6957b326","line":146,"range":{"start_line":146,"start_character":20,"end_line":146,"end_character":58},"in_reply_to":"7aa08908_adc3a056","updated":"2016-06-16 15:25:56.000000000","message":"Done","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"00277b59484580068cc437885e89576629b512c0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            yield _indent("},{"line_number":144,"context_line":"                \u0027:Advanced Option: not used by the majority of users and\u0027,)"},{"line_number":145,"context_line":"            yield _indent("},{"line_number":146,"context_line":"                \u0027:might have a significant effect on stability and/or\u0027,"},{"line_number":147,"context_line":"                )"},{"line_number":148,"context_line":"            yield _indent("},{"line_number":149,"context_line":"                \u0027:performance.\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_51a94b23","line":146,"updated":"2016-06-30 15:40:31.000000000","message":"maybe everybody else knows why there\u0027s a : at the start of the line.","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"cb777a95f1e62672f12e6eadb3bb494351909407","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            yield _indent("},{"line_number":144,"context_line":"                \u0027:Advanced Option: not used by the majority of users and\u0027,)"},{"line_number":145,"context_line":"            yield _indent("},{"line_number":146,"context_line":"                \u0027:might have a significant effect on stability and/or\u0027,"},{"line_number":147,"context_line":"                )"},{"line_number":148,"context_line":"            yield _indent("},{"line_number":149,"context_line":"                \u0027:performance.\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_2e5563f9","line":146,"in_reply_to":"3aaa91ec_51a94b23","updated":"2016-07-06 13:58:31.000000000","message":"Remaining consistent with the rest of the file.","commit_id":"1e2b1fd1556b0e89209fc58030bd5438a66bb337"}],"oslo_config/tests/test_generator.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"1e58a4950cc6232357637ae594d6c952151ab52c","unresolved":false,"context_lines":[{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"class AdvancedOptionsTestCase(base.BaseTestCase):"},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"    opts \u003d [cfg.StrOpt(\u0027foo\u0027, help\u003d\u0027foo option\u0027, default\u003d\u0027fred\u0027),"},{"line_number":1171,"context_line":"            cfg.StrOpt(\u0027bar\u0027, help\u003d\u0027bar option\u0027, advanced\u003dTrue),"},{"line_number":1172,"context_line":"            cfg.StrOpt(\u0027foo_bar\u0027, help\u003d\u0027foobar\u0027),"},{"line_number":1173,"context_line":"            cfg.StrOpt(\u0027bars\u0027, help\u003d\u0027bars foo\u0027, default\u003d\u0027foos\u0027, advanced\u003dTrue)]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_fd675722","line":1170,"updated":"2016-06-14 16:09:15.000000000","message":"Might be good to add more variety to the option types here since this parameter is designed to not just work with StrOpt","commit_id":"60a96bec5714a0f28767d24de278ec50f9f840f2"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"fb00d312c21775c4dd53344d4a57d46c053c4fed","unresolved":false,"context_lines":[{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"class AdvancedOptionsTestCase(base.BaseTestCase):"},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"    opts \u003d [cfg.StrOpt(\u0027foo\u0027, help\u003d\u0027foo option\u0027, default\u003d\u0027fred\u0027),"},{"line_number":1171,"context_line":"            cfg.StrOpt(\u0027bar\u0027, help\u003d\u0027bar option\u0027, advanced\u003dTrue),"},{"line_number":1172,"context_line":"            cfg.StrOpt(\u0027foo_bar\u0027, help\u003d\u0027foobar\u0027),"},{"line_number":1173,"context_line":"            cfg.StrOpt(\u0027bars\u0027, help\u003d\u0027bars foo\u0027, default\u003d\u0027foos\u0027, advanced\u003dTrue)]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_7790694f","line":1170,"in_reply_to":"7aa08908_fd675722","updated":"2016-06-15 15:35:22.000000000","message":"Done","commit_id":"60a96bec5714a0f28767d24de278ec50f9f840f2"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f85d309fbcb2d690d5fa0a58f5c9fc9f7a74146b","unresolved":false,"context_lines":[{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"# bar option (string value)"},{"line_number":1198,"context_line":"# Advanced Option: not used by the majority of users and"},{"line_number":1199,"context_line":"# might have a significant affect to stability and/or"},{"line_number":1200,"context_line":"# performance."},{"line_number":1201,"context_line":"#bar \u003d \u003cNone\u003e"},{"line_number":1202,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_ed8ac819","line":1199,"range":{"start_line":1199,"start_character":9,"end_line":1199,"end_character":38},"updated":"2016-06-15 16:07:26.000000000","message":"Ditto comments in cfg.py","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2234656a37edde51fccf987bd17043c2eaf3fa7d","unresolved":false,"context_lines":[{"line_number":1196,"context_line":""},{"line_number":1197,"context_line":"# bar option (string value)"},{"line_number":1198,"context_line":"# Advanced Option: not used by the majority of users and"},{"line_number":1199,"context_line":"# might have a significant affect to stability and/or"},{"line_number":1200,"context_line":"# performance."},{"line_number":1201,"context_line":"#bar \u003d \u003cNone\u003e"},{"line_number":1202,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_692e93a6","line":1199,"range":{"start_line":1199,"start_character":9,"end_line":1199,"end_character":38},"in_reply_to":"7aa08908_ed8ac819","updated":"2016-06-16 15:25:56.000000000","message":"Done","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f85d309fbcb2d690d5fa0a58f5c9fc9f7a74146b","unresolved":false,"context_lines":[{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"# bars foo (boolean value)"},{"line_number":1204,"context_line":"# Advanced Option: not used by the majority of users and"},{"line_number":1205,"context_line":"# might have a significant affect to stability and/or"},{"line_number":1206,"context_line":"# performance."},{"line_number":1207,"context_line":"#bars \u003d true"},{"line_number":1208,"context_line":"\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_4d803cf8","line":1205,"range":{"start_line":1205,"start_character":5,"end_line":1205,"end_character":38},"updated":"2016-06-15 16:07:26.000000000","message":"Ditto comments in cfg.py","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2234656a37edde51fccf987bd17043c2eaf3fa7d","unresolved":false,"context_lines":[{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"# bars foo (boolean value)"},{"line_number":1204,"context_line":"# Advanced Option: not used by the majority of users and"},{"line_number":1205,"context_line":"# might have a significant affect to stability and/or"},{"line_number":1206,"context_line":"# performance."},{"line_number":1207,"context_line":"#bars \u003d true"},{"line_number":1208,"context_line":"\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_89193f8a","line":1205,"range":{"start_line":1205,"start_character":5,"end_line":1205,"end_character":38},"in_reply_to":"7aa08908_4d803cf8","updated":"2016-06-16 15:25:56.000000000","message":"Done","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"c0ee451517c50f8113388b67bb220d95e226a1a3","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"            generator._output_opts(formatter, \u0027alpha\u0027, groups.pop(\u0027alpha\u0027))"},{"line_number":1239,"context_line":"        expected \u003d \u0027\u0027\u0027[alpha]"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"#"},{"line_number":1242,"context_line":"# From namespace1"},{"line_number":1243,"context_line":"#"},{"line_number":1244,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_1f976991","line":1241,"updated":"2016-06-20 17:46:06.000000000","message":"NIT Would be nice to use textwrap.dedent() here so code lines up nicer.","commit_id":"ee443e9712479f0247d03ef6018d491246355034"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"1684e6b5454c8bb7751444677cbf7fcef4358c05","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"            generator._output_opts(formatter, \u0027alpha\u0027, groups.pop(\u0027alpha\u0027))"},{"line_number":1239,"context_line":"        expected \u003d \u0027\u0027\u0027[alpha]"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"#"},{"line_number":1242,"context_line":"# From namespace1"},{"line_number":1243,"context_line":"#"},{"line_number":1244,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_f5d25f5a","line":1241,"in_reply_to":"5a9d85d2_1f976991","updated":"2016-06-28 15:08:30.000000000","message":"Tried to keep it in line with the rest of the file.","commit_id":"ee443e9712479f0247d03ef6018d491246355034"}],"oslo_config/tests/test_sphinxext.py":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"f85d309fbcb2d690d5fa0a58f5c9fc9f7a74146b","unresolved":false,"context_lines":[{"line_number":358,"context_line":"          :Type: string"},{"line_number":359,"context_line":"          :Default: ``\u003cNone\u003e``"},{"line_number":360,"context_line":"          :Advanced Option: not used by the majority of users and"},{"line_number":361,"context_line":"          :might have a significant affect to stability and/or"},{"line_number":362,"context_line":"          :performance."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        \u0027\u0027\u0027).lstrip(), results)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_cd742c38","line":361,"range":{"start_line":361,"start_character":17,"end_line":361,"end_character":46},"updated":"2016-06-15 16:07:26.000000000","message":"Ditto comments in cfg.py","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2234656a37edde51fccf987bd17043c2eaf3fa7d","unresolved":false,"context_lines":[{"line_number":358,"context_line":"          :Type: string"},{"line_number":359,"context_line":"          :Default: ``\u003cNone\u003e``"},{"line_number":360,"context_line":"          :Advanced Option: not used by the majority of users and"},{"line_number":361,"context_line":"          :might have a significant affect to stability and/or"},{"line_number":362,"context_line":"          :performance."},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        \u0027\u0027\u0027).lstrip(), results)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_290beb2c","line":361,"range":{"start_line":361,"start_character":17,"end_line":361,"end_character":46},"in_reply_to":"7aa08908_cd742c38","updated":"2016-06-16 15:25:56.000000000","message":"Done","commit_id":"392a6d803059ec4caf2e4713fe7af1b629681a73"}]}