)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"eee84b7d55dd8802aaeb031a3b982567dd238713","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Sample Default Handling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sample default, if provided currently overrides"},{"line_number":10,"context_line":"a defualt value in sample files if set.  This aims"},{"line_number":11,"context_line":"to change this behavior to list the sample_default"},{"line_number":12,"context_line":"as an example if a default value is provided.  This"},{"line_number":13,"context_line":"will also change how the sample_default is presented"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a95cdbc_6cd4d946","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":9},"updated":"2016-10-06 14:32:08.000000000","message":"nit typo: default","commit_id":"4143277b7852b52c832978df75c8935a6e09c901"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"c5da74504a72edb13ea86cc6151b0f3e5ef18d98","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Sample Default Handling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sample default, if provided currently overrides"},{"line_number":10,"context_line":"a defualt value in sample files if set.  This aims"},{"line_number":11,"context_line":"to change this behavior to list the sample_default"},{"line_number":12,"context_line":"as an example if a default value is provided.  This"},{"line_number":13,"context_line":"will also change how the sample_default is presented"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a95cdbc_def58bcb","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":9},"in_reply_to":"1a95cdbc_6cd4d946","updated":"2016-10-06 15:58:04.000000000","message":"Done","commit_id":"4143277b7852b52c832978df75c8935a6e09c901"}],"doc/source/generator.rst":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"ef27bfe0239f4cb56d4baf9d3aca9640e39fa335","unresolved":false,"context_lines":[{"line_number":189,"context_line":"to not confuse the actual default from a sample default::"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    [DEFAULT]"},{"line_number":192,"context_line":"    # Example: /usr/lib/myapp"},{"line_number":193,"context_line":"    #base_dir \u003d /my/cwd"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"API"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a430d35_114a0c28","line":192,"range":{"start_line":192,"start_character":6,"end_line":192,"end_character":13},"updated":"2017-02-09 15:09:35.000000000","message":"s/Example/Sample value is better?","commit_id":"d3a2a0fbdb08d80e4ae7310055353125324952cf"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"2f313d7f9991322bc31f5fbfd9351314fa3d2cac","unresolved":false,"context_lines":[{"line_number":189,"context_line":"to not confuse the actual default from a sample default::"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    [DEFAULT]"},{"line_number":192,"context_line":"    # Example: /usr/lib/myapp"},{"line_number":193,"context_line":"    #base_dir \u003d /my/cwd"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"API"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a1ced50_d2c87aab","line":192,"range":{"start_line":192,"start_character":6,"end_line":192,"end_character":13},"in_reply_to":"1a430d35_114a0c28","updated":"2017-03-23 16:41:38.000000000","message":"Done","commit_id":"d3a2a0fbdb08d80e4ae7310055353125324952cf"}],"oslo_config/generator.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"940156a900b3933dce65748d6e53e1256d68b0a1","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                                      for choice in opt.type.choices])"},{"line_number":190,"context_line":"            lines.append(\u0027# Allowed values: %s\\n\u0027 % choices_text)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if opt.default is not None and opt.sample_default is not None:"},{"line_number":193,"context_line":"            lines.append(\u0027# Example: %s\\n\u0027 % opt.sample_default)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f1e19b2b","line":192,"updated":"2016-04-26 13:33:30.000000000","message":"Don\u0027t you want \"if opt.default is None ...\" here? Or to not check it at all?\n\nI can\u0027t think of any cases where it would make sense to set the sample_default and the actual default to different values.","commit_id":"0b0961bb0a1e4df57c0efbe17d7256a17f1ad948"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"aea012b75a7f4a64c04aa19da11d4adceb3b0045","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                                      for choice in opt.type.choices])"},{"line_number":190,"context_line":"            lines.append(\u0027# Allowed values: %s\\n\u0027 % choices_text)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if opt.default is not None and opt.sample_default is not None:"},{"line_number":193,"context_line":"            lines.append(\u0027# Example: %s\\n\u0027 % opt.sample_default)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d7f0c5ff","line":192,"in_reply_to":"1a122d0e_f1e19b2b","updated":"2016-04-26 20:27:51.000000000","message":"This prevents the sample_default presenting itself in the sample file as the actual default.  This way clearly allows us to define this is an example default value, not the actual default value.","commit_id":"0b0961bb0a1e4df57c0efbe17d7256a17f1ad948"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"940156a900b3933dce65748d6e53e1256d68b0a1","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            lines.append(\u0027# Allowed values: %s\\n\u0027 % choices_text)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if opt.default is not None and opt.sample_default is not None:"},{"line_number":193,"context_line":"            lines.append(\u0027# Example: %s\\n\u0027 % opt.sample_default)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            if opt.mutable:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f1b87b13","line":193,"updated":"2016-04-26 13:33:30.000000000","message":"This should probably use the formatting logic from lines 231-245 below where the default is emitted, to allow for multi-value options, dicts, etc. You could pull that out into a function to make it easier to reuse.","commit_id":"0b0961bb0a1e4df57c0efbe17d7256a17f1ad948"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"aea012b75a7f4a64c04aa19da11d4adceb3b0045","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            lines.append(\u0027# Allowed values: %s\\n\u0027 % choices_text)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if opt.default is not None and opt.sample_default is not None:"},{"line_number":193,"context_line":"            lines.append(\u0027# Example: %s\\n\u0027 % opt.sample_default)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            if opt.mutable:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b7f549ee","line":193,"in_reply_to":"1a122d0e_f1b87b13","updated":"2016-04-26 20:27:51.000000000","message":"Agreed, will update.","commit_id":"0b0961bb0a1e4df57c0efbe17d7256a17f1ad948"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"2c8c906d85ad783e0cf4ebe35e9fc30ceafc02bc","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            lines.append(\u0027# Allowed values: %s\\n\u0027 % choices_text)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        if opt.default is not None and opt.sample_default is not None:"},{"line_number":193,"context_line":"            lines.append(\u0027# Example: %s\\n\u0027 % opt.sample_default)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            if opt.mutable:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f7498132","line":193,"in_reply_to":"1a122d0e_f1b87b13","updated":"2016-04-26 20:31:34.000000000","message":"Done","commit_id":"0b0961bb0a1e4df57c0efbe17d7256a17f1ad948"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ef4f409a57fcefe1f8e46731eac120683879a0a0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"Return a list of formatted default values.\""},{"line_number":70,"context_line":"    if isinstance(opt, cfg.MultiStrOpt):"},{"line_number":71,"context_line":"        if not opt.default:"},{"line_number":72,"context_line":"            defaults \u003d [\u0027\u003cNone\u003e\u0027]"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            defaults \u003d opt.default"},{"line_number":75,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_9ee14301","line":72,"updated":"2016-10-06 15:59:20.000000000","message":"This changes the behavior when the default is the empty string. I think you want to treat that differently from None.","commit_id":"7178df5144543bea4e2339bbfb87d969cd147aed"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"7eed5c6e1a76ca46668ec22216b2e904c94a764a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"Return a list of formatted default values.\""},{"line_number":70,"context_line":"    if isinstance(opt, cfg.MultiStrOpt):"},{"line_number":71,"context_line":"        if not opt.default:"},{"line_number":72,"context_line":"            defaults \u003d [\u0027\u003cNone\u003e\u0027]"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            defaults \u003d opt.default"},{"line_number":75,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_8b72e2ab","line":72,"in_reply_to":"1a95cdbc_9ee14301","updated":"2016-10-06 17:00:10.000000000","message":"Done","commit_id":"7178df5144543bea4e2339bbfb87d969cd147aed"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"4d35df5d1a37b5e0440a78c02c5359d3a0068965","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"Return a list of formatted default values.\""},{"line_number":70,"context_line":"    if isinstance(opt, cfg.MultiStrOpt):"},{"line_number":71,"context_line":"        if not opt.default:"},{"line_number":72,"context_line":"            defaults \u003d [\u0027\u003cNone\u003e\u0027]"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            defaults \u003d opt.default"},{"line_number":75,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_de210bb6","line":72,"in_reply_to":"1a95cdbc_9ee14301","updated":"2016-10-06 16:07:20.000000000","message":"Yea, I was torn on this.  Sphinx will present it as \n:Default:\nThis was the prior behavior, did we want to just keep it this way or call out that it\u0027s \u003cNone\u003e?","commit_id":"7178df5144543bea4e2339bbfb87d969cd147aed"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"334f17a25a2aebe3e0ca472367d306bdd1ef91cd","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            defaults \u003d opt.default"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        if opt.sample_default is not None:"},{"line_number":90,"context_line":"            default_str \u003d str(opt.sample_default)"},{"line_number":91,"context_line":"        elif opt.default is None:"},{"line_number":92,"context_line":"            default_str \u003d \u0027\u003cNone\u003e\u0027"},{"line_number":93,"context_line":"        elif (isinstance(opt, (cfg.StrOpt, cfg.IPOpt,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_b651f9db","side":"PARENT","line":90,"updated":"2017-04-10 20:45:54.000000000","message":"I still think we should use a sentinel value if a sample_default is set so there\u0027s no confusion.  For example, you might have:\n\n# Hostname of this node. Defaults to this system\u0027s current hostname\n# (string value)\n# Example:\n#   hostname \u003d my-hostname\n#hostname \u003d \u003cDefault varies, see help and example\u003e\n\nOr maybe \"description and example\".  Not sure which would be more clear.  Maybe they\u0027re both fine.","commit_id":"efb287a94645b15b634e8c344352696ff85c219f"}],"oslo_config/tests/test_generator.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"1a53c5ab53c891733cea838859fb18f9b5b73b3c","unresolved":false,"context_lines":[{"line_number":730,"context_line":"#"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"# multiple strings (multi valued)"},{"line_number":733,"context_line":"# Example: [\u00275\u0027, \u00276\u0027]"},{"line_number":734,"context_line":"#multi_opt \u003d 1"},{"line_number":735,"context_line":"#multi_opt \u003d 2"},{"line_number":736,"context_line":"#multi_opt \u003d 3"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_0448db5a","line":733,"updated":"2016-11-21 23:27:54.000000000","message":"Is this a valid example for a multi-opt?  As in, would\n\nmulti_opt \u003d [\u00275\u0027, \u00276\u0027]\n\nresult in the same thing as\n\nmulti_opt \u003d 5\nmulti_opt \u003d 6\n\n?  I don\u0027t know that I would -1 for it since I don\u0027t off-hand have a better suggestion for formatting the example, but I think it\u0027s worth some consideration.","commit_id":"d3a2a0fbdb08d80e4ae7310055353125324952cf"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f8db7f7cd7b0513ce7e228dca183a1df9c187d61","unresolved":false,"context_lines":[{"line_number":730,"context_line":"#"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"# multiple strings (multi valued)"},{"line_number":733,"context_line":"# Example: [\u00275\u0027, \u00276\u0027]"},{"line_number":734,"context_line":"#multi_opt \u003d 1"},{"line_number":735,"context_line":"#multi_opt \u003d 2"},{"line_number":736,"context_line":"#multi_opt \u003d 3"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_65a8eada","line":733,"in_reply_to":"1a1ced50_b29e9eb6","updated":"2017-03-30 16:29:06.000000000","message":"The only good(?) thought I have is maybe something like:\n\n# Example:\n#   multi_opt \u003d 1\n#   multi_opt \u003d 2\n\nAnybody familiar with RST or YAML should understand that the indented block is the example.","commit_id":"d3a2a0fbdb08d80e4ae7310055353125324952cf"},{"author":{"_account_id":7037,"name":"John Perkins","email":"john.perkins@rackspace.com","username":"JPerkins"},"change_message_id":"2f313d7f9991322bc31f5fbfd9351314fa3d2cac","unresolved":false,"context_lines":[{"line_number":730,"context_line":"#"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"# multiple strings (multi valued)"},{"line_number":733,"context_line":"# Example: [\u00275\u0027, \u00276\u0027]"},{"line_number":734,"context_line":"#multi_opt \u003d 1"},{"line_number":735,"context_line":"#multi_opt \u003d 2"},{"line_number":736,"context_line":"#multi_opt \u003d 3"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a1ced50_b29e9eb6","line":733,"in_reply_to":"7a77a97e_0448db5a","updated":"2017-03-23 16:41:38.000000000","message":"Any ideas yet on how you\u0027d like to see this example changed?","commit_id":"d3a2a0fbdb08d80e4ae7310055353125324952cf"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"ef27bfe0239f4cb56d4baf9d3aca9640e39fa335","unresolved":false,"context_lines":[{"line_number":730,"context_line":"#"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"# multiple strings (multi valued)"},{"line_number":733,"context_line":"# Example: [\u00275\u0027, \u00276\u0027]"},{"line_number":734,"context_line":"#multi_opt \u003d 1"},{"line_number":735,"context_line":"#multi_opt \u003d 2"},{"line_number":736,"context_line":"#multi_opt \u003d 3"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a430d35_3178e82b","line":733,"in_reply_to":"7a77a97e_0448db5a","updated":"2017-02-09 15:09:35.000000000","message":"same concern","commit_id":"d3a2a0fbdb08d80e4ae7310055353125324952cf"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"dc8200e5243f0a48153e9596d4f63df017303b65","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"        self.assertEqual(expected, actual)"},{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":""},{"line_number":1365,"context_line":"class SampleDefaultTestCase(base.BaseTestCase):"},{"line_number":1366,"context_line":""},{"line_number":1367,"context_line":"    def _generate_tmp_file(self, opts):"},{"line_number":1368,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_65cfcab0","line":1365,"updated":"2017-03-30 17:19:44.000000000","message":"I can\u0027t remember if I noticed this before, but why are these tests being added as a new class instead of as additional scenarios in the existing one?  Is there something about the current scenario tests that isn\u0027t compatible with this?  I don\u0027t see any reason that would be the case.","commit_id":"284eaa951355ef7da86038c0268837cb3e954220"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"334f17a25a2aebe3e0ca472367d306bdd1ef91cd","unresolved":false,"context_lines":[{"line_number":735,"context_line":"#"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"# multiple strings (multi valued)"},{"line_number":738,"context_line":"# Example: [\u00275\u0027, \u00276\u0027]"},{"line_number":739,"context_line":"#multi_opt \u003d 1"},{"line_number":740,"context_line":"#multi_opt \u003d 2"},{"line_number":741,"context_line":"#multi_opt \u003d 3"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_360cc9ea","line":738,"updated":"2017-04-10 20:45:54.000000000","message":"This isn\u0027t what I suggested on the previous patch set.  Is there a reason for that?","commit_id":"943ce4c805da865efe56da7b955fcb6c776f07dd"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9c7a2232aebf652f1d2cbd22a15909c73dba4a3b","unresolved":false,"context_lines":[{"line_number":947,"context_line":""},{"line_number":948,"context_line":"        fd, tmp_file \u003d tempfile.mkstemp()"},{"line_number":949,"context_line":"        with open(tmp_file, \u0027w+\u0027) as f:"},{"line_number":950,"context_line":"            formatter \u003d generator._OptFormatter(output_file\u003df)"},{"line_number":951,"context_line":"            generator._output_opts(formatter, \u0027alpha\u0027, groups.pop(\u0027alpha\u0027))"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        return tmp_file"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_c1a0cea8","line":950,"updated":"2017-04-05 21:00:14.000000000","message":"Since we can pass a file handle here, why not use a StringIO instance instead of actually writing to disk and then re-reading it?","commit_id":"943ce4c805da865efe56da7b955fcb6c776f07dd"}],"oslo_config/tests/test_sphinxext.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9c7a2232aebf652f1d2cbd22a15909c73dba4a3b","unresolved":false,"context_lines":[{"line_number":452,"context_line":"          :Default: ``1``"},{"line_number":453,"context_line":"          :Default: ``2``"},{"line_number":454,"context_line":"          :Default: ``3``"},{"line_number":455,"context_line":"          :Example: ``[\u00275\u0027, \u00276\u0027]``"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        \u0027\u0027\u0027).lstrip(), results)"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bff0334d_e1ef52ae","line":455,"updated":"2017-04-05 21:00:14.000000000","message":"The difference between the \"default\" and \"example\" values here is surprising. Is the example format actually valid? Or do the values have to be specified as separate lines? Should the example and default formatting be the same or at least similar? I think this is related to bnemec\u0027s earlier comments in the other test file.","commit_id":"943ce4c805da865efe56da7b955fcb6c776f07dd"}],"oslo_config/types.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"86a09c04aed16588dd75773ece525b286ffe1a57","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        if sample_default is not None \\"},{"line_number":42,"context_line":"                and default is None:"},{"line_number":43,"context_line":"            default_str \u003d \u0027\u003cexample: %s\u003e\u0027 % self._formatter(sample_default)"},{"line_number":44,"context_line":"        elif default is None:"},{"line_number":45,"context_line":"            default_str \u003d self.NONE_DEFAULT"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_3a665851","line":42,"updated":"2016-07-11 21:11:47.000000000","message":"style nit: use one line or wrap in parentheses for line continuation","commit_id":"02a47ed712edd7a0a3d47802fab354c25573baff"}],"releasenotes/notes/add-sample-default-handling-c418e28da8196e37.yaml":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9c7a2232aebf652f1d2cbd22a15909c73dba4a3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - sample_default, with regard to generator sample files, would"},{"line_number":4,"context_line":"    overwrite default values, potentially causing confusion. The"},{"line_number":5,"context_line":"    behavior was adjusted to still present what the default value"},{"line_number":6,"context_line":"    would potentially be, but if a sample_default is configured,"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bff0334d_014fd6bd","line":3,"updated":"2017-04-05 21:00:14.000000000","message":"The tense and phrasing here is a little awkward. How about\n\n  The sample default value in generated sample configuration files used to\n  overwrite the default value, ...","commit_id":"943ce4c805da865efe56da7b955fcb6c776f07dd"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9c7a2232aebf652f1d2cbd22a15909c73dba4a3b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - sample_default, with regard to generator sample files, would"},{"line_number":4,"context_line":"    overwrite default values, potentially causing confusion. The"},{"line_number":5,"context_line":"    behavior was adjusted to still present what the default value"},{"line_number":6,"context_line":"    would potentially be, but if a sample_default is configured,"},{"line_number":7,"context_line":"    the sample file will print the sample_default as an example."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bff0334d_a1cb8a1c","line":6,"updated":"2017-04-05 21:00:14.000000000","message":"s/would potentially be/is/","commit_id":"943ce4c805da865efe56da7b955fcb6c776f07dd"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9c7a2232aebf652f1d2cbd22a15909c73dba4a3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    overwrite default values, potentially causing confusion. The"},{"line_number":5,"context_line":"    behavior was adjusted to still present what the default value"},{"line_number":6,"context_line":"    would potentially be, but if a sample_default is configured,"},{"line_number":7,"context_line":"    the sample file will print the sample_default as an example."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bff0334d_21d77ac2","line":7,"updated":"2017-04-05 21:00:14.000000000","message":"s/print/include/","commit_id":"943ce4c805da865efe56da7b955fcb6c776f07dd"}]}