)]}'
{"oslo_config/sphinxconfiggen.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0ac6ddb77652f3c027f4b405c8367a17c3e9a7aa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                 \"skipping sample config generation\")"},{"line_number":25,"context_line":"        return"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Decided to update the existing config option config_generator_config_file to"},{"line_number":28,"context_line":"# support a value that is a list of tuples, containing the file names as"},{"line_number":29,"context_line":"# (input, output)."},{"line_number":30,"context_line":"# We need to retain support for the option referring to a single string,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_aac73f94","line":27,"updated":"2016-05-11 17:09:57.000000000","message":"This comment should be indented the same amount as the code to which it refers.","commit_id":"f4e301caa8a930f0ae6973234248f7b03ce22d25"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"c649e3595e1d5293805a0e910834f3f209b9b485","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                 \"skipping sample config generation\")"},{"line_number":25,"context_line":"        return"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# Decided to update the existing config option config_generator_config_file to"},{"line_number":28,"context_line":"# support a value that is a list of tuples, containing the file names as"},{"line_number":29,"context_line":"# (input, output)."},{"line_number":30,"context_line":"# We need to retain support for the option referring to a single string,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_2a2eaffa","line":27,"in_reply_to":"dab17558_aac73f94","updated":"2016-05-11 17:14:57.000000000","message":"Done","commit_id":"f4e301caa8a930f0ae6973234248f7b03ce22d25"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"62f9ddc052b0fcf9e6c34065ecad32c915d0f7b4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# being a single string."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if isinstance(app.config.config_generator_config_file, list):"},{"line_number":38,"context_line":"        for config_file, base_name in app.config.config_generator_config_file:"},{"line_number":39,"context_line":"            if base_name is None:"},{"line_number":40,"context_line":"                base_name \u003d _get_default_basename(config_file)"},{"line_number":41,"context_line":"        _generate_sample(app, config_file, base_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_ef767904","line":38,"range":{"start_line":38,"start_character":38,"end_line":38,"end_character":77},"updated":"2016-05-11 17:04:30.000000000","message":"Should we do type validation on this to ensure everything is a tuple as we desire?","commit_id":"f4e301caa8a930f0ae6973234248f7b03ce22d25"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0ac6ddb77652f3c027f4b405c8367a17c3e9a7aa","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# being a single string."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if isinstance(app.config.config_generator_config_file, list):"},{"line_number":38,"context_line":"        for config_file, base_name in app.config.config_generator_config_file:"},{"line_number":39,"context_line":"            if base_name is None:"},{"line_number":40,"context_line":"                base_name \u003d _get_default_basename(config_file)"},{"line_number":41,"context_line":"        _generate_sample(app, config_file, base_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_ca4f2332","line":38,"range":{"start_line":38,"start_character":38,"end_line":38,"end_character":77},"in_reply_to":"dab17558_ef767904","updated":"2016-05-11 17:09:57.000000000","message":"That\u0027s not necessary. If it\u0027s not a 2-member-tuple this will throw an exception when we iterate over it.","commit_id":"f4e301caa8a930f0ae6973234248f7b03ce22d25"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0ac6ddb77652f3c027f4b405c8367a17c3e9a7aa","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        for config_file, base_name in app.config.config_generator_config_file:"},{"line_number":39,"context_line":"            if base_name is None:"},{"line_number":40,"context_line":"                base_name \u003d _get_default_basename(config_file)"},{"line_number":41,"context_line":"        _generate_sample(app, config_file, base_name)"},{"line_number":42,"context_line":"    else:"},{"line_number":43,"context_line":"        _generate_sample(app,"},{"line_number":44,"context_line":"                         app.config.config_generator_config_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_6a0ef7e5","line":41,"updated":"2016-05-11 17:09:57.000000000","message":"This should probably be indented one more level so it is inside the loop, right?","commit_id":"f4e301caa8a930f0ae6973234248f7b03ce22d25"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"c649e3595e1d5293805a0e910834f3f209b9b485","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        for config_file, base_name in app.config.config_generator_config_file:"},{"line_number":39,"context_line":"            if base_name is None:"},{"line_number":40,"context_line":"                base_name \u003d _get_default_basename(config_file)"},{"line_number":41,"context_line":"        _generate_sample(app, config_file, base_name)"},{"line_number":42,"context_line":"    else:"},{"line_number":43,"context_line":"        _generate_sample(app,"},{"line_number":44,"context_line":"                         app.config.config_generator_config_file,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_caec43bd","line":41,"in_reply_to":"dab17558_6a0ef7e5","updated":"2016-05-11 17:14:57.000000000","message":"Bah, silly!\nWill fix it.","commit_id":"f4e301caa8a930f0ae6973234248f7b03ce22d25"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"62f9ddc052b0fcf9e6c34065ecad32c915d0f7b4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if not os.path.isdir(os.path.dirname(os.path.abspath(out_file))):"},{"line_number":77,"context_line":"            os.mkdir(os.path.dirname(os.path.abspath(out_file)))"},{"line_number":78,"context_line":"    else:"},{"line_number":79,"context_line":"        file_name \u003d \u0027sample.config\u0027"},{"line_number":80,"context_line":"        out_file \u003d os.path.join(app.srcdir, file_name)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    info(\u0027writing sample configuration to %s\u0027 % out_file)"},{"line_number":83,"context_line":"    generator.main(args\u003d[\u0027--config-file\u0027, config_path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_8a66bbea","line":80,"range":{"start_line":79,"start_character":1,"end_line":80,"end_character":54},"updated":"2016-05-11 17:04:30.000000000","message":"Although I introduced a way to derive basename from config file, I left this as-is for backwards compatibility reasons just in case. Let me know if this is not required.","commit_id":"f4e301caa8a930f0ae6973234248f7b03ce22d25"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0ac6ddb77652f3c027f4b405c8367a17c3e9a7aa","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if not os.path.isdir(os.path.dirname(os.path.abspath(out_file))):"},{"line_number":77,"context_line":"            os.mkdir(os.path.dirname(os.path.abspath(out_file)))"},{"line_number":78,"context_line":"    else:"},{"line_number":79,"context_line":"        file_name \u003d \u0027sample.config\u0027"},{"line_number":80,"context_line":"        out_file \u003d os.path.join(app.srcdir, file_name)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    info(\u0027writing sample configuration to %s\u0027 % out_file)"},{"line_number":83,"context_line":"    generator.main(args\u003d[\u0027--config-file\u0027, config_path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_8a1ebb09","line":80,"range":{"start_line":79,"start_character":1,"end_line":80,"end_character":54},"in_reply_to":"dab17558_8a66bbea","updated":"2016-05-11 17:09:57.000000000","message":"I agree, let\u0027s keep this until we drop support for the option holding a single string.","commit_id":"f4e301caa8a930f0ae6973234248f7b03ce22d25"}]}