)]}'
{"oslo_config/types.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"1001c1ed7f39489bb3f9a5fd8157a7cecd6cab1f","unresolved":false,"context_lines":[{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def __init__(self, max_length\u003dNone, type_name\u003d\u0027uri value\u0027):"},{"line_number":678,"context_line":"        super(URI, self).__init__(type_name\u003dtype_name)"},{"line_number":679,"context_line":"        self.max_length \u003d max_length or 0"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"    def __call__(self, value):"},{"line_number":682,"context_line":"        if not rfc3986.is_valid_uri(value, require_scheme\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_5ef63491","line":679,"updated":"2016-07-13 22:15:45.000000000","message":"How about:\n\n \u003e\u003e\u003e if max_length is None:\n ...    self.max_length \u003d -1\n ... else:\n ...    self.max_length \u003d max_length\n ... \n\nUsing a length of zero that is a valid length (zero length means no length, not infinite length in my view) seems bad, at least with the above negative values will be used to distinguish the lack of any length limit.\n\nOther option; just use the initial None and do,\n\n  if self.max_length is not None and len(value) \u003e self.max_length:","commit_id":"0ba83310ca6a2626fe52d9430df0370834f0bcb3"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"6ba98f90a22875e085cd081238a7e74d95829784","unresolved":false,"context_lines":[{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def __init__(self, max_length\u003dNone, type_name\u003d\u0027uri value\u0027):"},{"line_number":678,"context_line":"        super(URI, self).__init__(type_name\u003dtype_name)"},{"line_number":679,"context_line":"        self.max_length \u003d max_length or 0"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"    def __call__(self, value):"},{"line_number":682,"context_line":"        if not rfc3986.is_valid_uri(value, require_scheme\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_eb4f5268","line":679,"in_reply_to":"1aa78d24_5ef63491","updated":"2016-07-14 08:00:27.000000000","message":"how about this:\n\ndef __init__(self, max_length\u003d-1, type_name\u003d\u0027uri value\u0027):\n    self.max_length \u003d max_length if isinstance(max_length,Int) and max_length \u003e 0 else Raise...","commit_id":"0ba83310ca6a2626fe52d9430df0370834f0bcb3"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"d1da23f6d1f8510688e166cb720fda5a93292d48","unresolved":false,"context_lines":[{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def __init__(self, max_length\u003dNone, type_name\u003d\u0027uri value\u0027):"},{"line_number":678,"context_line":"        super(URI, self).__init__(type_name\u003dtype_name)"},{"line_number":679,"context_line":"        self.max_length \u003d max_length or 0"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"    def __call__(self, value):"},{"line_number":682,"context_line":"        if not rfc3986.is_valid_uri(value, require_scheme\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_fb46e91f","line":679,"in_reply_to":"1aa78d24_b2f3fa9e","updated":"2016-07-14 15:25:43.000000000","message":"The only reason I chose this way is to be consistent with StrOpt. I\u0027m happy to change to a None if we\u0027re okay that be different than StrOpt. Thoughts?","commit_id":"0ba83310ca6a2626fe52d9430df0370834f0bcb3"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"640bf274c850598febd35b436b10ccf10c5bfd66","unresolved":false,"context_lines":[{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def __init__(self, max_length\u003dNone, type_name\u003d\u0027uri value\u0027):"},{"line_number":678,"context_line":"        super(URI, self).__init__(type_name\u003dtype_name)"},{"line_number":679,"context_line":"        self.max_length \u003d max_length or 0"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"    def __call__(self, value):"},{"line_number":682,"context_line":"        if not rfc3986.is_valid_uri(value, require_scheme\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_b2f3fa9e","line":679,"in_reply_to":"1aa78d24_eb4f5268","updated":"2016-07-14 08:56:58.000000000","message":"I like Josh\u0027s suggestion","commit_id":"0ba83310ca6a2626fe52d9430df0370834f0bcb3"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"96e74e9e30aa0aa693dd30f88c36a4ac1841a508","unresolved":false,"context_lines":[{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def __init__(self, max_length\u003dNone, type_name\u003d\u0027uri value\u0027):"},{"line_number":678,"context_line":"        super(URI, self).__init__(type_name\u003dtype_name)"},{"line_number":679,"context_line":"        self.max_length \u003d max_length or 0"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"    def __call__(self, value):"},{"line_number":682,"context_line":"        if not rfc3986.is_valid_uri(value, require_scheme\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_96ba1c70","line":679,"in_reply_to":"1aa78d24_fb46e91f","updated":"2016-07-14 15:56:35.000000000","message":"why we set max_length\u003dNone as default, and set it to 0 ?\nso I like Josh\u0027s 2nd suggestion\n\nas for StrOpt, the same opinion, I don\u0027t know weather is appropriate to change this snip of StrOpt, if yes, change it also.","commit_id":"0ba83310ca6a2626fe52d9430df0370834f0bcb3"}]}
