)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"72bdf1acdc96ddc5f48f5fad4d8d48bdeebba88b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"When the opt is set to HostnameOpt type, currently even an"},{"line_number":12,"context_line":"incomplete or invalid IP passes as a valid hostname."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"According to RFC 1123, (https://tools.ietf.org/html/rfc1123#section-6.1.2.4),"},{"line_number":15,"context_line":"a valid host name can never have the dotted-decimal form #.#.#.#,"},{"line_number":16,"context_line":"since at least the highest-level component label will be alphabetic."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"fa6399be_3c6732ea","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":75},"updated":"2016-10-14 03:07:56.000000000","message":"s2.1?","commit_id":"cce0568cb422efde08f4c95112e1a617aa327484"}],"oslo_config/cfg.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"c1d1a25172bc50237bfb830f67e5738f34eca326","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"class HostAddressOpt(Opt):"},{"line_number":1281,"context_line":"    \"\"\"Option for either an IP or a hostname."},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"       Accepts valid hostnames and valid IP addresses."},{"line_number":1284,"context_line":"    \"\"\""},{"line_number":1285,"context_line":""},{"line_number":1286,"context_line":"    def __init__(self, name, version\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_2ee319a5","line":1283,"updated":"2016-08-20 10:59:08.000000000","message":"Please add versionadded","commit_id":"dc5f57a080a9b2685faf87dea01ef284eaa32bf4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ff5282d00fa6e3a72984714b29fca58a531643b9","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":"Type                                  Option"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":":class:`oslo_config.types.String`     - :class:`oslo_config.cfg.StrOpt`"},{"line_number":53,"context_line":"                                      - :class:`oslo_config.cfg.SubCommandOpt`"},{"line_number":54,"context_line":":class:`oslo_config.types.Boolean`    :class:`oslo_config.cfg.BoolOpt`"},{"line_number":55,"context_line":":class:`oslo_config.types.Integer`    - :class:`oslo_config.cfg.IntOpt`"},{"line_number":56,"context_line":"                                      - :class:`oslo_config.cfg.PortOpt`"},{"line_number":57,"context_line":":class:`oslo_config.types.Float`      :class:`oslo_config.cfg.FloatOpt`"},{"line_number":58,"context_line":":class:`oslo_config.types.List`       :class:`oslo_config.cfg.ListOpt`"},{"line_number":59,"context_line":":class:`oslo_config.types.Dict`       :class:`oslo_config.cfg.DictOpt`"},{"line_number":60,"context_line":":class:`oslo_config.types.IPAddress`  :class:`oslo_config.cfg.IPOpt`"},{"line_number":61,"context_line":":class:`oslo_config.types.Hostname`   :class:`oslo_config.cfg.HostnameOpt`"},{"line_number":62,"context_line":":class:`oslo_config.types.URI`        :class:`oslo_config.cfg.URIOpt`"},{"line_number":63,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For :class:`oslo_config.cfg.MultiOpt` the `item_type` parameter defines"},{"line_number":66,"context_line":"the type of the values. For convenience, :class:`oslo_config.cfg.MultiStrOpt`"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_0cf51482","line":63,"range":{"start_line":51,"start_character":1,"end_line":63,"end_character":44},"updated":"2016-08-28 23:36:41.000000000","message":"HostAddressOpt missing here","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"92aa6944e3f371ea1b13ff404bc72c0d80bb3d1e","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":"Type                                  Option"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":":class:`oslo_config.types.String`     - :class:`oslo_config.cfg.StrOpt`"},{"line_number":53,"context_line":"                                      - :class:`oslo_config.cfg.SubCommandOpt`"},{"line_number":54,"context_line":":class:`oslo_config.types.Boolean`    :class:`oslo_config.cfg.BoolOpt`"},{"line_number":55,"context_line":":class:`oslo_config.types.Integer`    - :class:`oslo_config.cfg.IntOpt`"},{"line_number":56,"context_line":"                                      - :class:`oslo_config.cfg.PortOpt`"},{"line_number":57,"context_line":":class:`oslo_config.types.Float`      :class:`oslo_config.cfg.FloatOpt`"},{"line_number":58,"context_line":":class:`oslo_config.types.List`       :class:`oslo_config.cfg.ListOpt`"},{"line_number":59,"context_line":":class:`oslo_config.types.Dict`       :class:`oslo_config.cfg.DictOpt`"},{"line_number":60,"context_line":":class:`oslo_config.types.IPAddress`  :class:`oslo_config.cfg.IPOpt`"},{"line_number":61,"context_line":":class:`oslo_config.types.Hostname`   :class:`oslo_config.cfg.HostnameOpt`"},{"line_number":62,"context_line":":class:`oslo_config.types.URI`        :class:`oslo_config.cfg.URIOpt`"},{"line_number":63,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"For :class:`oslo_config.cfg.MultiOpt` the `item_type` parameter defines"},{"line_number":66,"context_line":"the type of the values. For convenience, :class:`oslo_config.cfg.MultiStrOpt`"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_8e5d6717","line":63,"range":{"start_line":51,"start_character":1,"end_line":63,"end_character":44},"in_reply_to":"fa7ab95a_0cf51482","updated":"2016-08-29 17:26:56.000000000","message":"Done","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ff5282d00fa6e3a72984714b29fca58a531643b9","unresolved":false,"context_lines":[{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"       Accepts valid hostnames and valid IP addresses."},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"       .. versionadded:: 3.17.0"},{"line_number":1286,"context_line":"    \"\"\""},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"    def __init__(self, name, version\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_4cd8fc1d","line":1285,"range":{"start_line":1285,"start_character":25,"end_line":1285,"end_character":31},"updated":"2016-08-28 23:36:41.000000000","message":"Should be 3.18.0 now","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"92aa6944e3f371ea1b13ff404bc72c0d80bb3d1e","unresolved":false,"context_lines":[{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"       Accepts valid hostnames and valid IP addresses."},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"       .. versionadded:: 3.17.0"},{"line_number":1286,"context_line":"    \"\"\""},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"    def __init__(self, name, version\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_ae9cebc0","line":1285,"range":{"start_line":1285,"start_character":25,"end_line":1285,"end_character":31},"in_reply_to":"fa7ab95a_4cd8fc1d","updated":"2016-08-29 17:26:56.000000000","message":"Done","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"aaf1f16ed4074d6fd54a400189e5ab2547685f16","unresolved":false,"context_lines":[{"line_number":1324,"context_line":""},{"line_number":1325,"context_line":"       Accepts valid hostnames and valid IP addresses."},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"       .. versionadded:: 3.18.0"},{"line_number":1328,"context_line":"    \"\"\""},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"    def __init__(self, name, version\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa6399be_6732c7a8","line":1327,"range":{"start_line":1327,"start_character":10,"end_line":1327,"end_character":22},"updated":"2016-10-15 00:23:42.000000000","message":"this versionadded? You make a good point. I don\u0027t know that it should be 3.18.0.\n\nJust pattern matching, everyone else has a versionadded M.N, not P.Q.R.\n\nI don\u0027t see a 3.17, is there a reason you skipped that?\n\ntruth be told, I don\u0027t know what the right answer is","commit_id":"34815b281b06f9acdbd690f08f713f27a067fa9b"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"420b7d6b352031bcf94cc7caaa6cb6f78663b611","unresolved":false,"context_lines":[{"line_number":1324,"context_line":""},{"line_number":1325,"context_line":"       Accepts valid hostnames and valid IP addresses."},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"       .. versionadded:: 3.18.0"},{"line_number":1328,"context_line":"    \"\"\""},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"    def __init__(self, name, version\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a629dbe_9b757965","line":1327,"range":{"start_line":1327,"start_character":10,"end_line":1327,"end_character":22},"in_reply_to":"fa6399be_6732c7a8","updated":"2016-11-11 09:27:43.000000000","message":"Please add the version in format X.Y ,this value is the target version to merge. in other word, if current version is 3.18,you should set it with 3.19.","commit_id":"34815b281b06f9acdbd690f08f713f27a067fa9b"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"065f8297145323d6c8258542b840443c12006011","unresolved":false,"context_lines":[{"line_number":1324,"context_line":""},{"line_number":1325,"context_line":"       Accepts valid hostnames and valid IP addresses."},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"       .. versionadded:: 3.18"},{"line_number":1328,"context_line":"    \"\"\""},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"    def __init__(self, name, version\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a71b18c_cb29d29c","line":1327,"range":{"start_line":1327,"start_character":24,"end_line":1327,"end_character":29},"updated":"2016-12-07 02:15:56.000000000","message":"should be 3.22 now, we just release 3.21 in https://review.openstack.org/#/c/407719/2/deliverables/ocata/oslo.config.yaml","commit_id":"1ea78cf5dfd159b50914fc7750875941d8a00626"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"923f494d89c925797465d183237d21787580bc6c","unresolved":false,"context_lines":[{"line_number":1324,"context_line":""},{"line_number":1325,"context_line":"       Accepts valid hostnames and valid IP addresses."},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"       .. versionadded:: 3.18"},{"line_number":1328,"context_line":"    \"\"\""},{"line_number":1329,"context_line":""},{"line_number":1330,"context_line":"    def __init__(self, name, version\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a71b18c_fc2bb27f","line":1327,"range":{"start_line":1327,"start_character":24,"end_line":1327,"end_character":29},"in_reply_to":"3a71b18c_cb29d29c","updated":"2016-12-07 03:28:17.000000000","message":"Done","commit_id":"1ea78cf5dfd159b50914fc7750875941d8a00626"}],"oslo_config/tests/test_types.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f694cc224027cd5e2b2adffc2a6681e321858aa0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def assertConvertedValue(self, s, expected):"},{"line_number":47,"context_line":"        self.assertEqual(expected, self.type_instance(s))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def assertInvalid(self, value):"},{"line_number":50,"context_line":"        self.assertRaises(ValueError, self.type_instance, value)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_8f786a91","line":49,"updated":"2016-09-09 17:57:14.000000000","message":"you may need to add another assert method here","commit_id":"9bd628f170dbd8b7b1a7a61953ff363ae1ef125e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f694cc224027cd5e2b2adffc2a6681e321858aa0","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    def test_valid_host_addresses(self):"},{"line_number":701,"context_line":"        try:"},{"line_number":702,"context_line":"            self.assertInvalid(\u0027foo.bar\u0027)"},{"line_number":703,"context_line":"            self.assertInvalid(\u0027192.168.0.1\u0027)"},{"line_number":704,"context_line":"            self.assertInvalid(\u0027abcd:ef::1\u0027)"},{"line_number":705,"context_line":"            self.assertInvalid(\u0027home-site-here.org.com\u0027)"},{"line_number":706,"context_line":"        except AssertionError:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_4f1ae26f","line":703,"range":{"start_line":703,"start_character":12,"end_line":703,"end_character":45},"updated":"2016-09-09 17:57:14.000000000","message":"I don\u0027t think this will work.\n\nThe first statement will raise and you will see a pass so other negative test cases will not be tested. \n\nIf first one fails and even if one of the others is valid the test will pass which isn\u0027t what\u0027s intended.","commit_id":"9bd628f170dbd8b7b1a7a61953ff363ae1ef125e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d3df68b8b5aabf977d0f95d7e4a52d6648d0fca4","unresolved":false,"context_lines":[{"line_number":693,"context_line":"    def test_invalid_host_addresses(self):"},{"line_number":694,"context_line":"        self.assertInvalid(\u0027-1\u0027)"},{"line_number":695,"context_line":"        self.assertInvalid(\u0027_foo\u0027)"},{"line_number":696,"context_line":"        self.assertInvalid(\u00273.14\u0027)"},{"line_number":697,"context_line":"        self.assertInvalid(\u002710.0\u0027)"},{"line_number":698,"context_line":"        self.assertInvalid(\u0027host..name\u0027)"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_02b9b1ec","line":696,"updated":"2016-09-19 20:29:59.000000000","message":"Do you know if RFC 1123 is currently the governing document for IANA host names?\n\nMy reading of RFC 1123 and RFC 952 is that \u00273.14\u0027 would be a legal host name (even though it\u0027s an illegal IPv4).  See section 2.1 in RFC 1123 (allows first char of name to be a digit), and see RFC 952 for the grammar.","commit_id":"215a003496d8717a98af03f67bdec2bd01576e71"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"0494c936b69201e0feb4603d1105eed6541c73c1","unresolved":false,"context_lines":[{"line_number":693,"context_line":"    def test_invalid_host_addresses(self):"},{"line_number":694,"context_line":"        self.assertInvalid(\u0027-1\u0027)"},{"line_number":695,"context_line":"        self.assertInvalid(\u0027_foo\u0027)"},{"line_number":696,"context_line":"        self.assertInvalid(\u00273.14\u0027)"},{"line_number":697,"context_line":"        self.assertInvalid(\u002710.0\u0027)"},{"line_number":698,"context_line":"        self.assertInvalid(\u0027host..name\u0027)"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a95cdbc_d75649d1","line":696,"in_reply_to":"1a95cdbc_81b483d1","updated":"2016-10-06 18:29:59.000000000","message":"Thank you Brian Stajkowski.\nUpdating this test file to make sure that a hostname beginning with a number but not having all digits is accepted as a valid hostname.\n\nBrian Rosmaita, thank you for pointing that out. Looks like a valid hostname may begin with a digit but not be fully composed of digits.\n\nThanks.","commit_id":"215a003496d8717a98af03f67bdec2bd01576e71"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"0442bcb8dccd734ebcd6edc1522a1dd15ab28bc9","unresolved":false,"context_lines":[{"line_number":693,"context_line":"    def test_invalid_host_addresses(self):"},{"line_number":694,"context_line":"        self.assertInvalid(\u0027-1\u0027)"},{"line_number":695,"context_line":"        self.assertInvalid(\u0027_foo\u0027)"},{"line_number":696,"context_line":"        self.assertInvalid(\u00273.14\u0027)"},{"line_number":697,"context_line":"        self.assertInvalid(\u002710.0\u0027)"},{"line_number":698,"context_line":"        self.assertInvalid(\u0027host..name\u0027)"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a95cdbc_81b483d1","line":696,"in_reply_to":"7a8ec9b2_02b9b1ec","updated":"2016-10-06 17:52:40.000000000","message":"RFC1912:\n\n\"Allowable characters in a label for a host name are only ASCII\nletters, digits, and the `-\u0027 character.  Labels may not be all\nnumbers, but may have a leading digit  (e.g., 3com.com).\"","commit_id":"215a003496d8717a98af03f67bdec2bd01576e71"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d3df68b8b5aabf977d0f95d7e4a52d6648d0fca4","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        self.assertInvalid(\u0027-1\u0027)"},{"line_number":695,"context_line":"        self.assertInvalid(\u0027_foo\u0027)"},{"line_number":696,"context_line":"        self.assertInvalid(\u00273.14\u0027)"},{"line_number":697,"context_line":"        self.assertInvalid(\u002710.0\u0027)"},{"line_number":698,"context_line":"        self.assertInvalid(\u0027host..name\u0027)"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"    def test_valid_host_addresses(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_a2cabd6c","line":697,"updated":"2016-09-19 20:29:59.000000000","message":"Same question.","commit_id":"215a003496d8717a98af03f67bdec2bd01576e71"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3d4cf24d695fc8c6f9f169c5b0e1b648bae0ece7","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        self.assertConvertedEqual(\u0027site01001\u0027)"},{"line_number":760,"context_line":"        self.assertConvertedEqual(\u0027home-site-here.org.com\u0027)"},{"line_number":761,"context_line":"        self.assertConvertedEqual(\u0027192.168.0.1\u0027)"},{"line_number":762,"context_line":"        self.assertConvertedEqual(\u00271.1.1\u0027)"},{"line_number":763,"context_line":"        self.assertConvertedEqual(\u0027localhost\u0027)"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def test_max_segment_size(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_28a62253","line":762,"updated":"2016-10-06 22:52:30.000000000","message":"I don\u0027t mean to beat a dead horse, but the current HostnameOpt apparently accepts all digits.  So it looks like your HostAddressOpt is more strict.  Is this a bug in HostnameOpt?","commit_id":"692def23345d2c5cd78f55f62e67883aff45300f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"d68adf932b7d53993145ee82d5ef34a829712cc1","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        self.assertConvertedEqual(\u0027site01001\u0027)"},{"line_number":760,"context_line":"        self.assertConvertedEqual(\u0027home-site-here.org.com\u0027)"},{"line_number":761,"context_line":"        self.assertConvertedEqual(\u0027192.168.0.1\u0027)"},{"line_number":762,"context_line":"        self.assertConvertedEqual(\u00271.1.1\u0027)"},{"line_number":763,"context_line":"        self.assertConvertedEqual(\u0027localhost\u0027)"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def test_max_segment_size(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_23a64553","line":762,"in_reply_to":"1a95cdbc_28a62253","updated":"2016-10-06 23:29:51.000000000","message":"Brian, \nYeah. The hostname allows all digits (kept that way probably cos ipv4 addresses could be given) as hostnames. But, it does not have a way to ensure that the all-digit-hostname given is a valid IP.  Adding this will complicate checks for the regular hostnames. Also, ipv6 are not accepted by HostnameOpt. And we cannot make hostnameOpt accept IPv6 addresses either. Cos that will validate an invalid hostname that might seem like a valid IPv6 address.\nHence, this patch to accommodate both hostnames and IP addresses.\nAnd the hostnameOpt and IPAddressOpt can be used only for hostnames and addresses respectively. \nLet me know what you think.\nThanks.","commit_id":"692def23345d2c5cd78f55f62e67883aff45300f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"29e0909b3260b9866df0a138f4743ec388d9ee4b","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        self.assertConvertedValue(\u0027cell1.\u0027, \u0027cell1\u0027)"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def test_valid_hostname(self):"},{"line_number":766,"context_line":"        self.assertConvertedEqual(\u0027cell1.nova.site1\u0027)"},{"line_number":767,"context_line":"        self.assertConvertedEqual(\u0027site01001\u0027)"},{"line_number":768,"context_line":"        self.assertConvertedEqual(\u0027home-site-here.org.com\u0027)"},{"line_number":769,"context_line":"        self.assertConvertedEqual(\u0027localhost\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_8fb59bef","line":766,"range":{"start_line":766,"start_character":0,"end_line":766,"end_character":53},"updated":"2016-10-12 23:51:59.000000000","message":"Can somebody confirm that hostnames of this type are to be validated and accepted?","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"29e0909b3260b9866df0a138f4743ec388d9ee4b","unresolved":false,"context_lines":[{"line_number":769,"context_line":"        self.assertConvertedEqual(\u0027localhost\u0027)"},{"line_number":770,"context_line":"        self.assertConvertedEqual(\u00273com.com\u0027)"},{"line_number":771,"context_line":"        self.assertConvertedEqual(\u002710.org\u0027)"},{"line_number":772,"context_line":"        self.assertConvertedEqual(\u002710ab.10ab\u0027)"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    def test_max_segment_size(self):"},{"line_number":775,"context_line":"        self.assertConvertedEqual(\u0027host.%s.com\u0027 % (\u0027x\u0027 * 63))"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_afb89fe6","line":772,"updated":"2016-10-12 23:51:59.000000000","message":"Same as line 766.","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"}],"oslo_config/types.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a0074560fda22af5804b0a972ff3e6b4b85b06e8","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        return value"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"class HostAddress(IPAddress, Hostname):"},{"line_number":755,"context_line":"    \"\"\"HostAddress type."},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    Represents both valid IP addresses and valid hostnames."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_cf7334b3","line":754,"updated":"2016-09-01 05:58:45.000000000","message":"So why prefer inheritance here vs. composition?\n\nDoes the inheritance give u anything?\n\nIMHO multi-inheritance here feels weird, since it\u0027s not really both and it\u0027s not really either and u can\u0027t really treat it like a ipaddress and a hostname at the same time.","commit_id":"90ec234884cf780c0b576d90708af965b94db50e"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2df3370dd9d6928943f40ac503ed1025aef827dc","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        return value"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"class HostAddress(IPAddress, Hostname):"},{"line_number":755,"context_line":"    \"\"\"HostAddress type."},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    Represents both valid IP addresses and valid hostnames."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_c82698cd","line":754,"in_reply_to":"fa7ab95a_cf7334b3","updated":"2016-09-01 21:09:14.000000000","message":"I agree Joshua. Since we want a part of each class\u0027s functionality, composition makes more sense here.\nWill adopt composition as suggested.","commit_id":"90ec234884cf780c0b576d90708af965b94db50e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f694cc224027cd5e2b2adffc2a6681e321858aa0","unresolved":false,"context_lines":[{"line_number":754,"context_line":"class HostAddress(object):"},{"line_number":755,"context_line":"    \"\"\"HostAddress type."},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"    Represents both valid IP addresses and valid hostnames."},{"line_number":758,"context_line":"    Performs strict checks for both IP addresses and valid hostnames,"},{"line_number":759,"context_line":"    matching the opt values to the respective types."},{"line_number":760,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_cfa992e1","line":757,"updated":"2016-09-09 17:57:14.000000000","message":"I think some ops would want to see fqdn too so you can add that here.","commit_id":"9bd628f170dbd8b7b1a7a61953ff363ae1ef125e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f694cc224027cd5e2b2adffc2a6681e321858aa0","unresolved":false,"context_lines":[{"line_number":770,"context_line":"        \"\"\""},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        self.IPAddress \u003d IPAddress(version, type_name)"},{"line_number":773,"context_line":"        self.Hostname \u003d Hostname(type_name)"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"    def __call__(self, value):"},{"line_number":776,"context_line":"        \"\"\"Checks if is a valid IP/hostname."}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_af7b6e7a","line":773,"range":{"start_line":773,"start_character":33,"end_line":773,"end_character":42},"updated":"2016-09-09 17:57:14.000000000","message":"may be default to \"localhost\"","commit_id":"9bd628f170dbd8b7b1a7a61953ff363ae1ef125e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f694cc224027cd5e2b2adffc2a6681e321858aa0","unresolved":false,"context_lines":[{"line_number":783,"context_line":"        try:"},{"line_number":784,"context_line":"            self.IPAddress.__call__(value)"},{"line_number":785,"context_line":"        except ValueError:"},{"line_number":786,"context_line":"            if re.search(\u0027[a-zA-Z]\u0027, value):"},{"line_number":787,"context_line":"                try:"},{"line_number":788,"context_line":"                    self.Hostname.__call__(value)"},{"line_number":789,"context_line":"                except ValueError:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_0f929a57","line":786,"range":{"start_line":786,"start_character":26,"end_line":786,"end_character":34},"updated":"2016-09-09 17:57:14.000000000","message":"this will ignore some special chars like \"*\"\n\nbut I guess all that can be caught at line 739 above","commit_id":"9bd628f170dbd8b7b1a7a61953ff363ae1ef125e"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"0814f32cba9b96741990524f37948df1b906044c","unresolved":false,"context_lines":[{"line_number":790,"context_line":"                except ValueError:"},{"line_number":791,"context_line":"                    raise ValueError(\"%s is not a valid host address\", value)"},{"line_number":792,"context_line":"            else:"},{"line_number":793,"context_line":"                raise ValueError(\"%s is not a valid host address\", value)"},{"line_number":794,"context_line":"        return value"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_10a23199","line":793,"range":{"start_line":793,"start_character":52,"end_line":793,"end_character":56},"updated":"2016-09-16 20:53:31.000000000","message":"Would it be better to say: \"IPv4 or IPv6\" instead of \"host\" here?","commit_id":"01ceb32b3068e184a2a7d2bd46dcd7f6995dbe8f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"019098204d3ff12e2eb47882fc41740775cc0425","unresolved":false,"context_lines":[{"line_number":790,"context_line":"                except ValueError:"},{"line_number":791,"context_line":"                    raise ValueError(\"%s is not a valid host address\", value)"},{"line_number":792,"context_line":"            else:"},{"line_number":793,"context_line":"                raise ValueError(\"%s is not a valid host address\", value)"},{"line_number":794,"context_line":"        return value"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def __repr__(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_50ed99b5","line":793,"range":{"start_line":793,"start_character":52,"end_line":793,"end_character":56},"in_reply_to":"7a8ec9b2_10a23199","updated":"2016-09-16 21:07:06.000000000","message":"Done","commit_id":"01ceb32b3068e184a2a7d2bd46dcd7f6995dbe8f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3d4cf24d695fc8c6f9f169c5b0e1b648bae0ece7","unresolved":false,"context_lines":[{"line_number":757,"context_line":"    Represents both valid IP addresses and valid hostnames"},{"line_number":758,"context_line":"    including fully qualified domain names."},{"line_number":759,"context_line":"    Performs strict checks for both IP addresses and valid hostnames,"},{"line_number":760,"context_line":"    matching the opt values to the respective types."},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    :param version: defines which version should be explicitly"},{"line_number":763,"context_line":"    checked (4 or 6) in case of an IP address"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_68510a36","line":760,"updated":"2016-10-06 22:52:30.000000000","message":"I suggest adding the RFC(s) under which this validates hostnames so it\u0027s clear to everyone what to expect.","commit_id":"692def23345d2c5cd78f55f62e67883aff45300f"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"de05c3b66beb4f62eb81b72e6e1a64a7123527d5","unresolved":false,"context_lines":[{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        \"\"\""},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        self.IPAddress \u003d IPAddress(version, type_name)"},{"line_number":774,"context_line":"        self.Hostname \u003d Hostname(\u0027localhost\u0027)"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    def __call__(self, value):"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_13749f9a","line":773,"updated":"2016-10-11 15:13:42.000000000","message":"Unless it\u0027s convention in this module to name attributes like classes, I\u0027d prefer you not name these attributes this way.","commit_id":"692def23345d2c5cd78f55f62e67883aff45300f"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"de05c3b66beb4f62eb81b72e6e1a64a7123527d5","unresolved":false,"context_lines":[{"line_number":782,"context_line":"        \"\"\""},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"        try:"},{"line_number":785,"context_line":"            value \u003d self.IPAddress.__call__(value)"},{"line_number":786,"context_line":"        except ValueError:"},{"line_number":787,"context_line":"            if re.search(\u0027[a-zA-Z]\u0027, value):"},{"line_number":788,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa6399be_f35f2b0c","line":785,"updated":"2016-10-11 15:13:42.000000000","message":"Why are you using __call__ here and below? Why aren\u0027t you simply doing\n\n    value \u003d self.IPAddress(value)","commit_id":"692def23345d2c5cd78f55f62e67883aff45300f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3cdbc83a15d459daab2a446c9b9ff4c5223de984","unresolved":false,"context_lines":[{"line_number":724,"context_line":"        - Consists only of allowed characters: letters (A-Z and a-z),"},{"line_number":725,"context_line":"          digits (0-9), and hyphen (-)"},{"line_number":726,"context_line":"        - Does not begin or end with a hyphen"},{"line_number":727,"context_line":"        - maximum total length of 253 characters"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        For more details , please see: http://tools.ietf.org/html/rfc1035"},{"line_number":730,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_5e4ede6f","line":727,"updated":"2016-10-12 20:46:03.000000000","message":"need to add:\n\n  - ensures that the final segment (representing the top\n    level domain name) contains at least one non-numeric\n    character","commit_id":"fa8c3efb1eef69274e85490bf52db3eae3b76231"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3cdbc83a15d459daab2a446c9b9ff4c5223de984","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        - Does not begin or end with a hyphen"},{"line_number":727,"context_line":"        - maximum total length of 253 characters"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"        For more details , please see: http://tools.ietf.org/html/rfc1035"},{"line_number":730,"context_line":"        \"\"\""},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        if len(value) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_9ef4f6f2","line":729,"updated":"2016-10-12 20:46:03.000000000","message":"Should probably also give a reference to that other RFC someone mentioned, I don\u0027t think this one requires the top level domain name to be non-numeric.","commit_id":"fa8c3efb1eef69274e85490bf52db3eae3b76231"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3cdbc83a15d459daab2a446c9b9ff4c5223de984","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        if value.endswith(\".\"):"},{"line_number":738,"context_line":"            value \u003d value[:-1]"},{"line_number":739,"context_line":"        allowed \u003d re.compile(\"(?!-)[A-Z0-9-]{1,63}(?\u003c!-)$\", re.IGNORECASE)"},{"line_number":740,"context_line":"        if re.search(\u0027[a-zA-Z]\u0027, value):"},{"line_number":741,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":742,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"},{"line_number":743,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_db2680cd","line":740,"updated":"2016-10-12 20:46:03.000000000","message":"This is just checking to make sure that there\u0027s at least one non-numeric character in the hostname.  That\u0027s why \"com.11\" is passing.  What you need to do is to make sure that the *last* segment contains at least one non-numeric character.  (You don\u0027t necessarily have to remove this check, but you definitely need to check the last segment.)","commit_id":"fa8c3efb1eef69274e85490bf52db3eae3b76231"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3cdbc83a15d459daab2a446c9b9ff4c5223de984","unresolved":false,"context_lines":[{"line_number":741,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":742,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"},{"line_number":743,"context_line":"        else:"},{"line_number":744,"context_line":"            raise ValueError(\"%s contains no characters and is \\"},{"line_number":745,"context_line":"                              invalid\" % value)"},{"line_number":746,"context_line":"        return value"},{"line_number":747,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_3eb68a3d","line":744,"range":{"start_line":744,"start_character":42,"end_line":744,"end_character":56},"updated":"2016-10-12 20:46:03.000000000","message":"I\u0027d suggest changing this to \"no non-numeric characters\".","commit_id":"fa8c3efb1eef69274e85490bf52db3eae3b76231"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9c7600dd834a71e71d367efbcb7b3a1371f44f00","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        - maximum total length of 253 characters"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"        For more details , please see: http://tools.ietf.org/html/rfc1035"},{"line_number":732,"context_line":"        and https://tools.ietf.org/html/rfc1123#section-6.1.2.4"},{"line_number":733,"context_line":"        \"\"\""},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        if len(value) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_01d13efa","line":732,"range":{"start_line":732,"start_character":12,"end_line":732,"end_character":63},"updated":"2016-10-13 15:20:34.000000000","message":"6.1.2.4 deals with compression. I suspect you mean 2.1 and not the reference in 2.1 ...","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1753044a205bfdc906ccefc9d7413e41b274311","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        - maximum total length of 253 characters"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"        For more details , please see: http://tools.ietf.org/html/rfc1035"},{"line_number":732,"context_line":"        and https://tools.ietf.org/html/rfc1123#section-6.1.2.4"},{"line_number":733,"context_line":"        \"\"\""},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        if len(value) \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_70ec71f3","line":732,"range":{"start_line":732,"start_character":12,"end_line":732,"end_character":63},"in_reply_to":"fa6399be_01d13efa","updated":"2016-10-14 00:08:43.000000000","message":"Done","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9c7600dd834a71e71d367efbcb7b3a1371f44f00","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                             % value)"},{"line_number":740,"context_line":"        if value.endswith(\".\"):"},{"line_number":741,"context_line":"            value \u003d value[:-1]"},{"line_number":742,"context_line":"        allowed \u003d re.compile(\"(?!-)[A-Z0-9-]{1,63}(?\u003c!-)$\", re.IGNORECASE)"},{"line_number":743,"context_line":"        if re.search(\u0027[a-zA-Z]\u0027, value) and re.search(\u0027[a-zA-Z]\u0027,"},{"line_number":744,"context_line":"                                                      value.split(\".\")[-1]):"},{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_0c05f512","line":742,"updated":"2016-10-13 15:20:34.000000000","message":"should we include _ as required by RFC1912?","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1753044a205bfdc906ccefc9d7413e41b274311","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                             % value)"},{"line_number":740,"context_line":"        if value.endswith(\".\"):"},{"line_number":741,"context_line":"            value \u003d value[:-1]"},{"line_number":742,"context_line":"        allowed \u003d re.compile(\"(?!-)[A-Z0-9-]{1,63}(?\u003c!-)$\", re.IGNORECASE)"},{"line_number":743,"context_line":"        if re.search(\u0027[a-zA-Z]\u0027, value) and re.search(\u0027[a-zA-Z]\u0027,"},{"line_number":744,"context_line":"                                                      value.split(\".\")[-1]):"},{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_50ef6de8","line":742,"in_reply_to":"fa6399be_0c05f512","updated":"2016-10-14 00:08:43.000000000","message":"Amrith, according to https://www.ietf.org/rfc/rfc1912:\n```\nThe presence\n   of underscores in a label is allowed in [RFC 1033], except [RFC 1033]\n   is informational only and was not defining a standard.  There is at\n   least one popular TCP/IP implementation which currently refuses to\n   talk to hosts named with underscores in them.  It must be noted that\n   the language in [1035] is such that these rules are voluntary -- they\n   are there for those who wish to minimize problems.\n```\nSo underscore is not accepted everywhere.","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9c7600dd834a71e71d367efbcb7b3a1371f44f00","unresolved":false,"context_lines":[{"line_number":740,"context_line":"        if value.endswith(\".\"):"},{"line_number":741,"context_line":"            value \u003d value[:-1]"},{"line_number":742,"context_line":"        allowed \u003d re.compile(\"(?!-)[A-Z0-9-]{1,63}(?\u003c!-)$\", re.IGNORECASE)"},{"line_number":743,"context_line":"        if re.search(\u0027[a-zA-Z]\u0027, value) and re.search(\u0027[a-zA-Z]\u0027,"},{"line_number":744,"context_line":"                                                      value.split(\".\")[-1]):"},{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":746,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_8c24a560","line":743,"range":{"start_line":743,"start_character":54,"end_line":743,"end_character":64},"updated":"2016-10-13 15:20:34.000000000","message":"this pattern is wrong because if allowed characters for a hostname are as defined in RFC952, (B. Lexical Grammar) the \"-\" character should be allowed as well.\n\nThe more permissive _ should be allowed as well.\n\nRFC1912 indicates this.","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"f1dca8e8a65ad909c40bc07cf2eb598231e9c0c2","unresolved":false,"context_lines":[{"line_number":740,"context_line":"        if value.endswith(\".\"):"},{"line_number":741,"context_line":"            value \u003d value[:-1]"},{"line_number":742,"context_line":"        allowed \u003d re.compile(\"(?!-)[A-Z0-9-]{1,63}(?\u003c!-)$\", re.IGNORECASE)"},{"line_number":743,"context_line":"        if re.search(\u0027[a-zA-Z]\u0027, value) and re.search(\u0027[a-zA-Z]\u0027,"},{"line_number":744,"context_line":"                                                      value.split(\".\")[-1]):"},{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":746,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_e3b279e4","line":743,"range":{"start_line":743,"start_character":54,"end_line":743,"end_character":64},"in_reply_to":"fa6399be_30cd9985","updated":"2016-10-14 01:06:02.000000000","message":"Thank you but I am well aware of what a regular expression is. What you are missing is the fact that a \"-\" is also a valid non-numeric character.\n\nDid you read the comment I posted?\n\nLet me (again) direct your attention to \n\nhttps://gist.github.com/anonymous/81a739374e7af02aa330b6bda981ee16\n\nIf you\u0027d like an explanation of that gist; let me know and I will try and do a better job of it ...","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1753044a205bfdc906ccefc9d7413e41b274311","unresolved":false,"context_lines":[{"line_number":740,"context_line":"        if value.endswith(\".\"):"},{"line_number":741,"context_line":"            value \u003d value[:-1]"},{"line_number":742,"context_line":"        allowed \u003d re.compile(\"(?!-)[A-Z0-9-]{1,63}(?\u003c!-)$\", re.IGNORECASE)"},{"line_number":743,"context_line":"        if re.search(\u0027[a-zA-Z]\u0027, value) and re.search(\u0027[a-zA-Z]\u0027,"},{"line_number":744,"context_line":"                                                      value.split(\".\")[-1]):"},{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":746,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_30cd9985","line":743,"range":{"start_line":743,"start_character":54,"end_line":743,"end_character":64},"in_reply_to":"fa6399be_8c24a560","updated":"2016-10-14 00:08:43.000000000","message":"The hyphens (minus signs) here do not mean we are not allowing them here. We check what is allowed only after this conditional statement which simple just checks if there is at least one non numeric character in the hostname and TLD.","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9c7600dd834a71e71d367efbcb7b3a1371f44f00","unresolved":false,"context_lines":[{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":746,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"},{"line_number":747,"context_line":"        else:"},{"line_number":748,"context_line":"            raise ValueError(\"%s contains no non-numeric characters and is \\"},{"line_number":749,"context_line":"                              invalid\" % value)"},{"line_number":750,"context_line":"        return value"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def __repr__(self):"},{"line_number":753,"context_line":"        return \u0027Hostname\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_a1425266","line":750,"range":{"start_line":748,"start_character":0,"end_line":750,"end_character":20},"updated":"2016-10-13 15:20:34.000000000","message":"this message is now wrong. Earlier, the test was against the entire value; did the entire value contain at least one alphanumeric character.\n\nSo, you should update the message to indicate that the last part of the address (and that is value.split(\".\")[-1]) is all numeric.\n\nSee: https://gist.github.com/anonymous/81a739374e7af02aa330b6bda981ee16\n\nAlso, this message is wrapped using a \"\\\" but the next line (749) indents \"invalid\" under the %. That means the message includes a bunch of spaces as shown in the test that fails.","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"c1753044a205bfdc906ccefc9d7413e41b274311","unresolved":false,"context_lines":[{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":746,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"},{"line_number":747,"context_line":"        else:"},{"line_number":748,"context_line":"            raise ValueError(\"%s contains no non-numeric characters and is \\"},{"line_number":749,"context_line":"                              invalid\" % value)"},{"line_number":750,"context_line":"        return value"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def __repr__(self):"},{"line_number":753,"context_line":"        return \u0027Hostname\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_90a2e5ac","line":750,"range":{"start_line":748,"start_character":0,"end_line":750,"end_character":20},"in_reply_to":"fa6399be_a1425266","updated":"2016-10-14 00:08:43.000000000","message":"Done","commit_id":"f4d6c6173ccf230e6a4180d28b1d2e81dbd73dc1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"650f6ab6e611c38b96a9f063a0599954e05b1bde","unresolved":false,"context_lines":[{"line_number":741,"context_line":"        if value.endswith(\".\"):"},{"line_number":742,"context_line":"            value \u003d value[:-1]"},{"line_number":743,"context_line":"        allowed \u003d re.compile(\"(?!-)[A-Z0-9-]{1,63}(?\u003c!-)$\", re.IGNORECASE)"},{"line_number":744,"context_line":"        if re.search(\u0027[a-zA-Z]\u0027, value.split(\".\")[-1]):"},{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":746,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"},{"line_number":747,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_3993a8fb","line":744,"updated":"2016-10-14 15:53:10.000000000","message":"Dharini, per our conversation I tested that the change\n\nhttps://gist.github.com/anonymous/d37434541605ed6001034f65f463c6ce\n\nDoes what I believe are the right things. It adds a couple of tests as well","commit_id":"cce0568cb422efde08f4c95112e1a617aa327484"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"11402130d027e6d75385268096d72e246d5d2a3c","unresolved":false,"context_lines":[{"line_number":741,"context_line":"        if value.endswith(\".\"):"},{"line_number":742,"context_line":"            value \u003d value[:-1]"},{"line_number":743,"context_line":"        allowed \u003d re.compile(\"(?!-)[A-Z0-9-]{1,63}(?\u003c!-)$\", re.IGNORECASE)"},{"line_number":744,"context_line":"        if re.search(\u0027[a-zA-Z]\u0027, value.split(\".\")[-1]):"},{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":746,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"},{"line_number":747,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_f2fb0577","line":744,"in_reply_to":"fa6399be_3993a8fb","updated":"2016-10-14 17:00:11.000000000","message":"Thanks Amrith.","commit_id":"cce0568cb422efde08f4c95112e1a617aa327484"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"1851b3cd196e75d8e065fd92efe93d8c54cc05b9","unresolved":false,"context_lines":[{"line_number":742,"context_line":"            value \u003d value[:-1]"},{"line_number":743,"context_line":"        allowed \u003d re.compile(\"(?!-)[A-Z0-9-]{1,63}(?\u003c!-)$\", re.IGNORECASE)"},{"line_number":744,"context_line":"        if re.search(\u0027[a-zA-Z-]\u0027, value.split(\".\")[-1]):"},{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":746,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"},{"line_number":747,"context_line":"        else:"},{"line_number":748,"context_line":"            raise ValueError(\u0027%s contains no non-numeric characters in the \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_0cb6128a","line":745,"updated":"2016-11-22 18:41:54.000000000","message":"Doesn\u0027t this change the if statement to do something different?\n\nShouldn\u0027t it be:\n\n  if not re.search(\u0027[a-zA-Z-]\u0027, value.split(\".\")[-1]):\n    raise ValueError(\u0027%s contains no non-numeric characters in the \u0027\n                             \u0027top-level domain part of the host name and is \u0027\n                             \u0027invalid\u0027 % value)\n  if any((not allowed.match(x)) for x in value.split(\".\")):\n    raise ValueError(\"%s is an invalid hostname\" % value)\n\nOtherwise seems ok, just unsure about the logic change when u put the re.search as the top level \u0027if\u0027","commit_id":"f7800ff7e2b4372bc9321533ef6ab6f1eeba2e95"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"f37b2683e6ac95ee7b7d23d845a4a1f4ad3e9ed5","unresolved":false,"context_lines":[{"line_number":742,"context_line":"            value \u003d value[:-1]"},{"line_number":743,"context_line":"        allowed \u003d re.compile(\"(?!-)[A-Z0-9-]{1,63}(?\u003c!-)$\", re.IGNORECASE)"},{"line_number":744,"context_line":"        if re.search(\u0027[a-zA-Z-]\u0027, value.split(\".\")[-1]):"},{"line_number":745,"context_line":"            if any((not allowed.match(x)) for x in value.split(\".\")):"},{"line_number":746,"context_line":"                raise ValueError(\"%s is an invalid hostname\" % value)"},{"line_number":747,"context_line":"        else:"},{"line_number":748,"context_line":"            raise ValueError(\u0027%s contains no non-numeric characters in the \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_2744c719","line":745,"in_reply_to":"7a77a97e_0cb6128a","updated":"2016-11-22 18:56:15.000000000","message":"Joshua, I meant to proceed with the second check only if the first passed. But since we raise an exception anyway, I agree with what you say. Will upload a new PS.\nThanks.","commit_id":"f7800ff7e2b4372bc9321533ef6ab6f1eeba2e95"}],"releasenotes/notes/add-HostAddressOpt-6e7e2afe7c7863cb.yaml":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ff5282d00fa6e3a72984714b29fca58a531643b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - HostAddress added as an opt type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and valid hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions, and hostnames would be performed for"},{"line_number":6,"context_line":"    this opt type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_acffc865","line":3,"range":{"start_line":3,"start_character":28,"end_line":3,"end_character":31},"updated":"2016-08-28 23:36:41.000000000","message":"option","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"92aa6944e3f371ea1b13ff404bc72c0d80bb3d1e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - HostAddress added as an opt type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and valid hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions, and hostnames would be performed for"},{"line_number":6,"context_line":"    this opt type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_ee6b53b7","line":3,"range":{"start_line":3,"start_character":28,"end_line":3,"end_character":31},"in_reply_to":"fa7ab95a_acffc865","updated":"2016-08-29 17:26:56.000000000","message":"Done","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ff5282d00fa6e3a72984714b29fca58a531643b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - HostAddress added as an opt type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and valid hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions, and hostnames would be performed for"},{"line_number":6,"context_line":"    this opt type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_6c05c078","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":13},"updated":"2016-08-28 23:36:41.000000000","message":"\u0027valid\u0027 here is redundant","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"92aa6944e3f371ea1b13ff404bc72c0d80bb3d1e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - HostAddress added as an opt type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and valid hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions, and hostnames would be performed for"},{"line_number":6,"context_line":"    this opt type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_2e6a9bb3","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":13},"in_reply_to":"fa7ab95a_6c05c078","updated":"2016-08-29 17:26:56.000000000","message":"Done","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ff5282d00fa6e3a72984714b29fca58a531643b9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - HostAddress added as an opt type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and valid hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions, and hostnames would be performed for"},{"line_number":6,"context_line":"    this opt type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_cc024c6f","line":5,"range":{"start_line":5,"start_character":36,"end_line":5,"end_character":37},"updated":"2016-08-28 23:36:41.000000000","message":"remove comma","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"92aa6944e3f371ea1b13ff404bc72c0d80bb3d1e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - HostAddress added as an opt type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and valid hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions, and hostnames would be performed for"},{"line_number":6,"context_line":"    this opt type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_4e67dfe8","line":5,"range":{"start_line":5,"start_character":36,"end_line":5,"end_character":37},"in_reply_to":"fa7ab95a_cc024c6f","updated":"2016-08-29 17:26:56.000000000","message":"Done","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ff5282d00fa6e3a72984714b29fca58a531643b9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - HostAddress added as an opt type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and valid hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions, and hostnames would be performed for"},{"line_number":6,"context_line":"    this opt type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_ecf9d081","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":12},"updated":"2016-08-28 23:36:41.000000000","message":"option","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"92aa6944e3f371ea1b13ff404bc72c0d80bb3d1e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - HostAddress added as an opt type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and valid hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions, and hostnames would be performed for"},{"line_number":6,"context_line":"    this opt type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa7ab95a_6e6023d0","line":6,"range":{"start_line":6,"start_character":9,"end_line":6,"end_character":12},"in_reply_to":"fa7ab95a_ecf9d081","updated":"2016-08-29 17:26:56.000000000","message":"Done","commit_id":"b7910c3b457e9ce198d509c755cdf68598c728e1"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f694cc224027cd5e2b2adffc2a6681e321858aa0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - HostAddress added as an option type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and hostnames as values for configuration options."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a89bdaa_4fd8221e","line":1,"updated":"2016-09-09 17:57:14.000000000","message":"I think you can add prelude for this will be a decent addition.","commit_id":"9bd628f170dbd8b7b1a7a61953ff363ae1ef125e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f694cc224027cd5e2b2adffc2a6681e321858aa0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - HostAddress added as an option type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions and hostnames would be performed for"},{"line_number":6,"context_line":"    this option type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a89bdaa_0ff53a82","line":3,"range":{"start_line":3,"start_character":56,"end_line":3,"end_character":59},"updated":"2016-09-09 17:57:14.000000000","message":"IP addresses","commit_id":"9bd628f170dbd8b7b1a7a61953ff363ae1ef125e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f694cc224027cd5e2b2adffc2a6681e321858aa0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - HostAddress added as an option type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions and hostnames would be performed for"},{"line_number":6,"context_line":"    this option type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a89bdaa_cf02726f","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":15},"updated":"2016-09-09 17:57:14.000000000","message":"``HostAddress``","commit_id":"9bd628f170dbd8b7b1a7a61953ff363ae1ef125e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f694cc224027cd5e2b2adffc2a6681e321858aa0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - HostAddress added as an option type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions and hostnames would be performed for"},{"line_number":6,"context_line":"    this option type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a89bdaa_0f6a9a1a","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":27},"updated":"2016-09-09 17:57:14.000000000","message":"you can rephrase the sentence\n\n\n... a configuration option type to accept valid values for ... hostnames. \n\n(remove for configuration options)","commit_id":"9bd628f170dbd8b7b1a7a61953ff363ae1ef125e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f694cc224027cd5e2b2adffc2a6681e321858aa0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - HostAddress added as an option type to accept valid IPs (IPv4 and IPv6)"},{"line_number":4,"context_line":"    and hostnames as values for configuration options."},{"line_number":5,"context_line":"    Strict checks on the IP versions and hostnames would be performed for"},{"line_number":6,"context_line":"    this option type ensuring that no invalid IP passes as a valid hostname."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a89bdaa_afd0ceca","line":6,"updated":"2016-09-09 17:57:14.000000000","message":"please add the same explanation from CM on how other types are allowing this invalid value","commit_id":"9bd628f170dbd8b7b1a7a61953ff363ae1ef125e"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"0814f32cba9b96741990524f37948df1b906044c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``features`` section for more information."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"features:"},{"line_number":8,"context_line":"  - ``HostAddress`` added as a configuration option type to accept valid"},{"line_number":9,"context_line":"    values for IP addresses (IPv4 and IPv6) and hostnames."},{"line_number":10,"context_line":"    This option type will perform strict checks for both IP addresses and"},{"line_number":11,"context_line":"    Hostnames."},{"line_number":12,"context_line":"    Currently, IPOpt type for configuration options accepts only valid IPv4"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a8ec9b2_d028c935","line":9,"range":{"start_line":8,"start_character":57,"end_line":9,"end_character":58},"updated":"2016-09-16 20:53:31.000000000","message":"This might sound better as:\n\"...to accept both valid IP address (IPv4 and IPv6) values as well as hostnames.\"","commit_id":"01ceb32b3068e184a2a7d2bd46dcd7f6995dbe8f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"019098204d3ff12e2eb47882fc41740775cc0425","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``features`` section for more information."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"features:"},{"line_number":8,"context_line":"  - ``HostAddress`` added as a configuration option type to accept valid"},{"line_number":9,"context_line":"    values for IP addresses (IPv4 and IPv6) and hostnames."},{"line_number":10,"context_line":"    This option type will perform strict checks for both IP addresses and"},{"line_number":11,"context_line":"    Hostnames."},{"line_number":12,"context_line":"    Currently, IPOpt type for configuration options accepts only valid IPv4"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a8ec9b2_7066152b","line":9,"range":{"start_line":8,"start_character":57,"end_line":9,"end_character":58},"in_reply_to":"7a8ec9b2_d028c935","updated":"2016-09-16 21:07:06.000000000","message":"Done","commit_id":"01ceb32b3068e184a2a7d2bd46dcd7f6995dbe8f"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"0814f32cba9b96741990524f37948df1b906044c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    Currently, IPOpt type for configuration options accepts only valid IPv4"},{"line_number":13,"context_line":"    or IPv6 addresses. The HostnameOpt accepts values that can be either IPv4"},{"line_number":14,"context_line":"    addresses or hostnames but does not validate the value to be a valid IPv4"},{"line_number":15,"context_line":"    address and does not accept IPv6 addresses.  "},{"line_number":16,"context_line":"    The ``HostAddressOpt`` solves this issue and will accept both IPv4"},{"line_number":17,"context_line":"    and IPv6 addresses and ensure that strict checks are performed on the IP"},{"line_number":18,"context_line":"    versions. This option type will also accept and accurately validate"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a8ec9b2_101f9108","line":15,"range":{"start_line":15,"start_character":47,"end_line":15,"end_character":49},"updated":"2016-09-16 20:53:31.000000000","message":"whitespace","commit_id":"01ceb32b3068e184a2a7d2bd46dcd7f6995dbe8f"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"019098204d3ff12e2eb47882fc41740775cc0425","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    Currently, IPOpt type for configuration options accepts only valid IPv4"},{"line_number":13,"context_line":"    or IPv6 addresses. The HostnameOpt accepts values that can be either IPv4"},{"line_number":14,"context_line":"    addresses or hostnames but does not validate the value to be a valid IPv4"},{"line_number":15,"context_line":"    address and does not accept IPv6 addresses.  "},{"line_number":16,"context_line":"    The ``HostAddressOpt`` solves this issue and will accept both IPv4"},{"line_number":17,"context_line":"    and IPv6 addresses and ensure that strict checks are performed on the IP"},{"line_number":18,"context_line":"    versions. This option type will also accept and accurately validate"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a8ec9b2_50a59944","line":15,"range":{"start_line":15,"start_character":47,"end_line":15,"end_character":49},"in_reply_to":"7a8ec9b2_101f9108","updated":"2016-09-16 21:07:06.000000000","message":"Done","commit_id":"01ceb32b3068e184a2a7d2bd46dcd7f6995dbe8f"}]}
