)]}'
{"oslo_config/types.py":[{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"c4f6dc11419510649fa4e49044553f07a449762f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    def __repr__(self):"},{"line_number":159,"context_line":"        details \u003d []"},{"line_number":160,"context_line":"        if self.choices:"},{"line_number":161,"context_line":"            details.append(\"choices\u003d{!r}\".format(self.choices))"},{"line_number":162,"context_line":"        if self.regex:"},{"line_number":163,"context_line":"            details.append(\"regex\u003d%r\" % self.regex.pattern)"},{"line_number":164,"context_line":"        if details:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_9d128457","line":161,"range":{"start_line":161,"start_character":35,"end_line":161,"end_character":38},"updated":"2016-09-09 08:36:02.000000000","message":"I would like to see here the same fix using %-operator (just for uniformity and consistency with the rest of the code; for example, see line 300 where the same problem was solved within Number.__repr__).","commit_id":"74d6328f10fafae344440e37fc44ffe8f8db0035"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"eb30ff98407011efd07b480ed704e1bf75845672","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    def __repr__(self):"},{"line_number":159,"context_line":"        details \u003d []"},{"line_number":160,"context_line":"        if self.choices:"},{"line_number":161,"context_line":"            details.append(\"choices\u003d{!r}\".format(self.choices))"},{"line_number":162,"context_line":"        if self.regex:"},{"line_number":163,"context_line":"            details.append(\"regex\u003d%r\" % self.regex.pattern)"},{"line_number":164,"context_line":"        if details:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_5da46a07","line":161,"range":{"start_line":161,"start_character":35,"end_line":161,"end_character":38},"in_reply_to":"9a89bdaa_47301d9f","updated":"2016-09-09 13:22:41.000000000","message":"One of the reasons I prefer the \u0027format\u0027 function over \u0027%\u0027 is don\u0027t need to do silly hacks like (obj, ).\n\nSo I\u0027m not sure if doing that falls into the \u0027foolish consistency\u0027 category or not.\n\nI\u0027d be happy to change the one below to \u0027format\u0027 :)","commit_id":"74d6328f10fafae344440e37fc44ffe8f8db0035"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"71725ddda1d8c281b1144f2e758050f0c554e724","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    def __repr__(self):"},{"line_number":159,"context_line":"        details \u003d []"},{"line_number":160,"context_line":"        if self.choices:"},{"line_number":161,"context_line":"            details.append(\"choices\u003d{!r}\".format(self.choices))"},{"line_number":162,"context_line":"        if self.regex:"},{"line_number":163,"context_line":"            details.append(\"regex\u003d%r\" % self.regex.pattern)"},{"line_number":164,"context_line":"        if details:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_dd195a24","line":161,"range":{"start_line":161,"start_character":35,"end_line":161,"end_character":38},"in_reply_to":"9a89bdaa_5da46a07","updated":"2016-09-09 13:26:40.000000000","message":"Ok, it would be great :)","commit_id":"74d6328f10fafae344440e37fc44ffe8f8db0035"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"28b84f182238ebc30d2104bf67d72cd5b323f70a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    def __repr__(self):"},{"line_number":159,"context_line":"        details \u003d []"},{"line_number":160,"context_line":"        if self.choices:"},{"line_number":161,"context_line":"            details.append(\"choices\u003d{!r}\".format(self.choices))"},{"line_number":162,"context_line":"        if self.regex:"},{"line_number":163,"context_line":"            details.append(\"regex\u003d%r\" % self.regex.pattern)"},{"line_number":164,"context_line":"        if details:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_47301d9f","line":161,"range":{"start_line":161,"start_character":35,"end_line":161,"end_character":38},"in_reply_to":"9a89bdaa_9d128457","updated":"2016-09-09 12:53:07.000000000","message":"the simplest possible fix is\n\n details.append(\"choices\u003d%r\" % (self.choices,))","commit_id":"74d6328f10fafae344440e37fc44ffe8f8db0035"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"eb05e1e289dbc2e880224f0fcbb7963374e9fb48","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    def __repr__(self):"},{"line_number":159,"context_line":"        details \u003d []"},{"line_number":160,"context_line":"        if self.choices is not None:"},{"line_number":161,"context_line":"            details.append(\"choices\u003d{!r}\".format(self.choices))"},{"line_number":162,"context_line":"        if self.regex:"},{"line_number":163,"context_line":"            details.append(\"regex\u003d%r\" % self.regex.pattern)"},{"line_number":164,"context_line":"        if details:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_b5ad269d","line":161,"updated":"2016-09-12 20:40:06.000000000","message":"Is it going to be confusing to readers of these files that sometimes the choices show up like:\n\n  choices\u003d[\u0027a\u0027, \u0027b\u0027]\n\nand sometimes like\n\n  choices\u003d(\u0027c\u0027, \u0027d\u0027)\n\nwith different punctuation? Maybe not.","commit_id":"a45025bddcaefa0bc8b84792347bca238374f33b"}]}